Commit Graph

114899 Commits

Author SHA1 Message Date
alekar
605991d4d5
Merge branch 'master' into 48716 2023-05-09 13:38:11 -07:00
Suzy Wang
ce471a2e8b Updated code as suggested 2023-05-09 13:31:54 -07:00
Dan Roscigno
7a4c3b9741
Merge pull request #49691 from duyet/patch-1
Fix incorrect docs for `use_query_cache`
2023-05-09 16:31:18 -04:00
Azat Khuzhin
9b3bcd0870 Fix stack-use-after-scope in gtest_resource_manager_static
Reordering of the static variables should be enough to fix this:

    [ RUN      ] IOResourceStaticResourceManager.Prioritization
    =================================================================
    ==13==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7f7d8d621970 at pc 0x5636b80dcbb2 bp 0x7f7c48e47dd0 sp 0x7f7c48e47dc8
    READ of size 8 at 0x7f7d8d621970 thread T3975 (ThreadPool)
        #0 0x5636b80dcbb1 in IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_1::operator()(long) const build_docker/./src/IO/Resource/tests/gtest_resource_manager_static.cpp:78:13
        #1 0x5636b80dcbb1 in IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0::operator()() const build_docker/./src/IO/Resource/tests/gtest_resource_manager_static.cpp:95:21
        #2 0x5636b80dcbb1 in decltype(std::declval<IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0&>()()) std::__1::__invoke[abi:v15000]<IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0&>(IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0&) build_docker/./contrib/llvm-project/libcxx/include/__functional/invoke.h:394:23
        #3 0x5636b80dcbb1 in decltype(auto) std::__1::__apply_tuple_impl[abi:v15000]<IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0&, std::__1::tuple<>&>(IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0&, std::__1::tuple<>&, std::__1::__tuple_indices<>) build_docker/./contrib/llvm-project/libcxx/include/tuple:1789:1
        #4 0x5636b80dcbb1 in decltype(auto) std::__1::apply[abi:v15000]<IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0&, std::__1::tuple<>&>(IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0&, std::__1::tuple<>&) build_docker/./contrib/llvm-project/libcxx/include/tuple:1798:1
        #5 0x5636b80dcbb1 in ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0>(IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0&&)::'lambda'()::operator()() build_docker/./src/Common/ThreadPool.h:228:13
        #6 0x5636b80dcbb1 in decltype(std::declval<IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0>()()) std::__1::__invoke[abi:v15000]<ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0>(IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0&&)::'lambda'()&>(IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0&&) build_docker/./contrib/llvm-project/libcxx/include/__functional/invoke.h:394:23
        #7 0x5636b80dcbb1 in void std::__1::__invoke_void_return_wrapper<void, true>::__call<ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0>(IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0&&)::'lambda'()&>(ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0>(IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0&&)::'lambda'()&) build_docker/./contrib/llvm-project/libcxx/include/__functional/invoke.h:479:9
        #8 0x5636b80dcbb1 in std::__1::__function::__default_alloc_func<ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0>(IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0&&)::'lambda'(), void ()>::operator()[abi:v15000]() build_docker/./contrib/llvm-project/libcxx/include/__functional/function.h:235:12
        #9 0x5636b80dcbb1 in void std::__1::__function::__policy_invoker<void ()>::__call_impl<std::__1::__function::__default_alloc_func<ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0>(IOResourceStaticResourceManager_Prioritization_Test::TestBody()::$_0&&)::'lambda'(), void ()>>(std::__1::__function::__policy_storage const*) build_docker/./contrib/llvm-project/libcxx/include/__functional/function.h:716:16
        #10 0x5636ea219310 in std::__1::__function::__policy_func<void ()>::operator()[abi:v15000]() const build_docker/./contrib/llvm-project/libcxx/include/__functional/function.h:848:16
        #11 0x5636ea219310 in std::__1::function<void ()>::operator()() const build_docker/./contrib/llvm-project/libcxx/include/__functional/function.h:1187:12
        #12 0x5636ea219310 in ThreadPoolImpl<std::__1::thread>::worker(std::__1::__list_iterator<std::__1::thread, void*>) build_docker/./src/Common/ThreadPool.cpp:416:13
        #13 0x5636ea2258ac in void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, long, std::__1::optional<unsigned long>, bool)::'lambda0'()::operator()() const build_docker/./src/Common/ThreadPool.cpp:180:73
        #14 0x5636ea2258ac in decltype(std::declval<void>()()) std::__1::__invoke[abi:v15000]<void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, long, std::__1::optional<unsigned long>, bool)::'lambda0'()>(void&&) build_docker/./contrib/llvm-project/libcxx/include/__functional/invoke.h:394:23
        #15 0x5636ea2258ac in void std::__1::__thread_execute[abi:v15000]<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct>>, void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, long, std::__1::optional<unsigned long>, bool)::'lambda0'()>(std::__1::tuple<void, void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, long, std::__1::optional<unsigned long>, bool)::'lambda0'()>&, std::__1::__tuple_indices<>) build_docker/./contrib/llvm-project/libcxx/include/thread:284:5
        #16 0x5636ea2258ac in void* std::__1::__thread_proxy[abi:v15000]<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct>>, void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, long, std::__1::optional<unsigned long>, bool)::'lambda0'()>>(void*) build_docker/./contrib/llvm-project/libcxx/include/thread:295:5
        #17 0x7f7d8fcf1608 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x8608) (BuildId: 7b4536f41cdaa5888408e82d0836e33dcf436466)
        #18 0x7f7d8fc16132 in __clone (/lib/x86_64-linux-gnu/libc.so.6+0x11f132) (BuildId: 1878e6b475720c7c51969e69ab2d276fae6d1dee)

    Address 0x7f7d8d621970 is located in stack of thread T0 at offset 368 in frame
        #0 0x5636b80d9bef in IOResourceStaticResourceManager_Prioritization_Test::TestBody() build_docker/./src/IO/Resource/tests/gtest_resource_manager_static.cpp:46

      This frame has 10 object(s):
        [32, 36) 'requests_per_thead' (line 48)
        [48, 208) 't' (line 49)
        [272, 296) 'ref.tmp' (line 51)
        [336, 352) 'last_priority' (line 74)
        [368, 376) 'check' (line 75) <== Memory access at offset 368 is inside this variable
        [400, 424) 'name' (line 83)
        [464, 512) 'ref.tmp13' (line 87)
        [544, 560) 'c' (line 101)
        [576, 600) 'ref.tmp32' (line 101)
        [640, 664) 'ref.tmp41' (line 102)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 21:32:13 +02:00
Azat Khuzhin
d8dd50a9c6 Fix misc-misplaced-const clang-tidy warning
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 21:27:21 +02:00
Azat Khuzhin
0610865811 Fix readability-redundant-string-cstr clang-tidy warning
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 21:22:05 +02:00
Azat Khuzhin
d03ae2abfa Fix modernize-loop-convert clang-tidy warning
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 21:19:37 +02:00
Azat Khuzhin
fa4099bef8 Update 02417_opentelemetry_insert_on_distributed_table for clang 16
CI: https://s3.amazonaws.com/clickhouse-test-reports/49678/6e9985a94d88d49169a48551ba8910c2b373d0de/stateless_tests__debug__[1_5].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 20:59:24 +02:00
Nikita Mikhaylov
df97f5890a Done 2023-05-09 20:58:59 +02:00
Azat Khuzhin
051d0e57ff Suppress bugprone-standalone-empty in DatabaseMySQL
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 20:47:52 +02:00
Azat Khuzhin
e1d7f466cb Disable misc-use-anonymous-namespace check in clang-tidy
It is too noisy during upgrade:

$ grep error: build_log.log | awk '{print $NF}' | sort | uniq -c
      1 [bugprone-standalone-empty,-warnings-as-errors]
      1 [misc-misplaced-const,-warnings-as-errors]
   2147 [misc-use-anonymous-namespace,-warnings-as-errors]
      6 [modernize-loop-convert,-warnings-as-errors]
      9 [readability-redundant-string-cstr,-warnings-as-errors]

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 20:43:52 +02:00
Azat Khuzhin
be39e8e566 Merge remote-tracking branch 'u/master' into build/llvm-16
Conflicts:
	docker/test/codebrowser/Dockerfile
2023-05-09 20:40:43 +02:00
Azat Khuzhin
833652b7c9 Revert "Suppress clang-analyzer-cplusplus.NewDelete in MsgPackRowInputFormat"
Let's try to revert this quirk during upgrading to clang 16.

This reverts commit c1e70169d2.
2023-05-09 20:36:39 +02:00
Azat Khuzhin
184efcb77a Get back -fno-sanitize-address-use-after-scope quirk for llvm/clang-15
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 20:35:43 +02:00
Azat Khuzhin
432250a85d Update instructions for building under OSX to clang-16
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 20:28:38 +02:00
Han Fei
ddce47f79e refine table source for regexp tree dictionary 2023-05-09 20:17:54 +02:00
DanRoscigno
0a83f2aee8 fix broken note rendering 2023-05-09 13:29:59 -04:00
kssenii
c20aa0786d More logging 2023-05-09 19:29:57 +02:00
Dan Roscigno
c75e056d98
Update docs/en/engines/table-engines/mergetree-family/replacingmergetree.md 2023-05-09 13:18:42 -04:00
Dan Roscigno
199838e7fb
Update docs/en/engines/table-engines/mergetree-family/replacingmergetree.md 2023-05-09 13:18:35 -04:00
Dan Roscigno
cd62df4887
Update docs/en/engines/table-engines/mergetree-family/replacingmergetree.md 2023-05-09 13:18:26 -04:00
Dan Roscigno
582767e9ab
Update docs/en/engines/table-engines/mergetree-family/replacingmergetree.md 2023-05-09 13:18:18 -04:00
Dan Roscigno
2e20603b01
Update docs/en/engines/table-engines/mergetree-family/replacingmergetree.md 2023-05-09 13:18:09 -04:00
kssenii
abc909fb21 Merge remote-tracking branch 'upstream/master' into add-logging-for-try-reserve 2023-05-09 19:13:58 +02:00
kssenii
13b77f1dac Fix 2023-05-09 19:13:39 +02:00
Nikita Taranov
3f6ca2f9e8
Backport fix for UBSan error in musl/logf.c 2023-05-09 19:05:40 +02:00
Constantine Peresypkin
cef9862628 docs: fix the is_deleted option docs
- `is_deleted` type __must__ be `UInt8` and not `Int8`
- strange wording on how `clean_deleted_rows` works is fixed
2023-05-09 12:40:33 -04:00
Anton Popov
d88224dc43 fix build 2023-05-09 16:30:43 +00:00
Nikita Taranov
7cd6db3fb3
Enable do_not_evict_index_and_mark_files by default 2023-05-09 18:04:47 +02:00
kssenii
a899b5a399 Ping CI 2023-05-09 18:00:05 +02:00
Dmitry Novik
1da54538f1
Merge branch 'master' into fix-cnf-new-analyzer 2023-05-09 17:31:05 +02:00
kssenii
75aa775d2b Add logging 2023-05-09 15:58:20 +02:00
Nikolay Degterinsky
b7d8c99fbe Fix member call on null pointer in fuzzer 2023-05-09 13:12:11 +00:00
serxa
459181568c remove not used ErrorCodes 2023-05-09 11:54:25 +00:00
alesapin
a2eaa79b37
Merge pull request #49676 from ClickHouse/fix_database_replica_recovery
Correctly update log pointer during database replica recovery
2023-05-09 13:17:24 +02:00
alesapin
277b42451e
Merge branch 'master' into fix_database_replica_recovery 2023-05-09 13:06:45 +02:00
Mikhail f. Shiryaev
4ae18c2a0b
Merge pull request #49692 from ClickHouse/fix-browser
Fix a wrong built generator removal, use `depth=1`
2023-05-09 12:52:10 +02:00
Mikhail f. Shiryaev
780b5a6f97
Fix a wrong built generator removal, use depth=1 2023-05-09 12:36:02 +02:00
Azat Khuzhin
6e9985a94d Remove removed in clang 16 -fexperimental-new-pass-manager
"The -fexperimental-new-pass-manager and -fno-legacy-pass-manager flags
have been removed. These flags have been silently ignored since Clang
15."

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 12:22:14 +02:00
Azat Khuzhin
a794177dc3 Use __powerpc64__ over __ppc64__ (clang 16 stops declaring __ppc64__)
From the release notes [1]:

    To match GCC, __ppc64__ is no longer defined on PowerPC64 targets. Use __powerpc64__ instead.

  [1]: https://releases.llvm.org/16.0.0/tools/clang/docs/ReleaseNotes.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 12:20:50 +02:00
Han Fei
f28834f60b fix fast test 2023-05-09 12:12:35 +02:00
Duyet Le
4c7849a9c8
Fix incorrect docs for use_query_cache 2023-05-09 17:08:49 +07:00
Nikolay Degterinsky
39deaf4f2a
Merge pull request #49632 from evillique/fix-ssl-test
Try to fix integration test 'test_ssl_cert_authentication'
2023-05-09 11:53:21 +02:00
vdimir
6bb552377f
Merge pull request #49085 from ClibMouse/saveIntervals 2023-05-09 11:33:05 +02:00
Kseniia Sumarokova
abde991cc4
Merge pull request #49675 from ClickHouse/cache-cleanup-after-locking-rework
Some cache cleanup after rework locking
2023-05-09 11:29:45 +02:00
Azat Khuzhin
6ae41be0cc Add riscv64 support for boringssl
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 10:33:37 +02:00
Azat Khuzhin
8cfe0eb3f2 Do not change CMAKE_EXE_LINKER_FLAGS_INIT in toolchains
Otherwise check in PreLoad.cmake will throw.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 10:33:37 +02:00
Azat Khuzhin
bf17c819c3 docker: fix path to clang builtin headers for woboq code browser
By default woboq uses $version.$minor.$patch, while clang simply uses
$version:

    CMake Error at generator/CMakeLists.txt:77 (message):
      Could not find any clang builtins headers in
      /usr/lib/llvm-16/lib/clang/16.0.4/include

    # ls -d /usr/lib/llvm-16/lib/clang/16/include
    /usr/lib/llvm-16/lib/clang/16/include

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 10:31:55 +02:00
Azat Khuzhin
08b8b7e587 docker: remove symlink for libclang (not required anymore)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 10:30:02 +02:00
Azat Khuzhin
82536fedde docker: install libclang-16-dev for woboq code browser
Otherwise you will get the following error:

    CMake Error at /usr/lib/llvm-16/lib/cmake/clang/ClangTargets.cmake:792 (message):
      The imported target "clangBasic" references the file

         "/usr/lib/llvm-16/lib/libclangBasic.a"

      but this file does not exist.  Possible reasons include:

      * The file was deleted, renamed, or moved to another location.

      * An install or uninstall procedure did not complete successfully.

      * The installation package was faulty and contained

         "/usr/lib/llvm-16/lib/cmake/clang/ClangTargets.cmake"

      but not all the files it references.

    Call Stack (most recent call first):
      /usr/lib/llvm-16/lib/cmake/clang/ClangConfig.cmake:20 (include)
      generator/CMakeLists.txt:7 (Find_Package)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 10:25:50 +02:00