Commit Graph

3484 Commits

Author SHA1 Message Date
sundy-li
9aa7c7ef09 Fix same bug in another function 2021-01-11 11:35:56 +08:00
sundy-li
4865439130 Empty line after sql 2021-01-11 11:35:56 +08:00
sundy-li
893efab7c3 Fix AggregateFunctionGroupBitmapData bitmapOrCardinality using wrong variable 2021-01-11 11:35:56 +08:00
Ivan Lezhankin
ab6371fbf5 More tests into skip-list 2021-01-10 22:07:23 +03:00
alexey-milovidov
f7e7725b8e
Merge pull request #18884 from fuwhu/feature/fix-windowFunnel-inconsistency
fix the inconsistent result of windowFunnel in case of same timestamp for different events
2021-01-10 14:56:58 +03:00
alexey-milovidov
95ac01ab82
Merge pull request #18893 from ClickHouse/fix-clickhouse-local
Fix hang at shutdown in clickhouse-local
2021-01-10 13:26:44 +03:00
Amos Bird
44758935df
correct index analysis of WITH aliases 2021-01-10 17:40:47 +08:00
Azat Khuzhin
ff16f68116 Add a smoke test for SYSTEM RESTART REPLICAS 2021-01-10 12:40:41 +03:00
Azat Khuzhin
30741232d2 Drop RESTART REPLICAS from stateless tests to avoid locking lots of mutexes
Under TSan you can lock only not more then 64 mutexes from one thread at
once [1] [2], while RESTART REPLICAS can acquire more (it depends on the
number of replicated tables).

  [1]: https://github.com/google/sanitizers/issues/950#issuecomment-386711603
  [2]: b02eab9058/compiler-rt/lib/sanitizer_common/sanitizer_deadlock_detector.h (L67)

And since stress tests run tests in parallel, you can have more then 64
ReplicatedMergeTree tables at once (even though it is unlikely).

Fix this by using RESTART REPLICA table over RESTART REPLICAS.
2021-01-10 12:39:27 +03:00
Alexey Milovidov
79a38c4c6e Fix hang at shutdown in clickhouse-local 2021-01-10 06:35:05 +03:00
HuFuwang
d0378395c5 add tests 01646_fix_window_funnel_inconistency. 2021-01-10 07:49:11 +08:00
feng lv
94e1bc05d2 Merge branch 'master' of github.com:ClickHouse/ClickHouse into select-all 2021-01-09 16:07:52 +00:00
Azat Khuzhin
471deab63a Rename fsync_tmp_directory to fsync_directories for Distributed engine 2021-01-09 17:51:30 +03:00
Azat Khuzhin
b5ace27014 Add fsync support for Distributed engine.
Two new settings (by analogy with MergeTree family) has been added:

- `fsync_after_insert` - Do fsync for every inserted. Will decreases
  performance of inserts.

- `fsync_tmp_directory` - Do fsync for temporary directory (that is used
  for async INSERT only) after all part operations (writes, renames,
  etc.).

Refs: #17380 (p1)
2021-01-09 11:31:32 +03:00
feng lv
8ab2832324 Merge branch 'master' of github.com:ClickHouse/ClickHouse into select-all 2021-01-09 02:36:25 +00:00
Azat Khuzhin
a24be01025 Drop Kafka storage from 01645_system_table_engines for fasttest 2021-01-09 00:59:03 +03:00
Azat Khuzhin
c312676368 Add a smoke test for system.table_engines 2021-01-08 14:57:24 +03:00
sundy-li
5dbda5d627 Update tests 2021-01-08 16:18:12 +08:00
alexey-milovidov
45f53bacfa
Merge pull request #18845 from azat/fsync-fixes
Fix never worked fsync_part_directory/fsync_after_insert/in_memory_parts_insert_sync
2021-01-08 07:26:24 +03:00
Alexey Milovidov
ffa5bbd5fd Add SYSTEM SUSPEND command #15979 2021-01-07 22:19:33 +03:00
Azat Khuzhin
798fb4e842 Smoke coverage of various fsync capabilities 2021-01-07 19:30:25 +03:00
alexey-milovidov
a08db94343
Revert "Add metrics for part number in MergeTree in ClickHouse" 2021-01-07 16:40:52 +03:00
alexey-milovidov
f91626e7ff
Merge pull request #17838 from weeds085490/dev/add_metrics_for_parts
Add metrics for part number in MergeTree in ClickHouse
2021-01-07 15:27:04 +03:00
alexey-milovidov
0f28473ec1
Merge pull request #18808 from ClickHouse/lld-build-id
Generate build id when ClickHouse is linked with lld
2021-01-07 15:26:26 +03:00
alexey-milovidov
b73722e587
Merge pull request #18806 from azat/If-combinator-Nullable-fix
Fix *If combinator with unary function and Nullable types
2021-01-07 15:25:54 +03:00
feng lv
1a47cf8611 Merge branch 'master' of github.com:ClickHouse/ClickHouse into select-all 2021-01-07 10:26:28 +00:00
alexey-milovidov
65b4008d1f
Update 01600_count_of_parts_metrics.sh 2021-01-07 06:36:00 +03:00
Alexey Milovidov
6f75901ffb Update test 2021-01-07 04:09:18 +03:00
Azat Khuzhin
fdcfacda60 Fix *If combinator with Nullable types
sumIf(Nullable()) and similar unary functions (unary w/o If combinator)
was working incorrectly, since it returns "sum" from the getName()
helper, and so distributed query processing fails.

The problem is in the optimization in
AggregateFunctionIfNullUnary::add() for the unary functions. It pass
only one column to write result to, instead of all passed arguments +
result columns.
While AggregateFunctionIf::add() assumes that it accepts arguments  +
result columns, and use last column as a result.

Introduced-in: #16610
Fixes: #18210
2021-01-07 03:09:13 +03:00
Azat Khuzhin
6261d4135c Add sanity checks for Sim/Min hash arguments
Fixes: #18799
Fixes: #18524
2021-01-06 22:38:05 +03:00
alexey-milovidov
13e4579052
Merge pull request #18712 from amosbird/limitpartition
add max_partitions_to_read setting
2021-01-06 21:29:58 +03:00
alexey-milovidov
c944035f0b
Merge pull request #18699 from amosbird/exceptregex
column excepts with regex
2021-01-06 21:28:09 +03:00
alexey-milovidov
f84426ebef
Merge pull request #18771 from den-crane/tests/simple_aggregate_funcs2
more tests for simple aggregate functions in summingMT aggregatingMT try2
2021-01-06 21:26:06 +03:00
alexey-milovidov
49f70b3b5f
Merge pull request #18763 from azat/marks-corruption-test
Add a regression test for marks corruption
2021-01-06 21:20:55 +03:00
Alexey Milovidov
8ab40d2747 Newline 2021-01-06 21:06:34 +03:00
jianmei zhang
4950377fbf code changes according to reviewer's comments 2021-01-06 21:05:45 +03:00
jianmei zhang
2256227361 SQL compatibility: provide POSITION(needle IN haystack) syntax. 2021-01-06 21:05:45 +03:00
alexey-milovidov
417e685830
Merge pull request #18775 from ClickHouse/dont-insert-empty-blocks-distributed-sync
Do not insert empty blocks on sync Distributed INSERT
2021-01-06 20:06:35 +03:00
weeds085490
b2e4c0ee71 refine test 2021-01-06 19:29:51 +08:00
weeds085490
5f5b86b485 Merge remote-tracking branch 'origin' into dev/add_metrics_for_parts 2021-01-06 17:32:45 +08:00
Amos Bird
0260953a47
better 2021-01-06 17:18:48 +08:00
feng lv
beab4f98da Merge branch 'master' of github.com:ClickHouse/ClickHouse into select-all 2021-01-06 06:10:09 +00:00
Alexey Milovidov
438f0f971b Fix the issue with async Distributed INSERTs and network_compression_method #18741 2021-01-06 03:24:42 +03:00
Alexey Milovidov
d77dfeaafb Arcadia does not support distributed tables 2021-01-06 03:06:19 +03:00
Alexey Milovidov
7547aee66a Add a test 2021-01-06 03:05:45 +03:00
alexey-milovidov
d68fdd8798
Update 01640_marks_corruption_regression.sql 2021-01-06 02:05:02 +03:00
Denis Zhuravlev
d23409da50 more tests for simple aggregate functions in summingMT aggregatingMT 2021-01-05 16:25:35 -04:00
Alexey Milovidov
f8313a33aa Add test for some possible ambiguities in syntax 2021-01-05 23:10:10 +03:00
alexey-milovidov
202d1f2211
Merge pull request #18760 from spongedu/fix_#18701
[For #18707] MySQL compatibility: support DIV and MOD operators
2021-01-05 20:42:58 +03:00
alexey-milovidov
06143d73ca
Merge pull request #15260 from ClickHouse/revert-15259-revert-14962-log-avoid-deadlock
Avoid deadlocks in Log/TinyLog (part 2)
2021-01-05 20:12:17 +03:00
alexey-milovidov
2d1afa5dad
Merge pull request #18753 from ClickHouse/null-fuzz
Add a test from #15641
2021-01-05 19:58:57 +03:00
alexey-milovidov
06225f7910
Merge pull request #18749 from ClickHouse/uuid-fuzz
Don't allow conversion between UUID and numeric types
2021-01-05 19:57:33 +03:00
alexey-milovidov
2e98f6f4ee
Merge pull request #18745 from ClickHouse/dont-throw-from-parser
Do not throw from Parser
2021-01-05 19:57:17 +03:00
Azat Khuzhin
6c50f537a0 Add a regression test for marks corruption
In #17120 (that was reverted in #17918 already) marks adjustemnt was
introduced, but it may lead to corruption of marks files, that may cause
two things:
1) Incorrect marks files, which lead to reading more rows than there are
   (can be reproduced with `max_threads`>1 or/and `PREWHERE`, and
    `optimize_move_to_prewhere`)
2) Can't adjust last granule because it has X rows, but try to subtract Y
   rows (#9260)

And 1) is pretty hard to diagnosis, since it does not throw any error,
it just may return wrong result.

Fortunately both problems can be fixed with `OPTIMIZE TABLE ... [ FINAL]`.

Cc: @alesapin
Refs: #17943
Refs: #18223
2021-01-05 15:41:54 +03:00
feng lv
421feb8cf9 Merge branch 'master' of github.com:ClickHouse/ClickHouse into select-all 2021-01-05 07:47:11 +00:00
feng lv
3ca5cf18a4 remove throw exception
fix
2021-01-05 06:03:57 +00:00
spongedc
99335563d1 [For #18707] MySQL compatibility: support DIV and MOD operators 2021-01-05 13:03:19 +08:00
Alexey Milovidov
cbc54e2dd7 Merge branch 'master' into revert-15259-revert-14962-log-avoid-deadlock 2021-01-05 04:27:32 +03:00
Alexey Milovidov
a1ce6c4165 Fix errors 2021-01-05 04:26:29 +03:00
Alexey Milovidov
ab6798addd One more test 2021-01-05 04:03:38 +03:00
Alexey Milovidov
c2c1d97da2 Arcadia does not support distributed queries 2021-01-05 03:59:09 +03:00
Alexey Milovidov
f6dff13db8 Add a test for #14974 2021-01-05 03:56:56 +03:00
Alexey Milovidov
21467cf97a Added a test from #15641 2021-01-05 03:44:14 +03:00
Alexey Milovidov
06405531a1 Update tests 2021-01-05 02:58:16 +03:00
Alexey Milovidov
3bbdacc66b Update test 2021-01-05 01:35:54 +03:00
Alexey Milovidov
039edbb724 Don't allow conversion between UUID and numeric types 2021-01-05 01:33:59 +03:00
Alexey Milovidov
36ad289cdb Merge branch 'master' into summap-check 2021-01-04 21:15:37 +03:00
feng lv
c70ab6a18a fix
fix
2021-01-04 15:47:04 +00:00
Alexey Milovidov
21cb0f21ad Moved "max_result_rows" test to bugs 2021-01-04 17:52:23 +03:00
feng lv
7a04724b3c add select all syntax 2021-01-04 14:23:17 +00:00
Alexey Milovidov
c07bff15aa Merge branch 'master' into summap-check 2021-01-04 17:11:48 +03:00
alexey-milovidov
750a391716
Merge pull request #18708 from ClickHouse/limit-fuzz
Added a test for #13477
2021-01-04 16:45:36 +03:00
alexey-milovidov
0b56bec69c
Merge pull request #15162 from 4ertus2/joins
Fix crash in not equi join on
2021-01-04 16:37:16 +03:00
alexey-milovidov
5332b0327c
Merge pull request #18702 from ClickHouse/fix-fuzz-test-msan
Add a test for already fixed issue
2021-01-04 16:35:41 +03:00
zhang2014
84ddff92f2 ISSUES-7690 try fix nullable string type convert to decimal type 2021-01-04 20:40:33 +08:00
Amos Bird
a157a5b3b3
add max_partitions_to_read setting 2021-01-04 12:40:48 +08:00
Alexey Milovidov
fbed8bb426 Fix fuzz errors in sumMap 2021-01-04 04:54:00 +03:00
Alexey Milovidov
17ff7e3413 Added a test for #13477 2021-01-04 03:52:45 +03:00
Alexey Milovidov
53ffaa89bf Merge branch 'master' into 4ertus2-joins-2 2021-01-04 02:19:57 +03:00
Alexey Milovidov
0f06b9631b Add a test for already fixed issue 2021-01-04 02:14:04 +03:00
Amos Bird
3145ca999d
column excepts with regex 2021-01-04 00:45:27 +08:00
Alexey Milovidov
9d5b2023e8 Fix tests 2021-01-03 19:12:22 +03:00
Alexey Milovidov
e8e9d0311a Fix shellcheck 2021-01-03 18:45:08 +03:00
Alexey Milovidov
da943ef95f Merge branch 'master' into revert-15259-revert-14962-log-avoid-deadlock 2021-01-03 18:07:58 +03:00
Alexey Milovidov
501785c397 Merge branch 'master' into function_byte_size 2021-01-03 18:07:40 +03:00
Alexey Milovidov
25b100761f Merge branch 'master' into function_byte_size 2021-01-03 04:36:48 +03:00
Alexey Milovidov
d059c245ab Add another test 2021-01-03 02:03:09 +03:00
Alexey Milovidov
a368a6802d Move implementation inside out 2021-01-03 01:58:10 +03:00
Alexey Milovidov
2a6388bdf6 Update test 2021-01-03 00:32:37 +03:00
Alexey Milovidov
820af3a48d Simplify code of function "bar" 2021-01-02 23:40:15 +03:00
sundyli
f8815f233c
Merge branch 'master' into alias_column_partition_prune 2021-01-02 11:23:55 +08:00
Alexey Milovidov
d8f2fed96f Add another test 2021-01-01 23:15:43 +03:00
Alexey Milovidov
1a90c569cb Merge branch 'master' into revert-15259-revert-14962-log-avoid-deadlock 2021-01-01 21:39:08 +03:00
alexey-milovidov
19e0e1a403
Merge pull request #17646 from azat/Buffer-memory-tracking
Do not ignore server memory limits during Buffer flush
2021-01-01 18:58:52 +03:00
Amos Bird
6a644b2af1
Fix SimpleAggregateFunction in SummingMergeTree 2 2021-01-01 12:42:22 +08:00
Nikita Mikhaylov
4165a58ce4
Merge pull request #11617 from nikitamikhaylov/parallel-parsing-input-format
Parallel formatting
2020-12-31 21:22:16 +04:00
pingyu
b8b3c1f166 wip 2021-01-01 01:14:21 +08:00
Alexey Milovidov
f1e38c9e06 Merge branch 'master' into 4ertus2-joins-2 2020-12-31 17:45:27 +03:00
alexey-milovidov
c2f0451e39
Merge pull request #18362 from ClickHouse/allow_low_cardinality_key_alter
Add ability to change some types for primary key
2020-12-31 15:27:52 +03:00
alexey-milovidov
a2e1f21ef2
Merge pull request #18637 from amosbird/summingsimple
Fix SimpleAggregateFunction in SummingMergeTree
2020-12-31 15:23:26 +03:00