thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-03 13:02:00 +00:00
Code Issues Packages Projects Releases Wiki Activity
59,490 Commits 9,183 Branches 1,782 Tags 2.2 GiB
0e379585ac
Commit Graph

59490 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Maksim Kita
6be5c271ae Added explicit function interface 2021-03-13 14:09:56 +03:00
Azat Khuzhin
833dbf1225 Mark 01294_lazy_database_concurrent_recreate_reattach_and_show_tables as long 2021-03-13 13:43:17 +03:00
Azat Khuzhin
092b0b49f0 Set SOCK_CLOEXEC for sockets (hardcoded via poco update) 
Found this in [1]:

    [Detaching after fork from child process 184152]
    ...
    Cannot get server pid with {}, got {}: {} lsof -i tcp:9000 -s tcp:LISTEN -Fp | awk '/^p[0-9]+$/{print substr($0, 2)}' b'301\n184152\n' invalid literal for int() with base 10: b'301\n184152\n'

But the major idea is that parent process should not export any file
descriptors to childrens, otherwise this may create security and other
breaches (like extra pipe endpoints, ...)

  [1]: https://clickhouse-test-reports.s3.yandex.net/21511/d7d9638ceb6bd702f34a88ee54f8f83197e90af5/stress_test_(address).html#fail1

Refs: https://github.com/ClickHouse-Extras/poco/pull/35
 2021-03-13 13:00:16 +03:00
Azat Khuzhin
0c1b2f6d59 Update exception message for lack of attribute with access_to_key_from_attributes 2021-03-13 12:53:10 +03:00
Maksim Kita
79b061ac3c
Merge pull request #21668 from kitaisreal/dictionary-attributes-unique-names 
DictionaryStructure fix non unique attribute names
 2021-03-13 12:31:33 +03:00
Azat Khuzhin
2d66a5c393 Fix hang check for 00966_live_view_watch_events_http 
If INSERT was failed then WATCH EVENTS will hang:

    2021.03.12 23:45:33.666223 [ 1901 ] {} <Trace> DynamicQueryHandler: Request URI: /?allow_experimental_live_view=1&query=WATCH%20test.lv%20EVENTS
    ...
    2021.03.12 23:45:34.119465 [ 35492 ] {55f2c8ec-df9f-4e97-9acc-385ed5b5fde2} <Error> executeQuery: Code: 241, e.displayText() = DB::Exception: Memory limit (for user) exceeded: would use 153.99 MiB (attempt to allocate chunk of 4194729 bytes), maximum: 150.00 MiB (version 21.4.1.6239) (from [::1]:43910) (in query: INSERT INTO test.mt VALUES ), Stack trace (when copying this message, always include the lines below):
    ...

Hung check:

    elapsed:              597.835824299
    is_cancelled:         0
    query:                WATCH test.lv EVENTS
    thread_ids:           [1901]

gdb:

    Thread 133 (Thread 0x7f26ac95b700 (LWP 1901)):
    0  0x00007f2793d447b1 in pthread_cond_timedwait@@GLIBC_2.3.2 () from /lib/x86_64-linux-gnu/libpthread.so.0
    1  0x0000000008cbd5c5 in __tsan::call_pthread_cancel_with_cleanup(int (*)(void*, void*, void*), void*, void*, void*, void (*)(void*), void*) ()
    2  0x0000000008c4f134 in cond_wait(__tsan::ThreadState*, unsigned long, __tsan::ScopedInterceptor*, int (*)(void*, void*, void*), void*, void*, void*) ()
    3  0x0000000008c4f339 in pthread_cond_timedwait ()
    4  0x000000001831c8b6 in std::__1::__libcpp_condvar_timedwait (__cv=0x7b5801053520, __m=0x189, __ts=0x7f26ac9132b8) at ../contrib/libcxx/include/__threading_support:442
    5  std::__1::condition_variable::__do_timed_wait (this=0x7b5801053520, lk=..., tp=...) at ../contrib/libcxx/src/condition_variable.cpp:74
    6  0x00000000134fe7f2 in std::__1::condition_variable::wait_for<long long, std::__1::ratio<1l, 1000000l> > (this=this@entry=0x7b5801053520, __lk=..., __d=...) at ../contrib/libcxx/include/__mutex_base:462
    7  0x00000000134fe2c9 in DB::LiveViewEventsBlockInputStream::tryReadImpl (this=this@entry=0x7b5c0070ff98, blocking=false) at ../src/Storages/LiveView/LiveViewEventsBlockInputStream.h:180
    8  0x00000000134fd6e4 in DB::LiveViewEventsBlockInputStream::readImpl (this=0x189) at ../src/Storages/LiveView/LiveViewEventsBlockInputStream.h:115
    9  0x0000000012285593 in DB::IBlockInputStream::read (this=0x7b5c0070ff98) at ../src/DataStreams/IBlockInputStream.cpp:58
    10 0x00000000122afc7e in DB::copyDataImpl<std::__1::function<bool ()> const&, std::__1::function<void (DB::Block const&)> const&>(DB::IBlockInputStream&, DB::IBlockOutputStream&, std::__1::function<bool ()> const&, std::__1::function<void (DB::Block const&)> const&) (from=..., to=..., is_cancelled=..., progress=...) at ../src/DataStreams/copyData.cpp:26
    11 0x00000000122af8e1 in DB::copyData(DB::IBlockInputStream&, DB::IBlockOutputStream&, std::__1::function<bool ()> const&, std::__1::function<void (DB::Block const&)> const&) (from=..., to=..., is_cancelled=..., progress=...) at ../src/DataStreams/copyData.cpp:73
    12 0x0000000012cfc5e2 in DB::executeQuery(DB::ReadBuffer&, DB::WriteBuffer&, bool, DB::Context&, std::__1::function<void (std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)>) (istr=..., ostr=..., allow_into_outfile=false, context=..., set_result_details=...) at ../src/Interpreters/executeQuery.cpp:1033
    13 0x000000001357941d in DB::HTTPHandler::processQuery (this=this@entry=0x7b1c006f41b0, context=..., request=..., params=..., response=..., used_output=..., query_scope=...) at ../src/Server/HTTPHandler.cpp:772
    14 0x000000001357c507 in DB::HTTPHandler::handleRequest (this=<optimized out>, request=..., response=...) at ../src/Server/HTTPHandler.cpp:910
    15 0x00000000135f3081 in DB::HTTPServerConnection::run (this=<optimized out>) at ../src/Server/HTTP/HTTPServerConnection.cpp:48
    16 0x00000000161f9e73 in Poco::Net::TCPServerConnection::start (this=0x7b8c01554000) at ../contrib/poco/Net/src/TCPServerConnection.cpp:43
    17 0x00000000161fa59f in Poco::Net::TCPServerDispatcher::run (this=<optimized out>) at ../contrib/poco/Net/src/TCPServerDispatcher.cpp:113
    18 0x0000000016361732 in Poco::PooledThread::run (this=<optimized out>) at ../contrib/poco/Foundation/src/ThreadPool.cpp:199
    19 0x000000001635fcd0 in Poco::(anonymous namespace)::RunnableHolder::run (this=<optimized out>) at ../contrib/poco/Foundation/src/Thread.cpp:55
    20 0x000000001635e4d8 in Poco::ThreadImpl::runnableEntry (pThread=0x7b5400082538) at ../contrib/poco/Foundation/src/Thread_POSIX.cpp:345
    21 0x0000000008c4e36d in __tsan_thread_start_func ()
    22 0x00007f2793d3d609 in start_thread () from /lib/x86_64-linux-gnu/libpthread.so.0
    23 0x00007f2793c64293 in clone () from /lib/x86_64-linux-gnu/libc.so.6

Cc: @vzakaznikov
 2021-03-13 11:32:55 +03:00
Azat Khuzhin
68dff2d954 Mark 01018_ip_dictionary as long 
https://clickhouse-test-reports.s3.yandex.net/21692/481d897cadb6b1a309478f24a46efe506b7108d6/functional_stateless_tests_flaky_check_(address).html#fail1
 2021-03-13 11:06:49 +03:00
Alexey Milovidov
a446612e8a Remove currently unused code 2021-03-13 10:39:43 +03:00
Alexey Milovidov
6d91881f6a Remove currently unused code 2021-03-13 10:38:35 +03:00
Azat Khuzhin
a301aa64da Do not use system-wide SYSTEM STOP TTL MERGES, use per-table instead 
Fixes 01294_lazy_database_concurrent_recreate_reattach_and_show_tables
 2021-03-13 10:37:26 +03:00
Azat Khuzhin
1ce9293e97 Fix 01035_lc_empty_part_bug under stress tests 
Found in [1]:

    2021.03.12 23:32:58.897190 [ 436606 ] {97a08a8f-4630-44f8-ba18-a94c6fabbded} <Information> test_13.lc_empty_part_bug: Waiting mutation: mutation_3.txt
    ...
    2021.03.12 23:32:58.900444 [ 374 ] {} <Debug> test_13.lc_empty_part_bug: Current max source part size for mutation is 0 but part size 1. Will not mutate part all_1_1_0_2. Max size depends not only on available space, but also on settings 'number_of_free_entries_in_pool_to_execute_mutation' and 'background_pool_size'
    ...

Hang check:

    query:                alter table lc_empty_part_bug modify column s LowCardinality(String);
    elapsed:              2156.396613506

  [1]: https://clickhouse-test-reports.s3.yandex.net/21511/d7d9638ceb6bd702f34a88ee54f8f83197e90af5/stress_test_(address).html#fail1
 2021-03-13 10:31:19 +03:00
Alexey Milovidov
e8919c49fb Merge branch 'master' into replace-memcpy 2021-03-13 09:39:58 +03:00
Azat Khuzhin
481d897cad Fix SIGSEGV on not existing attributes from ip_trie with access_to_key_from_attributes 
Found with fuzzer [1]:

  [1]: https://clickhouse-test-reports.s3.yandex.net/21674/2e99dad56213413a72969d47650050b42cbcc073/fuzzer_asan/report.html#fail1
 2021-03-13 09:08:45 +03:00
Azat Khuzhin
eb3710c164 Fix error message in clickhouse-test 
{} was not replaced:

    Cannot get server pid with {}, got {}: {} lsof -i tcp:9000 -s tcp:LISTEN -Fp | awk '/^p[0-9]+$/{print substr($0, 2)}' b'306\n1025011\n' invalid literal for int() with base 10: b'306\n1025011\n'
 2021-03-13 08:43:41 +03:00
Maksim Kita
8312553d24 LibraryDictionarySource fix possible leak 2021-03-13 00:30:59 +03:00
Pavel Kruglov
58e415c7d4 Update clusters only if their configs were updated 2021-03-13 00:17:19 +03:00
Vladimir
b2a6a8feb8
Merge pull request #21658 from vdimir/fix-joins_in_memory 2021-03-12 22:48:04 +03:00
Alexander Kuzmenkov
388f5d5144
Update fuzzing-clickhouse.md 2021-03-12 22:38:43 +03:00
Azat Khuzhin
ff1cb65f0b Start accepting connections after DDLWorker and dictionaries initialization 
Found by integration tests [1]:

    Code: 139. DB::Exception: Received from 172.18.0.6:9000. DB::Exception: DDL background thread is not initialized. Stack trace:

  [1]: https://clickhouse-test-reports.s3.yandex.net/21643/65f90f2ce9ea9e9d4076f06c58ddd981c82cc098/integration_tests_(thread).html#fail1
 2021-03-12 21:48:13 +03:00
Maksim Kita
12e411f8b9 PODArray swap fix 2021-03-12 21:38:52 +03:00
alexey-milovidov
f6bedf55e9
Merge pull request #21642 from azat/fsync_part_directory-horizontal-merge-fix 
Fix fsync_part_directory for horizontal merge
 2021-03-12 21:22:55 +03:00
Michael Monashev
34915d0311
Fix ORDER BY syntax 2021-03-12 21:13:20 +03:00
Azat Khuzhin
2e99dad562 Tiny "machine" cleanup of test_replace_partition 2021-03-12 21:10:16 +03:00
Azat Khuzhin
5af5c90b8b Fix test_replace_partition flakiness 
test_replace_partition/test.py::test_replace_after_replace_failover
statistics:

```sql
┌──────ymd─┬─success─┬─failure─┐
│ 20200613 │      40 │       2 │
│ 20200614 │      98 │       2 │
│ 20200615 │     126 │       9 │
│ 20200616 │     141 │      10 │
│ 20200617 │     119 │       7 │
│ 20200618 │      87 │      12 │
│ 20200619 │      81 │       9 │
...
│ 20210305 │      60 │      28 │
│ 20210306 │      69 │       7 │
│ 20210307 │      42 │       0 │
│ 20210308 │      53 │       8 │
│ 20210309 │     137 │      23 │
│ 20210310 │      84 │      14 │
│ 20210311 │      81 │      20 │
└──────────┴─────────┴─────────┘
```
 2021-03-12 21:10:16 +03:00
Maksim Kita
49f6fd0923
Merge pull request #21662 from kitaisreal/executable-pool-fix-default-max-execution-time-setting 
ExecutablePool fix default max execution time setting
 2021-03-12 20:58:56 +03:00
Vitaliy Zakaznikov
3269e1d331 Updating TestFlows to 1.6.74 2021-03-12 12:32:32 -05:00
Kruglov Pavel
ab9a99babf
Merge pull request #21391 from ka1bi4/romanzhukov-DOCSUP-7100-avg 
DOCSUP-7100: Edit and translate to Russian (AVG function)
 2021-03-12 19:48:01 +03:00
Roman Bug
1c0c5f4441
Update avg.md 2021-03-12 19:44:36 +03:00
George
f89247d7bd updated attach.md 2021-03-12 19:28:04 +03:00
George
53fd7cb8a8 Updated example 2021-03-12 19:14:40 +03:00
gyuton
ca5e20a57d
Update docs/en/sql-reference/statements/detach.md 
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
 2021-03-12 19:11:27 +03:00
gyuton
ed87521fcf
Update docs/en/sql-reference/statements/detach.md 
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
 2021-03-12 19:10:01 +03:00
gyuton
b3f8ac796c
Update docs/en/sql-reference/statements/detach.md 
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
 2021-03-12 19:09:55 +03:00
Vasily Nemkov
f4246e7be5
Merge branch 'master' into governance/query_log 2021-03-12 18:31:08 +03:00
tavplubix
a10c4c9ded
Update Dockerfile 2021-03-12 18:26:35 +03:00
Pavel Kruglov
7f2d03b128 Change test 2021-03-12 18:24:59 +03:00
Maksim Kita
8443ff563b Fixed code review issues 2021-03-12 18:22:04 +03:00
Alexander Kuzmenkov
5e5e54af30
Update fuzzing-clickhouse.md 2021-03-12 18:13:21 +03:00
robot-clickhouse
ede0031dc4 Update version_date.tsv after release 21.3.2.5 2021-03-12 18:08:46 +03:00
Nikita Mikhaylov
e234990cf6
Merge pull request #19257 from nikitamikhaylov/geometry_functions 
Merging geometry functions
 2021-03-12 17:05:24 +03:00
Maksim Kita
97a58777b8 DictionaryStructure fix non unique attribute names 2021-03-12 16:36:42 +03:00
Alexander Kuzmenkov
122790efd1
Merge pull request #21629 from ucasFL/errorcode 
redefine some errorcode
 2021-03-12 16:25:13 +03:00
Nikita Mikhaylov
a14110a9a5
Merge pull request #21497 from olgarev/DOCSUP-6545_edit_and_translate 
DOSCUP-6545: Edit and translate
 2021-03-12 16:04:31 +03:00
tavplubix
e3141124fd
Merge pull request #20946 from ClickHouse/stress_test_results 
Move some CI-related scripts to github
 2021-03-12 15:54:15 +03:00
Maksim Kita
1b908cad88 ExecutablePool fix default max execution time setting 2021-03-12 15:37:56 +03:00
Alexander Kuzmenkov
8529b6a5bb
Update fuzzing-clickhouse.md 2021-03-12 15:23:38 +03:00
Pavel Kruglov
b83564bdad Add test for path as a query parameter in system.zookeeper 2021-03-12 15:08:00 +03:00
Kruglov Pavel
2e7f756d7c
Merge pull request #21494 from ucasFL/format 
add --backslash option for clickhouse-format
 2021-03-12 14:31:58 +03:00
Nikita Mikhaylov
e4b4665ff5 better 2021-03-12 13:58:03 +03:00
feng lv
1eba096f2a fix conflict 2021-03-12 10:28:04 +00:00