Dmitry Novik
71b6f89166
Merge pull request #35637 from ClickHouse/memory-overcommit-free
...
Memory overcommit: continue query execution if memory is available
2022-05-02 19:00:18 +02:00
kssenii
70e2bb6264
Reimplement write-through cache
2022-05-02 18:55:11 +02:00
Ilya Yatsishin
6c3bbb4933
Add Other Time Microseconds Profile Event
2022-05-02 17:13:57 +02:00
Vladimir C
7293a69e5e
Merge pull request #36656 from amosbird/timefunctionunderflow
...
Saturate date/datetime to zero (part 2)
2022-05-02 17:10:48 +02:00
Maksim Kita
9bea207680
Merge pull request #36839 from rschu1ze/concepts
...
Replace uses of SFINAE by C++20 concepts
2022-05-02 14:20:12 +02:00
Robert Schulze
ad0b3be79d
Replace uses of SFINAE by C++20 concepts
...
- enable_if is usually regarded as fragile and unreadable
- C++20 concepts are much easier to read and produce more expressive
error messages
2022-05-02 09:23:53 +02:00
Robert Schulze
330212e0f4
Remove inherited create() method + disallow copying
...
The original motivation for this commit was that shared_ptr_helper used
std::shared_ptr<>() which does two heap allocations instead of
make_shared<>() which does a single allocation. Turned out that
1. the affected code (--> Storages/) is not on a hot path (rendering the
performance argument moot ...)
2. yet copying Storage objects is potentially dangerous and was
previously allowed.
Hence, this change
- removes shared_ptr_helper and as a result all inherited create() methods,
- instead, Storage objects are now created using make_shared<>() by the
caller (for that to work, many constructors had to be made public), and
- all Storage classes were marked as noncopyable using boost::noncopyable.
In sum, we are (likely) not making things faster but the code becomes
cleaner and harder to misuse.
2022-05-02 08:46:52 +02:00
Alexey Milovidov
ef9633499c
Merge branch 'master' into fix-trash-s3-metrics
2022-05-02 03:55:10 +02:00
KinderRiven
7d0789472c
fix
2022-05-01 19:45:16 +08:00
KinderRiven
e1acacf831
fix
2022-05-01 19:45:16 +08:00
KinderRiven
d80aa0fd17
impl system.filesystem_cache_log
2022-05-01 19:45:16 +08:00
KinderRiven
d595df1604
fix
2022-05-01 19:45:16 +08:00
KinderRiven
6a2e4559c8
impl system.cache_log
2022-05-01 19:45:16 +08:00
KinderRiven
ce9a6965d0
impl system.log_table
2022-05-01 19:45:16 +08:00
KinderRiven
a4b8f9e9cf
impl system.cache_log
2022-05-01 19:45:16 +08:00
KinderRiven
9c9870f021
build cache_log table
2022-05-01 19:45:16 +08:00
KinderRiven
5a361a0db5
impl cache_log in filecache
2022-05-01 19:45:16 +08:00
KinderRiven
5b7b2d26ea
fix add miss header
2022-05-01 19:45:16 +08:00
KinderRiven
df81496ba1
fix bug for cache log table
2022-05-01 19:45:16 +08:00
KinderRiven
de7e89661d
resubmit
2022-05-01 19:45:16 +08:00
kssenii
8cf83a2daf
Fix
2022-04-30 22:02:44 +02:00
Robert Schulze
89aa9ae00f
Fixed clang-tidy check "bugprone-branch-clone"
...
The check is currently *not* part of .clang-tidy. It complains about:
(1) "switch has multiple consecutive identical branches"
(2) "repeated branch in conditional chain"
About (1): Lots of findings in switches were about redundant
"[[fallthrough]]" in places where the compiler would not warn anyways. I
have cleaned these up.
About (2): In if-else_if-else chains, fixing the warning would usually
mean concatenating multiple if-conditions. As this would reduce
readability in most cases, I did not fix these places.
Because of (2), I also refrained from adding "bugprone-branch-clone" to
.clang-tidy.
2022-04-30 19:40:28 +02:00
Kseniia Sumarokova
66f62b2ba6
Merge pull request #36632 from DevTeamBK/Fix-Coverity-Issues
...
Minor Coverity defects fixes
2022-04-30 15:11:40 +02:00
kssenii
eea0a009dc
Debug
2022-04-30 15:02:21 +02:00
Alexey Milovidov
1ddb04b992
Merge pull request #36715 from amosbird/refactorbase
...
Reorganize source files so that base won't depend on Common
2022-04-30 09:40:58 +03:00
HeenaBansal2009
042157efca
Clang -Tidy Fixes
2022-04-29 20:17:45 -07:00
mergify[bot]
e9fde5d067
Merge branch 'master' into memory-overcommit-free
2022-04-29 19:31:59 +00:00
Nikolai Kochetov
5807ca47b0
Merge pull request #36425 from ClickHouse/pool-size-hot-reload
...
Allow to increase number of threads and tasks for background executors
2022-04-29 17:24:12 +02:00
Kseniia Sumarokova
ca994e0861
Merge pull request #36660 from kssenii/fix-stress-test
...
Fix stress test after 36639
2022-04-29 12:56:25 +02:00
Amos Bird
4a5e4274f0
base should not depend on Common
2022-04-29 10:26:35 +08:00
Amos Bird
e81929a8b5
Saturate date/datetime to zero (part 2)
...
For partial hours/minutes timezones.
2022-04-29 10:24:18 +08:00
Kseniia Sumarokova
ace3fe253d
Merge pull request #36737 from KinderRiven/fix_bug_for_local_cache
...
fix bug for local cache
2022-04-29 02:54:33 +02:00
mergify[bot]
41aa85fd4c
Merge branch 'master' into fix-stress-test
2022-04-29 00:54:09 +00:00
kssenii
1cbf672237
Another fix
2022-04-28 22:51:57 +02:00
Alexey Milovidov
d8fa806fca
Merge pull request #36360 from ClickHouse/optimize-asynchronous-metric-log
...
Optimize `system.asynchronous_metric_log`
2022-04-28 20:16:17 +03:00
Dmitry Novik
8fb7e2dbab
Cleanup
2022-04-28 15:31:13 +00:00
HeenaBansal2009
3ac9434c57
Merge branch 'master' into Fix-Coverity-Issues
2022-04-28 08:14:50 -07:00
kssenii
9b38c9f7eb
Fix
2022-04-28 13:06:43 +02:00
Kseniia Sumarokova
0c2f074c60
Update FileCache.cpp
2022-04-28 12:47:02 +02:00
Kseniia Sumarokova
2039e0e974
Update FileCache.h
2022-04-28 12:46:45 +02:00
KinderRiven
63804fd425
fix
2022-04-28 18:45:01 +08:00
KinderRiven
1fbaddf559
fix bug for local_cache
2022-04-28 17:11:25 +08:00
Vitaly Baranov
641a5f5e35
Merge pull request #36198 from vitlibar/backup-improvements-3
...
Backup for replicated tables and other improvements
2022-04-28 09:23:53 +02:00
Alexey Milovidov
de3a47c67a
Merge branch 'master' into optimize-asynchronous-metric-log
2022-04-28 05:03:57 +02:00
kssenii
37d11cfb1c
Merge master
2022-04-28 00:44:15 +02:00
mergify[bot]
b7e63154df
Merge branch 'master' into optimize-asynchronous-metric-log
2022-04-27 18:27:27 +00:00
kssenii
da1392877a
Better
2022-04-27 20:01:59 +02:00
mergify[bot]
9410e2813f
Merge branch 'master' into fix-stress-test
2022-04-27 14:51:55 +00:00
HeenaBansal2009
4961caec13
Merge branch 'master' into Fix-Coverity-Issues
2022-04-26 11:43:44 -07:00
kssenii
64168faf0a
Fix
2022-04-26 20:31:42 +02:00
HeenaBansal2009
a34fca27d5
Incorporated review comments
2022-04-26 11:12:14 -07:00
HeenaBansal2009
13a9a8fd5e
Style check fix
2022-04-26 07:13:09 -07:00
HeenaBansal2009
267f426605
Minor Coverity defetcs fixes
2022-04-26 07:13:09 -07:00
mergify[bot]
7571387a6e
Merge branch 'master' into memory-overcommit-free
2022-04-26 10:15:18 +00:00
kssenii
b874750807
Better
2022-04-26 12:13:21 +02:00
kssenii
41bba15e20
Fix
2022-04-26 12:09:58 +02:00
Vladimir C
1aa9d77246
Merge pull request #36453 from zombee0/master
2022-04-26 11:47:42 +02:00
Kseniia Sumarokova
81db081b88
Merge pull request #36639 from kssenii/better-drop-cache
...
Improve drop cache query
2022-04-26 11:25:46 +02:00
Vitaly Baranov
1c0b731ea6
Fix compilation.
2022-04-26 10:13:08 +02:00
mergify[bot]
4e82b56a8d
Merge branch 'master' into optimize-asynchronous-metric-log
2022-04-26 05:40:49 +00:00
Alexey Milovidov
86bf67c93c
Merge pull request #36526 from Joeywzr/to_start_of_five_minutes
...
Replace toStartOfFiveMinute to toStartOfFiveMinutes
2022-04-26 05:52:02 +03:00
alesapin
92296484e7
Merge pull request #36348 from rschu1ze/erase_if3
...
Replace remove-erase idiom by C++20 erase()/erase_if()
2022-04-25 23:34:18 +02:00
alesapin
7a901c0826
Merge pull request #36602 from azat/netlink-strict-resubmit
...
Strict taskstats parser (resubmit)
2022-04-25 23:28:08 +02:00
alesapin
04afe552f8
Trying to avoid segfaults
2022-04-25 22:51:09 +02:00
kssenii
35b8d302da
Fix
2022-04-25 21:57:13 +02:00
alesapin
1fffa56f63
Merge branch 'master' into memory-overcommit-free
2022-04-25 20:21:08 +02:00
mergify[bot]
d2ac9b2223
Merge branch 'master' into to_start_of_five_minutes
2022-04-25 17:36:38 +00:00
mergify[bot]
e79de5a577
Merge branch 'master' into optimize-asynchronous-metric-log
2022-04-25 17:29:11 +00:00
mergify[bot]
fdc895462e
Merge branch 'master' into fix-trash-s3-metrics
2022-04-25 17:28:06 +00:00
kssenii
a76a35d3ce
Better drop cache
2022-04-25 19:20:25 +02:00
Vitaly Baranov
d20b3d78c5
Rename some restore settings.
2022-04-25 16:34:17 +02:00
Sergei Trifonov
ad9d57807f
fix typo
2022-04-25 16:06:14 +02:00
Kruglov Pavel
34c342fdd3
Merge pull request #36205 from Avogar/improve-globs
...
Some refactoring around schema inference with globs
2022-04-25 13:14:46 +02:00
Nikolai Kochetov
d5b2d28f7b
Merge pull request #36579 from amosbird/refactor-executor1
...
Small refactoring of Processors and QueryPipeline
2022-04-25 12:47:59 +02:00
Antonio Andelic
d60384d336
Merge pull request #36469 from bigo-sg/fix_ranger_generator
...
Fix bug of range generator
2022-04-25 10:52:34 +02:00
Azat Khuzhin
278101fc0c
Add a comment for taskstruct netlink interface rounding to KiB
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-25 08:49:17 +03:00
Azat Khuzhin
d161b798a8
Strict taskstats parser
...
This will unhide possible issues (since sometimes statistics is
inaccurate).
Also before this patch TASKSTATS_TYPE_AGGR_TGID had been handled, while
it not correct to take into account, but it was not requested anyway.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
(cherry picked from commit bfa65b651a
2022-04-25 07:56:54 +03:00
Azat Khuzhin
6df54611a9
Log which taskstats provider is in use
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
v2: add missing __builtin_unreachable() for gcc built [1]
[1]: https://s3.amazonaws.com/clickhouse-builds/36351/99e72a960325cc1fb3cd3d6a1b56cf2b1cc2d733/binary_gcc/build_log.log
(cherry picked from commit 2be022cb56
2022-04-25 07:56:54 +03:00
mergify[bot]
705d5af3a0
Merge branch 'master' into to_start_of_five_minutes
2022-04-24 22:24:24 +00:00
Alexey Milovidov
74bb6349c2
Revert "Strict taskstats parser"
2022-04-25 01:15:08 +03:00
Amos Bird
a25bb50096
Refactor many exception messages
...
1. Always use fmt variant
2. Remove redundant period at the end of message
3. Remove useless parenthesis
2022-04-24 19:44:00 +08:00
taiyang-li
6716aa9d95
Merge remote-tracking branch 'ck/master' into fix_ranger_generator
2022-04-24 11:31:19 +08:00
Alexey Milovidov
8af3159916
Merge pull request #36351 from azat/netlink-strict
...
Strict taskstats parser
2022-04-24 05:14:06 +03:00
Alexey Milovidov
d08da0f63c
Everything related to S3 metrics was a trash
2022-04-24 03:46:35 +02:00
Alexey Milovidov
6de4f2bbff
Everything related to S3 metrics was a trash
2022-04-24 03:42:18 +02:00
zombee0
c02de61086
fixed the cow_compositions.cpp clone inner column when there is no need
...
Signed-off-by: zombee0 <flylucas_10@163.com>
2022-04-23 18:42:04 +08:00
alesapin
7380a71333
Merge pull request #31833 from ClickHouse/musl-check
...
Build clickhouse-keeper with Musl
2022-04-22 22:41:16 +02:00
Nikita Mikhaylov
36bdee0499
Deleted settings
2022-04-22 13:56:16 +00:00
Kseniia Sumarokova
33bb48106f
Merge pull request #36314 from CurtizJ/print-bad-filenames
...
Show names of erroneous files in case of parsing errors while executing table functions
2022-04-22 13:24:55 +02:00
taiyang-li
3751c69aaa
fix code style
2022-04-22 15:38:19 +08:00
taiyang-li
6bcf24ae36
add test for range generator
2022-04-22 12:33:16 +08:00
Memo
956d525840
fix conflict
2022-04-22 11:22:50 +08:00
Memo
39aadf0975
replaced toStartOfFiveMinute to toStartOfFiveMinutes
2022-04-22 10:49:59 +08:00
Maksim Kita
57444fc7d3
Merge pull request #36444 from rschu1ze/clang-tidy-fixes
...
Clang tidy fixes
2022-04-21 16:11:27 +02:00
mergify[bot]
1ba1cad5cf
Merge branch 'master' into improve-globs
2022-04-21 11:52:13 +00:00
taiyang-li
adb1288e10
fix bug of range generator
2022-04-21 11:33:15 +08:00
Azat Khuzhin
2be022cb56
Log which taskstats provider is in use
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
v2: add missing __builtin_unreachable() for gcc built [1]
[1]: https://s3.amazonaws.com/clickhouse-builds/36351/99e72a960325cc1fb3cd3d6a1b56cf2b1cc2d733/binary_gcc/build_log.log
2022-04-20 21:39:26 +03:00
Azat Khuzhin
bfa65b651a
Strict taskstats parser
...
This will unhide possible issues (since sometimes statistics is
inaccurate).
Also before this patch TASKSTATS_TYPE_AGGR_TGID had been handled, while
it not correct to take into account, but it was not requested anyway.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-20 21:39:25 +03:00
Kruglov Pavel
813e228fcc
Merge branch 'master' into improve-globs
2022-04-20 16:31:47 +02:00
Anton Popov
d4df38a0e6
fix tests
2022-04-20 14:13:04 +00:00
