Commit Graph

34 Commits

Author SHA1 Message Date
Azat Khuzhin
cd74da4c03 Remove unused code in StorageSystemStackTrace
This columns mask is actually useless, since the main thing is done
without out, in particular:
- detect does the signal should be sent to thread
- does the thread name should be read for this thread

And this cannot be done with columns mask, because multiple columns
depends on signals and thread names.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-08-02 21:25:00 +02:00
Alexey Milovidov
6b742bb1d1
Merge branch 'master' into system-stack-trace-fix 2023-05-07 06:05:47 +03:00
Sema Checherinda
3c6deddd1d work with comments on PR 2023-03-16 19:55:58 +01:00
Alexander Tokmakov
70d1adfe4b
Better formatting for exception messages (#45449)
* save format string for NetException

* format exceptions

* format exceptions 2

* format exceptions 3

* format exceptions 4

* format exceptions 5

* format exceptions 6

* fix

* format exceptions 7

* format exceptions 8

* Update MergeTreeIndexGin.cpp

* Update AggregateFunctionMap.cpp

* Update AggregateFunctionMap.cpp

* fix
2023-01-24 00:13:58 +03:00
Alexey Milovidov
462e7f76bf Attempt to fix the "system.stack_trace" test 2022-12-27 13:28:25 +01:00
Azat Khuzhin
4e76629aaf Fixes for -Wshorten-64-to-32
- lots of static_cast
- add safe_cast
- types adjustments
  - config
  - IStorage::read/watch
  - ...
- some TODO's (to convert types in future)

P.S. That was quite a journey...

v2: fixes after rebase
v3: fix conflicts after #42308 merged
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:19 +02:00
Robert Schulze
13482af4ee
First try at reducing the use of StringRef
- to be replaced by std::string_view
- suggested in #39262
2022-07-17 17:26:02 +00:00
Azat Khuzhin
531e3b13ce Optimize accesses to system.stack_trace (filter by name before sending signal)
Because of failed rebase/push this part of the patch was lost, so
resending separatelly (sigh).

Follow-up for: #39177 (cc @yakov-olkhovskiy)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-14 11:49:34 +03:00
Azat Khuzhin
8122c1b07f Optimize accesses to system.stack_trace
- filter by thread_id
- filter by thread_name
- filter by requested columns (query_id/trace, thread_name)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-13 15:17:09 +03:00
Robert Schulze
1b81bb49b4
Enable clang-tidy modernize-deprecated-headers & hicpp-deprecated-headers
Official docs:

  Some headers from C library were deprecated in C++ and are no longer
  welcome in C++ codebases. Some have no effect in C++. For more details
  refer to the C++ 14 Standard [depr.c.headers] section. This check
  replaces C standard library headers with their C++ alternatives and
  removes redundant ones.
2022-05-09 08:23:33 +02:00
Amos Bird
4a5e4274f0
base should not depend on Common 2022-04-29 10:26:35 +08:00
Alexey Milovidov
fe6b7c77c7 Rename "common" to "base" 2021-10-02 10:13:14 +03:00
Alexey Milovidov
4df8de76c8 Fix #24124 2021-07-11 03:34:00 +03:00
Maksim Kita
67e9b85951 Merge ext into common 2021-06-16 23:28:41 +03:00
tavplubix
42d5400e36
Update StorageSystemStackTrace.cpp 2021-05-17 12:07:50 +03:00
abel-wang
4edd5fbb35 Add thread_name in system.stack_trace 2021-05-17 12:44:57 +08:00
Ivan
495c6e03aa
Replace all Context references with std::weak_ptr (#22297)
* Replace all Context references with std::weak_ptr

* Fix shared context captured by value

* Fix build

* Fix Context with named sessions

* Fix copy context

* Fix gcc build

* Merge with master and fix build

* Fix gcc-9 build
2021-04-11 02:33:54 +03:00
Azat Khuzhin
7c04f15c80 Add log message when stacktrace cannot be obtained for thread
This is to provide better diagnostics for 01051_system_stack_trace
failure [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/20881/866dfaec793f764dc9ba167d3ac9f6521b9b3381/functional_stateless_tests_(release,_wide_parts_enabled).html#fail1
2021-02-20 09:13:00 +03:00
Alexander Tokmakov
ff6c3c75c2 add protection from unsafe allocations 2021-01-12 18:41:24 +03:00
alexey-milovidov
aedb1874af
Fix clang-tidy 2020-12-23 04:40:23 +03:00
Alexey Milovidov
b9df795595 Another code for TSan 2020-12-22 11:16:36 +03:00
Alexey Milovidov
7ca86f176c Fix TSan warning in system.stack_trace 2020-12-16 01:43:07 +03:00
Amos Bird
04128c33e1
disable TSAN for real 2020-12-12 14:17:48 +08:00
Amos Bird
0aa75e6023
Another try of TSan fix 2020-12-12 13:59:34 +08:00
alexey-milovidov
cfeaff6aa7
Update StorageSystemStackTrace.cpp 2020-12-12 13:59:34 +08:00
alexey-milovidov
b513eeee7f
Another try... 2020-12-12 13:59:34 +08:00
Amos Bird
5e71f4e810
Have to resort to NO_SANITIZE_THREAD 2020-12-12 13:59:34 +08:00
Amos Bird
c4306b5788
Another try of TSan fix 2020-12-12 13:59:34 +08:00
Amos Bird
d0044886ab
fix TSan 2020-12-12 13:59:34 +08:00
Amos Bird
4809b5975a
Fix system.stack_trace in daemon 2020-12-12 13:59:33 +08:00
Alexander Tokmakov
a6ff049eec use Atomic for system database 2020-08-12 23:40:13 +03:00
Alexey Milovidov
ea970fd57c Remove bad ugliness 2020-07-09 04:00:16 +03:00
Ivan Blinkov
709b4f42c8 Prototype sending crash reports on segfaults 2020-05-27 22:11:04 +03:00
Ivan Lezhankin
06446b4f08 dbms/ → src/ 2020-04-03 18:14:31 +03:00