Commit Graph

59512 Commits

Author SHA1 Message Date
Robert Schulze
0ed3466124
Cleanup FunctionArgumentDescriptor
const char * can be nullptr, std::string_view can't.
2024-07-02 16:30:48 +00:00
Alexey Milovidov
9d8cc51dc5
Merge pull request #65917 from azat/mysql-server-TLS-retries
Fix possible issues with MySQL server protocol TLS connections
2024-07-02 05:06:55 +00:00
Alexey Milovidov
3b1e1d01d4
Merge pull request #65848 from ClickHouse/Add_missing_workload_identity_changes
Add missing workload identity changes
2024-07-02 04:35:31 +00:00
Alexey Milovidov
3d67e6b127
Merge pull request #65928 from ClickHouse/follow-up-to-65046
Follow up to #65046
2024-07-02 03:27:08 +00:00
Alexey Milovidov
8a8b6a881b
Merge pull request #58970 from ClickHouse/dont-optimize-trivial-insert-select
Disable `optimize_trivial_insert_select` by default
2024-07-02 01:33:23 +00:00
Smita Kulkarni
ac648a1fe3 Fix build 2024-07-01 19:41:45 +02:00
kssenii
5541461b99 Fix time of writing to _log table 2024-07-01 16:04:43 +02:00
Azat Khuzhin
4f2a0e8eeb Fix possible issues with MySQL server protocol TLS connections
The problem here is that retries (in SecureSocketImpl.cpp::mustRetry())
relies on non-zero socket timeout, but MySQL handler does not set
timeouts for the socket (like other does), and this leads to a problem
when OpenSSL returns SSL_ERROR_WANT_READ/SSL_ERROR_WANT_WRITE, the
connection will be simply terminated.

I've played with this patch, by hacking the openssl sources:

    diff --git a/crypto/bio/bss_sock.c b/crypto/bio/bss_sock.c
    index 82f7be85ae..a399291ff4 100644
    --- a/crypto/bio/bss_sock.c
    +++ b/crypto/bio/bss_sock.c
    @@ -124,7 +125,18 @@ static int sock_read(BIO *b, char *out, int outl)
                 ret = ktls_read_record(b->num, out, outl);
             else
     # endif
    -            ret = readsocket(b->num, out, outl);
    +        {
    +            /* pthread_kill(pthread_self(), SIGUSR1); */
    +            static int i = 0;
    +            if (!(++i % 2))
    +            {
    +                fprintf(stderr, "sock_read: inject EAGAIN\n");
    +                ret = -1;
    +                errno = EAGAIN;
    +            }
    +            else
    +                ret = readsocket(b->num, out, outl);
    +        }
             BIO_clear_retry_flags(b);
             if (ret <= 0) {
                 if (BIO_sock_should_retry(ret))

And after this patch this succeed without errors:

    ch benchmark -c10 -q "SELECT * FROM mysql('127.0.0.1:9004', system, one, 'default', '', SETTINGS connection_pool_size=1, connect_timeout = 100, connection_wait_timeout = 100)"

Note, that this also fixes the timeouts for plain (non-TLS) connections

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-07-01 15:22:33 +02:00
Nikolai Kochetov
5a6e6d3c5d
Merge pull request #65771 from kitaisreal/postgresql-source-support-cancel-query
PostgreSQL source support cancel query
2024-07-01 10:17:01 +00:00
Antonio Andelic
50c1121c6a
Merge pull request #65735 from ClickHouse/fix-keeper-session-close-bug
Fix bug with session closing in Keeper
2024-07-01 07:12:33 +00:00
Antonio Andelic
43bd12f86b
Merge pull request #65819 from ClickHouse/keeper-respect-cgroup-cpu
Respect cgroup CPU limit in Keeper
2024-07-01 06:57:43 +00:00
Alexey Milovidov
97311bd51f Merge branch 'master' of github.com:ClickHouse/ClickHouse into dont-optimize-trivial-insert-select 2024-06-30 20:56:54 +02:00
Igor Nikonov
2fcca61fe9
Merge pull request #65769 from ClickHouse/fix-progress-bar-read-in-order
Fix: progress bar for read in order queries
2024-06-30 18:07:13 +00:00
Alexey Milovidov
06d0f2fd5d Merge branch 'master' into dont-optimize-trivial-insert-select 2024-06-30 18:52:28 +02:00
Robert Schulze
c72ce5be8a
Merge remote-tracking branch 'ClickHouse/master' into patch-1 2024-06-30 08:55:58 +00:00
Robert Schulze
235133aa5c
Move code from header to source file 2024-06-30 08:50:28 +00:00
Robert Schulze
8fdb3b83e0 Fix style 2024-06-30 10:33:54 +08:00
Robert Schulze
cec2aba6bb Some fixups 2024-06-30 10:33:54 +08:00
cw5121
b97158f5b6 implement with std::initializer_list 2024-06-30 10:33:44 +08:00
cw5121
10a0eb1712 fix 2024-06-30 10:33:32 +08:00
Robert Schulze
0bff61de13 Move parsedatetime_parse_without_leading_zeros to the right place 2024-06-30 10:33:28 +08:00
cw5121
b6500bcdf1 Fix and prevent compatibility settings from becoming not effective 2024-06-30 10:32:43 +08:00
Alexey Milovidov
01c4301165 Merge branch 'master' into dont-optimize-trivial-insert-select 2024-06-29 21:52:21 +02:00
Alexey Milovidov
e72d54ce34
Merge pull request #65246 from ClickHouse/fix-flaky-cli-completion-test
Fix flaky autocompletion test
2024-06-29 16:43:40 +00:00
Alexey Milovidov
1531aeb029
Merge pull request #65635 from ClickHouse/dont-load-outdated-parts-on-readonly
Do not load inactive parts on readonly disks
2024-06-29 13:45:07 +00:00
Kseniia Sumarokova
5a6666d330
Merge pull request #63348 from ClickHouse/small-refactoring-for-tmp-data-in-cache
Make write to temporary data in cache do all checks and assertions as during write to ordinary cache
2024-06-29 09:40:50 +00:00
Alexey Milovidov
9113981d0c Merge branch 'master' into dont-load-outdated-parts-on-readonly 2024-06-29 04:38:44 +02:00
Alexey Milovidov
3649e209c4 Merge branch 'master' into dont-optimize-trivial-insert-select 2024-06-29 04:34:00 +02:00
Alexander Tokmakov
4748e2929f
Merge pull request #65570 from ClickHouse/keeper_az
Improve ZooKeeper load balancing
2024-06-28 22:57:20 +00:00
Smita Kulkarni
95932db170 Add missing workload identity changes 2024-06-28 22:01:12 +02:00
Alexander Tokmakov
c97ef5dc32
Merge pull request #65405 from Avogar/check-cyclic-dependencies-on-create
Check cyclic dependencies on CREATE/REPLACE/RENAME/EXCHANGE queries
2024-06-28 16:28:14 +00:00
Alexander Tokmakov
6dd4fcae37
Merge pull request #65746 from ClickHouse/tavplubix-patch-14
Always optimize `ClientBase::parseAndCheckOptions`
2024-06-28 15:59:55 +00:00
Han Fei
8f086d7eff
Merge pull request #65820 from ClickHouse/vdimir/fix_hash_join_any_last_row
Propogate join_any_take_last_row to hash join in any query
2024-06-28 15:19:06 +00:00
SmitaRKulkarni
ccfe7c0121
Merge pull request #64757 from azat/load-part-without-columns.txt
Fix filling parts columns from metadata (when columns.txt does not exists)
2024-06-28 15:16:39 +00:00
Kseniia Sumarokova
2673a773c3
Merge pull request #65458 from ClickHouse/add-azure-queue-storage
Add AzureQueue storage
2024-06-28 12:39:05 +00:00
Maksim Kita
f61d1052e2 PostgreSQL source support cancel query 2024-06-28 15:16:10 +03:00
Konstantin Bogdanov
c8497c81b7
Lint 2024-06-28 13:59:16 +02:00
vdimir
8e034c499f
Propigate join_any_take_last_row to hash join in any query 2024-06-28 11:58:10 +00:00
Nikita Mikhaylov
191aad6b53
Merge pull request #65669 from ClickHouse/client-refactoring
Miscellaneous and insignificant changes around Client/ClientBase.
2024-06-28 11:44:40 +00:00
Antonio Andelic
e8dfc2ee2c Respect cgroup CPU limit 2024-06-28 13:42:11 +02:00
kssenii
3ad17f5854 Fix test 00429_http_long_bufferization.sh 2024-06-28 13:11:35 +02:00
Kruglov Pavel
f2a39ae2f1
Merge pull request #65802 from jsc0218/FixBugInShortCircuitLogic
Fix Short Circuit Logic
2024-06-28 11:11:25 +00:00
Antonio Andelic
510924b6b2
Merge pull request #65768 from ClickHouse/fix-parse-iso-date
Fix invalid exceptions in `parseDateTime` with `%F` and `%D` placeholders
2024-06-28 08:07:36 +00:00
Konstantin Bogdanov
f3028acc3d
Yet another fix 2024-06-28 08:03:55 +02:00
jsc0218
8dbf159f3f fix 2024-06-28 01:24:20 +00:00
Michael Kolupaev
6357c3a072
Merge pull request #64951 from ClickHouse/emp
Fix AST formatting of 'create table b empty as a'
2024-06-27 23:52:56 +00:00
Michael Kolupaev
3229cb5874
Merge pull request #61750 from KevinyhZou/improve_json_each_row_ignore_key_case
Improve JSONEachRow reading by ignoring the keys case
2024-06-27 23:38:50 +00:00
Nikita Taranov
f838c25d20
Merge pull request #65705 from ClickHouse/fix_linkage
Fix duplicate symbol linkage error
2024-06-27 23:02:09 +00:00
Michael Kolupaev
b5bb9fa17e git Merge remote-tracking branch 'origin/master' into emp 2024-06-27 20:40:24 +00:00
Igor Nikonov
9a9c36cc5f Fix 2024-06-27 20:04:30 +00:00