thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-16 19:32:07 +00:00
Code Issues Packages Projects Releases Wiki Activity
126,388 Commits 9,319 Branches 1,783 Tags 2.1 GiB
0fb6ed5af7
Commit Graph

126388 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Tyler Hannan
76345a5f60
Update README.md 
Updating meetups
 2023-10-08 17:42:15 +02:00
Sema Checherinda
bfabeaf474
Merge pull request #55218 from CheSema/metadata-version-is-fixed 
remove the blocker to grow the metadata file version
 2023-10-08 17:35:34 +02:00
Azat Khuzhin
cd3c140dd6 Fix data-race in CreatingSetsTransform (on errors) due to throwing shared exception 
WARNING: ThreadSanitizer: data race (pid=3436)
  Read of size 1 at 0x7b50001b07a7 by thread T187:
    0 std::__1::basic_string<>::__is_long[abi:v15000] const build_docker/./contrib/llvm-project/libcxx/include/string:1499:33 (clickhouse-tsan+0x1faa29ff) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
    1 std::__1::basic_string<>::size[abi:v15000]() const build_docker/./contrib/llvm-project/libcxx/include/string:968:17 (clickhouse-tsan+0x1faa29ff)
    2 std::__1::basic_string<>::empty[abi:v15000]() const build_docker/./contrib/llvm-project/libcxx/include/string:996:42 (clickhouse-tsan+0x1faa29ff)
    3 Poco::Exception::extendedMessage() build_docker/./base/poco/Foundation/src/Exception.cpp:114:13 (clickhouse-tsan+0x1faa29ff)
    4 DB::Exception::addMessage() <null> (clickhouse-tsan+0x7e0d5f1) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
    5 DB::executeJob(DB::ExecutingGraph::Node*, DB::ReadProgressCallback*) build_docker/./src/Processors/Executors/ExecutionThreadContext.cpp:70:23 (clickhouse-tsan+0x1b3f2fed) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
    6 DB::ExecutionThreadContext::executeTask() build_docker/./src/Processors/Executors/ExecutionThreadContext.cpp:95:9 (clickhouse-tsan+0x1b3f2fed)
    7 DB::PipelineExecutor::executeStepImpl(unsigned long, std::__1::atomic<bool>*) build_docker/./src/Processors/Executors/PipelineExecutor.cpp:273:26 (clickhouse-tsan+0x1b3e5a10) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
    8 DB::PipelineExecutor::executeSingleThread(unsigned long) build_docker/./src/Processors/Executors/PipelineExecutor.cpp:239:5 (clickhouse-tsan+0x1b3e4bb8) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
    9 DB::PipelineExecutor::executeImpl(unsigned long, bool) build_docker/./src/Processors/Executors/PipelineExecutor.cpp:399:9 (clickhouse-tsan+0x1b3e4bb8)
    10 DB::PipelineExecutor::execute(unsigned long, bool) build_docker/./src/Processors/Executors/PipelineExecutor.cpp:111:9 (clickhouse-tsan+0x1b3e48be) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
    11 DB::CompletedPipelineExecutor::execute() build_docker/./src/Processors/Executors/CompletedPipelineExecutor.cpp:110:18 (clickhouse-tsan+0x1b3e31c8) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
    12 DB::FutureSetFromSubquery::buildOrderedSetInplace(std::__1::shared_ptr<DB::Context const> const&) build_docker/./src/Interpreters/PreparedSets.cpp:202:14 (clickhouse-tsan+0x19a58396) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)

  Previous write of size 8 at 0x7b50001b07a0 by thread T192:
    0 std::__1::basic_string<>::__set_long_cap[abi:v15000](unsigned long) build_docker/./contrib/llvm-project/libcxx/include/string:1592:37 (clickhouse-tsan+0x238809e2) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
    1 std::__1::basic_string<>::__grow_by_and_replace(unsigned long, unsigned long, unsigned long, unsigned long, unsigned long, unsigned long, char const*) build_docker/./contrib/llvm-project/libcxx/include/string:2367:5 (clickhouse-tsan+0x238809e2)
    2 std::__1::basic_string<>::append(char const*, unsigned long) build_docker/./contrib/llvm-project/libcxx/include/string:2692:9 (clickhouse-tsan+0x238809e2)
    3 std::__1::basic_string<>::append(char const*) build_docker/./contrib/llvm-project/libcxx/include/string:2849:12 (clickhouse-tsan+0x1faa2a58) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
    4 Poco::Exception::extendedMessage() build_docker/./base/poco/Foundation/src/Exception.cpp:114:27 (clickhouse-tsan+0x1faa2a58)
    5 DB::Exception::addMessage() <null> (clickhouse-tsan+0x7e0d5f1) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
    6 DB::executeJob(DB::ExecutingGraph::Node*, DB::ReadProgressCallback*) build_docker/./src/Processors/Executors/ExecutionThreadContext.cpp:70:23 (clickhouse-tsan+0x1b3f2fed) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
    7 DB::ExecutionThreadContext::executeTask() build_docker/./src/Processors/Executors/ExecutionThreadContext.cpp:95:9 (clickhouse-tsan+0x1b3f2fed)
    8 DB::PipelineExecutor::executeStepImpl(unsigned long, std::__1::atomic<bool>*) build_docker/./src/Processors/Executors/PipelineExecutor.cpp:273:26 (clickhouse-tsan+0x1b3e5a10) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
    9 DB::PipelineExecutor::executeSingleThread(unsigned long) build_docker/./src/Processors/Executors/PipelineExecutor.cpp:239:5 (clickhouse-tsan+0x1b3e4bb8) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
    10 DB::PipelineExecutor::executeImpl(unsigned long, bool) build_docker/./src/Processors/Executors/PipelineExecutor.cpp:399:9 (clickhouse-tsan+0x1b3e4bb8)
    11 DB::PipelineExecutor::execute(unsigned long, bool) build_docker/./src/Processors/Executors/PipelineExecutor.cpp:111:9 (clickhouse-tsan+0x1b3e48be) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
    12 DB::CompletedPipelineExecutor::execute() build_docker/./src/Processors/Executors/CompletedPipelineExecutor.cpp:110:18 (clickhouse-tsan+0x1b3e31c8) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
    13 DB::FutureSetFromSubquery::buildOrderedSetInplace(std::__1::shared_ptr<DB::Context const> const&) build_docker/./src/Interpreters/PreparedSets.cpp:202:14 (clickhouse-tsan+0x19a58396) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)

  Location is heap block of size 480 at 0x7b50001b0600 allocated by thread T193:
    0 posix_memalign <null> (clickhouse-tsan+0x7d6ac85) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
    1 std::__1::__libcpp_aligned_alloc[abi:v15000](unsigned long, unsigned long) build_docker/./contrib/llvm-project/libcxxabi/../libcxx/include/new:328:9 (clickhouse-tsan+0x238b5a05) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
    2 __cxxabiv1::__aligned_malloc_with_fallback(unsigned long) build_docker/./contrib/llvm-project/libcxxabi/src/fallback_malloc.cpp:215:20 (clickhouse-tsan+0x238b5a05)
    3 __cxa_allocate_exception build_docker/./contrib/llvm-project/libcxxabi/src/cxa_exception.cpp:190:17 (clickhouse-tsan+0x238b31e5) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
    4 std::exception_ptr std::make_exception_ptr[abi:v15000]<DB::Exception>(DB::Exception) build_docker/./contrib/llvm-project/libcxx/include/exception:206:9 (clickhouse-tsan+0x144bfa8a) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
    5 DB::CreatingSetsTransform::~CreatingSetsTransform() build_docker/./src/Processors/Transforms/CreatingSetsTransform.cpp:30:45 (clickhouse-tsan+0x1b7603c3) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
    ...
    35 DB::FutureSetFromSubquery::buildOrderedSetInplace(std::__1::shared_ptr<DB::Context const> const&) build_docker/./src/Interpreters/PreparedSets.cpp:211:1 (clickhouse-tsan+0x19a58608) (BuildId: f978f51991d62a36512b8fc6952335a82292896f)
 2023-10-08 17:16:39 +02:00
Robert Schulze
38c64b3cd1
Fix tests 2023-10-08 14:26:31 +00:00
Alexey Milovidov
ba12695525
Merge pull request #55276 from azat/SummingMergeTree-Nested-fix 
Fix incorrect merging of Nested for SELECT FINAL FROM SummingMergeTree
 2023-10-08 16:08:25 +02:00
Robert Schulze
558b2ff7b9
Fix spelling 2023-10-08 13:50:33 +00:00
Alexey Milovidov
caf3c85b38
Merge pull request #55275 from azat/sparse-columns-function-fix 
Fix functions execution over sparse columns
 2023-10-08 15:27:46 +02:00
Alexey Milovidov
a7716a56ac
Update IFunction.cpp 2023-10-08 16:27:33 +03:00
Alexey Milovidov
781da580ac
Merge pull request #55283 from bytadaniel/patch-2 
Update client-libraries.md
 2023-10-08 15:25:51 +02:00
Priyansh Agrawal
63b0df9f1d byteSwap is now documented; remove it from the list of undocumented functions 2023-10-08 13:25:09 +00:00
Alexey Milovidov
c7ae1afb8f Review #51946 and partially revert it 2023-10-08 15:17:41 +02:00
Alexey Milovidov
6e502a899d
Merge pull request #55311 from rschu1ze/croaring-tsan 
Fix tsan issue in croaring
 2023-10-08 13:31:06 +02:00
Alexey Milovidov
75e8e190f6 Better docs for #55326 2023-10-08 13:28:51 +02:00
Robert Schulze
3f33c32684
Fix style 2023-10-08 10:46:28 +00:00
Robert Schulze
70eb2ab4fc
Try to fix flakyness, pt. II 2023-10-08 10:43:46 +00:00
alesapin
55fc3fe8ab
Merge pull request #55247 from azat/tests/test_throttling-https 
tests: switch test_throttling to S3 over https to make it more production like
 2023-10-08 12:39:54 +02:00
Robert Schulze
8c35ccf9e8
Some fixups 2023-10-08 10:29:46 +00:00
Robert Schulze
282200ef50
Merge pull request #55215 from rschu1ze/more-mysql-compat 
Add `information_schema.columns.extra` and `information_schema.tables.table_rows`
 2023-10-08 12:21:34 +02:00
alesapin
08f4621b48 Fix for write-once storages 2023-10-08 12:20:31 +02:00
Robert Schulze
8a8f769508
Update docs 2023-10-08 10:16:05 +00:00
Kseniia Sumarokova
20868f3b65
Merge pull request #55252 from kssenii/fix-background-download-in-cache 
Fix for background download in fs cache
 2023-10-08 10:38:23 +02:00
Kseniia Sumarokova
0af252ae31
Merge pull request #55297 from ClickHouse/kssenii-patch-6 
MaterializedPostgreSQL: remove back check
 2023-10-08 10:31:23 +02:00
Robert Schulze
66d4706338
Try to fix flakyness 2023-10-08 07:56:42 +00:00
Robert Schulze
f4bc58ea92
Merge remote-tracking branch 'rschu1ze/master' into more-mysql-compat 2023-10-08 07:49:37 +00:00
Azat Khuzhin
28f17bec96 Avoid possible memory leaks in case of missing buffer finalization 
Sometimes it is still possible, the pattern could looks like this:

    try
    {
        writer->finalize();
        writer->flush();
        write_buf->finalize();
    }
    catch (...)
    {
        /// Stop ParallelFormattingOutputFormat correctly.
        release();
        throw;
    }

Here, write_buf will not be finalized, in case of exception during
writer finalize()/flush().

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-10-08 08:51:45 +02:00
Azat Khuzhin
099665478d Fix incorrect merging of Nested for SELECT FINAL FROM SummingMergeTree 
The problem was the order of the columns, in case of SELECT FINAL it got
"counters_Map.count", "counters_Map.id"

But in case of OPTIMIZE FINAL it got "counters_Map.id",
"counters_Map.count" correctly.

Note, that this bugs exists there from the very recent versions, I've
checked 19.x and it was there.

P.S. there is a workaround for this problem, if you will use one of the
following patterns for key columns:
- *ID
- *Key
- *Type

That way it will be explicitly matched as key and everything will work.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-10-08 07:32:47 +02:00
Azat Khuzhin
2a27a8b0bf tests/test_throttling: check the maximum execution time as well 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-10-08 07:31:33 +02:00
Azat Khuzhin
c883da2b26 tests/test_throttling: adjust delays due to HTTPS usage 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-10-08 07:31:33 +02:00
Azat Khuzhin
9c8096455e tests: switch test_throttling to S3 over https to make it more production like 
One interesting thing about S3 C++ SDK is that it can read file multiple
times for calculating checksums and signature, but the last is not done
for the https protocol, though the checksum "could".

And indeed it does, since default checksum algorithm (MD5) does not
support streaming, and so it always calculated, regardless of the
protocol, however everything else (CRC*/SHA*) supports streamming and
actually will not be calculated for https at all!

This will be fixed in the follow up patch.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-10-08 07:31:33 +02:00
Azat Khuzhin
4179ff7111 Adjust the test_storage_delta::test_multiple_log_files after MinIO upgrade 
After upgrade MinIO stopped handling of objects with leading slash:

    (Pdb) p minio_client.fput_object(bucket_name='root', object_name='/test_multiple_log_files/_delta_log/00000000000000000001.json', file_path='/test_multiple_log_files/_delta_log/00000000000000000001.json').http_headers
    HTTPHeaderDict({'Accept-Ranges': 'bytes', 'Content-Length': '0', 'ETag': '"f1f3276c787b3f6724b9a8edb313c4fa"', 'Server': 'MinIO', 'Strict-Transport-Security': 'max-age=31536000; includeSubDomains', 'Vary': 'Origin, Accept-Encoding', 'X-Amz-Id-2': '7987905dee74cdeb212432486a178e511309594cee7cb75f892cd53e35f09ea4', 'X-Amz-Request-Id': '178B9B0904A9640D', 'X-Content-Type-Options': 'nosniff', 'X-Xss-Protection': '1; mode=block', 'Date': 'Fri, 06 Oct 2023 19:22:27 GMT'})
    (Pdb) p list(minio_client.list_objects('root', '/test_multiple_log_files/_delta_log/'))
    []
    (Pdb) p minio_client.get_object(bucket_name='root', object_name='/test_multiple_log_files/_delta_log/00000000000000000001.json').read()
    b'{"commitInfo":{"timestamp":1696618985577,"operation":"WRITE","operationParameters":{"mode":"Overwrite","partitionBy":"[]"},"readVersion":0,"isolationLevel":"Serializable","isBlindAppend":false,"operationMetrics":{"numFiles":"1","numOutputRows":"100","numOutputBytes":"2459"},"engineInfo":"Apache-Spark/3.3.2 Delta-Lake/2.3.0","txnId":"2a69a4c9-f72e-4ac9-9374-bdff96707edf"}}\n{"add":{"path":"part-00000-9ff4728b-d5fe-49ac-a773-e2d6e01f4139-c000.parquet","partitionValues":{},"size":2459,"modificationTime":1696618985310,"dataChange":true,"stats":"{\\"numRecords\\":100,\\"minValues\\":{\\"col-ab7641d2-f0a9-4ffb-ae37-27087d13dfc8\\":0,\\"col-6cbfced4-5921-4e3b-9226-558171c11949\\":\\"1\\"},\\"maxValues\\":{\\"col-ab7641d2-f0a9-4ffb-ae37-27087d13dfc8\\":99,\\"col-6cbfced4-5921-4e3b-9226-558171c11949\\":\\"99\\"},\\"nullCount\\":{\\"col-ab7641d2-f0a9-4ffb-ae37-27087d13dfc8\\":0,\\"col-6cbfced4-5921-4e3b-9226-558171c11949\\":0}}"}}\n{"remove":{"path":"part-00000-7c29f5d9-e14d-419a-a273-58d07775e1e9-c000.parquet","deletionTimestamp":1696618985576,"dataChange":true,"extendedFileMetadata":true,"partitionValues":{},"size":2459}}\n'
    (Pdb) p list(minio_client.list_objects(bucket_name='root', prefix='test_multiple_log_files/', recursive=True))
    [<minio.datatypes.Object object at 0x7ffff1ec2fe0>, <minio.datatypes.Object object at 0x7ffff1ec39d0>, <minio.datatypes.Object object at 0x7ffff1ec2590>, <minio.datatypes.Object object at 0x7ffff1ec3dc0>, <minio.datatypes.Object object at 0x7ffff1ec3a00>, <minio.datatypes.Object object at 0x7ffff1ec3fa0>, <minio.datatypes.Object object at 0x7ffff1ec3f40>, <minio.datatypes.Object object at 0x7ffff1ec2770>]

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-10-08 07:30:13 +02:00
Azat Khuzhin
ce9cdc408c Upgrade MinIO to support accepting non signed requests 
During fixing one issue with multiple reads of input files while sending
them to S3 this had been pops up.

The problem is in this place [1].

  [1]: 200caab82b/cmd/object-handlers.go (L1573-L1591)

And this had been added only in [2].

  [2]: https://github.com/minio/minio/pull/16484

But even this implementation is not complete, since it does not
correctly support STREAMING-UNSIGNED-PAYLOAD-TRAILER, but this will be
the first step, to see if there are still problems with newer MinIO.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-10-08 07:30:13 +02:00
Priyansh Agrawal
2c04370e5f Use std::byteswap instead of custom implementations. 
- Also allow signed ints now because std::byteswap accepts them.
- Fix for style check.
 2023-10-07 23:59:24 +00:00
Priyansh Agrawal
302291e17b Address a few review comments. 
- Consider byteswap injective.
- Make function case-insensitive.
- Add in-code documentation and copy-paste it to the markdown docs.
 2023-10-07 23:05:07 +00:00
Alexey Milovidov
b38d4b5b0f
Merge pull request #55119 from jmaicher/fix/54318/deadlock-ldap-role-update 
Fix deadlock in LDAP assigned role update
 2023-10-08 00:38:10 +02:00
robot-clickhouse-ci-1
48ce595e24
Merge pull request #55220 from den-crane/Docs/use_local_cache_for_remote_storage 
Doc. Update use_local_cache_for_remote_storage settings name
 2023-10-08 00:23:54 +02:00
Alexey Milovidov
f5b0fb27a4
Update DiskObjectStorageMetadata.cpp 2023-10-08 00:53:33 +03:00
Alexey Milovidov
25a7f86da7
Update hive.md 2023-10-08 00:51:19 +03:00
Alexey Milovidov
857ac2705d
Merge pull request #55226 from ClickHouse/server-provides-keeper 
Make clickhouse-server provides keeper
 2023-10-07 23:49:14 +02:00
Alexey Milovidov
186bd9c859
Merge pull request #55243 from den-crane/patch-62 
Doc. fix a mistake about refcount
 2023-10-07 23:43:16 +02:00
Alexey Milovidov
6b9696fd97
Update 02891_functions_over_sparse_columns.sql 2023-10-08 00:38:04 +03:00
Robert Schulze
8d58c4d389
Suppress some shellcheck errors 2023-10-07 20:19:47 +00:00
robot-clickhouse-ci-1
2cd23c293a
Merge pull request #55307 from ClickHouse/make_code_more_stupid 
Make `HandlingRuleHTTPHandlerFactory` more stupid, but less error prone
 2023-10-07 22:12:43 +02:00
Robert Schulze
0450da9bac
Naming fixes 2023-10-07 20:12:10 +00:00
Robert Schulze
312fe8e31d
Merge pull request #55298 from rschu1ze/use_mysql_types_in_show_columns 
Make `use_mysql_types_in_show_columns` independent from the connection
 2023-10-07 22:03:24 +02:00
Robert Schulze
727f831c0c
Update croaring 
Fixes: #55270
 2023-10-07 19:44:19 +00:00
alesapin
ec69b28386 Black 2023-10-07 21:18:54 +02:00
alesapin
77d96e67d1 Merge branch 'fix_redundant_check' of github.com:ClickHouse/ClickHouse into fix_redundant_check 2023-10-07 21:18:39 +02:00
alesapin
aa130b74e5 Fix offsets bug 2023-10-07 21:18:23 +02:00
Robert Schulze
73ff017fb5
Merge remote-tracking branch 'rschu1ze/master' into israelov/generate-random-int-array 2023-10-07 18:10:09 +00:00
Robert Schulze
3580c4d730
Fixups 2023-10-07 18:08:54 +00:00