Commit Graph

117320 Commits

Author SHA1 Message Date
Azat Khuzhin
5caa3a9e80 Adjust min_insert_block_size_rows for materialized_view_parallelize_output_from_storages
Otherwise it is too slow for perf tests on CI [1].

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/50214/e287ec50920c7cadabea6ec19ef14b353345ac93/performance_comparison_[3_4]/report.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-06-14 19:11:23 +03:00
Azat Khuzhin
3c4f638bd7 Disable parallelize_output_from_storages for storages with only one block
$ clickhouse-benchmark -i 10000 -d 0 --parallelize_output_from_storages=0 -q "select * from values('foo')"
    Loaded 1 queries.

    Queries executed: 10000.

    localhost:9000, queries 10000, QPS: 2800.490, RPS: 2800.490, MiB/s: 0.032, result RPS: 2800.490, result MiB/s: 0.032.

    0.000%          0.000 sec.
    10.000%         0.000 sec.
    20.000%         0.000 sec.
    30.000%         0.000 sec.
    40.000%         0.000 sec.
    50.000%         0.000 sec.
    60.000%         0.000 sec.
    70.000%         0.000 sec.
    80.000%         0.000 sec.
    90.000%         0.000 sec.
    95.000%         0.000 sec.
    99.000%         0.001 sec.
    99.900%         0.001 sec.
    99.990%         0.001 sec.

    $ clickhouse-benchmark -i 10000 -d 0 --parallelize_output_from_storages=1 -q "select * from values('foo')"
    Loaded 1 queries.

    Queries executed: 10000.

    localhost:9000, queries 10000, QPS: 1259.805, RPS: 1259.805, MiB/s: 0.014, result RPS: 1259.805, result MiB/s: 0.014.

    0.000%          0.001 sec.
    10.000%         0.001 sec.
    20.000%         0.001 sec.
    30.000%         0.001 sec.
    40.000%         0.001 sec.
    50.000%         0.001 sec.
    60.000%         0.001 sec.
    70.000%         0.001 sec.
    80.000%         0.001 sec.
    90.000%         0.001 sec.
    95.000%         0.001 sec.
    99.000%         0.001 sec.
    99.900%         0.001 sec.
    99.990%         0.003 sec.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-06-14 19:11:23 +03:00
Azat Khuzhin
3e419730c3 Disable parallelize_output_from_storages for processing MATERIALIZED VIEWs
Adding more processors for parallelize_output_from_storages is not a
costless operation (I've experienced some issues in production because
of this), and it is not easy to fix in a normal way, so let's disable it
for now.

Before this patch:
- INSERT INTO input SELECT * FROM numbers(10e6) SETTINGS parallelize_output_from_storages=1, min_insert_block_size_rows=1000
  0 rows in set. Elapsed: 3.648 sec. Processed 20.00 million rows, 120.00 MB (5.48 million rows/s., 32.90 MB/s.)

- INSERT INTO input SELECT * FROM numbers(10e6) SETTINGS parallelize_output_from_storages=0, min_insert_block_size_rows=1000
  0 rows in set. Elapsed: 1.851 sec. Processed 20.00 million rows, 120.00 MB (10.80 million rows/s., 64.82 MB/s.)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-06-14 19:11:23 +03:00
Azat Khuzhin
035334fc15 tests: mark 02585_query_status_deadlock as long
CI: https://s3.amazonaws.com/clickhouse-test-reports/50934/bb971fd7b7fd5bc400bbe28d16867c9dc337fb17/stateless_tests_flaky_check__asan_.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-06-14 18:06:36 +02:00
Dmitry Novik
95a2f6bec6 Attempt to make 01281_group_by_limit_memory_tracking not-flaky 2023-06-14 15:05:12 +00:00
Alexander Tokmakov
ffde5affeb
Merge pull request #50929 from ClickHouse/fix_illegal_column_timezone
Fix 'Illegal column timezone' in stress tests
2023-06-14 17:56:57 +03:00
Thom O'Connor
37245783ab
Update mysql.md
Updating mysql table function with example for copying data from MySQL into a ClickHouse MergeTree table
2023-06-14 08:03:18 -06:00
Thom O'Connor
c49bde8961
Update postgresql.md
Updated PostgreSQL documentation to better show example of using PostgreSQL() table engine for SELECT and INSERT, vs. copying data via postgresql() table function for copying data into ClickHouse
2023-06-14 07:11:28 -06:00
Igor Nikonov
bdeabd848a
Merge pull request #50095 from ClickHouse/test-plan-optimization-analyzer
Test plan optimization analyzer
2023-06-14 14:56:35 +02:00
Kruglov Pavel
85db1eb6fc
Change submodule capnproto to it's fork in ClickHouse 2023-06-14 14:55:11 +02:00
Derek Chia
811f6c1532
Update delete.md 2023-06-14 20:50:47 +08:00
Dmitry Novik
1d88b16830
Merge pull request #50584 from ClickHouse/analyzer-optimizations-on-shards
Analyzer: Do not apply Query Tree optimizations on shards
2023-06-14 14:31:46 +02:00
Val Doroshchuk
e7c5991b39 MaterializedMySQL: Keep parenthesises for empty table overrides
Empty table overrides are formatted without any parenthesises,
but they are required by a parser,
and it is not possible to parse empty table overrides without it.

:) CREATE DATABASE db ... TABLE OVERRIDE t1()

CREATE DATABASE db
...
TABLE OVERRIDE `t1`

This query will be saved to metadata and ClickHouse will not be able to start up, since
table overrides require ().
2023-06-14 13:37:49 +02:00
Nikolai Kochetov
5163927b7d
Merge pull request #50923 from ClickHouse/read-in-order-proj-bug
Do not apply projection if read-in-order was enabled.
2023-06-14 13:13:25 +02:00
Nikita Taranov
a00e42f75b
Fix erroneous sort_description propagation in CreatingSets (#50955) 2023-06-14 13:00:47 +02:00
kssenii
827ac17dc2 Fix 2023-06-14 12:59:06 +02:00
kssenii
47a6db596e Better 2023-06-14 11:37:57 +02:00
kssenii
2a3ef3941e Fix 2023-06-14 11:31:28 +02:00
Kseniia Sumarokova
e2d8299b23
Merge pull request #50952 from nickitat/fix_remote_read_perf_degr
Fix logic in `AsynchronousBoundedReadBuffer::seek`
2023-06-14 11:25:26 +02:00
Robert Schulze
2643fd2c25
Merge pull request #50689 from arenadata/ADQM-871
Added connection string to clickhouse-client
2023-06-14 10:39:32 +02:00
Nikolai Kochetov
ab6ac6beb1 Fixing a test. 2023-06-14 08:37:18 +00:00
Robert Schulze
b1eacab44a
Merge pull request #50972 from rschu1ze/docs-embedded-link
Docs: Fix embedded video link
2023-06-14 10:13:49 +02:00
Robert Schulze
f4cfb9e370
Fix line break 2023-06-14 07:50:26 +00:00
Robert Schulze
b1f0a91b78
Docs: Fix embedded video link 2023-06-14 07:48:08 +00:00
Robert Schulze
edd29492c3
Merge pull request #50893 from rschu1ze/snowflake-crash
Fix LOGICAL_ERROR in snowflakeToDateTime*()
2023-06-14 09:42:21 +02:00
Robert Schulze
853c224a78
Merge pull request #50954 from arenadata/Fix-convert_type_with_default
Uncomment flaky test (01746_convert_type_with_default)
2023-06-14 09:39:17 +02:00
Chang Chen
86694847c6 using Reader instead of typename CapnpType::Reader 2023-06-14 15:22:32 +08:00
Alexander Gololobov
f74c585426
Typos 2023-06-14 07:46:11 +02:00
Derek Chia
08cd94e826
Update delete.md
LWD is not supported in table with projection
2023-06-14 12:57:50 +08:00
Alexey Gerasimchuck
4db8fa39c7 Removed extra lines 2023-06-14 04:38:46 +00:00
Chang Chen
e281026e00 fix build issue on clang 15 2023-06-14 12:29:55 +08:00
Alexey Gerasimchuck
868c3bd45d minor change 2023-06-14 04:29:08 +00:00
kevinyhzou
f3b99156ac review fix 2023-06-14 10:48:21 +08:00
Alexey Gerasimchuck
1f76d08743 fixed --password "" --password issue 2023-06-14 02:24:45 +00:00
pufit
91d794cf0a
Merge pull request #50150 from JackyWoo/support_redis
Add Redis table Engine/Function
2023-06-13 21:34:14 -04:00
Alexey Gerasimchuck
f1b5d47ce2 corrections after second review iteration 2023-06-14 01:26:39 +00:00
pufit
c05bcf5605 Fix keeper-client help message 2023-06-13 21:09:30 -04:00
JackyWoo
49082bfe89 fix typos in redis.md 2023-06-14 09:00:50 +08:00
Rich Raposa
081376e3c8
Merge pull request #50960 from ClickHouse/rfraposa-patch-2
Update azureBlobStorage.md
2023-06-13 17:13:38 -06:00
Rich Raposa
86075dbae4
Update azureBlobStorage.md 2023-06-13 16:40:14 -06:00
Denny Crane
404a52432c
Update README.md 2023-06-13 19:39:23 -03:00
Denny Crane
d8d5700810
Update README.md 2023-06-13 19:24:36 -03:00
Denny Crane
a570b00bdf
Update README.md 2023-06-13 19:19:34 -03:00
Dmitry Kardymon
994228ab20 Uncomment flaky test 2023-06-13 20:54:02 +00:00
Igor Nikonov
fc46a787c7
Merge branch 'master' into test-plan-optimization-analyzer 2023-06-13 21:53:03 +02:00
Nikita Taranov
1bc5598aa7 impl 2023-06-13 20:02:50 +02:00
Sergei Trifonov
37f55ce253
Merge branch 'master' into tests/02703_max_local_write_bandwidth 2023-06-13 19:48:43 +02:00
Azat Khuzhin
bb971fd7b7 check-style: allow {database} for ReplicatedMergeTree as well
CLICKHOUSE_TEST_ZOOKEEPER_PREFIX is a {test_name}_{database}, but
actually {database} should be enough, since it is uniq for each test run.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-06-13 19:45:51 +02:00
Azat Khuzhin
0444aa2fda tests: add missing current_database condition for query_log
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-06-13 19:45:51 +02:00
Azat Khuzhin
77775c6074 Rename 02701_fail_on_invalid_having to 02701_invalid_having_NOT_AN_AGGREGATE
To remove "fail" from the test name, which is prohibited

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-06-13 19:45:51 +02:00