Commit Graph

396 Commits

Author SHA1 Message Date
Robert Schulze
89aa9ae00f
Fixed clang-tidy check "bugprone-branch-clone"
The check is currently *not* part of .clang-tidy. It complains about:
(1) "switch has multiple consecutive identical branches"
(2) "repeated branch in conditional chain"

About (1): Lots of findings in switches were about redundant
"[[fallthrough]]" in places where the compiler would not warn anyways. I
have cleaned these up.

About (2): In if-else_if-else chains, fixing the warning would usually
mean concatenating multiple if-conditions. As this would reduce
readability in most cases, I did not fix these places.

Because of (2), I also refrained from adding "bugprone-branch-clone" to
.clang-tidy.
2022-04-30 19:40:28 +02:00
Amos Bird
4a5e4274f0
base should not depend on Common 2022-04-29 10:26:35 +08:00
Suzy Wang
59f0e83c4b
fix clang tidy warning, add nullptr check (#35540)
update passing reference instead of pointer in queryHasWithClause based on recommandation

Co-authored-by: larryluogit <larry.luo@ca.ibm.com>
2022-04-20 11:26:44 +02:00
Anton Popov
13cb564d1e
Merge pull request #35716 from kssenii/fix-local-logs-level
Fix send_logs_level for clickhouse local
2022-04-06 18:52:47 +02:00
Kseniia Sumarokova
d3763c4a62 Update ClientBase.h 2022-04-06 12:13:34 +02:00
Alexey Milovidov
3c0c1a1176 Add a comment #35919 2022-04-05 18:35:23 +02:00
Alexey Milovidov
e452949334
Merge pull request #35919 from DevTeamBK/clang-tidy-issues
Clang tidy issues
2022-04-05 19:31:09 +03:00
Meena Renganathan
cf71b18472 Modified the code to fix the getenv() call issue idenitified in the clang-tidy 2022-04-04 07:23:31 -07:00
Denny Crane
0722beca0c
Update Client.cpp 2022-03-30 08:45:30 -03:00
mergify[bot]
5295dd0ef2
Merge branch 'master' into stress-test 2022-03-17 11:10:37 +00:00
Kruglov Pavel
ea5ace7b18
Merge pull request #35309 from Avogar/fix-client-host-help
Fix disappeared host and port from client help message
2022-03-16 12:24:07 +01:00
Vladimir C
e022245a33
Merge pull request #35193 from vdimir/issue-34776 2022-03-15 19:56:09 +01:00
avogar
96c6a4b401 Fix disappeared host and port from client help message 2022-03-15 18:36:54 +00:00
vdimir
db46c2ada8
Fix reading port from config 2022-03-14 11:58:47 +00:00
kssenii
199188be08 Support test mode for clickhouse-local 2022-03-14 12:02:06 +01:00
Kruglov Pavel
dbba752398
Merge branch 'master' into stress-test 2022-03-04 18:33:37 +03:00
mergify[bot]
c90d24e10b
Merge branch 'master' into random-settings 2022-03-03 13:07:12 +00:00
avogar
d25d83580a Fix tests 2022-03-02 16:33:21 +00:00
freedomDR
43ac214dc5 get credentials from environment variables for clickhouse-client
include CLICKHOUSE_USER, CLICKHOUSE_PASSWORD
2022-03-02 00:54:51 +00:00
mergify[bot]
8014cdf9d3
Merge branch 'master' into random-settings 2022-02-28 14:06:22 +00:00
vdimir
dfc990aed4
Fix using host/port from config for client 2022-02-21 12:08:23 +00:00
avogar
ba7f723961 Fix comments 2022-02-18 13:54:21 +00:00
Kruglov Pavel
e77319bf01
Merge branch 'master' into stress-test 2022-02-17 20:28:46 +03:00
avogar
1e797c1a8f Fix some tests 2022-02-16 15:10:02 +00:00
Kruglov Pavel
e8d855ef4c
Update description 2022-02-15 15:12:21 +03:00
Kruglov Pavel
767bcabd5b
Fix style 2022-02-10 14:21:41 +03:00
Kruglov Pavel
8947c5de11
Update description
Co-authored-by: Vladimir C <vdimir@clickhouse.com>
2022-02-10 14:07:21 +03:00
avogar
75c56163a0 Refactor client fault tolerant connection 2022-02-10 12:43:08 +03:00
DF5HSE
e657219e01 Delete not used include 2022-02-08 12:40:44 +03:00
DF5HSE
c08bc7ad65 Merge branch 'master' of github.com:ClickHouse/ClickHouse into client-fault-tolerant-connection 2022-02-08 11:37:31 +03:00
DF5HSE
b035ad7843 Fix error with IPv6 in host param and impove HostPort reading from input stream 2022-02-08 02:03:39 +03:00
DF5HSE
3cb433762b Fix errors in build check 2022-02-08 02:03:39 +03:00
DF5HSE
3343a22788 Merge branch 'client-fault-tolerant-connection' of github.com:ManagedDatabases/ClickHouse into client-fault-tolerant-connection 2022-02-08 02:03:38 +03:00
Filippov Denis
226759b674 Update programs/client/Client.cpp
Fix `--host` parameter description

Co-authored-by: Kruglov Pavel <48961922+Avogar@users.noreply.github.com>
2022-02-08 02:03:38 +03:00
DF5HSE
18a777cc8b Add function which gets port from configuration 2022-02-08 02:03:37 +03:00
DF5HSE
a9ff296960 Fix codestyle 2022-02-08 02:03:36 +03:00
DF5HSE
e780c1292d Add tests, remove saving host in config 2022-02-08 02:03:35 +03:00
DF5HSE
19cf4e6dec round robin connection on fail 2022-02-08 02:03:25 +03:00
Anton Popov
5bb1b3ce77 support async inserts in clickhouse-client for queries with inlined data 2022-02-02 20:59:37 +03:00
Kruglov Pavel
b54bf18b27
Merge branch 'master' into stress-test 2022-01-25 14:35:42 +03:00
DF5HSE
fb2a45009a Fix formatting 2022-01-20 00:44:37 +03:00
DF5HSE
c126afa93b Fix formatting 2022-01-20 00:44:12 +03:00
DF5HSE
76769ac133 Fix formatting 2022-01-20 00:43:40 +03:00
DF5HSE
aa328fa4d8 Fix formatting 2022-01-20 00:42:29 +03:00
DF5HSE
b46af3e0c4 Add list of '<host>:[<port>]' reading in --host param 2022-01-20 00:36:18 +03:00
DF5HSE
f6d50f6fd3 Add list of hosts reading 2022-01-20 00:15:11 +03:00
avogar
0ae0aa712b Don't print exception twice in client in case of exception in parallel parsing 2022-01-11 18:37:07 +03:00
Azat Khuzhin
0685fd9985 clickhouse-local: track memory under --max_memory_usage_in_client option 2021-12-31 11:06:15 +03:00
Kruglov Pavel
ffb6c5b37b
Merge branch 'master' into stress-test 2021-12-23 20:14:15 +03:00
Azat Khuzhin
57c027be0e Remove arcadia build support 2021-12-11 21:25:23 +03:00