thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-24 00:22:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
123,892 Commits 9,167 Branches 1,781 Tags 2.1 GiB
132ab6067b
Commit Graph

123892 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Azat Khuzhin
d0397acafc Add ability to override credentials for accessing base backup in S3 
Sometimes credentials with which the backup had been done are inactive
already, and ClickHouse will not be able to read the metadata file to
continue and fail.

Add a setting to allow ignoring credential from base_backup -
`use_same_s3_credentials_for_base_backup` (default to true).

And the same for RESTORE.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-08-30 20:16:22 +02:00
Mikhail f. Shiryaev
b32345242c
Merge pull request #54081 from ClickHouse/apache-archive 
Replace dlcdn.apache.org by archive domain
 2023-08-30 19:43:43 +02:00
Mikhail f. Shiryaev
c111adb7ce
Replace dlcdn.apache.org by archive domain 2023-08-30 18:40:36 +02:00
Alexander Tokmakov
5cfd1c6d63
Merge pull request #54066 from kssenii/fix-named-collections-access-type-change 
Fix named_collection_admin alias
 2023-08-30 18:34:03 +02:00
Victor Krasnov
6dd926b68b Rename back_table_up to backup_table 2023-08-30 18:53:07 +03:00
Victor Krasnov
81db0f3b0f Rename BackupOperationInfo::ID to BackupOperationID 2023-08-30 18:52:43 +03:00
ltrk2
b6d4b5598b Fix SipHash128 reference for big-endian platforms 2023-08-30 08:15:09 -07:00
vdimir
dbdcea30a0
fix style, add built-in documentation 2023-08-30 15:06:35 +00:00
robot-ch-test-poll4
aa3b687d4a
Merge pull request #54064 from kssenii/fix-logical-error 
Fix after #52943
 2023-08-30 17:06:25 +02:00
Roman Vasin
92b89e8b9e Use NodePtr instead of Node * 2023-08-30 13:50:10 +00:00
vdimir
dd094d1f55
Parse IS NOT DISTINCT and <=> operators 2023-08-30 13:12:43 +00:00
Alexander Tokmakov
4d70624ca3
Merge pull request #53907 from arenadata/ADQM-1126 
Added validate_tcp_client_information server setting
 2023-08-30 15:10:13 +02:00
kssenii
185e3819ac Fix 2023-08-30 13:41:18 +02:00
kssenii
662f22aed0 Fix 2023-08-30 13:31:54 +02:00
Mikhail Koviazin
021c607725
ConfigReloader: use last_write_time for FileWithTimestamp 
Previously it used `FS::getModificationTime` which has only a second precision.
This caused an issue in some cases where the configuration has been changed
more frequently than once per second, and the change wasn't propagated. This
commit fixes that issue.
Closes #53276
 2023-08-30 11:06:19 +00:00
Alexander Tokmakov
55af6e5c3e
Merge pull request #54063 from ClickHouse/revert-53677-mutations_subcolumns 
Revert "Fix bug on mutations with subcolumns of type JSON in predicates of UPDATE and DELETE queries."
 2023-08-30 12:59:51 +02:00
Alexander Tokmakov
83c5e2fba6
Revert "Fix bug on mutations with subcolumns of type JSON in predicates of UPDATE and DELETE queries." 2023-08-30 12:56:17 +02:00
robot-ch-test-poll2
3e5790451e
Merge pull request #54056 from lucasfcnunes/patch-1 
fix typo on s3queue.md
 2023-08-30 12:53:17 +02:00
Jiebin Sun
7c529e5691
Optimize the merge if all hashSets are singleLevel in UniqExactSet (#52973) 
* Optimize the merge if all hashSets are singleLevel

In PR(https://github.com/ClickHouse/ClickHouse/pull/50748), it has added new phase
`parallelizeMergePrepare` before merge if all the hashSets are not all singleLevel
or not all twoLevel. Then it will convert all the singleLevelSet to twoLevelSet in
parallel, which will increase the CPU utilization and QPS.

But if all the hashtables are singleLevel, it could also benefit from the
`parallelizeMergePrepare` optimization in most cases if the hashtable size are not
too small. By tuning the Query `SELECT COUNT(DISTINCT SearchPhase) FROM hits_v1`
in different threads, we have got the mild threshold 6,000.

Test patch with the Query 'SELECT COUNT(DISTINCT Title) FROM hits_v1' on 2x80 vCPUs
server. If the threads are less than 48, the hashSets are all twoLevel or mixed by
singleLevel and twoLevel. If the threads are over 56, all the hashSets are singleLevel.
And the QPS has got at most 2.35x performance gain.

Threads	Opt/Base
8	100.0%
16	99.4%
24	110.3%
32	99.9%
40	99.3%
48	99.8%
56	183.0%
64	234.7%
72	233.1%
80	229.9%
88	224.5%
96	229.6%
104	235.1%
112	229.5%
120	229.1%
128	217.8%
136	222.9%
144	217.8%
152	204.3%
160	203.2%

Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>

* Add the comment and explanation for PR#52973

Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>

---------

Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>
 2023-08-30 11:26:16 +02:00
Antonio Andelic
f406019413 Apply PR comments 2023-08-30 09:26:01 +00:00
Raúl Marín
4f9ddcab2b Correct doc for filesystem_prefetch_max_memory_usage 2023-08-30 10:27:29 +02:00
Antonio Andelic
ddb58217d4 Merge branch 'master' into archive-improvements-2 2023-08-30 07:43:25 +00:00
Antonio Andelic
36fb7cfbd1
Merge pull request #54012 from ClickHouse/refactor-async-insert-with-dedup 
Refactor logic around async insert with deduplication
 2023-08-30 09:37:55 +02:00
Lucas Fernando Cardoso Nunes
6bb406fda9
fix typo on s3queue.md 
Signed-off-by: Lucas Fernando Cardoso Nunes <lucasfc.nunes@gmail.com>
 2023-08-30 04:30:34 -03:00
Alexey Gerasimchuck
f7d1041e61 minor improvement 2023-08-30 06:14:39 +00:00
Azat Khuzhin
aaa68a525a Add no-replicated-database for 02870_move_partition_to_volume_io_throttling 
ALTER TABLE MOVE PARTITION TO DISK/VOLUME should not be replicated since
replicas will not contains this part:

    azat:~/ch/tmp/53338$ for i in clickhouse-server*.log.zst; do echo -n "$i: " && zstd -cdq $i | grep -m1 -e Executed.*ALTER.*test_cnmf4xnb.test_move_partition_throttling -e Exception.*ALTER.*test_cnmf4xnb.test_move_partition_throttling; done
    clickhouse-server1.log.zst: 2023.08.29 16:46:53.960065 [ 1843 ] {19b13d67-54c0-496d-96b9-b1ec09df3618} <Error> executeQuery: Code: 232. DB::Exception: Nothing to move (check that the partition exists). (NO_SUCH_DATA_PART) (version 23.8.1.2862) (from 0.0.0.0:0) (comment: 02870_move_partition_to_volume_io_throttling.sql) (in query: /* ddl_entry=query-0000000005 */ ALTER TABLE test_cnmf4xnb.test_move_partition_throttling MOVE PARTITION tuple() TO VOLUME 'remote' SETTINGS max_remote_write_network_bandwidth = 1600000), Stack trace (when copying this message, always include the lines below):
    clickhouse-server2.log.zst: 2023.08.29 16:46:53.959560 [ 1842 ] {3cd2b5e8-24b9-4cfd-aa47-854e634936f2} <Error> executeQuery: Code: 232. DB::Exception: Nothing to move (check that the partition exists). (NO_SUCH_DATA_PART) (version 23.8.1.2862) (from 0.0.0.0:0) (comment: 02870_move_partition_to_volume_io_throttling.sql) (in query: /* ddl_entry=query-0000000005 */ ALTER TABLE test_cnmf4xnb.test_move_partition_throttling MOVE PARTITION tuple() TO VOLUME 'remote' SETTINGS max_remote_write_network_bandwidth = 1600000), Stack trace (when copying this message, always include the lines below):
    clickhouse-server.log.zst: 2023.08.29 16:46:53.950730 [ 721 ] {df6b20ee-1903-404a-9398-7fead209ccd7} <Debug> DDLWorker(test_cnmf4xnb): Executed query: /* ddl_entry=query-0000000005 */ ALTER TABLE test_cnmf4xnb.test_move_partition_throttling MOVE PARTITION tuple() TO VOLUME 'remote' SETTINGS max_remote_write_network_bandwidth = 1600000

CI: https://s3.amazonaws.com/clickhouse-test-reports/53338/ed401cba9b8254b4a29a5ed9e5ad838c26ffaac1/stateless_tests__release__databasereplicated__[4_4].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-08-30 07:27:11 +02:00
Alexey Gerasimchuck
be2f80cc1c minor corrections 2023-08-29 23:59:36 +00:00
Alexey Gerasimchuck
a1687e618b backward compatibility changes + fixes 2023-08-29 23:50:41 +00:00
Azat Khuzhin
ed401cba9b Add a test for IO throttling for ALTER TABLE MOVE PARTITION TO VOLUME 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-08-29 23:43:03 +02:00
Azat Khuzhin
51e8b16916 Fix IO throttling during copying whole directories 
v2: pass local context during ALTER TABLE MOVE PARTITION TO VOLUME/DISK as well
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-08-29 23:13:46 +02:00
Nikita Mikhaylov
97efd14e90
Merge pull request #54009 from ClickHouse/change-istorage-interface 
Change IStorage interface by random walk, no goal in particular
 2023-08-29 22:22:53 +02:00
Alexey Milovidov
9b74939110
Merge pull request #53742 from aiven-sal/aiven-sal/fix_53187 
transform: correctly handle default column with multiple rows
 2023-08-29 21:57:59 +03:00
Alexey Milovidov
62747ea20f
Merge pull request #53739 from Hexta/arm-clocksource 
Do not warn about arch_sys_counter clock
 2023-08-29 21:57:39 +03:00
kothiga
c25dd560c9
Make UniquesHashSet endianness-independent. 2023-08-29 11:06:21 -07:00
Sergei Trifonov
802579f3f1
Merge pull request #49618 from ClickHouse/concurrency-control-controllable 
Make concurrency control controllable
 2023-08-29 19:44:51 +02:00
Alexey Milovidov
36a01253a0
Merge pull request #54044 from ClickHouse/alexey-milovidov-patch-7 
More assertive
 2023-08-29 20:33:38 +03:00
Alexey Milovidov
c19a20cc23
More assertive 2023-08-29 20:33:03 +03:00
Antonio Andelic
e96c665be7 Refactor logic around async insert with dedup 2023-08-29 14:48:43 +00:00
Alexander Tokmakov
17f3754193
Merge pull request #53851 from ClickHouse/distributed_no_flush_on_shutdown 
Follow-up to #53501
 2023-08-29 16:34:22 +02:00
Nikita Mikhaylov
96cabcae3a Change interface 2023-08-29 16:26:48 +02:00
Mike Kot
8b1e30d774 fix 2023-08-29 13:36:47 +00:00
Robert Schulze
342c78bfe6
Merge pull request #53763 from rschu1ze/branch-references 
Remove branch references from .gitmodules
 2023-08-29 15:29:43 +02:00
Alexander Tokmakov
464c49fdcb
Merge pull request #53929 from ClickHouse/revert-53713-ADQM-1107 
Revert "Fixed wrong python test name pattern"
 2023-08-29 15:23:01 +02:00
Alexander Tokmakov
e610a1867c
Revert "Fixed wrong python test name pattern" 2023-08-29 15:19:13 +02:00
robot-clickhouse-ci-1
f5c0890b32
Merge pull request #53895 from ClickHouse/vdimir/write_buffer_to_file_segment_dtor 
Finalize file descriptor in ~WriteBufferToFileSegment
 2023-08-29 15:15:44 +02:00
Anton Popov
6ce4a82a04
Merge pull request #53677 from VanDarkholme7/mutations_subcolumns 
Fix bug on mutations with subcolumns of type JSON in predicates of UPDATE and DELETE queries.
 2023-08-29 15:08:00 +02:00
Kseniia Sumarokova
463a197da4
Merge pull request #53847 from kssenii/fix-segfault-in-pg 
Fix possible segfault while using PostgreSQL engine
 2023-08-29 14:45:46 +02:00
JackyWoo
51e64f6e4f Simplify reference file content 2023-08-29 20:42:59 +08:00
Alexander Tokmakov
87890ef02d update tests 2023-08-29 14:35:30 +02:00
Mike Kot
061bbe13c0 add docs for clickhouse-disks 2023-08-29 12:25:04 +00:00