thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 08:40:50 +00:00
Code Issues Packages Projects Releases Wiki Activity
144,611 Commits 8,927 Branches 1,765 Tags 2 GiB
13c2f7221d
Commit Graph

175 Commits

Author SHA1 Message Date
Antonio Andelic
69fd05cb55 Merge branch 'master' into fix-gwp-asan 2024-06-05 09:31:36 +02:00
Alexey Milovidov
5a5bdd87cb
Merge pull request #64592 from tomershafir/xray 
xray: add global xray instrumentation support
 2024-06-05 01:25:25 +02:00
Antonio Andelic
5df91804f6 Add probability setting for GWPAsan 2024-06-03 11:54:37 +02:00
Antonio Andelic
5633a18f2f Merge branch 'master' into fix-gwp-asan 2024-06-03 10:43:14 +02:00
tomershafir
6397f26998 xray: add global xray instrumentation support 2024-05-29 17:33:21 +03:00
Antonio Andelic
804b1ad1e0 Better 2024-05-27 10:34:16 +00:00
Antonio Andelic
6753a0ad18 Better 2024-05-24 17:03:49 +02:00
Robert Schulze
a14e58ab88
Merge remote-tracking branch 'rschu1ze/master' into redundant-inline 2024-05-21 05:15:35 +00:00
Robert Schulze
113bb00005
Fix clang-tidy "-readability-redundant-inline-specifier" 2024-05-19 10:23:58 +00:00
Alexey Milovidov
bd6a4a3068 Merge branch 'master' into libunwind-fix-crash 2024-05-17 07:24:39 +02:00
Azat Khuzhin
27b41650f8 Fix crash on exit with sentry enabled (due to openssl destroyed before sentry) 
The problem is tha openssl registers OPENSSL_cleanup() as atexit
handler, which called before destroying of SentryWriter, so to avoid
this problem, let's destroy it explicitly.

<details>

<summary>stack trace example</summary>

    Thread 2 (Thread 0x7ffff54006c0 (LWP 24847) "clickhouse-serv"):
    0  ___pthread_rwlock_rdlock (rwlock=0x0) at pthread_rwlock_rdlock.c:26
    1  0x00000000164c18a9 in CRYPTO_THREAD_read_lock (lock=0x0) at threads_pthread.c:93
    2  0x000000001642e6b9 in int_err_get_item (d=0x7ffff53f74e0) at err.c:192
    ...
    7  ossl_connect_common (cf=0x7ffff7812c80, data=0x7ffff70a4c00, nonblocking=bool_true, done=0x7ffff53f834c) at openssl.c:4486
    ...
    17 curl_easy_perform (data=data@entry=0x7ffff70a4c00) at easy.c:787
    18 0x000000000b4c3854 in sentry__curl_send_task (_envelope=<optimized out>, _state=0x7ffff7074300) at sentry_transport_curl.c:225
    19 0x000000000b4ba880 in worker_thread (data=0x7ffff70e5500) at sentry_sync.c:262

    Thread 1 (Thread 0x7ffff7cb2c80 (LWP 24842) "clickhouse-serv"):
    5  0x000000000b4bb0e2 in sentry__cond_wait_timeout (cv=0x7ffff70e5540, mutex=0x7ffff70e5570, msecs=250) at sentry_sync.h:332
    6  sentry__bgworker_shutdown (bgw=0x7ffff70e5500, timeout=2000) at sentry_sync.c:412
    7  0x000000000b4b3e95 in sentry_close () at sentry_core.c:238
    8  0x000000000b4a5f1f in SentryWriter::~SentryWriter (this=0x7ffff71a1240) at SentryWriter.cpp:147
    9  std::__1::default_delete<SentryWriter>::operator()[abi:v15000](SentryWriter*) const (this=0x7ffff70e5568, __ptr=0x7ffff71a1240) at unique_ptr.h:48
    10 std::__1::unique_ptr<SentryWriter, std::__1::default_delete<SentryWriter> >::reset[abi:v15000](SentryWriter*) (this=0x7ffff70e5568, __p=0x0) at unique_ptr.h:305
    11 std::__1::unique_ptr<SentryWriter, std::__1::default_delete<SentryWriter> >::~unique_ptr[abi:v15000]() (this=0x7ffff70e5568) at unique_ptr.h:259
    12 0x00007ffff7de62e6 in __run_exit_handlers (status=0, listp=<optimized out>, run_list_atexit=run_list_atexit@entry=true, run_dtors=run_dtors@entry=true) at exit.c:108
    13 0x00007ffff7de642e in __GI_exit (status=<optimized out>) at exit.c:138
    14 0x00007ffff7dccd51 in __libc_start_call_main (main=main@entry=0x6111c20 <main(int, char**)>, argc=argc@entry=13, argv=argv@entry=0x7fffffffb718) at libc_start_call_main.h:74
    15 0x00007ffff7dcce0c in __libc_start_main_impl (main=0x6111c20 <main(int, char**)>, argc=13, argv=0x7fffffffb718, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffb708) at libc-start.c:360

    (gdb) p req.body
    $7 = 0x7ffff7816000 "{\"dsn\":\"...\"}\n{\"type\":\"session\",\"length\":190}\n{\"init\":true,\"sid\":\"...\",\"status\":\"exited\",\"errors\":0,\"started\":\"2024-05-08T20:29:23.253Z\",\"duration\":17.213,\"attrs\":{\"release\":\"24.5\",\"environment\":\"test\"}}"

</details>

P.S. Likely started happens after conversion to OpenSSL (#59870).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-05-09 07:39:23 +02:00
Alexey Milovidov
875507c921 Merge branch 'master' into libunwind-fix-crash 2024-05-03 03:41:36 +02:00
Alexey Milovidov
9b75f93470 Merge branch 'master' into libunwind-fix-crash 2024-04-12 02:08:24 +02:00
Azat Khuzhin
66c6ef0463 More cleaner SentryWriter API 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-11 17:26:49 +02:00
Azat Khuzhin
f1cb1f80b6 Make sending LOGICAL_ERRORs to sentry configurable 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-11 15:56:26 +02:00
Azat Khuzhin
81dec9a077 Avoid SentryWriter deps for Exception 
$ ninja unit_tests_dbms
    FAILED: src/unit_tests_dbms
    : && /usr/bin/clang++ --target=x86_64-linux-gnu --sysroot=/src/ch/clickhouse/cmake/linux/../../contrib/sysroot/linux-x86_64/x86_64-linux-gnu/libc --gcc-toolchain=/src/ch/clickhouse/cmake/linux/../../contrib/sysroot/linux-x86_64 -fdiagnostics-color=always -Xclang -fuse-ctor-homing -Wno-enum-constexpr-conversion -fsized-deallocation  -gdwarf-aranges -pipe -mssse3 -msse4.1 -msse4.2 -mpclmul -mpopcnt -fasynchronous-unwind-tables -falign-functions=32 -mbranches-within-32B-boundaries -ffp-contract=off  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdiagnostics-absolute-paths -fstrict-vtable-pointers -Wall -Wextra -Wframe-larger-than=65536 -Weverything -Wpedantic -Wno-zero-length-array -Wno-c++98-compat-pedantic -Wno-c++98-compat -Wno-c++20-compat -Wno-sign-conversion -Wno-implicit-int-conversion -Wno-implicit-int-float-conversion -Wno-ctad-maybe-unsupported -Wno-disabled-macro-expansion -Wno-documentation-unknown-command -Wno-double-promotion -Wno-exit-time-destructors -Wno-float-equal -Wno-global-constructors -Wno-missing-prototypes -Wno-missing-variable-declarations -Wno-padded -Wno-switch-enum -Wno-undefined-func-template -Wno-unused-template -Wno-vla -Wno-weak-template-vtables -Wno-weak-vtables -Wno-thread-safety-negative -Wno-enum-constexpr-conversion -Wno-unsafe-buffer-usage -Wno-switch-default -O2 -g -DNDEBUG -O3 -g  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fno-pie --gcc-toolchain=/src/ch/clickhouse/cmake/linux/../../contrib/sysroot/linux-x86_64 --ld-path=/usr/bin/ld.lld -Wl,--no-export-dynamic -Wl,--gc-sections -Wl,--gdb-index -Wl,--build-id=sha1 -no-pie -Wl,-no-pie    -Xlinker --no-undefined @CMakeFiles/unit_tests_dbms.rsp -o src/unit_tests_dbms && :
    ld.lld: error: undefined symbol: SentryWriter::getInstance()
    >>> referenced by Exception.cpp:63 (/src/ch/clickhouse/src/Common/Exception.cpp:63)
    >>>               Exception.cpp.o:(DB::handle_error_code(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, int, bool, std::__1::vector<void*, std::__1::allocator<void*>> const&)) in archive src/libclickhouse_common_io.a
    >>> referenced by Exception.cpp:63 (/src/ch/clickhouse/src/Common/Exception.cpp:63)
    >>>               Exception.cpp.o:(DB::Exception::Exception(DB::Exception::MessageMasked const&, int, bool)) in archive src/libclickhouse_common_io.a
    >>> referenced by Exception.cpp:63 (/src/ch/clickhouse/src/Common/Exception.cpp:63)
    >>>               Exception.cpp.o:(DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool)) in archive src/libclickhouse_common_io.a

    ld.lld: error: undefined symbol: SentryWriter::onFault(int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, std::__1::array<void*, 45ul> const&, unsigned long, unsigned long)
    >>> referenced by Exception.cpp:68 (/src/ch/clickhouse/src/Common/Exception.cpp:68)
    >>>               Exception.cpp.o:(DB::handle_error_code(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, int, bool, std::__1::vector<void*, std::__1::allocator<void*>> const&)) in archive src/libclickhouse_common_io.a
    >>> referenced by Exception.cpp:68 (/src/ch/clickhouse/src/Common/Exception.cpp:68)
    >>>               Exception.cpp.o:(DB::Exception::Exception(DB::Exception::MessageMasked const&, int, bool)) in archive src/libclickhouse_common_io.a
    >>> referenced by Exception.cpp:68 (/src/ch/clickhouse/src/Common/Exception.cpp:68)
    >>>               Exception.cpp.o:(DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool)) in archive src/libclickhouse_common_io.a
    clang++: error: linker command failed with exit code 1 (use -v to see invocation)
    ninja: build stopped: subcommand failed.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-11 15:51:23 +02:00
Azat Khuzhin
f854595cd4 Rewrite SentryWriter to a singleton 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-11 15:50:36 +02:00
Azat Khuzhin
f4ad005249 Send LOGICAL_ERRORs to sentry 
This is like an assert() in the code, so it is useful to know about them
as well.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-11 15:50:32 +02:00
Alexander Tokmakov
8a28cbc865
Merge pull request #62418 from azat/uncaught-exception-onFault 
Avoid uncaught exception for onFault handler
 2024-04-09 21:59:19 +00:00
Alexey Milovidov
5db0df0bc1
Update BaseDaemon.cpp 2024-04-08 21:48:36 +03:00
Azat Khuzhin
75e46f865c Avoid uncaught exception for onFault handler 
onFault() is called from the std::thread, and it should catch all
exceptions, otherwise you can unrelated fatal errors.

<details>

<summary>stacktrace</summary>

    2024.04.08 13:15:29.526847 [ 2067427 ] {} <Fatal> BaseDaemon: (version 24.2.2.71 (official build), build id: 57F857DCFE8BA6838F6463E4665CD700852BFF0E, git hash: 9293d361e7) (from thread 2118603) Terminate called for uncaught exception:
    2024.04.08 13:15:29.526904 [ 2067427 ] {} <Fatal> BaseDaemon: Code: 210. DB::NetException: I/O error: Broken pipe, while writing to socket (10.61.7.253:9000 -> 10.101.53.134:46036). (NETWORK_ERROR), Stack trace (when copying this message, always include the lines below):
    2024.04.08 13:15:29.526983 [ 2067427 ] {} <Fatal> BaseDaemon:
    2024.04.08 13:15:29.527042 [ 2067427 ] {} <Fatal> BaseDaemon: 0. ./build_docker/./src/Common/Exception.cpp:96: DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000000cf5af1b
    2024.04.08 13:15:29.527061 [ 2067427 ] {} <Fatal> BaseDaemon: 1. ./contrib/llvm-project/libcxx/include/string:1499: DB::NetException::NetException<String, String, String>(int, FormatStringHelperImpl<std::type_identity<String>::type, std::type_identity<String>::type, std::type_identity<String>::type>, String&&, String&&, String&&) @ 0x000000000d07dfe1
    2024.04.08 13:15:29.527082 [ 2067427 ] {} <Fatal> BaseDaemon: 2. ./build_docker/./src/IO/WriteBufferFromPocoSocket.cpp:0: DB::WriteBufferFromPocoSocket::nextImpl() @ 0x000000000d07e97e
    2024.04.08 13:15:29.527125 [ 2067427 ] {} <Fatal> BaseDaemon: 3. ./src/IO/WriteBuffer.h:65: DB::TCPHandler::sendLogs() @ 0x0000000012fd31c1
    2024.04.08 13:15:29.527144 [ 2067427 ] {} <Fatal> BaseDaemon: 4. ./contrib/llvm-project/libcxx/include/atomic:958: void std::__function::__policy_invoker<void ()>::__call_impl<std::__function::__default_alloc_func<DB::TCPHandler::runImpl()::$_0, void ()>>(std::__function::__policy_storage const*) @ 0x0000000012fdcc6e
    2024.04.08 13:15:29.527163 [ 2067427 ] {} <Fatal> BaseDaemon: 5. ./contrib/llvm-project/libcxx/include/__functional/function.h:0: ? @ 0x000000000d25c65b
    2024.04.08 13:15:29.527182 [ 2067427 ] {} <Fatal> BaseDaemon: 6. ./build_docker/./src/Daemon/BaseDaemon.cpp:286: void* std::__thread_proxy[abi:v15000]<std::tuple<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, SignalListener::run()::'lambda'()>>(void*) @ 0x000000000d25e775
    2024.04.08 13:15:29.527191 [ 2067427 ] {} <Fatal> BaseDaemon: 7. ? @ 0x00007f0fe4906609
    2024.04.08 13:15:29.527211 [ 2067427 ] {} <Fatal> BaseDaemon: 8. ? @ 0x00007f0fe482b353

    2024.04.08 13:15:29.534235 [ 2118604 ] {} <Fatal> BaseDaemon: ########## Short fault info ############
    2024.04.08 13:15:29.534347 [ 2118604 ] {} <Fatal> BaseDaemon: (version 24.2.2.71 (official build), build id: 57F857DCFE8BA6838F6463E4665CD700852BFF0E, git hash: 9293d361e7) (from thread 2118603) Received signal 6
    2024.04.08 13:15:29.534476 [ 2118604 ] {} <Fatal> BaseDaemon: Signal description: Aborted
    2024.04.08 13:15:29.534484 [ 2118604 ] {} <Fatal> BaseDaemon:
    2024.04.08 13:15:29.534510 [ 2118604 ] {} <Fatal> BaseDaemon: Stack trace: 0x00007f0fe474f00b 0x00007f0fe472e859 0x000000000d24f72e 0x0000000017d15be3 0x0000000017d15818 0x0000000012fd350d 0x0000000012fdcc6e 0x000000000d25c65b 0x000000000d25e775 0x00007f0fe4906609 0x00007f0fe482b353
    2024.04.08 13:15:29.534531 [ 2118604 ] {} <Fatal> BaseDaemon: ########################################
    2024.04.08 13:15:29.534609 [ 2118604 ] {} <Fatal> BaseDaemon: (version 24.2.2.71 (official build), build id: 57F857DCFE8BA6838F6463E4665CD700852BFF0E, git hash: 9293d361e7) (from thread 2118603) (no query) Received signal Aborted (6)
    2024.04.08 13:15:29.534638 [ 2118604 ] {} <Fatal> BaseDaemon:
    2024.04.08 13:15:29.534663 [ 2118604 ] {} <Fatal> BaseDaemon: Stack trace: 0x00007f0fe474f00b 0x00007f0fe472e859 0x000000000d24f72e 0x0000000017d15be3 0x0000000017d15818 0x0000000012fd350d 0x0000000012fdcc6e 0x000000000d25c65b 0x000000000d25e775 0x00007f0fe4906609 0x00007f0fe482b353
    2024.04.08 13:15:29.534711 [ 2118604 ] {} <Fatal> BaseDaemon: 2. ? @ 0x00007f0fe474f00b
    2024.04.08 13:15:29.534728 [ 2118604 ] {} <Fatal> BaseDaemon: 3. ? @ 0x00007f0fe472e859
    2024.04.08 13:15:29.613230 [ 2118604 ] {} <Fatal> BaseDaemon: 4.0. inlined from ./contrib/llvm-project/libcxxabi/src/cxa_exception.cpp:670: __cxa_decrement_exception_refcount
    2024.04.08 13:15:29.613283 [ 2118604 ] {} <Fatal> BaseDaemon: 4.1. inlined from ./contrib/llvm-project/libcxx/src/support/runtime/exception_pointer_cxxabi.ipp:17: ~exception_ptr
    2024.04.08 13:15:29.613311 [ 2118604 ] {} <Fatal> BaseDaemon: 4. ./build_docker/./src/Daemon/BaseDaemon.cpp:591: terminate_handler() @ 0x000000000d24f72e
    2024.04.08 13:15:29.617590 [ 2118604 ] {} <Fatal> BaseDaemon: 5. ./build_docker/./contrib/llvm-project/libcxxabi/src/cxa_handlers.cpp:61: std::__terminate(void (*)()) @ 0x0000000017d15be3
    2024.04.08 13:15:29.619575 [ 2118604 ] {} <Fatal> BaseDaemon: 6. ./build_docker/./contrib/llvm-project/libcxxabi/src/cxa_exception.cpp:0: __cxa_rethrow @ 0x0000000017d15818
    2024.04.08 13:15:30.104097 [ 2118604 ] {} <Fatal> BaseDaemon: 7.0. inlined from ./src/IO/WriteBuffer.h:0: DB::WriteBuffer::next()
    2024.04.08 13:15:30.104331 [ 2118604 ] {} <Fatal> BaseDaemon: 7.1. inlined from ./build_docker/./src/Server/TCPHandler.cpp:2225: DB::TCPHandler::sendLogData(DB::Block const&)
    2024.04.08 13:15:30.104408 [ 2118604 ] {} <Fatal> BaseDaemon: 7. ./build_docker/./src/Server/TCPHandler.cpp:2303: DB::TCPHandler::sendLogs() @ 0x0000000012fd350d
    2024.04.08 13:15:30.217481 [ 2118604 ] {} <Fatal> BaseDaemon: 8.0. inlined from ./contrib/llvm-project/libcxx/include/atomic:958: double std::__cxx_atomic_load[abi:v15000]<double>(std::__cxx_atomic_base_impl<double> const*, std::memory_order)
    2024.04.08 13:15:30.217579 [ 2118604 ] {} <Fatal> BaseDaemon: 8.1. inlined from ./contrib/llvm-project/libcxx/include/atomic:1588: std::__atomic_base<double, false>::load[abi:v15000](std::memory_order) const
    2024.04.08 13:15:30.217617 [ 2118604 ] {} <Fatal> BaseDaemon: 8.2. inlined from ./src/Common/ThreadFuzzer.cpp:407: pthread_mutex_unlock
    2024.04.08 13:15:30.217644 [ 2118604 ] {} <Fatal> BaseDaemon: 8.3. inlined from ./contrib/llvm-project/libcxx/include/__threading_support:314: std::__libcpp_mutex_unlock[abi:v15000](pthread_mutex_t*)
    2024.04.08 13:15:30.217676 [ 2118604 ] {} <Fatal> BaseDaemon: 8.4. inlined from ./contrib/llvm-project/libcxx/src/mutex.cpp:52: std::mutex::unlock()
    2024.04.08 13:15:30.217699 [ 2118604 ] {} <Fatal> BaseDaemon: 8.5. inlined from ./contrib/llvm-project/libcxx/include/__mutex_base💯 ~lock_guard
    2024.04.08 13:15:30.217747 [ 2118604 ] {} <Fatal> BaseDaemon: 8.6. inlined from ./build_docker/./src/Server/TCPHandler.cpp:392: operator()
    2024.04.08 13:15:30.217776 [ 2118604 ] {} <Fatal> BaseDaemon: 8.7. inlined from ./contrib/llvm-project/libcxx/include/__functional/invoke.h:394: ?
    2024.04.08 13:15:30.217796 [ 2118604 ] {} <Fatal> BaseDaemon: 8.8. inlined from ./contrib/llvm-project/libcxx/include/__functional/invoke.h:479: ?
    2024.04.08 13:15:30.217859 [ 2118604 ] {} <Fatal> BaseDaemon: 8.9. inlined from ./contrib/llvm-project/libcxx/include/__functional/function.h:235: ?
    2024.04.08 13:15:30.217878 [ 2118604 ] {} <Fatal> BaseDaemon: 8. ./contrib/llvm-project/libcxx/include/__functional/function.h:716: ? @ 0x0000000012fdcc6e
    2024.04.08 13:15:30.240809 [ 2118604 ] {} <Fatal> BaseDaemon: 9. ./contrib/llvm-project/libcxx/include/__functional/function.h:0: ? @ 0x000000000d25c65b
    2024.04.08 13:15:30.283617 [ 2118604 ] {} <Fatal> BaseDaemon: 10.0. inlined from ./build_docker/./src/Daemon/BaseDaemon.cpp:286: operator()
    2024.04.08 13:15:30.283686 [ 2118604 ] {} <Fatal> BaseDaemon: 10.1. inlined from ./contrib/llvm-project/libcxx/include/__functional/invoke.h:394: ?
    2024.04.08 13:15:30.283725 [ 2118604 ] {} <Fatal> BaseDaemon: 10.2. inlined from ./contrib/llvm-project/libcxx/include/thread:284: void std::__thread_execute[abi:v15000]<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, SignalListener::run()::'lambda'()>(std::tuple<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, SignalListener::run()::'lambda'()>&, std::__tuple_indices<>)
    2024.04.08 13:15:30.283755 [ 2118604 ] {} <Fatal> BaseDaemon: 10. ./contrib/llvm-project/libcxx/include/thread:295: void* std::__thread_proxy[abi:v15000]<std::tuple<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, SignalListener::run()::'lambda'()>>(void*) @ 0x000000000d25e775
    2024.04.08 13:15:30.283799 [ 2118604 ] {} <Fatal> BaseDaemon: 11. ? @ 0x00007f0fe4906609
    2024.04.08 13:15:30.283821 [ 2118604 ] {} <Fatal> BaseDaemon: 12. ? @ 0x00007f0fe482b353
    2024.04.08 13:15:30.574588 [ 2118604 ] {} <Fatal> BaseDaemon: Integrity check of the executable successfully passed (checksum: 3485110FABDB0C94202BD684999A9814)
    2024.04.08 13:15:30.574704 [ 2118604 ] {} <Fatal> BaseDaemon: Report this error to https://github.com/ClickHouse/ClickHouse/issues

</details>

v2: fatal logging

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-08 20:20:25 +02:00
Robert Schulze
97281203b8
Don't access static members through instance, pt. II 
clang-tidy rightfully complains
(-readability-static-accessed-through-instance) that static member
functions are accessed through non-static members
 2024-04-07 11:09:35 +00:00
Raúl Marín
c35a436435 Remove nested dependency on DateLutImpl 2024-04-02 14:45:48 +02:00
Alexey Milovidov
9dece1a7f6
Merge branch 'master' into libunwind-fix-crash 2024-03-29 02:10:22 +03:00
Antonio Andelic
638754f988 Fix signal handler for sanitizer signals 2024-03-21 13:34:32 +01:00
Raúl Marín
de855ca917 Reduce header dependencies 2024-03-19 17:04:29 +01:00
Robert Schulze
c17536c3b3
Enable clang-tidy in headers 2024-03-18 08:00:09 +00:00
Alexey Milovidov
784b656c6a Another approach 2024-03-11 00:44:36 +01:00
Alexey Milovidov
a67d862bd0 Support for sanitizers 2024-03-03 02:47:15 +01:00
Alexey Milovidov
a95e7de257 Support for MSan 2024-03-03 02:44:55 +01:00
Alexey Milovidov
ee07f8b856 Merge branch 'libunwind-fix-crash' of github.com:ClickHouse/ClickHouse into libunwind-fix-crash 2024-03-02 03:20:01 +01:00
Alexey Milovidov
aace0e39f1 Merge branch 'master' into libunwind-fix-crash 2024-03-02 03:19:46 +01:00
Robert Schulze
4ee1aa8c7c
Fixing more headers 2024-02-29 15:40:30 +00:00
Michael Kolupaev
b1e67c7bc6
s/jmp_buf/sigjmp_buf/ 2024-02-28 09:55:16 +00:00
Alexey Milovidov
676519ce90 Fix crash in libunwind while interpreting debug info 2024-02-27 23:06:47 +01:00
Alexey Milovidov
e77d1076b8 Fix crash in libunwind while interpreting debug info 2024-02-27 23:03:22 +01:00
Alexander Tokmakov
64a80f1011
Fix default path when path is not specified in config (#59654) 
* Update Server.cpp

* Update SentryWriter.cpp

* Update Keeper.cpp

* Update SentryWriter.cpp
 2024-02-21 20:33:39 +01:00
Maksim Kita
2a327107b6 Updated implementation 2024-01-25 14:31:49 +03:00
Azat Khuzhin
c6225bdda2 Fix fault handler in case of thread (for fault handler) cannot be spawned 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-17 18:49:02 +03:00
Azat Khuzhin
d25832a29f Refactor stacktrace symbolizer to avoid copy-paste 
Note, that this patch slightly changes the behavior, since now inline
frames will be processed for sentry as well.

And also it properly uses offset argument for non ELF.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-01-11 15:17:51 +03:00
Raúl Marín
b269f87f4c Better text_log with ErrnoException 2023-12-15 19:27:56 +01:00
Alexey Milovidov
cb74f52c5c Make autogenerated file as light as possible 2023-11-14 06:27:39 +01:00
Alexey Milovidov
32dd1b26b3 Make autogenerated file as light as possible 2023-11-14 06:26:05 +01:00
Alexey Milovidov
82c461031e Fix build 2023-11-13 10:09:23 +01:00
Alexey Milovidov
9a7f5ab0a1 Better use of build cache 2023-11-13 08:54:24 +01:00
Robert Schulze
9fff447716
Re-enable clang-tidy checks 2023-09-26 09:34:12 +00:00
Alexey Milovidov
6a4e4cc361
Merge pull request #54744 from azat/server-shutdown 
Disable killing the server by systemd
 2023-09-22 18:04:20 +03:00
Robert Schulze
5209bd2d51
Merge remote-tracking branch 'rschu1ze/master' into clang-17 2023-09-21 14:45:55 +00:00
Robert Schulze
f5137dd0b4
More clang-tidy fixes 2023-09-21 14:40:57 +00:00
Antonio Andelic
6dab5bf3a7
Better 2023-09-20 15:55:12 +02:00