Commit Graph

51162 Commits

Author SHA1 Message Date
Robert Schulze
20c0347eef
Merge pull request #57885 from bigo-sg/if-opt
Branch-free evaluation in function `if()`
2023-12-21 10:24:06 +01:00
Alexey Milovidov
ab6a712ec6 Add compatibility in the replication protocol for a removed feature 2023-12-21 09:31:59 +01:00
Alexey Milovidov
3b1aa53460
Merge pull request #58100 from ClickHouse/optimize-cleanup-as-noop
Reintroduce OPTIMIZE CLEANUP as no-op
2023-12-21 09:27:10 +01:00
Antonio Andelic
b9466023ce
Merge pull request #58069 from ClickHouse/dont-preprocess-if-not-ready
Fix invalid preprocessing on Keeper
2023-12-21 09:08:56 +01:00
Alexey Milovidov
b57bc0e4ed
Merge pull request #58092 from Algunenano/cosmetic_changes
Minor cosmetic changes
2023-12-21 06:06:48 +01:00
Alexey Milovidov
411d1049dd Reintroduce OPTIMIZE CLEANUP as no-op 2023-12-21 06:02:46 +01:00
San
5b6d171145
Merge pull request #58060 from ClickHouse/non_post_request_shouldbe_readonly
Non post request should be readonly
2023-12-21 15:34:34 +11:00
zhanglistar
f0a51e5be5 Modify comments and merge master. 2023-12-21 09:55:26 +08:00
zhanglistar
408f9ea1ae
Merge branch 'ClickHouse:master' into if-opt 2023-12-21 09:50:23 +08:00
Alexey Milovidov
7be39a27cc
Revert "Consider lightweight deleted rows when selecting parts to merge" 2023-12-21 01:46:38 +03:00
Azat Khuzhin
6fd32d92d0 Add max/peak RSS into system.asynchronous_metrics
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-20 20:36:05 +01:00
Raúl Marín
a581450567 Cosmetic 2023-12-20 18:44:09 +01:00
Nikolai Kochetov
4d7a5d47ee
Merge pull request #58045 from ClickHouse/make-windowInsertResultInto-constant
Make window insert result into constant
2023-12-20 17:42:34 +01:00
Nikita Taranov
d57ac6dfdb
Set replica number to its position in cluster definition (#57800)
* impl

* fix
2023-12-20 17:33:05 +01:00
Alexander Tokmakov
015225c629
Merge pull request #57906 from ClickHouse/create_index_normalize
Normalize function names in CREATE INDEX
2023-12-20 17:24:19 +01:00
Kruglov Pavel
ca7001d70f
Merge pull request #57850 from shanielh/feature/s3-session-token
Feature/s3 session token
2023-12-20 17:22:09 +01:00
Alexander Tokmakov
858f2be6b5
Merge pull request #57337 from ClickHouse/drop_database_replica_no_throw
Don't throw if noop when dropping database replica in batch
2023-12-20 16:48:58 +01:00
vdimir
a78b00a854
Analyzer: Fix assert in tryReplaceAndEqualsChainsWithConstant 2023-12-20 15:44:05 +00:00
Anton Popov
87d0cec055
Merge pull request #57433 from CurtizJ/materialize-lightweight-delete
Add mutation command `APPLY DELETED MASK`
2023-12-20 14:44:11 +01:00
vdimir
ae4270465d
Merge pull request #57544 from ClickHouse/vdimir/dict_hashed_array_shard
Support SHARDS for HashedArrayDictionary
2023-12-20 13:02:26 +01:00
Nikolai Kochetov
b10183e7af
Merge pull request #58048 from ClickHouse/follow-up-57691
Follow up for #57691
2023-12-20 12:54:19 +01:00
Antonio Andelic
3cc8358b89 Avoid preprocessing if Keeper leader is not ready 2023-12-20 10:22:00 +00:00
Robert Schulze
ecb6f31211
Merge pull request #57969 from rschu1ze/punycode-is-cool
Implement punycode encoding/decoding
2023-12-20 10:20:34 +01:00
zhanglistar
810305fafe Fix if.xml. 2023-12-20 10:58:46 +08:00
santrancisco
1e86fb298a
Fixing check for HTTP POST request 2023-12-20 12:37:36 +11:00
Yakov Olkhovskiy
6830954cd3
Merge pull request #57988 from Chen768959/fix-literal-alias-misclassification
Fix literal alias misclassification
2023-12-19 19:36:59 -05:00
Alexey Milovidov
af32b33e93
Merge pull request #57648 from jewelzqiu/refine-lwd-merge
Consider lightweight deleted rows when selecting parts to merge
2023-12-20 01:10:32 +01:00
Alexey Milovidov
d190866fc0
Merge pull request #58031 from ClickHouse/revert-57766-fix-bug-window-functions
Revert "Fix bug window functions: revert #39631"
2023-12-20 01:08:08 +01:00
Alexey Milovidov
319a7e2911
Merge pull request #57994 from Algunenano/blake3_llvm
Replace rust's BLAKE3 with llvm's implementation
2023-12-20 01:06:35 +01:00
Yakov Olkhovskiy
43fcea64b6
Merge pull request #57186 from chenlx0/bytes_uncompressed
Show uncompressed data size in system.tables
2023-12-19 19:04:47 -05:00
Raúl Marín
ccff198265
Rename canUseParallelReplicas to canUseTaskBasedParallelReplicas (#58025) 2023-12-19 23:21:19 +01:00
Jordi Villar
7c281d9a6f
Allow max_size_to_drop settings in query time (#57452) 2023-12-19 23:16:03 +01:00
jsc0218
0a9475abc7
Merge pull request #57874 from joelynch/joelynch/host-psql
bugfix: addresses_expr ignored for psql named collections
2023-12-19 15:24:23 -05:00
Alexander Tokmakov
bbd7bc0dd9
Update SystemLogBase.cpp 2023-12-19 20:26:19 +01:00
Julia Kartseva
c7eff0e573
Merge pull request #58015 from jkartseva/fix-fuzzjson-segfault
Fix segfault in FuzzJSON engine
2023-12-19 11:19:20 -08:00
Julia Kartseva
2c32589949
Merge pull request #58019 from jkartseva/fix-build-errno-exception
fix freebsd build
2023-12-19 11:16:45 -08:00
Yarik Briukhovetskyi
6e816d45ae
Merge branch 'master' into paste_join 2023-12-19 20:02:24 +01:00
yariks5s
4e418a89d9 fixed suggestions 2023-12-19 19:00:37 +00:00
Julia Kartseva
58f75c9679
Update src/Storages/StorageFuzzJSON.cpp
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2023-12-19 10:17:15 -08:00
Sema Checherinda
802ad4ec47
Merge pull request #57523 from ClickHouse/remove-the-limit-for-connections-per-endpoint
Remove the limit for the number of connections per endpoint for background fetches + small refactoring
2023-12-19 19:16:01 +01:00
Nikolai Kochetov
9510b2ccfe Follow up for 57691 2023-12-19 17:57:52 +00:00
Nikolai Kochetov
ddb582c8b4 Make windowInsertResultInto constant 2023-12-19 16:52:50 +00:00
Bharat Nallan Chakravarthy
ecd2843b47 add a clarification to docs 2023-12-19 08:35:14 -08:00
Nikolai Kochetov
a69005525b Fix function ntile. 2023-12-19 16:15:39 +00:00
Nikita Taranov
a375b1eab8
Fix handling of unavailable replicas before first request happened (#57933) 2023-12-19 16:41:51 +01:00
Raúl Marín
b458c77340 Fix integration test 2023-12-19 14:36:03 +01:00
Raúl Marín
64247e9033 Try fix clang-tidy again 2023-12-19 14:28:41 +01:00
Kseniia Sumarokova
d4e71f96c1
Merge pull request #57897 from ClickHouse/allow-to-dynamically-change-fs-cache-size
Support dynamic reloading of filesystem cache size
2023-12-19 13:51:42 +01:00
Robert Schulze
952175ce39
Merge pull request #57875 from zhongyuankai/order_by_all
Support `ORDER BY ALL`
2023-12-19 13:38:07 +01:00
vdimir
252cb8a507
Merge pull request #54602 from fionera/issue-49028
Add setting http_make_head_request
2023-12-19 13:33:59 +01:00
Nikolai Kochetov
8ab6564538
Revert "Fix bug window functions: revert #39631" 2023-12-19 13:30:59 +01:00
Robert Schulze
f503aa7838
Merge pull request #57887 from canhld94/ch_fast_enum_default_serialization
More efficient constructor for SerializationEnum
2023-12-19 12:51:23 +01:00
Chen768959
c1f7de770d
Merge branch 'ClickHouse:master' into fix-literal-alias-misclassification 2023-12-19 19:48:25 +08:00
Raúl Marín
8bef92c92a Fix clang-tidy 2023-12-19 12:39:05 +01:00
Anton Popov
34cdecea70
Merge pull request #58013 from CurtizJ/fix-race-external-sort
Fix rare race in external sort/aggregation with temporary data in cache
2023-12-19 12:20:31 +01:00
Raúl Marín
3632688e55 Fix style 2023-12-19 11:48:15 +01:00
Antonio Andelic
52b3caec90
Revert "Add system.dropped_tables_parts table" 2023-12-19 10:36:22 +01:00
zhanglistar
59b049ce08 function if branch free fix tests. 2023-12-19 16:40:13 +08:00
Robert Schulze
a8845ba729
Reorganize the test (a bit) + whitespace fixes 2023-12-19 08:16:54 +00:00
Robert Schulze
1d9c0db1f6
Incorporate review feedback 2023-12-19 08:00:59 +00:00
ubuntu
a077ad4c15 support new analyzer 2023-12-19 15:18:27 +08:00
Robert Schulze
00c407ecc1
Merge remote-tracking branch 'rschu1ze/master' into punycode-is-cool 2023-12-19 06:27:23 +00:00
Shani Elharrar
679a0e1300 StorageS3 / TableFunctionS3: Allow passing session_token to AuthSettings
This can help users that want to pass temporary credentials that
issued by AWS in order to load data from S3 without changing
configuration or creating an IAM User.

Fixes #57848
2023-12-19 08:06:36 +02:00
zhanglistar
b252b7182c Function if performance improvment fix bug. 2023-12-19 12:09:00 +08:00
Julia Kartseva
31f04b66c5 fix freebsd build
https://github.com/ClickHouse/ClickHouse/actions/runs/7256640256/job/19769624432?pr=58015#step:8:5466
```
Dec 19 03:09:41 /build/src/IO/AIO.cpp:140:15: error: use of undeclared identifier 'ErrnoException'; did you mean 'DB::ErrnoException'?
Dec 19 03:09:41   140 |         throw ErrnoException(DB::ErrorCodes::CANNOT_IOSETUP, "io_setup failed");
```
2023-12-19 03:47:28 +00:00
Julia Kartseva
6014dca114 Allow multiple columns in StorageFuzzJSON 2023-12-19 02:34:23 +00:00
Julia Kartseva
0fc402c106 Fix segfault in FuzzJSON engine
Allow only String type for FuzzJSON engine table columns.

Fixes: https://github.com/ClickHouse/ClickHouse/issues/57858
2023-12-19 02:20:37 +00:00
Anton Popov
bfd403cc8c
Merge pull request #57996 from CurtizJ/better-trivial-count-merge
Better trivial count optimization for storage `Merge`
2023-12-19 02:25:58 +01:00
Yakov Olkhovskiy
fd460566f6
fix setting description 2023-12-18 19:34:08 -05:00
Han Fei
032fd08559
Merge pull request #57991 from hanfei1991/hanfei/refine-err-msg
refine error message
2023-12-19 01:14:18 +01:00
Nikita Mikhaylov
6360b76792 Merge branch 'master' of github.com:ClickHouse/ClickHouse into remove-the-limit-for-connections-per-endpoint 2023-12-18 21:49:31 +00:00
pufit
36d1905881
Merge pull request #57752 from chizhonkova/refactor_sql_udf_loader
Refactoring for UserDefinedSQLObjectsLoader
2023-12-18 16:08:46 -05:00
Alexey Milovidov
1a7de9158f
Merge pull request #57979 from ClickHouse/add-test-49708
Add a test for #49708
2023-12-18 21:29:11 +01:00
Anton Popov
27d632f5e4 fix race in operations with external temporary data in cache 2023-12-18 20:02:53 +00:00
Alexey Milovidov
7178bd5c88
Merge pull request #57910 from Algunenano/log_message_string
Improvements for 00002_log_and_exception_messages_formatting
2023-12-18 21:02:23 +01:00
Alexander Tokmakov
de7a349f0d
Update MergeTreeData.cpp 2023-12-18 20:44:50 +01:00
Raúl Marín
5601f97e0c Move FunctionsStringHashFixedString template to single file 2023-12-18 19:14:47 +01:00
Nikolai Kochetov
34ca74878e
Merge pull request #57555 from ClickHouse/ft-dropped_tables_parts
Add system.dropped_tables_parts table
2023-12-18 18:56:57 +01:00
Bharat Nallan Chakravarthy
aef4e2e6ec Merge upstream/master into ncb/async-metrics-pri-key-size 2023-12-18 09:46:51 -08:00
Raúl Marín
80af5cb78a Always build the necessary LLVM modules if blake3 is enabled 2023-12-18 18:32:31 +01:00
Raúl Marín
46067adce8 Improve ZooKeeperRetriesControl so it's easier to reuse 2023-12-18 17:43:10 +01:00
Nikolai Kochetov
5290b3c9ce
Merge pull request #57855 from kitaisreal/interpreter-create-query-sample-block-fix
InterpreterCreateQuery sample block fix
2023-12-18 17:22:24 +01:00
yariks5s
975c954d1a style check 2023-12-18 15:42:50 +00:00
Yakov Olkhovskiy
8e39c61401 Merge remote-tracking branch 'origin/master' into ft-dropped_tables_parts 2023-12-18 15:40:07 +00:00
Anton Popov
7ebb7d2955 better trivial count optimization for storage Merge 2023-12-18 15:13:43 +00:00
yariks5s
6740316a88 init 2023-12-18 15:02:51 +00:00
Raúl Marín
99d1659b4c Replace rust's BLAKE3 with llvm's implementation 2023-12-18 15:29:01 +01:00
Anton Popov
10bc2db56d add setting 2023-12-18 13:57:07 +00:00
Raúl Marín
88dcaefde8 Style 2023-12-18 14:51:46 +01:00
Han Fei
028d1c9478 refine error message 2023-12-18 14:47:54 +01:00
Nikolay Degterinsky
bd17ee769e
Merge pull request #57938 from bharatnc/ncb/tablesloder-remove-cruft
remove cruft from TablesLoader
2023-12-18 14:46:36 +01:00
chen768959
fdda0cf8ac Literal aliases incorrectly classified as 'complex_aliases'. 2023-12-18 21:43:07 +08:00
Kseniia Sumarokova
f11fc650ee
Merge branch 'master' into allow-to-dynamically-change-fs-cache-size 2023-12-18 13:10:36 +01:00
Raúl Marín
0346850897 Support keeper failures in quorum check 2023-12-18 12:54:15 +01:00
Robert Schulze
414a2893d0
Merge pull request #57821 from rschu1ze/consolidate-substring-tests
Dumb down `substring()` tests
2023-12-18 12:32:20 +01:00
Robert Schulze
29d70c12f6
Fix CI checks 2023-12-18 10:47:40 +00:00
Raúl Marín
2639d0715f Merge remote-tracking branch 'blessed/master' into log_message_string 2023-12-18 10:40:18 +01:00
Raúl Marín
65728f14ce Review error codes 2023-12-18 10:40:02 +01:00
vdimir
f024e39e3b
Merge pull request #57888 from ucasfl/fix-transfer-external-query
Fix transform query for external database
2023-12-18 10:28:32 +01:00
Raúl Marín
f10dae4761
Merge pull request #56917 from Algunenano/backup_1
Prepare the introduction of more keeper faults
2023-12-18 10:27:48 +01:00
zhanglistar
aaf6564711 if performance code format 2023-12-18 16:47:25 +08:00
zhanglistar
ba34b80087 If improvement add comment and performance test. 2023-12-18 16:43:45 +08:00
Alexey Milovidov
69e6e59e96 Add a test for #49708 2023-12-18 08:34:53 +01:00
Bharat Nallan Chakravarthy
42dd7b47aa Merge with 'upstream/master' 2023-12-17 23:09:14 -08:00
Alexey Milovidov
afd506984d
Merge pull request #57879 from rschu1ze/fix-arrayfold
Resurrect `arrayFold()`
2023-12-18 07:57:40 +01:00
Duc Canh Le
b07cde5ebb use const reference instead for pointer to values
Co-authored-by: Robert Schulze <robert@clickhouse.com>
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2023-12-18 05:35:38 +00:00
Alexey Milovidov
b07ee86cec
Merge branch 'master' into allow-to-dynamically-change-fs-cache-size 2023-12-18 05:50:31 +01:00
Pengyuan Bian
02311d1619 update. 2023-12-18 04:23:26 +00:00
Pengyuan Bian
32816d7e7e Add a setting to specify s3 disk is read only. 2023-12-18 04:07:54 +00:00
Alexey Milovidov
33cf8842bc
Merge branch 'master' into fix-arrayfold 2023-12-18 04:57:07 +01:00
Alexey Milovidov
52d7777b05 Merge branch 'remove-cpp-templates-3' of github.com:ClickHouse/ClickHouse into remove-cpp-templates-3 2023-12-18 04:53:06 +01:00
Alexey Milovidov
c05b0cf37f Merge branch 'master' into remove-cpp-templates-3 2023-12-18 04:52:50 +01:00
Alexey Milovidov
b0eb670776
Merge pull request #57974 from ClickHouse/revert-stack-trace-changes
Revert "Merge pull request #57907 from azat/system.stack_trace-rt_tgsigqueueinfo"
2023-12-18 04:50:12 +01:00
Alexey Milovidov
58396c5546
Merge pull request #57218 from tntnatbry/issue-43666
Issue 43666: Add skip_unavailable_shards as a setting for Distributed table.
2023-12-18 04:48:57 +01:00
Alexey Milovidov
2859ac08c9 Revert "Merge pull request #57907 from azat/system.stack_trace-rt_tgsigqueueinfo"
This reverts commit a33d6b0c96, reversing
changes made to cf031a1b8e.
2023-12-18 02:01:14 +01:00
Alexey Milovidov
168da20d51
Update executeQuery.cpp 2023-12-17 22:54:45 +03:00
Alexey Milovidov
dbd509417e
Merge pull request #57970 from ClickHouse/nickitat-patch-17
Always use `pread` for reading cache segments
2023-12-17 20:53:05 +01:00
Alexey Milovidov
ae003bcc43
Merge pull request #57414 from Algunenano/i48496
Add tests for #48496
2023-12-17 20:51:25 +01:00
Nikita Taranov
9c2ef4eae5
Add profile event for cache lookup in ThreadPoolRemoteFSReader (#57437) 2023-12-17 19:03:49 +01:00
Robert Schulze
af8b18707b
Fix style 2023-12-17 17:37:46 +00:00
Nikita Taranov
587f829eb8
Always use pread for reading cache segments 2023-12-17 18:37:07 +01:00
Robert Schulze
19c8ac567f
Implement punycodeEncode()/Decode() 2023-12-17 17:04:28 +00:00
Robert Schulze
69007b5f71
Fix another bug 2023-12-17 11:16:05 +00:00
Robert Schulze
41da561e3a
Fix crash 2023-12-17 10:16:25 +00:00
Robert Schulze
7f675ddf80
Merge pull request #57878 from Jpnock/master
Apply full-text skipping index when using `hasAny()`
2023-12-17 11:06:29 +01:00
Robert Schulze
fc67d2c0e9
Merge pull request #57867 from skyoct/read_code
Support trivial count optimization for `Merge`-engine tables
2023-12-17 10:45:21 +01:00
Robert Schulze
9033c96e29
Some fixups 2023-12-17 09:11:16 +00:00
Shani Elharrar
c696c0bfe7 S3Common.AuthSettings: Allow passing SESSION_TOKEN to AWSCredentials
This sets the infrastructure of loading session_token and passing it directly
to all AWSCredentials instances that are created using the AuthSettings.

The default SESSION_TOKEN is set to an empty string as documented in AWS SDK
reference: https://sdk.amazonaws.com/cpp/api/0.12.9/d4/d27/class_aws_1_1_auth_1_1_a_w_s_credentials.html
2023-12-17 10:29:15 +02:00
ubuntu
0e8b26d84f fix test 2023-12-17 11:21:46 +08:00
ubuntu
a5e4495ee5 Merge branch 'master' into order_by_all 2023-12-17 10:07:35 +08:00
Alexey Milovidov
6ada95ea00 Remove C++ templates (normalizeQuery) 2023-12-17 02:44:30 +01:00
serxa
ce51ef0e99 remove wrong test 2023-12-16 17:35:36 +00:00
Sergei Trifonov
3634b949a8
Merge pull request #57793 from ClickHouse/rename-system-table
Rename `system.async_loader` into `system.asynchronous_loader`
2023-12-16 17:33:04 +01:00
Nikolay Degterinsky
5a3f0e7a5b Forbid CREATE AS SELECT for Replicated storages only 2023-12-16 14:25:27 +00:00
Sergei Trifonov
37a01bc109
Merge branch 'master' into ft-dropped_tables_parts 2023-12-16 11:53:37 +01:00
zhongyuankai
5ccc5b4fd8 batter 2023-12-16 18:49:25 +08:00
zhongyuankai
01f5b20517 Support ORDER BY ALL 2023-12-16 18:48:23 +08:00
Kseniia Sumarokova
4279dd2bf1
Merge pull request #57687 from ClickHouse/make-system-filesystem-cache-query-no-memory-intensive
Make querying system.filesystem_cache not memory intensive
2023-12-16 11:28:28 +01:00
Bharat Nallan Chakravarthy
0a1a66fd18 remove cruft from TablesLoader 2023-12-15 22:54:47 -08:00
Alexey Milovidov
2d58dc512c
Merge pull request #57932 from ClickHouse/remove-shit-cleanup
Remove a feature
2023-12-16 06:04:59 +01:00
Anton Popov
5faf5e913e slightly faster and perf test 2023-12-16 03:35:59 +00:00
jsc0218
41873dc4a3
Merge pull request #57873 from ClickHouse/vdimir/hash_join_structure_equals_fix
Fix assertion in HashJoin
2023-12-15 21:35:08 -05:00
Alexey Milovidov
a18a61b34c Fix style 2023-12-15 23:36:50 +01:00
Alexey Milovidov
ee502ef6b9 Remove trash (OPTIMIZE CLEANUP) 2023-12-15 22:41:58 +01:00
Alexey Milovidov
d751561d44 Remove useless headers 2023-12-15 21:42:05 +01:00
Alexey Milovidov
a33d6b0c96
Merge pull request #57907 from azat/system.stack_trace-rt_tgsigqueueinfo
Fix system.stack_trace for threads with blocked SIGRTMIN
2023-12-15 20:28:05 +01:00
Raúl Marín
6cf8c9b607 Review improvements 2023-12-15 19:44:13 +01:00
Alexey Milovidov
7e55eab1c3 Revert "Merge pull request #56573 from mkmkme/mkmkme/reload-config"
This reverts commit 3067ca64df, reversing
changes made to 1e46460910.
2023-12-15 19:28:25 +01:00
Raúl Marín
b269f87f4c Better text_log with ErrnoException 2023-12-15 19:27:56 +01:00
Anton Popov
97ba04e4c7 remove settings 2023-12-15 18:26:23 +00:00
James Nock
9aa1ec488c Apply full-text skipping index when using hasAll() 2023-12-15 17:28:33 +00:00
Anton Popov
a226c75717 optimize usage of consecutive keys optimization 2023-12-15 16:58:45 +00:00
Azat Khuzhin
106042cf41 Fix system.stack_trace for threads with blocked SIGRTMIN
Some third-party libraries (i.e. librdkafka) could block it, and in this
case system.stack_trace will return stacktrace for the main process
(usually, basically it could be any thread with non blocked signal).

By replacing sigqueue() with more precise rt_tgsigqueueinfo(), other
threads will not respond to the signal.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-15 17:47:01 +01:00
Alexander Tokmakov
e4a831be17 normalize function names in CREATE INDEX 2023-12-15 17:40:03 +01:00
Maksim Kita
a4d287b576 Fixed tests 2023-12-15 18:54:15 +03:00
flynn
82fc51ffa6 add test 2023-12-15 15:29:15 +00:00
Raúl Marín
5b88c4ef05 BackupEntriesCollector format log 2023-12-15 16:09:46 +01:00
Robert Schulze
066579f7d7
Improve code aesthetics 2023-12-15 15:07:40 +00:00
Sema Checherinda
0dfe530a7f
Merge pull request #56744 from MikhailBurdukov/native_copy_for_s3_disks
Enabled s3 `copyObject` for copy between s3 disks.
2023-12-15 16:05:16 +01:00
Raúl Marín
6b4658ef52 Mysql log format 2023-12-15 16:00:58 +01:00
Nikita Mikhaylov
1780671443
ClickHouse Cloud promotion (#57638)
Co-authored-by: Alexander Sapin <alesapin@gmail.com>
2023-12-15 15:23:23 +01:00
Kruglov Pavel
4687b4a576
Delete debug logging in OutputFormatWithUTF8ValidationAdaptor 2023-12-15 14:54:04 +01:00
kssenii
0dcb3133c7 Allow to dynamically change fs cache size 2023-12-15 14:11:52 +01:00
Yarik Briukhovetskyi
325374c68b
Merge pull request #57342 from bharatnc/ncb/better-hint-if-table-doesnt-exist
provide a better hint if a table doesn't exist
2023-12-15 12:35:13 +01:00
vdimir
16c7c1e308
fix 2023-12-15 10:58:33 +00:00
Raúl Marín
946defa8a6
Merge pull request #57860 from zvonand/zvonand-fix-57819
Try to fix memory leak in StorageHDFS
2023-12-15 11:50:17 +01:00
kssenii
7bbb456ae9 Fix style check 2023-12-15 11:32:26 +01:00
kssenii
5de9c143a5 Merge remote-tracking branch 'origin/master' into make-system-filesystem-cache-query-no-memory-intensive 2023-12-15 11:32:14 +01:00
Kseniia Sumarokova
f285a01b17
Merge pull request #57863 from ClickHouse/fix-flaky-pg-test
Follow up to #57568
2023-12-15 11:29:32 +01:00
Kseniia Sumarokova
06438cc17b
Merge pull request #57578 from ClickHouse/allow-to-change-some-cache-settings-without-restart
Allow to apply some fs cache config settings changes without server restart
2023-12-15 11:18:19 +01:00
Nikolay Degterinsky
c7ce2b5d5f
Merge pull request #57569 from skyoct/fix/fix_format_error
Fix formatting string prompt error
2023-12-15 11:10:08 +01:00
Maksim Kita
8a5ffbb5f2 InterpreterCreateQuery sample block fix 2023-12-15 12:55:19 +03:00
flynn
2d45213f70 Fix transform query for external database 2023-12-15 08:34:58 +00:00
Duc Canh Le
6e6eb5c01e fast get default enum serialization
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2023-12-15 07:38:23 +00:00
zhanglistar
028cd8955b function if trival opt. 2023-12-15 15:19:05 +08:00
Julia Kartseva
7a5b40563a
Merge pull request #57574 from ClibMouse/dev-seriesPeriodDetect
Revert "Revert "Implemented series period detect method using pocketfft lib""
2023-12-14 21:10:23 -08:00
skyoct
3319934055 reafactor function 2023-12-15 04:49:38 +00:00
Alexey Milovidov
23cee7ef37
Merge pull request #57851 from azat/revert-55271-local-lazy-database
Revert "Replace --no-system-tables with loading virtual tables of system database lazily"
2023-12-15 03:25:59 +01:00
Robert Schulze
eee4bacd71
Fix #57816, fix #57458. 2023-12-14 21:03:17 +00:00
Robert Schulze
f17d7e44f4
Refactorings: rename variables, decreases scopes, add comments 2023-12-14 20:48:18 +00:00
Bharat Nallan Chakravarthy
c9f35a8f84 review fixes 2023-12-14 11:28:49 -08:00
Bharat Nallan Chakravarthy
daef2febf3 Merge with 'upstream/master' 2023-12-14 11:19:44 -08:00
Andrey Zvonov
0174b94469
Merge branch 'ClickHouse:master' into zvonand-fix-57819 2023-12-14 20:14:54 +01:00
Raúl Marín
546484d46b Merge remote-tracking branch 'blessed/master' into backup_1 2023-12-14 19:03:59 +01:00
Bhavna Jindal
bb8589cabe minor cosmetic changes 2023-12-14 08:34:37 -08:00
Duc Canh Le
93dd6b83e7
Do not allow creating replicated table with inconsistent merge params (#56833)
* save all merge params to zookeeper

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

* calculate hash for graphite merge params

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

* add graphite params hash to zookeeper + fix tests

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

* install new graphite for testing

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

* fix backward incompatibility

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

* minor fix test

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

* Update src/Storages/MergeTree/ReplicatedMergeTreeTableMetadata.cpp

Co-authored-by: Alexander Tokmakov <tavplubix@gmail.com>

* remove peekString and add more comments

- peekString doesn't always work even for ReadBufferFromString
- more comment re. backward compatibility

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

---------

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Co-authored-by: Alexander Tokmakov <tavplubix@gmail.com>
2023-12-14 17:26:35 +01:00
joelynch
b4bef78e63
bugfix: addresses_expr ignored for psql named collections 2023-12-14 17:17:14 +01:00
vdimir
eb350ffa7e
Fix assertion in HashJoin 2023-12-14 15:52:35 +00:00
Anton Popov
5630115faa optimize aggregation by large ranges of equal keys 2023-12-14 15:38:01 +00:00
Andrey Zvonov
f9579580e9 Retrigger CI + make docs a bit better 2023-12-14 16:34:10 +01:00
kssenii
12ed9952c4 Merge remote-tracking branch 'origin/allow-to-change-some-cache-settings-without-restart' into allow-to-change-some-cache-settings-without-restart 2023-12-14 16:31:13 +01:00
kssenii
3edbbab9a3 Better 2023-12-14 16:30:15 +01:00
vdimir
0473e39352
lowcard in join output 2023-12-14 15:28:19 +00:00
kssenii
3605caa8d9 Fxi 2023-12-14 16:05:40 +01:00
kssenii
ea7e55b929 Simplify 2023-12-14 15:58:06 +01:00
skyoct
0a4882d781 feat: update style 2023-12-14 14:26:47 +00:00
skyoct
d700eb2501 feat: support trivial count optimization for Merge 2023-12-14 14:08:24 +00:00
kssenii
a4a264c785 Fix 2023-12-14 14:04:17 +01:00
Raúl Marín
3200933144 Leave backups as HEAD 2023-12-14 13:49:06 +01:00
Andrey Zvonov
7d7aea9826 try fix memory leak in StorageHDFS 2023-12-14 13:01:47 +01:00
Nikita Mikhaylov
a0af0392cd
Random changes in random files (#57642) 2023-12-14 12:47:11 +01:00
János Benjamin Antal
fdfd1481df
Merge pull request #57610 from kitaisreal/jit-add-assembly-printer
CHJIT add assembly printer
2023-12-14 12:39:20 +01:00
Igor Nikonov
42d0afef1f
Merge pull request #57749 from ClickHouse/pr-perf-improve-hope
Parallel replicas: announcement response handling improvement
2023-12-14 11:48:51 +01:00
Konstantin Bogdanov
808b4a0213
Merge pull request #57628 from azat/config-nodes-override
Allow nodes in config with from_env/from_zk and non empty element with replace=1
2023-12-14 13:20:46 +03:00
Raúl Marín
efcacd3c34 Merge remote-tracking branch 'blessed/master' into backup_1 2023-12-14 11:08:50 +01:00
Robert Schulze
b36a93a25d
Revert "Remove arrayFold"
This reverts commit 15dc0ed610.
2023-12-14 09:52:29 +00:00
Azat Khuzhin
0e86e16a01
Revert "Replace --no-system-tables with loading virtual tables of system database lazily" 2023-12-14 09:07:47 +01:00
Alexey Milovidov
e4901323fd
Merge pull request #57836 from ClickHouse/remove-array-fold
Remove `arrayFold`
2023-12-14 07:15:29 +01:00
Alexey Milovidov
7a2edb4804
Merge pull request #57822 from azat/kafka-disable-stat
Disable system.kafka_consumers by default (due to possible live memory leak)
2023-12-14 04:37:50 +01:00
Alexey Milovidov
15dc0ed610 Remove arrayFold 2023-12-14 04:34:32 +01:00
Yakov Olkhovskiy
9e1d583f54 fix style 2023-12-13 23:36:54 +00:00
Kseniia Sumarokova
79db3c66df
Merge branch 'master' into allow-to-change-some-cache-settings-without-restart 2023-12-13 23:33:59 +01:00
Yakov Olkhovskiy
441050adce fix style, cleanup 2023-12-13 22:26:38 +00:00
Anton Popov
82ebb5e2d1
Merge pull request #57790 from CurtizJ/fix-external-aggregation-with-projections
Fix result of external aggregation in case of partially materialized projection
2023-12-13 22:56:02 +01:00
Julia Kartseva
b8d274d070
Add malformed output generation to JSON fuzzer (#57646)
Randomly modify structural characters of a valid JSON ('{', '}', '[', ']',
':', '"', ',') to generate output that cannot be parsed as JSON.

Follow-up to https://github.com/ClickHouse/ClickHouse/pull/56490
2023-12-13 19:59:31 +01:00
Alexey Milovidov
e989eb7bd2
Merge pull request #57787 from kitaisreal/serialization-string-reduce-memory-usage
SerializationString reduce memory usage
2023-12-13 19:56:56 +01:00
Alexey Milovidov
bf4964b177
Merge pull request #57712 from ClickHouse/clickbench-ci
Add ClickBench to CI
2023-12-13 19:52:44 +01:00
Nikita Taranov
560e66f3ca
More respect to min_number_of_marks in ParallelReplicasReadingCoordinator (#57763) 2023-12-13 19:51:49 +01:00
jsc0218
78773157b6
Merge pull request #57436 from ryanmjacobs/fix_issue_43186_pg_quote_array_ndims
Fix several issues regarding PostgreSQL `array_ndims` usage.
2023-12-13 13:41:43 -05:00
kssenii
38e38ef43f Minor fix 2023-12-13 19:32:47 +01:00
Nikita Mikhaylov
8372c70958 Merge branch 'master' of github.com:ClickHouse/ClickHouse into remove-the-limit-for-connections-per-endpoint 2023-12-13 18:29:56 +00:00
Yakov Olkhovskiy
f4e2933f5d use storage uuid instead of table name as a key in storage info because there are can be multiple dropped table with the same name 2023-12-13 18:08:41 +00:00
vdimir
48fe75a70d
Fix MergeJoin lowcard keys support 2023-12-13 17:43:15 +00:00
Anton Popov
1960713176 add docs 2023-12-13 17:29:34 +00:00
Azat Khuzhin
055c231438 Disable system.kafka_consumers by default (due to possible live memory leak)
It is not safe to use statistics because of how KafkaEngine works - it
pre-creates consumers, and this leads to the situation when this
statistics entries generated (RD_KAFKA_OP_STATS), but never consumed.

Which creates a live memory leak for a server with Kafka tables, but
without materialized view attached to it (and no SELECT).

Another problem is that this makes shutdown very slow, because of how
pending queue entries are handled in librdkafka, it uses
TAILQ_INSERT_SORTED, which is sorted insert into linked list, which
works incredibly slow (likely you will never wait till it ends and kill
the server)

For instance in my production setup the server was running for ~67 days
with such table, and it got 1'942'233 `TAILQ_INSERT_SORTED` entries
(which perfectly matches by the way - `67*86400/3` = 1'929'600), and it
moved only 289'806 entries for a few hours, though I'm not sure how much
time the process was in the running state, since most of the time it was
with debugger attached.

So for now let's disable it, to make this patch easy for backporting,
and I will think about long term fix - do not pre-create consumers in
Kafka engine.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-13 18:13:13 +01:00
Anton Popov
7598403f78 Merge remote-tracking branch 'upstream/master' into HEAD 2023-12-13 16:55:17 +00:00
Robert Schulze
d0a4443bbc
Consolidate substring() tests 2023-12-13 16:49:39 +00:00
Alexey Milovidov
54698cd2de
Merge pull request #55876 from ClickHouse/keeper-http-readiness-endpoint
Keeper HTTP readiness endpoint
2023-12-13 17:07:57 +01:00
Robert Schulze
bbd7d0c057
Merge pull request #57277 from slvrtrn/substr-with-enums
Add Enums support to `substring` function
2023-12-13 17:03:03 +01:00
Raúl Marín
d4522ee088
Merge pull request #57811 from Algunenano/revert_negative_positional_arguments
Revert #57741
2023-12-13 16:39:23 +01:00
Yakov Olkhovskiy
0ea4b16530
Merge branch 'master' into ft-dropped_tables_parts 2023-12-13 09:01:59 -05:00
Igor Nikonov
c165be76ab
Parallel replicas: friendly settings (#57542) 2023-12-13 14:42:06 +01:00
vdimir
398499d253
Support SHARDS for HashedArrayDictionary 2023-12-13 13:00:28 +00:00
Raúl Marín
dd405a655e Merge remote-tracking branch 'blessed/master' into backup_1 2023-12-13 13:39:58 +01:00
Raúl Marín
8c2137e0c6 Revert "Merge pull request #57741 from ucasfl/negtive-position"
This reverts commit 3d846800e0, reversing
changes made to b31b4c932f.
2023-12-13 13:09:36 +01:00
Vitaly Baranov
96bbff3af0
Merge pull request #57764 from vitlibar/fix-retries-for-disconnected-nodes-for-backup-on-cluster
Fix retries for disconnected nodes for BACKUP/RESTORE ON CLUSTER
2023-12-13 13:06:32 +01:00
Kseniia Sumarokova
b1325450e9
Merge pull request #57754 from ClickHouse/fix-loading-dependent-table-materialized-postgresql
Table engine MaterializedPostgreSQL fix dependency loading
2023-12-13 12:17:01 +01:00
robot-ch-test-poll1
c2f32f5994
Merge pull request #57795 from CurtizJ/fix-totals-maxMap
Fix merge in aggregation functions with `*Map` combinator
2023-12-13 10:31:15 +01:00
Yakov Olkhovskiy
5121bfcd78 major refactoring 2023-12-13 07:16:30 +00:00
Alexey Milovidov
62b6d1ef5e iMerge branch 'master' of github.com:ClickHouse/ClickHouse into clickbench-ci 2023-12-13 01:41:27 +01:00
Alexey Milovidov
f11b90e7bb Allow buckets without List access 2023-12-13 00:10:58 +01:00
Han Fei
6abe4b113a
Merge pull request #57375 from lingtaolf/feature/more_warnings
Feature/more warnings
2023-12-12 22:48:51 +01:00
Igor Nikonov
616d054dee Merge remote-tracking branch 'origin/master' into pr-perf-improve-hope 2023-12-12 21:27:31 +00:00
Igor Nikonov
7f4a028196 Test and fix 2023-12-12 21:26:58 +00:00
Alexander Tokmakov
3482224f83 Merge branch 'master' into keeper-http-readiness-endpoint 2023-12-12 21:19:57 +01:00
Bhavna Jindal
1190abae22 multiple rows fix 2023-12-12 10:55:15 -08:00
Nikolay Degterinsky
254bcade1e Forbid CREATE AS SELECT for database Replicated 2023-12-12 18:28:20 +00:00
Vitaly Baranov
028763def5 Simplify logic in BackupCoordinationStageSync::readCurrentState() and return earlier from the cycly on a connection problem. 2023-12-12 18:53:52 +01:00
Anton Popov
e4e97471a6 fix totals in aggregation functions with Map combinator 2023-12-12 17:31:56 +00:00
serxa
57d7a58dbe Rename system.async_loader into system.asynchronous_loader 2023-12-12 16:55:27 +00:00