Commit Graph

1277 Commits

Author SHA1 Message Date
Igor Nikonov
7123a27f30
Merge pull request #59380 from ClickHouse/cleanup-connection-pool-surroundings
Cleanup connection pool surroundings
2024-02-04 22:34:07 +01:00
Igor Nikonov
c7499b7395 Use ConnectionPoolPtr instead of raw pointer 2024-02-02 18:43:09 +00:00
Raúl Marín
7be91e66dd Add reverse step 2024-02-02 18:11:56 +01:00
Igor Nikonov
c93a2cd2dd Remove unused header 2024-02-01 17:31:14 +00:00
Igor Nikonov
03249f3efa Fixes & comments
staleness -> delay (double -> UInt32)
2024-02-01 12:24:24 +00:00
Raúl Marín
4b5e992565 Fix problems 2024-01-30 19:34:01 +01:00
Raúl Marín
299c390d2b Add some fuzzing to ASTLiterals 2024-01-30 19:34:01 +01:00
avogar
377937d415 Merge branch 'master' of github.com:ClickHouse/ClickHouse into auto-format-detection 2024-01-29 15:45:18 +00:00
Alexey Milovidov
a7483ec10b
Merge pull request #59242 from rschu1ze/dont-force-libssh-on-me
Make libssh build dependent on `-DENABLE_LIBRARIES`
2024-01-29 00:02:03 +01:00
Robert Schulze
caeb31940c
Allow to build without libssl 2024-01-25 21:14:03 +00:00
Kruglov Pavel
46a6b84a5a
Merge branch 'master' into auto-format-detection 2024-01-25 22:11:07 +01:00
Maksim Kita
2a327107b6 Updated implementation 2024-01-25 14:31:49 +03:00
avogar
1bff525666 Fix tests and docs 2024-01-23 18:59:40 +00:00
avogar
617cc514b7 Try to detect file format automatically during schema inference if it's unknown 2024-01-23 18:59:39 +00:00
Alexander Tokmakov
2f1d4f094b
Add a parameter for testing purposes (#59027)
* Update ConnectionParameters.cpp

* Update ConnectionParameters.cpp

* Update ConnectionParameters.cpp
2024-01-22 15:48:44 +01:00
Sema Checherinda
9adab57771
Correct initialization of ConnectionTimeouts (#59000) 2024-01-22 12:03:36 +01:00
Igor Nikonov
131f71b50a
Revert "Revert flaky" 2024-01-19 13:51:30 +01:00
Raúl Marín
477489a05d Revert "Merge pull request #57235 from ClickHouse/pr-custom-key-failover"
This reverts commit 8ba9b4a7ef, reversing
changes made to 0f39245cb8.
2024-01-19 12:46:05 +00:00
Igor Nikonov
8d4a395afa Merge remote-tracking branch 'origin/master' into pr-custom-key-failover 2024-01-10 20:28:04 +00:00
Igor Nikonov
e9fc869254 Fix test flakiness with hedge connections enabled 2024-01-10 15:59:48 +00:00
Robert Schulze
ced9e93ac6
Merge remote-tracking branch 'rschu1ze/master' into qatzstd_main 2024-01-09 20:36:02 +00:00
Alexey Milovidov
2c61015578 Do not load database engines in suggest 2024-01-07 23:06:36 +01:00
Robert Schulze
53965bb9f1
Merge remote-tracking branch 'rschu1ze/master' into qatzstd_main 2024-01-07 14:11:22 +00:00
Bharat Nallan Chakravarthy
3e8439a78b add to context access and suggest 2023-12-30 20:38:35 -08:00
Igor Nikonov
4fe54c213b Fix: round-robin load balancing for custom key queries
+ even subqueries distribution over available nodes for custom key query
+ creating load balancing instance for each custom key query separately
2023-12-27 15:06:41 +00:00
Igor Nikonov
bee15325fc Merge remote-tracking branch 'origin/master' into pr-custom-key-failover 2023-12-26 21:56:46 +00:00
Azat Khuzhin
3be3b0a280 Fix incorrect Exceptions
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-24 21:26:32 +01:00
jinjunzh
aaf98f0ed7 refine setting with enable_zstd_qat_codec 2023-12-22 14:24:15 -05:00
Igor Nikonov
db87ea0b86 Merge remote-tracking branch 'origin/master' into pr-custom-key-failover 2023-12-20 20:48:51 +00:00
Yarik Briukhovetskyi
6e816d45ae
Merge branch 'master' into paste_join 2023-12-19 20:02:24 +01:00
yariks5s
4e418a89d9 fixed suggestions 2023-12-19 19:00:37 +00:00
Raúl Marín
b269f87f4c Better text_log with ErrnoException 2023-12-15 19:27:56 +01:00
Igor Nikonov
f7e6a17052 Merge remote-tracking branch 'origin/master' into pr-custom-key-failover 2023-12-10 20:21:47 +00:00
Igor Nikonov
87e47bdbee
Merge pull request #57467 from ClickHouse/rm-select
Remove select() usage
2023-12-09 22:27:28 +01:00
Igor Nikonov
94fb23af0b Merge remote-tracking branch 'origin/master' into pr-custom-key-failover 2023-12-07 11:52:40 +00:00
Azat Khuzhin
477b782f86 Handle editor exit code correctly
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-06 20:21:15 +01:00
Azat Khuzhin
028c01c458 Do not abort the client if temporary file for query editor cannot be created
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-06 20:21:15 +01:00
Igor Nikonov
60ba1abc17 Fix build 2023-12-05 12:58:29 +00:00
Igor Nikonov
71204c2a82 Merge remote-tracking branch 'origin/master' into pr-custom-key-failover 2023-12-05 12:00:45 +00:00
Igor Nikonov
b3d3887f2c Fix test 2023-12-05 11:58:25 +00:00
Igor Nikonov
73ff984755 Remove select() usage 2023-12-04 09:33:34 +00:00
Azat Khuzhin
699d11628a Fix adjusting log_comment in case of multiple files passed
Previously, due to adjusting global_context and checking it as well, in
case of multiple files the log_comment will be adjusted only the first
time. Fix this by caching does user passed the log_comment explicitly or
not.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-04 10:02:24 +01:00
Raúl Marín
46acd8736c
Merge pull request #57189 from Algunenano/fix_respect_nulls
Fix RESPECT NULLS
2023-11-30 20:21:42 +01:00
Igor Nikonov
b4bf611d5d Merge remote-tracking branch 'origin/master' into pr-custom-key-failover 2023-11-30 14:09:26 +00:00
Raúl Marín
9432061652 Add RESPECT/IGNORE NULLS to the fuzzer 2023-11-29 12:41:15 +01:00
Raúl Marín
f1bbccd7dd Add suggestions about window functions 2023-11-29 12:14:37 +01:00
Igor Nikonov
961236a70b Change log level to avoid test failure 2023-11-29 00:05:28 +00:00
Yarik Briukhovetskyi
c4d157fe84
Update ClientBase.cpp 2023-11-28 15:38:20 +01:00
Yarik Briukhovetskyi
0b15efeb51
Update ClientBase.cpp 2023-11-28 14:41:55 +01:00
yariks5s
1ed776abfb consistency fix 2023-11-28 13:29:44 +00:00
yariks5s
ab0be2f236 init 2023-11-27 18:21:49 +00:00
Alexey Milovidov
fde14f0daf
Merge pull request #57191 from azat/client-log_comment-file
[RFC] Set log_comment to the file name while processing files in client
2023-11-26 03:44:40 +01:00
Alexey Milovidov
c50f096200
Merge pull request #57227 from azat/client-INS-cursor
Change cursor style for overwrite mode (INS) to blinking in client
2023-11-25 22:53:09 +01:00
Azat Khuzhin
ced0bbd932 Change cursor style for overwrite mode (INS) to blinking in client
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-11-25 22:00:56 +01:00
Azat Khuzhin
740cc3c053 Set log_comment to the file name while processing files in client
This will be useful for fuzzer, to know which file had been processed to
trigger the crash, since right now you need to find unique parts of the
query that had not been added by fuzzer to reproduce.

But I guess this will be useful not only for fuzzing, but for general
introspection as well.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-11-24 14:45:34 +01:00
Alexey Milovidov
98cddf5312
Merge pull request #57153 from ClickHouse/better-server-exit-code
Better server exit code
2023-11-23 23:55:28 +01:00
Alexey Milovidov
b62e9d3a1a Address review comments 2023-11-23 18:13:12 +01:00
Igor Nikonov
7c0198a26c Fix clang-tidy warning 2023-11-22 09:48:18 +00:00
Igor Nikonov
63a1625b77 Merge remote-tracking branch 'origin/master' into pr-cleanup-narrow-dependency 2023-11-21 16:05:48 +00:00
Igor Nikonov
ce98dfb251 Settings pointer to reference 2023-11-21 16:04:54 +00:00
Igor Nikonov
66f6a6575f Cleanup iteration: settings usage 2023-11-21 13:29:04 +00:00
Nikolay Degterinsky
fd26fab07f Merge remote-tracking branch 'upstream/master' into local-send-fatal-log 2023-11-19 17:59:51 +00:00
Nikolay Degterinsky
cf46214440 Always send fatal level logs 2023-11-19 15:09:52 +00:00
Kruglov Pavel
413c3d1ee3
Merge pull request #55994 from Avogar/fix-bad-logs-level-in-local
Fix clickhouse-local exit on bad send_logs_level setting
2023-11-16 14:49:23 +01:00
Kruglov Pavel
f1bf3f1fc3
Merge pull request #56710 from Avogar/fix-abort-in-local
Fix 'mutex lock failed: Invalid argument' in clickhouse-local during insert into function
2023-11-16 14:45:18 +01:00
Robert Schulze
2931bbfe62
Merge pull request #56665 from rschu1ze/refactor-ast-hash-calculation
Small refactoring of AST hash calculation (follow-up to #56545)
2023-11-14 11:24:30 +01:00
avogar
a09437c816 Fix possible 'uncaught exception of type std::__1::system_error: mutex lock failed: Invalid argument' in clickhouse-local 2023-11-13 22:23:38 +00:00
Alexey Milovidov
c81cc3f953
Merge pull request #56660 from ClickHouse/better-ccache-2
Better use of build cache
2023-11-13 19:28:33 +01:00
Robert Schulze
d6df7d8403
Merge remote-tracking branch 'rschu1ze/master' into refactor-ast-hash-calculation 2023-11-13 15:54:21 +00:00
Kruglov Pavel
abf08839ec
Merge pull request #55976 from Avogar/fix-client-insert-in-background
Fix 'Cannot read from file:' while running client in a background
2023-11-13 15:16:49 +00:00
Robert Schulze
b899270372
Remove default value for argument 'ignore_aliases' from IAST::updateTreeHash() 2023-11-13 13:18:35 +00:00
Alexey Milovidov
8e820185cb Merge branch 'master' of github.com:ClickHouse/ClickHouse into better-ccache-2 2023-11-13 11:17:18 +01:00
Alexey Milovidov
82c461031e Fix build 2023-11-13 10:09:23 +01:00
Alexey Milovidov
9a7f5ab0a1 Better use of build cache 2023-11-13 08:54:24 +01:00
Pradeep Chhetri
be1e061764 Use SSL port for clickhouse-client for hostnames pointing to clickhouse cloud 2023-11-13 10:31:56 +08:00
Pradeep Chhetri
3cb41bf0f2 Enable --secure flag for clickhouse-client for hostnames pointing to clickhouse cloud 2023-11-12 15:00:10 +08:00
Pradeep Chhetri
ce668e4491 Enable --secure flag for clickhouse-client for hostnames pointing to clickhouse cloud 2023-11-12 14:45:17 +08:00
Alexey Milovidov
9317357873
Merge pull request #56546 from ClickHouse/remove-1
Remove useless using
2023-11-10 16:56:56 +01:00
Alexey Milovidov
3f5b94b8ca Remove useless using 2023-11-09 23:37:39 +01:00
kssenii
9178fd4ad1 Fix case with replicated database 2023-11-07 16:02:51 +01:00
avogar
7c69dee5cd Fix review comment 2023-11-02 18:05:02 +00:00
avogar
1078047fb5 Fix 'Cannot read from file:' while running client in a background 2023-11-02 17:46:34 +00:00
Alexey Milovidov
3631e476eb
Merge pull request #54947 from amosbird/minmax-combinator
Introduce -ArgMin/-ArgMax combinators.
2023-10-30 03:35:28 +01:00
Alexey Milovidov
9313b343e4
Merge pull request #55240 from aiven-sal/aiven-sal/client
clickhouse-client: don't show "0 rows in set" if it is zero and if exception was thrown
2023-10-26 13:52:53 +02:00
avogar
2516c2ea28 Fix clickhouse-local exit on bad send_logs_level setting 2023-10-24 20:46:44 +00:00
Salvatore Mesoraca
7e8dac6064
Fix logic 2023-10-24 15:36:17 +02:00
Salvatore Mesoraca
fdabea6158
clickhouse-client: don't show "0 rows in set" if it is zero and if exception was thrown 2023-10-24 15:36:14 +02:00
Alexey Milovidov
7ec4b99e94 Revert partial result 2023-10-21 03:14:22 +02:00
Alexey Milovidov
14c2900185
Merge pull request #55853 from ClickHouse/local-allow-drop-current-database
Allow querying inside a dropped database in clickhouse-local
2023-10-20 19:04:54 +02:00
Anton Popov
5819bcd07a
Support asynchronous inserts for native protocol (#54730)
* support async insert for native protocol

* use separate queue for async inserts via native protocol

* fix test

* better logging for async inserts and more tests

* disable mixed internal and external data in async inserts

* fix tests

* fix quota in async inserts

* disable async insert for secondary query of distributed
2023-10-20 18:39:48 +02:00
Alexey Milovidov
c6e998290d Allow querying inside a dropped database in clickhouse-local 2023-10-20 05:14:09 +02:00
Michael Kolupaev
70711b0898
Remove temporary debug logging in MultiplexedConnections (#55764) 2023-10-18 23:05:03 -07:00
Azat Khuzhin
2fc858bfe1 Adjust output_format_pretty_max_rows if --pager is specified 2023-10-16 22:31:57 +02:00
Azat Khuzhin
4cb3de3110 Add pager property into ClientBase
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-16 22:31:55 +02:00
Azat Khuzhin
3257d5643d Move adjusting input_format_values_allow_data_after_semicolon into the client base
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-16 22:31:55 +02:00
Azat Khuzhin
fc354d7fbf Reset signals that is catched by clickhouse-client if pager is in use
We need to reset signals that had been installed in the
setupSignalHandler() (SIGINT/SIGQUIT), like other such tools dies (i.e.
less and open file in editor) since terminal will send signals to both
processes and so signals will be delivered to the
clickhouse-client/local as well, which will be terminated when signal
will be delivered second time.

So a simple `clickhouse-client --pager less` will be terminated on a
second C-C press. And it is really annoying when you are using this way
to analyze logs.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-16 22:03:36 +02:00
Alexey Milovidov
13ee46ed74
Merge pull request #55583 from azat/unittests-fix-context
Fix global context for tests with --gtest_filter
2023-10-14 00:27:30 +02:00
Alexander Tokmakov
e3e105d154
Merge pull request #55527 from azat/values-eof-check-fix
Fix checking of non handled data for Values format
2023-10-13 18:07:02 +02:00
Azat Khuzhin
f42cc282ec Do not include headers from tests into client
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-13 13:44:30 +02:00
Azat Khuzhin
a5cced2b9e Move comment into correct place
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-12 12:25:08 +02:00