Commit Graph

134681 Commits

Author SHA1 Message Date
Maksim Kita
a359ceecb5 ASOF JOIN use trySort with RadixSort 2024-02-13 15:41:17 +03:00
Kseniia Sumarokova
daf1ca0625
Merge pull request #59370 from valbok/attach-db-tests
MaterializedMySQL: Fix gtid_after_attach_test to retry on detach
2024-02-13 13:27:29 +01:00
Pablo Marcos
a4562ea013
Fix description for allow_prefetched_read_pool_for_local_filesystem
allow_prefetched_read_pool_for_local_filesystem wrongly used the same description as allow_prefetched_read_pool_for_remote_filesystem
2024-02-13 12:56:32 +01:00
alesapin
f48c5973cc
Merge pull request #59901 from ClickHouse/fix-partition-expression-parsing-with-parens
Fix parsing of partition expressions surrounded by parens
2024-02-13 12:52:24 +01:00
Nikolai Kochetov
5daab7a862 Fixing test. 2024-02-13 11:37:40 +00:00
Maksim Kita
ddf0f22819 UniqExactSet read crash fix 2024-02-13 14:36:46 +03:00
Kseniia Sumarokova
bb12fb45c4
Merge pull request #59873 from azat/file-log-shutdown-fix
Fix long shutdown of FileLog storage
2024-02-13 12:08:12 +01:00
Nikita Mikhaylov
4b85f6b39a
Revert "Less error prone interface of read buffers" (#59911) 2024-02-13 12:02:46 +01:00
Nikolai Kochetov
86bb67812f
Merge pull request #59907 from ClickHouse/fix-index-hint-tests-with-analyzer
Update tests with indexHint for analyzer.
2024-02-13 11:18:42 +01:00
Nikolai Kochetov
666b3d6664
Merge branch 'master' into allow-parallel-replicas-for-join-with-analyzer-2 2024-02-13 11:11:03 +01:00
avogar
743f2410c1 Fix crash in JSONColumnsWithMetadata format over http 2024-02-13 09:54:36 +00:00
Dmitry Novik
06f089c480
Analyzer: Update broken integration tests list 2024-02-13 10:49:04 +01:00
Azat Khuzhin
f3f7f5ca31 tests: fix 02981_vertical_merges_memory_usage flakiness
Note, that I've checked this change by reverting #59340, i.e.

    diff --git a/src/Processors/Transforms/ColumnGathererTransform.h b/src/Processors/Transforms/ColumnGathererTransform.h
    index 4e56cffa46a..dd3c555f361 100644
    --- a/src/Processors/Transforms/ColumnGathererTransform.h
    +++ b/src/Processors/Transforms/ColumnGathererTransform.h
    @@ -195,7 +195,7 @@ void ColumnGathererStream::gather(Column & column_res)
             }

             source.pos += len;
    -    } while (column_res.size() < block_preferred_size_rows && column_res.byteSize() < block_preferred_size_bytes);
    +    } while (true);
     }

     }

And it fails:

    02981_vertical_merges_memory_usage:                                     [ FAIL ] - result differs with reference:
    --- /src/ch/clickhouse/tests/queries/0_stateless/02981_vertical_merges_memory_usage.reference   2024-02-13 10:37:54.771393874 +0100
    +++ /src/ch/clickhouse/tests/queries/0_stateless/02981_vertical_merges_memory_usage.stdout      2024-02-13 10:41:06.781109565 +0100
    @@ -1 +1 @@
    -Vertical       OK
    +Vertical       FAIL: memory usage: 626.59 MiB

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-13 10:42:26 +01:00
xuzifu666
12599c4b8e Commands node args should add rvalue to push_back 2024-02-13 17:35:55 +08:00
vdimir
f438d35dad
Merge pull request #59892 from ClickHouse/vdimir/02988_join_using_prewhere_pushdown
Add test 02988_join_using_prewhere_pushdown
2024-02-13 09:59:15 +01:00
Azat Khuzhin
f62405b234 tests: suppress http retriable errors in 00157_cache_dictionary
CI reports [1]:

    2024-02-12 21:25:24 [5c66f008cd40] 2024.02.12 14:25:01.596769 [ 2530 ] {e71fcb6d-356d-4962-95bd-ef8b8c504e11} <Error> ReadWriteBufferFromHTTP: HTTP request to `https://clickhouse-datasets-web.s3.us-east-1.amazonaws.com/store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/UserAgent.bin` failed at try 1/10 with bytes read: 311149/378695. Error: DB::HTTPException: Received error from remote server /store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/UserAgent.bin. HTTP status code: 500 Internal Server Error, body: <?xml version="1.0" encoding="UTF-8"?>
    2024-02-12 21:25:24 <Error><Code>InternalError</Code><Message>We encountered an internal error. Please try again.</Message><RequestId>NSG3VKK6GWDFXMFJ</RequestId><HostId>9WhFfHfE6XtL2+InOZMJWv5ZCUY25Z3P+2EjoMx3I7UxACzLzFSHOUTT4v3EJ+ZTSAklw6Ech7E=</HostId></Error>. (Current backoff wait is 100/10000 ms)
    2024-02-12 21:25:24 [5c66f008cd40] 2024.02.12 14:25:02.527290 [ 2530 ] {e71fcb6d-356d-4962-95bd-ef8b8c504e11} <Error> ReadWriteBufferFromHTTP: HTTP request to `https://clickhouse-datasets-web.s3.us-east-1.amazonaws.com/store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/RefererCategories.size0.bin` failed at try 1/10 with bytes read: 1110527/1246029. Error: DB::HTTPException: Received error from remote server /store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/RefererCategories.size0.bin. HTTP status code: 500 Internal Server Error, body: <?xml version="1.0" encoding="UTF-8"?>
    2024-02-12 21:25:24 <Error><Code>InternalError</Code><Message>We encountered an internal error. Please try again.</Message><RequestId>GRRAYKKM9E73JG6A</RequestId><HostId>Ej/aHS4E6GujLjeZugLqgRhpQYLQrZtn4ZwTTz01Z0J3DJmbGQ5Ch6qzXB0NeNLmsSP6BeTy3O8=</HostId></Error>. (Current backoff wait is 100/10000 ms)
    2024-02-12 21:25:24 [5c66f008cd40] 2024.02.12 14:25:04.415182 [ 2530 ] {e71fcb6d-356d-4962-95bd-ef8b8c504e11} <Error> ReadWriteBufferFromHTTP: HTTP request to `https://clickhouse-datasets-web.s3.us-east-1.amazonaws.com/store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/SearchPhrase.bin` failed at try 1/10 with bytes read: 1615554/1843636. Error: DB::HTTPException: Received error from remote server /store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/SearchPhrase.bin. HTTP status code: 500 Internal Server Error, body: <?xml version="1.0" encoding="UTF-8"?>
    2024-02-12 21:25:24 <Error><Code>InternalError</Code><Message>We encountered an internal error. Please try again.</Message><RequestId>WP6PWQCNPK22CH2S</RequestId><HostId>gwYgmcnihSvFDXK3mhDfmXpDIebs39EJGCNcsghxwqqWIkvgsWOu5rSqv837589yB7Mmf+2qTcM=</HostId></Error>. (Current backoff wait is 100/10000 ms)
    2024-02-12 21:25:24 [5c66f008cd40] 2024.02.12 14:25:06.228120 [ 2530 ] {e71fcb6d-356d-4962-95bd-ef8b8c504e11} <Error> ReadWriteBufferFromHTTP: HTTP request to `https://clickhouse-datasets-web.s3.us-east-1.amazonaws.com/store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/HistoryLength.bin` failed at try 1/10 with bytes read: 373045/430913. Error: DB::HTTPException: Received error from remote server /store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/HistoryLength.bin. HTTP status code: 500 Internal Server Error, body: <?xml version="1.0" encoding="UTF-8"?>
    2024-02-12 21:25:24 <Error><Code>InternalError</Code><Message>We encountered an internal error. Please try again.</Message><RequestId>YMA18Y2A0Z9GKD1H</RequestId><HostId>RzI1ju46ixNRgjffHJNW8fndeSAARUKjyYh1T8a73ehCuyWqES/HpsEQNsc728dUL10cI0A6viU=</HostId></Error>. (Current backoff wait is 100/10000 ms)
    2024-02-12 21:25:24 [5c66f008cd40] 2024.02.12 14:25:07.742813 [ 2530 ] {e71fcb6d-356d-4962-95bd-ef8b8c504e11} <Error> ReadWriteBufferFromHTTP: HTTP request to `https://clickhouse-datasets-web.s3.us-east-1.amazonaws.com/store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/OpenstatCampaignID.bin` failed at try 1/10 with bytes read: 16494/20267. Error: DB::HTTPException: Received error from remote server /store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/OpenstatCampaignID.bin. HTTP status code: 500 Internal Server Error, body: <?

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/59895/c7c05c9881362079fa6a02430fc5cd63dfa65bb7/stateful_tests__debug_.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-13 08:34:17 +01:00
Azat Khuzhin
4228eaf44a Decrease logging level for http retriable errors to Warning
Messages like this:

    2024-02-12 21:25:24 [5c66f008cd40] 2024.02.12 14:25:01.596769 [ 2530 ] {e71fcb6d-356d-4962-95bd-ef8b8c504e11} <Error> ReadWriteBufferFromHTTP: HTTP request to `https://clickhouse-datasets-web.s3.us-east-1.amazonaws.com/store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/UserAgent.bin` failed at try 1/10 with bytes read: 311149/378695. Error: DB::HTTPException: Received error from remote server /store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/UserAgent.bin. HTTP status code: 500 Internal Server Error, body: <?xml version="1.0" encoding="UTF-8"?>

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-13 08:31:28 +01:00
Alexey Milovidov
025d82f47e
Merge pull request #59906 from ClickHouse/fix-selfextracting-mac
Fix self-extracting: macOS doesn't allow to run renamed executable - copy instead
2024-02-13 04:36:02 +01:00
Alexey Milovidov
58563ef036
Merge pull request #59857 from azat/build/components-cleanup
Remove ability to disable generic clickhouse components
2024-02-13 04:21:08 +01:00
Alexey Milovidov
4dc59051a1
Merge pull request #59897 from ClickHouse/s3queue-fix-uninitialized-value
s3queue: fix uninitialized value
2024-02-13 02:44:45 +01:00
robot-ch-test-poll
773baca877
Merge pull request #59612 from ClickHouse/docs-temporary-tables-cloud
[Docs] Add detail on using temporary tables in Cloud
2024-02-13 02:36:07 +01:00
Alexey Milovidov
b68bc3d3d7
Update docs/en/sql-reference/statements/create/table.md 2024-02-13 02:07:10 +01:00
Alexey Milovidov
31c5f1ec10
Merge pull request #59609 from ClickHouse/docs-cloud-memory-table-engine
[Docs] Specify Memory table engine usage on cloud
2024-02-13 02:06:08 +01:00
Alexey Milovidov
12f9981aab
Merge pull request #59896 from ClickHouse/add-comment-to-coverage_log-in-clickhouse-test
Fix `02982_comments_in_system_tables`
2024-02-13 01:49:35 +01:00
Azat Khuzhin
c61ac1d3bc Convert default_replica_path/default_replica_name into server settings
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 21:05:58 +01:00
Azat Khuzhin
5868cdc708 Remove one unused implementation of Macros::expand()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 21:05:58 +01:00
Nikolai Kochetov
4d220322cb Update analyzer_tech_debt.txt 2024-02-12 19:48:02 +00:00
Nikolai Kochetov
105308ee54
Merge pull request #59889 from ClickHouse/follow-up-58554
Follow up for #58554. Cleanup.
2024-02-12 20:46:36 +01:00
Nikolai Kochetov
50db80a7e3 Update tests with indexHint for analyzer. 2024-02-12 19:36:41 +00:00
kssenii
d008ee725f Add a test 2024-02-12 20:23:21 +01:00
SmitaRKulkarni
1935c67c12
Merge pull request #59874 from azat/tests/02322_sql_insert_format
tests: fix 02322_sql_insert_format flakiness
2024-02-12 20:03:18 +01:00
MyroTk
6a3c362443
Update Dockerfile 2024-02-12 10:39:26 -08:00
Mikhail f. Shiryaev
4e61152d75
Merge pull request #59902 from ClickHouse/do-not-rebuild-lambda
Do not rebuild a lambda package if it is updated
2024-02-12 19:36:54 +01:00
Yakov Olkhovskiy
3aefd0f50b copy on mac instead renaming 2024-02-12 18:01:43 +00:00
Justin de Guzman
d7850db40c
[Docs] Remove incorrect statement about Memory table engine 2024-02-12 09:54:38 -08:00
János Benjamin Antal
310b0773b2 Fix include used for debugging 2024-02-12 17:25:17 +00:00
Mikhail f. Shiryaev
f5a71455b8
Do not rebuild a lambda package if it is updated 2024-02-12 18:12:25 +01:00
János Benjamin Antal
69273b4645 Fix parsing of partition expressions surrounded by parens 2024-02-12 17:10:10 +00:00
kssenii
0628ae6268 S3 queue fix uninitialized value 2024-02-12 17:13:30 +01:00
Max K
40d39e6efa
Merge pull request #59890 from ClickHouse/ci_fix_build_jobs_issue
CI: Fix job failures due to jepsen artifacts
2024-02-12 16:33:13 +01:00
János Benjamin Antal
b094ab9763 Add comment 2024-02-12 15:27:20 +00:00
Max Kainov
c880739311 CI: Fix build job failures due to jepsen artifacts 2024-02-12 15:10:43 +00:00
Raúl Marín
407b7a4651
Merge pull request #59737 from Algunenano/more_asserts_memory
Add assertions around FixedString code
2024-02-12 16:01:02 +01:00
Antonio Andelic
5872ca520c
Merge pull request #59592 from ClickHouse/keeper-more-reduce
Reduce size of node in Keeper even more
2024-02-12 15:59:39 +01:00
vdimir
2d7fdc896a
Add test 02988_join_using_prewhere_pushdown 2024-02-12 14:03:45 +00:00
Dmitry Novik
00136b8f65
Merge pull request #59121 from ClickHouse/analyzer-fix-const-fold
Analyzer: Add cast for ConstantNode from constant folding
2024-02-12 15:01:15 +01:00
Nikolai Kochetov
87b6d65b9b Remove outdated comment. 2024-02-12 13:46:30 +00:00
Dmitry Novik
727e0bbf6a
Merge pull request #59750 from ClickHouse/fix-analyzer-integration-server-version
Analyzer: Fix test_replicating_constants/test.py::test_different_versions
2024-02-12 14:40:16 +01:00
Dmitry Novik
584d197e52
Merge pull request #59801 from ClickHouse/analyzer-fix-test_access_for_functions
Analyzer: fix test_access_for_functions/test.py::test_access_rights_for_function
2024-02-12 14:37:48 +01:00
Nikolai Kochetov
fd2ee19f65 Follow up for #58554. Cleanup. 2024-02-12 13:37:25 +00:00