thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-13 09:52:38 +00:00
Code Issues Packages Projects Releases Wiki Activity
155,657 Commits 9,324 Branches 1,783 Tags 2.1 GiB
1579ed83bb
Commit Graph

155657 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jiebin Sun
1579ed83bb optimize the mutex with shared_mutex in MemoryTracker 
The mutex lock `overcommit_m` has protected while read and write
the global variables in the OvercommitTracker of MemoryTracker.
But it will cause lots of `native_queued_spin_lock_slowpath` in
ClickBench Q8 and Q42 on large cores system. Most of time it will
only read, but not update. The patch will replace the mutex lock
with read/write lock.

Test the patch with clickbench on 256x2 vCPUs system. Overall geomean
has got 6.8% performance gain. Q8, 24, Q26 and Q42 have got 77%, 19.5%,
19.5% and 11.4%  performance gain.

Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>
 2024-11-26 02:34:15 +08:00
Vladimir Cherkasov
5227fe0934
Merge pull request #70487 from ClickHouse/vdimir/safe_http_exception_log 
Avoid spamming the logs with large HTTP response bodies
 2024-10-16 08:34:48 +00:00
Robert Schulze
1f1a9c8508
Merge pull request #70134 from rschu1ze/libcxx-debug-mode 
(Re?)-enable libcxx asserts for debug builds
 2024-10-16 07:50:52 +00:00
Antonio Andelic
ed79ebf0e3
Merge pull request #70299 from ClickHouse/fix-preadv2-with-nowait 
Fix usage of `preadv2` with `RWF_NOWAIT`
 2024-10-16 07:25:58 +00:00
Anton Popov
56b9f19ec3
Merge pull request #70635 from CurtizJ/fix-parsing-to-sparse-column 
Fix parsing of some formats into sparse columns
 2024-10-16 07:13:29 +00:00
Michael Kolupaev
1c45f9f6bd
Merge pull request #62966 from arthurpassos/add_parquet_bloom_filters_support 
Add parquet bloom filters support
 2024-10-16 00:15:56 +00:00
Alexey Milovidov
789382d295
Merge pull request #70696 from ClickHouse/vdimir/table-func-s3-respect-local-settings 
Insert into table function s3 respect query settings
 2024-10-15 23:45:44 +00:00
Robert Schulze
23fcefadc8
... re-enable only the assertions (not full debug mode) 2024-10-15 21:37:39 +00:00
Alexey Milovidov
63b4a70c94
Merge pull request #70511 from ClickHouse/fix-db-replicated-with-unavailable-source-table-function 
Fix `StorageTableFunction::supportsReplication` creating source storage unnecessarily
 2024-10-15 21:27:27 +00:00
Shichao Jin
7e1f7eca66
Merge pull request #70606 from Blargian/docs_timeSlot 
[Docs] updates `timeSlot` function
 2024-10-15 20:46:37 +00:00
Konstantin Bogdanov
21204a68e9
Merge pull request #70671 from ClickHouse/fix-native-macos 
Fix native macOS build
 2024-10-15 19:51:10 +00:00
Arthur Passos
424cd1b619 f_unknown if monotonic_functions not empty 2024-10-15 16:14:16 -03:00
Kseniia Sumarokova
b2fd0a905a
Merge pull request #70590 from aalexfvk/ignore_shadow_frozen_metadata 
Ignore frozen_metadata.txt while traversing shadow directory from system.remote_data_paths
 2024-10-15 16:12:56 +00:00
Alexey Milovidov
dfbd356295
Merge pull request #69481 from bigo-sg/poc_orc_lc_read 
Allow reading LowCardinality(String/FixedString) data from orc dictionary encoded columns
 2024-10-15 15:45:16 +00:00
Alexey Milovidov
1dfc68aefc
Merge pull request #70503 from cwurm/patch-5 
Update settings.md: Clarify throw_if_no_data_to_insert
 2024-10-15 15:44:13 +00:00
Alexey Milovidov
1c4d188974
Merge pull request #70660 from ClickHouse/fix-incorrect-formatting-of-check-query 
Fix incorrect formatting of CHECK query
 2024-10-15 15:42:17 +00:00
Nikolai Kochetov
96b9f4aa32
Merge pull request #70158 from ClickHouse/remove-plan-streams 
Remove QueryPlan DataStream.
 2024-10-15 15:40:02 +00:00
Alexey Milovidov
d7482835fb
Merge pull request #70677 from ClickHouse/sqltest-report 
Add report file to the test results
 2024-10-15 15:38:50 +00:00
Anton Popov
d7db8d0093 fix test 2024-10-15 15:27:23 +00:00
Nikita Mikhaylov
7c5374d7d7
Update contrib/grpc-cmake/CMakeLists.txt 
Co-authored-by: Aris Tritas <113912678+aris-aiven@users.noreply.github.com>
 2024-10-15 17:26:05 +02:00
Vladimir Cherkasov
bdc186d5da
Merge pull request #69738 from ClickHouse/vdimir/window-funnel-fix-dedup2 
Fix windowFunnel counting same event several times
 2024-10-15 15:12:15 +00:00
Shichao Jin
f29900d735
Merge pull request #70612 from AlekseyKanaev/settings-users_docs_fix 
Fixed docs typo in settings-users.md
 2024-10-15 15:08:20 +00:00
Anton Popov
8738f57d4d Merge remote-tracking branch 'upstream/master' into HEAD 2024-10-15 14:56:23 +00:00
vdimir
4812159545
Insert into table function s3 respect query settings 2024-10-15 14:46:10 +00:00
Alexey Milovidov
cf3e9e26f1
Merge pull request #70662 from ClickHouse/remove-strange-file 
Remove strange file
 2024-10-15 14:26:32 +00:00
Robert Schulze
b9b7a1091b
(Re)-enable libcxx debug mode 
- We previously compiled libcxx with _LIBCPP_DEBUG=0. In old libcxx
  versions, this (surprisingly) enabled the basic debug mode [1].

- In libcxx 15 (the version we are currently using), _LIBCPP_DEBUG=0
  does nothing [2], the replacement is _LIBCPP_ENABLE_DEBUG_MODE=1.

- The debug mode is only enabled in Debug builds. Their docs say the
  extra check change complexity guarantees + the asserts crash which we
  don't want in Release builds. The debug mode detects issues like in
  [3]. Crashes look like this (for example)

  ```
  /data/ch/contrib/llvm-project/libcxx/include/__iterator/wrap_iter.h:99: assertion ::std::__libcpp_is_constant_evaluated() || (__get_const_db()->__dereferenceable(this)) failed: Attempted to increment a non-incrementable iteratorAborted (core dumped)
  ```

- I had to mute some new clang-tidy warnings in places that deal with
  container iterators. They got heavier and copy-by-value now yields a
  warning, e.g.

     for (auto it : iterators) /// <-- warning
         [...]

[1] https://releases.llvm.org/12.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html
[2] https://releases.llvm.org/15.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html
[3] https://github.com/llvm/llvm-project/blob/main/libcxx/test/support/container_debug_tests.h
 2024-10-15 13:46:07 +00:00
Antonio Andelic
d8af90be5c Merge branch 'master' into fix-preadv2-with-nowait 2024-10-15 15:31:23 +02:00
Alexey Milovidov
6f170b0948 Empty commit 2024-10-15 15:15:15 +02:00
Arthur Passos
1e7f5b0705 docs change 2024-10-15 10:02:40 -03:00
Nikita Mikhaylov
fac2302d6d CXX version for GRPC 2024-10-15 14:41:07 +02:00
Arthur Passos
fd78ef62b4 fix in with invalid conversion 2024-10-15 09:30:41 -03:00
kssenii
26f9631e8f Fix test 2024-10-15 14:01:15 +02:00
Alexey Milovidov
f8346c8563 Merge branch 'master' into remove-strange-file 2024-10-15 13:59:20 +02:00
Mikhail f. Shiryaev
6d7091c224
Add report file to the test results 2024-10-15 13:41:22 +02:00
Vladimir Cherkasov
befc98ad5b
Merge branch 'master' into vdimir/window-funnel-fix-dedup2 2024-10-15 13:09:21 +02:00
Yarik Briukhovetskyi
4f3c9c3ee8
Merge pull request #70358 from azat/fix-protobuf-schema-cache-drop 
Fix possible use-after-free in SYSTEM DROP FORMAT SCHEMA CACHE FOR Protobuf
 2024-10-15 10:39:56 +00:00
Aleksei Filatov
a67b0af276
Update src/Core/Settings.cpp 
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
 2024-10-15 12:30:14 +03:00
Aleksei Filatov
2843ef9feb
Update docs/en/operations/settings/settings.md 
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
 2024-10-15 12:29:51 +03:00
Kseniia Sumarokova
ba0b7f5689
Merge pull request #70011 from sharathks118/setting-opentelemetry 
Enhance OpenTelemetry span logging to include query settings
 2024-10-15 09:18:45 +00:00
Nikita Mikhaylov
09acc12ca9 Fix native MacOS build 2024-10-15 11:03:51 +02:00
李扬
8cbaec96db
Merge branch 'master' into poc_orc_lc_read 2024-10-15 16:11:08 +08:00
taiyang-li
cdceb99469 fix flaky tests 2024-10-15 16:10:13 +08:00
Alexey Milovidov
e9c6fd3300
Merge pull request #70644 from Algunenano/validation_user_directories 
Don't do validation when synchronizing user_directories from keeper
 2024-10-14 23:01:05 +00:00
Alexey Milovidov
80bd0cd58d Even more files are removed 2024-10-15 00:56:27 +02:00
Alexey Milovidov
13d74479b9 Remove more files 2024-10-15 00:54:26 +02:00
Alexey Milovidov
d6e546bd54 Remove more files 2024-10-15 00:53:31 +02:00
Alexey Milovidov
a906883919 Remove strange file 2024-10-15 00:51:17 +02:00
Alexey Milovidov
7591628553 Add a test 2024-10-14 23:52:28 +02:00
Alexey Milovidov
09dae8c5e8 Fix incorrect formatting of CHECK query 2024-10-14 23:49:21 +02:00
Alexey Milovidov
332671085a
Merge pull request #70604 from Blargian/patch-9 
[Docs] Fix example
 2024-10-14 21:38:03 +00:00