Commit Graph

60373 Commits

Author SHA1 Message Date
alesapin
aa2244bad5 Fix more 2021-03-26 18:59:14 +03:00
alesapin
9bb0dc48b2 Fix one more test 2021-03-26 18:37:26 +03:00
alesapin
1b0a9461f0 Fix more tests 2021-03-26 18:30:35 +03:00
Sergey Demurin
482704c434
Update other-functions.md
fix typo
2021-03-26 18:29:07 +03:00
Kruglov Pavel
5c0c6a9aec
Delete unused users.xml 2021-03-26 18:16:15 +03:00
alesapin
0fae73071c Fix flaky test 2021-03-26 18:14:42 +03:00
Pavel Kruglov
2979feb23f Prevent busy waiting in hedged requests when async_socket_for_remote=0 2021-03-26 18:11:06 +03:00
alesapin
8b08c0c3a6 Fix test_odbc_interaction 2021-03-26 17:45:52 +03:00
Anton Popov
421d8eb180 fux build 2021-03-26 17:34:04 +03:00
alexey-milovidov
ac53d30e53
Merge pull request #22146 from azat/writers-uncaught-exceptions
Fix uncaught exception in InterserverIOHTTPHandler
2021-03-26 17:23:09 +03:00
Alexander Kuzmenkov
a455762933
Merge pull request #22117 from ucasFL/useless-code
remove useless code
2021-03-26 17:18:14 +03:00
alesapin
2f07056ef6 More stable last get 2021-03-26 16:39:09 +03:00
alesapin
35d1443a9c Don't wait when table shutdown called 2021-03-26 15:54:08 +03:00
tavplubix
d9ec4090d2
Merge pull request #21936 from abyss7/html-form-fix
Fix issues with HTMLForm::MultipartReadBuffer and PeekableReadBuffer
2021-03-26 15:35:34 +03:00
alesapin
b0e401088a Make this test sequential 2021-03-26 15:20:49 +03:00
alesapin
9bdeb436c2 Fix typo 2021-03-26 15:06:36 +03:00
alesapin
2db57f0f16 Followup fix 2021-03-26 14:18:31 +03:00
alesapin
331c5b6636 Fix startup one more time 2021-03-26 13:55:39 +03:00
Mikhail
3a83c3b903 link fix 2021-03-26 13:49:58 +03:00
alesapin
ba5c151037 Fix race condition on snapshots 2021-03-26 13:20:07 +03:00
Ilya Yatsishin
508234dc5f
Merge pull request #22153 from ClickHouse/pyyaml-update
Update requirements.txt
2021-03-26 13:06:06 +03:00
Alexander Kuzmenkov
a5fb5a7183
Merge pull request #22148 from ClickHouse/aku/perf-thresholds
adjust perf test thresholds
2021-03-26 12:59:20 +03:00
Mikhail
979beae635 Merge branch 'kuriatnikovm-DOCSUP-7105-translate_changes' of https://github.com/michon470/ClickHouse into kuriatnikovm-DOCSUP-7105-translate_changes 2021-03-26 12:20:56 +03:00
Mikhail
37d8dfbeda ошибка 2021-03-26 12:00:31 +03:00
michon470
9847b73250
Update docs/en/operations/settings/settings.md
Co-authored-by: tavplubix <tavplubix@gmail.com>
2021-03-26 10:46:25 +03:00
tavplubix
ae62bee939
Merge pull request #21913 from ClickHouse/fix_context_ref
Fix possibly dangling reference to Context
2021-03-26 10:39:13 +03:00
tavplubix
fa930d49c4
Update gtest_peekable_read_buffer.cpp 2021-03-26 10:29:58 +03:00
Azat Khuzhin
c36f147b16 Fix sleep_in_send_tables_status_ms/sleep_in_send_data_ms in integration tests 2021-03-26 10:05:56 +03:00
Ilya Yatsishin
3107920f31
Update requirements.txt 2021-03-26 09:43:33 +03:00
alexey-milovidov
40a99b7431
Merge pull request #21492 from azat/client-fix-highlight-multiline-comment
Fix heap-buffer-overflow in highlighting multi-line comments
2021-03-26 02:48:21 +03:00
alexey-milovidov
f1efa33571
Merge branch 'master' into client-fix-highlight-multiline-comment 2021-03-26 02:40:11 +03:00
alexey-milovidov
fe71d628a1
Update 01774_case_sensitive_connection_id.sql 2021-03-26 02:39:07 +03:00
alexey-milovidov
21ec42d7d2
Update 01773_case_sensitive_version.sql 2021-03-26 02:39:00 +03:00
alexey-milovidov
f4d014c022
Update connectionID.cpp 2021-03-26 02:38:49 +03:00
alexey-milovidov
0e42060523
Merge pull request #22114 from ucasFL/bar
Fix bar with invalid float value
2021-03-26 02:36:02 +03:00
alexey-milovidov
67f6efb94d
Update column.md 2021-03-26 02:35:38 +03:00
Alexey Milovidov
e55f7e6333 Fix error 2021-03-26 02:21:59 +03:00
Alexey Milovidov
ad66c4a916 Fix error 2021-03-26 01:56:24 +03:00
alexey-milovidov
ddbd95be2d
Suggestion from @l1tsolaiki 2021-03-26 01:55:42 +03:00
Alexander Kuzmenkov
f3ca9db832 forgot abs() 2021-03-26 01:00:06 +03:00
Alexander Kuzmenkov
a12cc5f559 adjust perf test thresholds 2021-03-26 00:00:18 +03:00
Azat Khuzhin
b68517f69e Fix cutToFirstSignificantSubdomainCustom()/firstSignificantSubdomainCustom() for 3+level domains
Custom TLD lists (added in #17748), may contain domain of the 3-d level,
however builtin TLD lists does not have such records, so it is not
affected.

Note that this will significantly increase hashtable lookups.

Fixes: #17748
2021-03-26 00:00:16 +03:00
Azat Khuzhin
30cd1c6145 Fix typo in FirstSignificantSubdomainCustomLookup name 2021-03-26 00:00:16 +03:00
Azat Khuzhin
f1907acbcd Use finalize() over next() for nested writers
Refs: https://github.com/ClickHouse/ClickHouse/pull/21325#discussion_r585348309
2021-03-25 23:42:58 +03:00
Azat Khuzhin
50003e496a Use existing logger for logging from WriteBufferFromS3 dtor 2021-03-25 23:41:03 +03:00
Azat Khuzhin
e1de960025 Fix uncaught exception in InterserverIOHTTPHandler
There was one more uncaught exception case [1]:

    2021.03.19 18:11:00.845632 [ 17469 ] {} <Debug> InterserverIOHTTPHandler: Done processing query
    ...
    2021.03.19 18:11:31.698961 [ 80145 ] {} <Fatal> BaseDaemon: ########################################
    2021.03.19 18:11:31.699903 [ 80145 ] {} <Fatal> BaseDaemon: (version 21.4.1.6293 (official build), build id: 859E400E1C65C4702FE491420741DD8B58190002) (from thread 17469) (no query) Received signal Aborted (6)
    2021.03.19 18:11:32.614075 [ 80145 ] {} <Fatal> BaseDaemon: 8. ./obj-x86_64-linux-gnu/../contrib/libcxxabi/src/cxa_handlers.cpp:89: std::terminate() @ 0x21e9b3a2 in /usr/bin/clickhouse
    2021.03.19 18:11:43.831215 [ 80145 ] {} <Fatal> BaseDaemon: 10. ./obj-x86_64-linux-gnu/../src/Server/HTTP/WriteBufferFromHTTPServerResponse.cpp:201: ? @ 0x1be77038 in /usr/bin/clickhouse
    2021.03.19 18:11:44.743193 [ 80145 ] {} <Fatal> BaseDaemon: 11. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:892: std::__1::allocator<DB::WriteBufferFromHTTPServerResponse>::destroy(DB::WriteBufferFromHTTPServerResponse*) @ 0x1bddd7c9 in /usr/bin/clickhouse
    2021.03.19 18:11:45.283905 [ 80145 ] {} <Fatal> BaseDaemon: 12. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/__memory/allocator_traits.h:541: void std::__1::allocator_traits<std::__1::allocator<DB::WriteBufferFromHTTPServerResponse> >::__destroy<DB::WriteBufferFromHTTPServerResponse>(std::__1::integral_constant<bool, true>, std::__1::allocator<DB::WriteBufferFromHTTPServerResponse>&, DB::WriteBufferFromHTTPServerResponse*) @ 0x1bddd79d in /usr/bin/clickhouse
    2021.03.19 18:11:45.805233 [ 80145 ] {} <Fatal> BaseDaemon: 13. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/__memory/allocator_traits.h:487: void std::__1::allocator_traits<std::__1::allocator<DB::WriteBufferFromHTTPServerResponse> >::destroy<DB::WriteBufferFromHTTPServerResponse>(std::__1::allocator<DB::WriteBufferFromHTTPServerResponse>&, DB::WriteBufferFromHTTPServerResponse*) @ 0x1bddd76d in /usr/bin/clickhouse
    2021.03.19 18:11:46.351371 [ 80145 ] {} <Fatal> BaseDaemon: 14. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2611: std::__1::__shared_ptr_emplace<DB::WriteBufferFromHTTPServerResponse, std::__1::allocator<DB::WriteBufferFromHTTPServerResponse> >::__on_zero_shared() @ 0x1bddd525 in /usr/bin/clickhouse
    2021.03.19 18:11:46.579263 [ 80145 ] {} <Fatal> BaseDaemon: 15. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2476: std::__1::__shared_count::__release_shared() @ 0x119490ed in /usr/bin/clickhouse
    2021.03.19 18:11:46.790912 [ 80145 ] {} <Fatal> BaseDaemon: 16. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2517: std::__1::__shared_weak_count::__release_shared() @ 0x1194908f in /usr/bin/clickhouse
    2021.03.19 18:11:47.277990 [ 80145 ] {} <Fatal> BaseDaemon: 17. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:3213: std::__1::shared_ptr<DB::WriteBufferFromHTTPServerResponse>::~shared_ptr() @ 0x1bdd75fc in /usr/bin/clickhouse
    2021.03.19 18:11:47.649213 [ 80145 ] {} <Fatal> BaseDaemon: 18. ./obj-x86_64-linux-gnu/../src/Server/InterserverIOHTTPHandler.h:34: DB::InterserverIOHTTPHandler::Output::~Output() @ 0x1bdf6bd5 in /usr/bin/clickhouse
    2021.03.19 18:11:47.921556 [ 80145 ] {} <Fatal> BaseDaemon: 19. ./obj-x86_64-linux-gnu/../src/Server/InterserverIOHTTPHandler.cpp:154: DB::InterserverIOHTTPHandler::handleRequest(DB::HTTPServerRequest&, DB::HTTPServerResponse&) @ 0x1bdf653f in /usr/bin/clickhouse

  [1]: https://clickhouse-test-reports.s3.yandex.net/0/78c56b891383288cf3a893139e796fc87476412e/stress_test_(debug).html

Since in case of no errors during processing we should call finalize, to
ensure that it will not be called from dtor.

Fixes: #22046
Fixes: #22067
2021-03-25 23:41:03 +03:00
Azat Khuzhin
48fe30e5a2 Add missing logging for exception in InterserverIOHTTPHandler 2021-03-25 23:41:03 +03:00
Azat Khuzhin
8e445c5e55 Disable async_socket_for_remote/use_hedged_requests for buggy linux kernels
async_socket_for_remote/use_hedged_requests uses nested epolls, which
may not be reliable in 5.5+ [1], but it has been fixed in shortly in
5.7+ [2] or
5.6.13+.

  [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=339ddb53d373
  [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0c54a6a44bf3
2021-03-25 23:39:30 +03:00
Alexey Milovidov
a8ce138788 Speedup codec NONE 2021-03-25 23:08:47 +03:00
Alexander Kuzmenkov
33647ef3d5 fix build 2021-03-25 23:02:09 +03:00