Commit Graph

92069 Commits

Author SHA1 Message Date
Alexey Milovidov
602739d487 Compatible benchmark 2022-06-27 02:53:55 +02:00
Alexey Milovidov
f117a86072 Compatible benchmark 2022-06-27 00:51:34 +02:00
Alexey Milovidov
c953edbe38 Compatible benchmark 2022-06-27 00:39:23 +02:00
kssenii
5727671cac Fix tests 2022-06-27 00:34:57 +02:00
Alexey Milovidov
424765f596 Compatible benchmark 2022-06-27 00:25:50 +02:00
Alexey Milovidov
57ad9b7a2c Compatible benchmark 2022-06-27 00:24:11 +02:00
Alexey Milovidov
6a98943c33 Compatible benchmark 2022-06-27 00:00:00 +02:00
Alexey Milovidov
48b320396a Compatible benchmark 2022-06-26 23:25:39 +02:00
Alexey Milovidov
236448be09 Compatible benchmark 2022-06-26 23:04:19 +02:00
Alexey Milovidov
0c51a9c1e0 Compatible benchmark 2022-06-26 20:14:43 +02:00
Alexey Milovidov
d2cb450fd9 Compatible benchmark 2022-06-26 20:14:34 +02:00
Alexey Milovidov
40fd7d9a5a Compatible benchmark 2022-06-26 19:42:50 +02:00
Robert Schulze
959cbaab02
Move loop over patterns into implementations
- This is preparation for non-const regexp arguments, where this loop
  will run for each row.
2022-06-26 16:26:13 +00:00
Robert Schulze
cb5d1a4a85
Fix style check 2022-06-26 16:25:49 +00:00
Robert Schulze
b8f67185bf
Cosmetics: Whitespaces 2022-06-26 16:25:49 +00:00
Robert Schulze
e2b11899a1
Move check if cfg allows hyperscan into implementations
- This is not needed for non-const regexp array arguments but cleans up
  the code and runs the check only in functions which actually use
  hyperscan.
2022-06-26 16:25:49 +00:00
Robert Schulze
c2cea38b97
Move local variable into if statement 2022-06-26 16:25:49 +00:00
Robert Schulze
c9ce0efa66
Instantiate MultiMatchAnyImpl template using enums
- With this, invalid combinations of the FindAny/FindAnyIndex bools are
  no longer possible and we can remove the corresponding check

- Also makes the instantiations more readable.
2022-06-26 16:25:49 +00:00
Robert Schulze
2f15d45f27
Move check for regexp array size into implementations
- This is not needed for non-const regexp array arguments (the
  cardinality of arrays is fixed per column) but it cleans up the code
  and runs the check only in functions which have restrictions on the
  number of patterns.

- For functions using hyperscans, it was checked that the number of
  regexes is < 2^32. Removed the check because I don't think anyone will
  every specify 4 billion patterns.
2022-06-26 16:25:43 +00:00
Robert Schulze
3478db9fb6
Move check for regexp array size into implementations
- This is not needed for non-const regexp array arguments (the
  cardinality of arrays is fixed per column) but it cleans up the code
  and runs the check only in functions which have restrictions on the
  number of patterns.

- For functions using hyperscans, it was checked that the number of
  regexes is < 2^32. Removed the check because I don't think anyone will
  every specify 4 billion patterns.
2022-06-26 15:38:12 +00:00
Robert Schulze
7913edc172
Move check for hyperscan regexp constraints into implementations
- This is preparation for non-const regexp arguments, where this check
  will run for each row.
2022-06-26 15:38:05 +00:00
Robert Schulze
89bfdd50bf
Remove unnecessary check
- getReturnTypeImpl() ensures that the haystack column has type "String"
  and we can simply assert that.
2022-06-26 15:34:24 +00:00
Robert Schulze
580d89477f
Minimally faster performance 2022-06-26 15:34:22 +00:00
Robert Schulze
4bc59c18e3
Cosmetics: Move some code around + docs + whitespaces + minor stuff 2022-06-26 15:34:15 +00:00
Robert Schulze
1273756911
Cosmetics: fmt-based exceptions 2022-06-26 15:33:18 +00:00
Robert Schulze
e5c74a14f7
Cosmetics: More consistent naming
- rename utility function and file to "checkHyperscanRegexp"
2022-06-26 15:33:18 +00:00
Robert Schulze
072e0855a8
Cosmetics: Make member variables const 2022-06-26 15:32:26 +00:00
Robert Schulze
2ebfd01c2e
Cosmetics: Pull out settings variable 2022-06-26 15:32:23 +00:00
Robert Schulze
bb7c627964
Cosmetics: Pass patterns around as std::string_view instead of StringRef
- The patterns are not used in hashing, there should not be a performance
  impact when we use stuff from the standard library instead.

- added forgotten .reserve() in FunctionsMultiStringPosition.h
2022-06-26 15:32:19 +00:00
kssenii
a15238d147 Review fixes, fix hdfs tests 2022-06-26 16:51:08 +02:00
xiedeyantu
7e660933f0 add allow trailing comma test 2022-06-26 21:39:53 +08:00
xiedeyantu
9eafae968d Allow trailing comma in columns list 2022-06-26 21:39:53 +08:00
mergify[bot]
f63c959679
Merge branch 'master' into cleanup_garbage_in_store_dir 2022-06-26 13:35:10 +00:00
kssenii
8da6136f88 Fix 2022-06-26 13:21:05 +02:00
Alexey Milovidov
f62aa0a8f6 Compatible benchmark 2022-06-26 10:14:00 +02:00
Alexey Milovidov
8357e84381 Compatible benchmark 2022-06-26 09:30:59 +02:00
Alexey Milovidov
e29582daad
Merge pull request #38417 from ClickHouse/lower-mutex-scope
Lower mutex scope in ThreadStatus
2022-06-26 10:05:25 +03:00
Alexey Milovidov
b3098822e0
Merge pull request #38171 from ClickHouse/hyper-to-vectorscan
Replace hyperscan by vectorscan
2022-06-26 10:01:45 +03:00
Alexey Milovidov
c5a1f70291 Compatible benchmark 2022-06-26 08:04:56 +02:00
Alexey Milovidov
9ab973a19c Compatible benchmark 2022-06-26 07:59:40 +02:00
Alexey Milovidov
ba5d9fad07 Compatible benchmark 2022-06-26 07:31:49 +02:00
Alexey Milovidov
56639806ae Compatible benchmark 2022-06-26 06:00:07 +02:00
kssenii
725d80d470 get rid of path separation 2022-06-26 01:17:19 +02:00
Alexey Milovidov
1d4f069e3e Compatible benchmark: ClickHouse 2022-06-26 00:31:57 +02:00
Alexey Milovidov
25cc406201
Update src/Common/ThreadStatus.cpp
Co-authored-by: Dmitry Novik <n0vik@clickhouse.com>
2022-06-26 01:29:06 +03:00
Alexey Milovidov
c124610b5e Compatible benchmark: ClickHouse 2022-06-26 00:27:32 +02:00
Robert Schulze
07f14c9bb2
Disable vectorscan-on-ARM for now 2022-06-26 00:03:01 +02:00
Alexey Milovidov
37903bfee0 Fix after #38427 2022-06-25 23:18:33 +02:00
Alexey Milovidov
38dc2b1cbc
Merge pull request #38427 from ClickHouse/automated-benchmark
Automated benchmark
2022-06-25 23:54:02 +03:00
Alexey Milovidov
756fd0dac8 Automated hardware benchmark 2022-06-25 18:27:26 +02:00