Commit Graph

175 Commits

Author SHA1 Message Date
Azat Khuzhin
758deac715 Do not check close() return value in BaseDaemon::closeFDs()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-08 05:52:35 +01:00
Azat Khuzhin
8cc41b7f41 Check return value of ::close()
Note, that according close(2), EINTR should not be retriable for close()

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 11:28:22 +01:00
Alexander Tokmakov
3f6594f4c6 forbid old ctor of Exception 2023-01-23 22:18:05 +01:00
Alexander Tokmakov
522686f78b less empty patterns 2023-01-17 01:19:44 +01:00
Alexey Milovidov
3a027d285f
Merge pull request #44828 from ClickHouse/remove-two-lines-of-code
What if I will remove two lines of code?
2023-01-04 04:50:52 +03:00
Robert Schulze
27f5aad49e
What happens if I remove 156 lines of code? 2023-01-03 18:51:16 +00:00
Alexey Milovidov
6e946cc757 Less OOM in stress test 2023-01-01 23:22:26 +01:00
Raúl Marín
e915ce1e95 Merge remote-tracking branch 'blessed/master' into perf_experiment 2022-12-28 20:15:43 +01:00
Alexey Milovidov
e1115828d0
Merge pull request #44593 from ClickHouse/better-diagnostic-in-stress-test
Better diagnostics on server stop for the stress test
2022-12-27 16:07:43 +03:00
Alexey Milovidov
c37fc45d07
Merge pull request #44611 from ClickHouse/maybe-fix-bogus-msan-error
Maybe fix a bogus MSan error
2022-12-27 15:08:42 +03:00
Raúl Marín
fc1fa82a39
Merge branch 'master' into perf_experiment 2022-12-27 10:51:58 +01:00
Alexey Milovidov
e1e1448143 Maybe fix a bogus MSan error 2022-12-26 20:26:55 +01:00
Alexey Milovidov
b6bf942f70 Fix bad punctuation in log 2022-12-26 13:35:44 +01:00
Alexey Milovidov
e98f217b87 Better diagnostics on stop 2022-12-26 12:15:58 +01:00
Alexander Gololobov
2f7228c012 Removed parent pid check that breaks in containers 2022-12-21 20:43:59 +01:00
Raúl Marín
45d27f461b
Merge branch 'master' into perf_experiment 2022-12-20 09:07:48 +00:00
Alexey Milovidov
30fd9b8317
Merge pull request #43597 from ClickHouse/sd_notify_followup_fixes
Followup fixes for systemd notification (#43400)
2022-12-17 04:35:05 +03:00
Nikolay Degterinsky
9b6d31b95d
Merge branch 'master' into perf_experiment 2022-12-13 17:15:07 +01:00
Alexey Milovidov
fddfd356f5 Better descriptions of signals 2022-12-11 03:19:36 +01:00
Alexander Gololobov
b62ca7b4e1 Some more fixes in startup logic 2022-12-06 16:49:35 +01:00
Alexander Gololobov
3608763a30 Wait for parent process to send MAINPID=... notification to the service manager 2022-12-06 16:14:46 +01:00
Alexander Gololobov
688e6fe714 Send MAINPID= notification from the parent (watchdog) process to make systemd handle READY=1 notifiaction from the child 2022-12-05 23:03:40 +01:00
Raúl Marín
97d6fc3071 Merge remote-tracking branch 'blessed/master' into perf_experiment 2022-11-17 11:48:46 +01:00
Alexey Milovidov
b4165f95a9
Merge branch 'master' into build/poco-leftovers 2022-11-16 06:09:58 +01:00
Raúl Marín
65f00cc246 Skip binary hash calculation if there isn't a checksum reference 2022-11-14 12:17:21 +01:00
Azat Khuzhin
953457de28 Remove POCO_CLICKHOUSE_PATCH
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-10 22:41:26 +01:00
Raúl Marín
6e0a9452e7 Merge remote-tracking branch 'blessed/master' into perf_experiment 2022-10-25 15:25:06 +02:00
Azat Khuzhin
4e76629aaf Fixes for -Wshorten-64-to-32
- lots of static_cast
- add safe_cast
- types adjustments
  - config
  - IStorage::read/watch
  - ...
- some TODO's (to convert types in future)

P.S. That was quite a journey...

v2: fixes after rebase
v3: fix conflicts after #42308 merged
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:19 +02:00
Raúl Marín
227af9a074 Optimizations around ThreadStatus 2022-10-13 21:49:21 +02:00
Robert Schulze
da5a2e2db0
Merge remote-tracking branch 'origin/master' into generated-file-cleanup
Physical merge conflicts:
- src/Common/ZooKeeper/ZooKeeperImpl.cpp
- src/Core/config_core.h.in
- src/Functions/FunctionsAES.h
- src/Functions/config_functions.h.in
- src/configure_config.cmake

Logical merge conflicts:
- Functions/tryDecrypt.cpp
2022-10-06 08:43:25 +00:00
Nikita Mikhaylov
d767e1f0d8
Added an option to specify environment name in Sentry's config (#42037) 2022-10-04 13:23:51 +02:00
Robert Schulze
1cbceb6611
Merge pull request #42014 from ClickHouse/drop-libexecinfo-leftovers
Drop leftovers of libexecinfo
2022-10-04 08:51:17 +02:00
ltrk2
ab609cfbd4 Fix linker error 2022-10-03 10:45:10 -04:00
Robert Schulze
919b4e2349
Drop leftovers of libexecinfo
- libexecinfo was perhaps used in the past but today it is unused
2022-10-03 08:51:28 +00:00
Robert Schulze
6d70b4a1f6
Generate config_version.h into ${CONFIG_INCLUDE_PATH}
This makes the target location consistent with other auto-generated
files like config_formats.h, config_core.h, and config_functions.h and
simplifies the build of clickhouse_common.
2022-09-28 12:48:26 +00:00
Robert Schulze
78fc36ca49
Generate config.h into ${CONFIG_INCLUDE_PATH}
This makes the target location consistent with other auto-generated
files like config_formats.h, config_core.h, and config_functions.h and
simplifies the build of clickhouse_common.
2022-09-28 12:48:26 +00:00
Robert Schulze
1885bb0524
Make comment consistent accross generated files 2022-09-28 08:11:09 +00:00
Robert Schulze
588a5e5a42
Simplify a bit 2022-09-27 07:47:18 +00:00
Robert Schulze
ec35ff9cd6
Log git hash during startup
We currently only log a compiler-generated "build id" at startup which
is different for each build. That makes it useless to determine the
exact source code state in tests (e.g. BC test) and from user log files
(e.g. if someone compiled an intermediate version of ClickHouse).

Current log message:
  Starting ClickHouse 22.10.1.1 with revision 54467, build id: 6F35820328F89C9F36E91C447FF9E61CAF0EF019, PID 42633

New log message:
  Starting ClickHouse 22.10.1.1 (revision 54467, git hash: b6b1f7f763f94ffa12133679a6f80342dd1c3afe, build id: 47B12BE61151926FBBD230DE42F3B7A6652AC482), PID 981813
2022-09-26 14:12:36 +00:00
Alexey Milovidov
fa62c7e982 Fix half of trash 2022-09-10 04:08:16 +02:00
root
d5db88fa27 Structured-logging-custom-keys PR init 2022-08-30 23:20:19 -03:00
Robert Schulze
e8b3f56733
Limit suppression to a specific warning 2022-08-21 18:24:17 +00:00
Alexey Milovidov
74e1f4dc61 Fix clang-tidy 2022-08-20 17:09:20 +02:00
Mallik Hassan
666fb8dc42
Merge branch 'ClickHouse:master' into Structured-Logging-Support 2022-08-09 15:39:00 -03:00
root
d58ae78712 removed default color enable in OwnPatternFormatter constructor calling 2022-08-03 06:30:48 -07:00
root
bec7408a0c reflected change requests asked on July 27 2022-07-28 09:20:28 -07:00
Mallik Hassan
0e68ac4e4d
Update BaseDaemon.cpp
removed conflict markers from BaseDaemon.cpp
2022-07-26 11:34:17 -03:00
root
f7dcf23404 removed pFormattterJSON pointer from OwnFormattingChannel and reformatted Loggers and BaseDaemon to look nicer 2022-07-26 06:53:06 -07:00
Mallik Hassan
943affe2da
Update src/Daemon/BaseDaemon.cpp
Co-authored-by: Nikolay Degterinsky <43110995+evillique@users.noreply.github.com>
2022-07-26 03:43:04 -03:00
root
1166181065 removed unwanted changes from BaseDaemon.cpp 2022-07-25 19:59:04 -07:00
root
f135a82141 Addressed changes requested by @evillique (Restructured OwnJSONPatternFormatter, used different version of writeJSONString() etc... 2022-07-25 19:39:13 -07:00
Mallik Hassan
b45e44b7e7
Merge branch 'ClickHouse:master' into Structured-Logging-Support 2022-07-25 12:10:41 -03:00
Nikolay Degterinsky
c4b72277df Fix logs rotation issue 2022-07-25 13:58:04 +00:00
root
afab965d7b style check 2022-07-19 12:38:47 -07:00
Robert Schulze
13482af4ee
First try at reducing the use of StringRef
- to be replaced by std::string_view
- suggested in #39262
2022-07-17 17:26:02 +00:00
root
03194eaeb9 Feature - Structured Logging Support resubmit 2022-07-15 10:01:30 -07:00
Alexander Tokmakov
c45482d6c6 disable instrumentation of sanitizer death callback 2022-07-07 22:10:12 +02:00
Robert Schulze
f692ead6ad
Don't use std::unique_lock unless we have to
Replace where possible by std::lock_guard which is more light-weight.
2022-06-28 19:19:06 +00:00
Alexander Tokmakov
e9c2157f01 Merge branch 'master' into fix_flaky_tests_with_transactions 2022-06-17 15:57:30 +02:00
Alexander Tokmakov
39c0219c11 fixes 2022-06-16 19:41:32 +02:00
Robert Schulze
b936abe813
+ comments about keeping stuff in sync 2022-06-16 00:07:59 +02:00
Robert Schulze
bc46cef63c
Minor follow-up
- change ELF section name to ".clickhouse.hash" (lowercase seems
  standard)

- more expressive/concise integrity check messages at startup
2022-06-14 08:52:13 +00:00
Robert Schulze
1a0b5f33b3
More consistent use of platform macros
cmake/target.cmake defines macros for the supported platforms, this
commit changes predefined system macros to our own macros.

__linux__ --> OS_LINUX
__APPLE__ --> OS_DARWIN
__FreeBSD__ --> OS_FREEBSD
2022-06-10 10:22:31 +02:00
Azat Khuzhin
c29768325c Print query in one line on fatal errors
executeQuery() logging query without new lines in SQL, and it is useful,
since you can grep and see the whole query (usually).

So let's use the same in fatal error handler to make CI reports more
informative.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-06-03 18:55:53 +03:00
Alexey Milovidov
11788c8129 Fix clang-tidy-14 2022-05-29 02:28:46 +02:00
Alexey Milovidov
be07c4c4b0 Fix clang-tidy-14, part 1 2022-05-27 23:03:16 +02:00
Alexey Milovidov
8e9d771237 Fix clang-tidy-14, part 1 2022-05-27 23:02:05 +02:00
Alexey Milovidov
3086c19341 Fix clang-tidy-14, part 1 2022-05-27 23:00:23 +02:00
Alexey Milovidov
d2c6fd90cb Fix clang-tidy-14, part 1 2022-05-27 22:51:37 +02:00
Robert Schulze
b475fbc9a7
Merge pull request #37300 from ClickHouse/cmake-cleanup-pt3
Various cmake cleanups
2022-05-20 10:02:36 +02:00
Robert Schulze
43945cea1b
Fixing some warnings 2022-05-16 20:59:27 +02:00
Robert Schulze
1b81bb49b4
Enable clang-tidy modernize-deprecated-headers & hicpp-deprecated-headers
Official docs:

  Some headers from C library were deprecated in C++ and are no longer
  welcome in C++ codebases. Some have no effect in C++. For more details
  refer to the C++ 14 Standard [depr.c.headers] section. This check
  replaces C standard library headers with their C++ alternatives and
  removes redundant ones.
2022-05-09 08:23:33 +02:00
Amos Bird
20f63a6fa4
Fix style check 2022-04-29 15:32:53 +08:00
Amos Bird
50a00b64fd
Fix build 2022-04-29 10:26:38 +08:00
Amos Bird
4a5e4274f0
base should not depend on Common 2022-04-29 10:26:35 +08:00