Commit Graph

1634 Commits

Author SHA1 Message Date
Yakov Olkhovskiy
75fc471cfc
Merge pull request #36542 from vdimir/literal_drop_const_issue36279
ASTLiteral clone only value
2022-05-05 09:39:00 -04:00
Vitaly Baranov
202dd864ed Fix compilation. 2022-05-03 18:34:29 +02:00
Vitaly Baranov
828f45f078 Add new restore setting 'allow_non_empty_tables'. 2022-05-03 16:18:45 +02:00
vdimir
7f24ae89d1
ASTLiteral clone all except unique_column_name 2022-05-03 10:18:18 +00:00
vdimir
a7fa253ccf
ASTLiteral clone only value 2022-05-03 10:18:18 +00:00
Vladimir C
1dd4562bfa
Update src/Parsers/ExpressionElementParsers.cpp 2022-05-03 12:15:28 +02:00
Vitaly Baranov
2c754f44fc Make calculation of shard_num & replica_num not dependant on match of the cluster's definitions on nodes. 2022-05-03 11:01:44 +02:00
Vitaly Baranov
bddec55d35 Added ASTBackupQuery::setDatabase(). 2022-05-03 11:01:44 +02:00
Nikita Mikhaylov
93a65463d0
Added SYSTEM SYNC DATABASE query (#35944) 2022-05-01 15:40:18 +02:00
Robert Schulze
89aa9ae00f
Fixed clang-tidy check "bugprone-branch-clone"
The check is currently *not* part of .clang-tidy. It complains about:
(1) "switch has multiple consecutive identical branches"
(2) "repeated branch in conditional chain"

About (1): Lots of findings in switches were about redundant
"[[fallthrough]]" in places where the compiler would not warn anyways. I
have cleaned these up.

About (2): In if-else_if-else chains, fixing the warning would usually
mean concatenating multiple if-conditions. As this would reduce
readability in most cases, I did not fix these places.

Because of (2), I also refrained from adding "bugprone-branch-clone" to
.clang-tidy.
2022-04-30 19:40:28 +02:00
Alexey Milovidov
1ddb04b992
Merge pull request #36715 from amosbird/refactorbase
Reorganize source files so that base won't depend on Common
2022-04-30 09:40:58 +03:00
Vladimir C
f6f58f7609
Check only suffix in ParserCollation 2022-04-29 12:24:27 +02:00
mergify[bot]
288b68c86e
Merge branch 'master' into followup_password_hash_salt 2022-04-29 08:17:05 +00:00
Amos Bird
4a5e4274f0
base should not depend on Common 2022-04-29 10:26:35 +08:00
Yakov Olkhovskiy
7001489095
Merge pull request #36633 from ucasfl/fix-crash
Fix format crash when default expression follow EPHEMERAL not literal
2022-04-28 12:38:43 -04:00
Kseniia Sumarokova
d5a7177bb1
Merge pull request #36658 from kssenii/follow-up
Fix formatting in drop cache system query
2022-04-28 13:12:16 +02:00
Vitaly Baranov
641a5f5e35
Merge pull request #36198 from vitlibar/backup-improvements-3
Backup for replicated tables and other improvements
2022-04-28 09:23:53 +02:00
Vitaly Baranov
a8e924caf6 Make BACKUP & RESTORE synchronous by default. 2022-04-26 18:45:39 +02:00
Alexander Tokmakov
32f4565def
Merge pull request #36642 from ClickHouse/fix_settings_in_create_query
Fix parsing of settings in create query
2022-04-26 15:22:12 +03:00
kssenii
c502a14404 Fix 2022-04-26 11:26:20 +02:00
Kseniia Sumarokova
81db081b88
Merge pull request #36639 from kssenii/better-drop-cache
Improve drop cache query
2022-04-26 11:25:46 +02:00
Vitaly Baranov
1c0b731ea6 Fix compilation. 2022-04-26 10:13:08 +02:00
Vitaly Baranov
78bcb96098 Rename backup & restore setting 'async' -> 'sync', and make backup & restore async by default. 2022-04-26 09:51:19 +02:00
fenglv
3086d0deda remove unneeded include file 2022-04-26 06:42:51 +00:00
fenglv
7150dc04ce fix 2022-04-26 05:18:14 +00:00
Vitaly Baranov
000b184691 Fix style & compilation. 2022-04-25 23:05:35 +02:00
kssenii
35b8d302da Fix 2022-04-25 21:57:13 +02:00
Alexander Tokmakov
cfcf8dbfbe fix backward incompatibility 2022-04-25 21:00:39 +02:00
Kseniia Sumarokova
cf34ae0f67
Update ASTSystemQuery.h 2022-04-25 19:40:28 +02:00
kssenii
a76a35d3ce Better drop cache 2022-04-25 19:20:25 +02:00
fenglv
85f35a6857 Fix format crash when default expression follow EPHEMERAL not literal 2022-04-25 14:57:14 +00:00
Vitaly Baranov
68a020ecea Implement BACKUP/RESTORE ON CLUSTER. 2022-04-25 16:34:33 +02:00
Vitaly Baranov
3477665659 Add shard_index and replica_index to params of getRewrittenASTWithoutOnCluster(). 2022-04-25 16:34:33 +02:00
Yakov Olkhovskiy
579e8105a3
Merge pull request #36468 from ClickHouse/decouple_ParserAttachAccessEntity
Refactoring dependency for ParserAttachAccessEntity
2022-04-25 08:28:17 -04:00
Alexey Milovidov
90297e225c
Merge pull request #36430 from amosbird/fixcolumnmatcher
Fix column matcher and column transformer
2022-04-24 09:11:21 +03:00
yuuch
0d9303acc0 fix style check 2022-04-23 00:41:14 +08:00
yuuch
79a4fb376f fix some bugs while parsing the collation 2022-04-22 23:46:03 +08:00
Anton Popov
5b5dd4fa46
Merge pull request #36423 from CurtizJ/return-back-36126
Return back #36126
2022-04-22 14:27:57 +02:00
yuuch
d126de6dda
Apply suggestions from code review
Co-authored-by: Vladimir C <vdimir@clickhouse.com>
2022-04-22 20:00:12 +08:00
Yakov Olkhovskiy
e6c5ac3b02 print error string 2022-04-22 00:31:23 -04:00
Maksim Kita
bac1f12a2b
Merge pull request #36167 from kitaisreal/special-operators-broken-aliases-fix
Fix broken aliases during parsing of special operators
2022-04-21 22:31:45 +02:00
Maksim Kita
a077751100 Fixed style check 2022-04-21 21:31:50 +02:00
Yakov Olkhovskiy
f966d69791 error processing for RAND_bytes, style issue 2022-04-21 13:07:44 -04:00
Maksim Kita
57444fc7d3
Merge pull request #36444 from rschu1ze/clang-tidy-fixes
Clang tidy fixes
2022-04-21 16:11:27 +02:00
Maksim Kita
be53daf405 Fixed tests 2022-04-21 14:20:10 +02:00
Maksim Kita
01e09ba44e Fixed tests 2022-04-21 13:47:43 +02:00
Maksim Kita
c9a1605b1e Fixed tests 2022-04-21 13:47:43 +02:00
Maksim Kita
fb28791d83 Fixed tests 2022-04-21 13:47:43 +02:00
Maksim Kita
90e3a75874 Fixed tests 2022-04-21 13:47:43 +02:00
Maksim Kita
00ac3231b2 Fix broken aliases during parsing of special operators 2022-04-21 13:47:43 +02:00
Yakov Olkhovskiy
b2d7cb769c dedicated files for ParserAttachAccessEntity 2022-04-20 22:59:12 -04:00
Yakov Olkhovskiy
85df222f15 refactoring ParserAttachAccessEntity 2022-04-20 22:57:44 -04:00
Dmitry Novik
61deae7105
Merge branch 'master' into grouping-sets-fix 2022-04-21 03:34:42 +02:00
Alexey Milovidov
ec9b86fd03
Merge branch 'master' into fixcolumnmatcher 2022-04-21 02:15:25 +03:00
Larry Luo
33cdeab4cc Removed space. 2022-04-20 11:07:06 -04:00
Larry Luo
cd59a2db08 Fixed unit tests. 2022-04-20 11:00:18 -04:00
mergify[bot]
ded06ff100
Merge branch 'master' into return-back-36126 2022-04-20 13:01:32 +00:00
larryluogit
46a9226bf6
Merge branch 'ClickHouse:master' into feature-password 2022-04-20 07:57:21 -04:00
Rajkumar
419970cc1c moved class definition to header 2022-04-20 04:05:23 -07:00
Rajkumar
16a3e9cb2d updated unit test case 2022-04-20 03:29:58 -07:00
Robert Schulze
b24ca8de52
Fix various clang-tidy warnings
When I tried to add cool new clang-tidy 14 warnings, I noticed that the
current clang-tidy settings already produce a ton of warnings. This
commit addresses many of these. Almost all of them were non-critical,
i.e. C vs. C++ style casts.
2022-04-20 10:29:05 +02:00
Larry Luo
ed7eb988d8 Addressed build warnings. 2022-04-19 21:45:30 -04:00
Amos Bird
158a25d5fa
Fix column matcher and column transformer 2022-04-20 01:22:04 +08:00
Anton Popov
7b7939c52c fix parsing of ints 2022-04-19 13:31:45 +00:00
Robert Schulze
118e94523c
Activate clang-tidy warning "readability-container-contains"
This check suggests replacing <Container>.count() by
<Container>.contains() which is more speaking and in case of
multimaps/multisets also faster.
2022-04-18 23:53:11 +02:00
Larry Luo
a7ed0ef568 Fixed style check error 2022-04-18 17:20:58 -04:00
Larry Luo
5a5cc3dd13 Added keyword SALT to indicate random salt value in CREATE/ALTER USER results. 2022-04-18 17:02:22 -04:00
Anton Popov
56bdc654d4 Revert "Merge pull request #36337 from ClickHouse/revert-36126-fork_chmaster2"
This reverts commit e04f80d4a7, reversing
changes made to 06e0afb67f.
2022-04-18 17:59:46 +00:00
Larry Luo
e4d83f5627 Remove test code. 2022-04-18 13:48:50 -04:00
Larry Luo
3b605b3fd7 Fixed check style error 2022-04-18 12:03:14 -04:00
larryluogit
393fd88d95
Merge branch 'ClickHouse:master' into feature-password 2022-04-18 11:39:40 -04:00
Larry Luo
6189b28489 Added unit tests for parsing sha256_password and sha256_hash with salt 2022-04-18 11:34:25 -04:00
Alexey Milovidov
1333b4cd89
Merge pull request #36345 from ucasfl/throw-no-data
Add setting throw_if_no_data_to_insert
2022-04-18 07:04:16 +03:00
Alexey Milovidov
f6ab2bd523
Merge pull request #36312 from ClickHouse/remove-arcadia
Remove remaining parts of Arcadia
2022-04-18 07:02:54 +03:00
Alexey Milovidov
36595e4206
Merge pull request #36320 from ClickHouse/fix-clang-tidy-14
Fix clang-tidy-14 (part 1)
2022-04-18 07:02:10 +03:00
Alexey Milovidov
242919eddd Remove abbreviation 2022-04-18 01:02:49 +02:00
fenglv
0024a08ace fix
fix typo
2022-04-17 15:12:07 +00:00
Alexey Milovidov
7de4f2b6c1 Merge branch 'master' into remove-arcadia 2022-04-17 16:30:09 +02:00
Alexey Milovidov
fb0a23881d Merge branch 'master' into fix-clang-tidy-14 2022-04-17 16:28:54 +02:00
Alexey Milovidov
42618239a4
Update ParserDataType.cpp 2022-04-17 01:53:11 +03:00
Alexey Milovidov
cb9675d0f2
Revert "support UNSIGNED modifier with unused parameters of INT" 2022-04-16 21:23:57 +03:00
larryluogit
c98e25d36c
Merge branch 'ClickHouse:master' into feature-password 2022-04-15 22:56:34 -04:00
Alexey Milovidov
294efeccfe Fix clang-tidy-14 (part 1) 2022-04-16 04:54:04 +02:00
Alexey Milovidov
cbeeb7ec4f Remove Arcadia 2022-04-16 00:20:47 +02:00
Larry Luo
01955fd221 Use upper case salt and address style check error 2022-04-15 16:46:47 -04:00
yuuch
6919ca9a6e remove parse about the not null in ParserCollation 2022-04-15 21:31:25 +08:00
Rajkumar
883eea5318 code review comments addressing 2022-04-14 17:06:13 -07:00
Dmitry Novik
a16710c750 Merge remote-tracking branch 'origin/master' into grouping-sets-fix 2022-04-14 17:29:51 +00:00
yuuch
29e0b4c3bb support collation in create query 2022-04-15 00:12:31 +08:00
Anton Popov
791454678b
Merge pull request #36126 from awakeljw/fork_chmaster2
support UNSIGNED modifier with unused parameters of INT
2022-04-14 13:43:51 +02:00
Rajkumar
f5c224f9fe compilation error fix 2022-04-13 19:04:16 -07:00
Rajkumar
92c01c7a8c space removed 2022-04-12 07:37:48 -07:00
Rajkumar
14cb87e3ef password hash salt feature 2022-04-12 07:30:09 -07:00
jewisliu
b2c10611d1 support UNSIGNED modifier with unused parameters of INT 2022-04-12 19:49:57 +08:00
Yakov Olkhovskiy
155a2a0d42
Merge pull request #35349 from yakov-olkhovskiy/interpolate-feature
Interpolate feature
2022-04-11 11:15:50 -04:00
Alexander Tokmakov
141fbc6980 Merge branch 'master' into mvcc_prototype 2022-04-08 13:38:11 +02:00
Alexander Tokmakov
49c35f3261 Merge branch 'master' into mvcc_prototype 2022-04-08 13:34:40 +02:00
Vitaly Baranov
45dea9933b
Merge pull request #35883 from azat/format-settings
Do not allow SETTINGS after FORMAT for INSERT queries
2022-04-08 12:38:14 +02:00
alesapin
8ec802bc62
Merge pull request #35475 from kssenii/remote-fs-cache-improvements
Allow to write remote fs cache on all write operations. Add `system.remote_filesystem_cache` table. Add `drop remote filesystem cache (<path>)` query. Add `system.remote_data_paths` table.
2022-04-08 12:06:26 +02:00
Yakov Olkhovskiy
64dcddc6e3 fixed ASTInterpolateElement::clone, fixed QueryNormalizer to exclude ASTInterpolateElement::children 2022-04-07 17:41:05 -04:00
Alexander Tokmakov
6a46da93ae Merge branch 'master' into mvcc_prototype 2022-04-07 23:22:19 +02:00
Azat Khuzhin
33d99c8ffb Introduce compatiblity mode for SETTINGS after FORMAT
Add allow_settings_after_format_in_insert setting, OFF by default.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
v2: s/parser_settings_after_format_compact/allow_settings_after_format_in_insert/ (suggested by vitlibar)
v3: replace ParserSettings with a flag (requested by vitlibar)
2022-04-07 16:36:34 +03:00
Azat Khuzhin
c5ffbc688e Do not allow SETTINGS after FORMAT for INSERT queries
Parsing SETTINGS after FORMAT, that has been introduced in [1], can
interpret SETTING as some values, which is misleading.

  [1]: https://github.com/ClickHouse/ClickHouse/pull/4174/files#diff-ba7bd0657630b1cd94cf6ed364bd857338096f49f66dc82918438d6745753775R106

Note, that we are touching only INSERT queries, not SELECT, since this
is a backward incompatible change, and in case of modifying SELECT it
can break too much.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Fixes: #35100
Fixes: #20343
2022-04-07 16:29:36 +03:00
jewisliu
77edd41b2e [Improvement] improvement in PARTITION ALL
1. ASTPartition::formatImpl should output ALL while executing ALTER TABLE t DETACH PARTITION ALL
2. prohibit PARTITION ALL excepte DETACH PARTITION ALL
2022-04-07 17:37:01 +08:00
Yakov Olkhovskiy
7dbe8bc2dc major bugs fixed, tests added, docs updated 2022-04-07 01:21:24 -04:00
Yakov Olkhovskiy
ac441b9dcf compiler suggestions 2022-04-06 00:05:06 -04:00
Yakov Olkhovskiy
90c4cd3de7
Merge branch 'master' into interpolate-feature 2022-04-05 14:39:07 -04:00
Yakov Olkhovskiy
e0d6033c39 all columns can participate in interpolate expression despite if they are selected or not, some optimization on expressionless INTERPOLATE 2022-04-05 14:26:49 -04:00
Alexander Tokmakov
1fe50ad201 Merge branch 'master' into mvcc_prototype 2022-04-05 14:38:02 +02:00
Alexander Tokmakov
da00beaf7f Merge branch 'master' into mvcc_prototype 2022-04-05 11:14:42 +02:00
Vladimir C
54b4049ea5
Merge pull request #35794 from awakeljw/fork_chmaster 2022-04-05 09:44:45 +02:00
Alexander Tokmakov
a2167f12b8 Merge branch 'master' into mvcc_prototype 2022-04-04 14:24:23 +02:00
Azat Khuzhin
93bbe9641a Fix formatting of INSERT ... COMPRESSION
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-04 10:33:12 +03:00
Azat Khuzhin
9a76efb850 Fix formatting of INSERT INFILE queries (missing quotes)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-04 10:33:12 +03:00
Yakov Olkhovskiy
38993f215f
Merge pull request #35706 from yakov-olkhovskiy/ephemeral-35641
Allow EPHEMERAL without explicit default expression
2022-04-01 10:49:29 -04:00
kssenii
6c8e073a61 Merge master 2022-04-01 16:48:29 +02:00
Alexander Tokmakov
6591d1ceb7 Merge branch 'master' into mvcc_prototype 2022-04-01 15:38:46 +02:00
Kseniia Sumarokova
cafff71d2f
Merge pull request #35799 from evillique/extract-parser-fix
Fix extract function parser
2022-04-01 10:59:39 +02:00
jewisliu
9a4cc78dfb support ALTER TABLE t DETACH PARTITION ALL syntax 2022-04-01 13:13:07 +08:00
Yakov Olkhovskiy
0367cbad3c messed merge fixed 2022-03-31 09:35:19 -04:00
Nikolay Degterinsky
e022f8527b Fix extract parser 2022-03-31 11:42:35 +00:00
Alexander Tokmakov
5a50ad9de3 Merge branch 'master' into mvcc_prototype 2022-03-31 11:35:04 +02:00
Yakov Olkhovskiy
3b40b56e56 refactored to remove parsers rependency on datatypes 2022-03-30 23:47:16 -04:00
kssenii
ac4897f4f9 Fix 2022-03-30 20:16:41 +02:00
kssenii
0fc92fe2aa Get rid of all "remote" mentions 2022-03-30 17:15:29 +02:00
kssenii
a2e950bd3b Fix 2022-03-29 17:34:50 +02:00
Yakov Olkhovskiy
46fd69d2bf
Update ParserCreateQuery.h
style fix
2022-03-29 09:15:27 -04:00
Yakov Olkhovskiy
ef34f7dbd7 allow EPHEMERAL without expression 2022-03-29 03:54:13 -04:00
Yakov Olkhovskiy
615efa1381 aliases processing fixed 2022-03-28 19:15:53 -04:00
Alexander Tokmakov
208b242188 Merge branch 'master' into mvcc_prototype 2022-03-28 19:58:06 +02:00
kssenii
6769b84638 Merge master 2022-03-24 20:47:43 +01:00
Yakov Olkhovskiy
adefcfd299
Merge branch 'master' into interpolate-feature 2022-03-24 15:33:09 -04:00
Yakov Olkhovskiy
83f406b722 optimization, INTERPOLATE without expr. list, any column is allowed except WITH FILL 2022-03-24 15:29:29 -04:00
Yakov Olkhovskiy
1631656803
Merge pull request #34353 from zvonand/issue_33147
Extended usage of Milliseconds, Microseconds, Nanoseconds
2022-03-23 13:33:07 -04:00
kssenii
c2c7f365ce Merge master 2022-03-23 16:58:35 +01:00
Alexander Tokmakov
bcec53aadc Merge branch 'master' into mvcc_prototype 2022-03-23 11:28:43 +01:00
Mikhail f. Shiryaev
e6f5a3f98b
Apply black formatter to all *.py files in the repo 2022-03-22 17:39:58 +01:00
Alexander Tokmakov
3c762f566d Merge branch 'master' into mvcc_prototype 2022-03-21 20:16:29 +01:00
mergify[bot]
e11ef05c2b
Merge branch 'master' into issue_33147 2022-03-21 13:40:17 +00:00
kssenii
eabbce69a7 Add system drop remote filesystem cache query, allow to write cache on insert 2022-03-21 12:32:44 +01:00
Vitaly Baranov
7a46e7a0d1
Merge branch 'master' into improve-backup-and-restore 2022-03-21 11:49:26 +01:00
Alexey Milovidov
0ce4696c49
Revert "[WIP] New row policies" 2022-03-21 08:41:33 +03:00
Alexander Tokmakov
9e05b12d2c Merge branch 'master' into mvcc_prototype 2022-03-20 22:42:26 +01:00
Vitaly Baranov
54d554f55d Simplify elements of ASTBackupQuery. 2022-03-20 20:01:54 +01:00
Yakov Olkhovskiy
eb7474e73a
Merge branch 'master' into interpolate-feature 2022-03-19 03:11:14 -04:00
Yakov Olkhovskiy
a8e1671a76 type match check for INTERPOLATE expressions added, bugfix, printout fixed 2022-03-18 16:44:27 -04:00
Alexander Tokmakov
0719d01d39 more introspection 2022-03-18 14:33:59 +01:00
Vitaly Baranov
98e48d7b54 SHOW CREATE ROW POLICY now always shows AS permissive/restrictive if there is TO section. 2022-03-17 15:28:53 +01:00
Vitaly Baranov
470582e262 Change type of RowPolicyKind: bool -> enum. 2022-03-17 15:28:05 +01:00
Yakov Olkhovskiy
00700988ee style fix 2022-03-17 02:31:01 -04:00