Commit Graph

65922 Commits

Author SHA1 Message Date
Azat Khuzhin
1b5ca07ff4 Convert VersionNumber::fromString() to constructor 2021-06-14 10:38:26 +03:00
Azat Khuzhin
ba05bf3977 Use LOGICAL_ERROR instead of introducing BAD_VERSION
But note, that tests with EXPECT_EXIT() does not work with --gtest_filter:

a) only this test is included into unit_tests_dbms

   $ src/unit_tests_dbms --gtest_filter=VersionNumber*
   Running main() from ../contrib/googletest/googletest/src/gtest_main.cc
   Note: Google Test filter = VersionNumber*
   [==========] Running 2 tests from 1 test suite.
   [----------] Global test environment set-up.
   [----------] 2 tests from VersionNumber
   [ RUN      ] VersionNumber.VersionNumber
   [       OK ] VersionNumber.VersionNumber (0 ms)
   [ RUN      ] VersionNumber.fromString
   Segmentation fault (core dumped)

   (gdb) bt
   0  0x00007fffda323d22 in raise () from /usr/lib/libc.so.6
   1  0x00007fffda30d862 in abort () from /usr/lib/libc.so.6
   2  0x00007fffdbe686f5 in DB::handle_error_code (msg=..., code=49, remote=false, trace=...) at Exception.cpp:49
   3  0x00007fffdbe68846 in DB::Exception::Exception (this=0x7fffd5c5a240, msg=..., code=49, remote_=false) at Exception.cpp:60
   4  0x00007fffe26b2cb3 in DB::Exception::Exception<unsigned long> (this=0x7fffd5c5a240, code=49, fmt=..., args=@0x7fffffffc7e8: 4) at Exception.h:40
   5  0x00007fffdbf4d201 in DB::VersionNumber::VersionNumber (this=0x7fffffffcc20, vec=...) at VersionNumber.cpp:17
   6  0x00007fffdbf4d650 in DB::VersionNumber::fromString (version=..., strict=true) at VersionNumber.cpp:57
   7  0x00005555555db53d in VersionNumber_fromString_Test::TestBody (this=0x7fffd5c12330) at gtest_version_number.cpp:24

b) regular build

   $ src/unit_tests_dbms --gtest_filter=VersionNumber*
   Running main() from ../contrib/googletest/googletest/src/gtest_main.cc
   Note: Google Test filter = VersionNumber*
   [==========] Running 2 tests from 1 test suite.
   [----------] Global test environment set-up.
   [----------] 2 tests from VersionNumber
   [ RUN      ] VersionNumber.VersionNumber
   [       OK ] VersionNumber.VersionNumber (0 ms)
   [ RUN      ] VersionNumber.fromString
   [       OK ] VersionNumber.fromString (495 ms)
   [----------] 2 tests from VersionNumber (495 ms total)

   [----------] Global test environment tear-down
   Segmentation fault (core dumped)

   (gdb) bt
   0  testing::TestInfo::should_run (this=0xe0) at gtest.h:760
   1  0x00007ffff7f6edd5 in testing::TestSuite::ShouldRunTest (test_info=0xe0) at gtest.h:1009
   2  0x00007ffff7f6ebb2 in testing::internal::CountIf<std::__1::vector<testing::TestInfo*, std::__1::allocator<testing::TestInfo*> >, bool (*)(testing::TestInfo const*)> (c=..., predicate=0x7ffff7f6edc0 <testing::TestSuite::ShouldRunTest(testing::TestInfo const*)>)
      at gtest-internal-inl.h:294
   3  0x00007ffff7f41ae5 in testing::TestSuite::test_to_run_count (this=0x7fffd5028500) at gtest.cc:2919
   4  0x00007ffff7f41719 in testing::internal::SumOverTestSuiteList (case_list=..., method=(int (testing::TestSuite::*)(const testing::TestSuite * const)) 0x7ffff7f41ac0 <testing::TestSuite::test_to_run_count() const>) at gtest.cc:377
   5  0x00007ffff7f41ab9 in testing::internal::UnitTestImpl::test_to_run_count (this=0x7fffd5d5c000) at gtest.cc:1012
   6  0x00007ffff7f4b59d in testing::UnitTest::test_to_run_count (this=0x7ffff7fbcb80 <testing::UnitTest::GetInstance()::instance>) at gtest.cc:5059
   7  0x00007ffff7f4c4ed in testing::internal::PrettyUnitTestResultPrinter::OnTestIterationEnd (this=0x7fffd5ca4a68, unit_test=...) at gtest.cc:3589
   8  0x00007ffff7f4daf9 in testing::internal::TestEventRepeater::OnTestIterationEnd (this=0x7fffd5c83770, unit_test=..., iteration=0) at gtest.cc:3852
   9  0x00007ffff7f57570 in testing::internal::UnitTestImpl::RunAllTests (this=0x7fffd5d5c000) at gtest.cc:5737
   10 0x00007ffff7fa3a84 in testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> (object=0x7fffd5d5c000,
      method=(bool (testing::internal::UnitTestImpl::*)(testing::internal::UnitTestImpl * const)) 0x7ffff7f56f20 <testing::internal::UnitTestImpl::RunAllTests()>, location=0x7ffff7f11d9b "auxiliary test code (environments or event listeners)") at gtest.cc:2589
   11 0x00007ffff7f71788 in testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> (object=0x7fffd5d5c000,
      method=(bool (testing::internal::UnitTestImpl::*)(testing::internal::UnitTestImpl * const)) 0x7ffff7f56f20 <testing::internal::UnitTestImpl::RunAllTests()>, location=0x7ffff7f11d9b "auxiliary test code (environments or event listeners)") at gtest.cc:2625
   12 0x00007ffff7f56ea3 in testing::UnitTest::Run (this=0x7ffff7fbcb80 <testing::UnitTest::GetInstance()::instance>) at gtest.cc:5291
2021-06-14 10:38:26 +03:00
Azat Khuzhin
5cc03535bf Set -Wno-covered-switch-default for unit_tests_dbms
Otherwise code that uses EXPECT_EXIT() fails with -Werror

v2: adjust only unit_tests_dbms, not googltest via
contrib/CMakeListst.txt itself.
2021-06-14 10:38:26 +03:00
Azat Khuzhin
c08daa3ca5 Detect linux version at runtime (for worked nested epoll)
The #22109 adds the check but at compilation time, which is pointless,
move the check into runtime.

Remember nested epoll is required for
async_socket_for_remote/use_hedged_requests, otherwise remote queries
may stuck.
2021-06-14 10:38:26 +03:00
alexey-milovidov
34d12063f8
Merge pull request #23349 from azat/dist-respect-insert_allow_materialized_columns
Respect insert_allow_materialized_columns for INSERT into Distributed()
2021-06-14 07:23:00 +03:00
Alexey Milovidov
39515083e4 Remove broken check for non-production feature 2021-06-14 04:14:38 +03:00
Alexey Milovidov
19f8f0241d Fix strange typo 2021-06-14 04:11:16 +03:00
alexey-milovidov
77721734ed
Merge pull request #21267 from filimonov/kafka-failover
Kafka failover issue fix
2021-06-14 01:42:42 +03:00
Alexey Milovidov
d0aa387e64 Fixed the annoying Arcadia, it is bogging my weekend. 2021-06-13 23:53:49 +03:00
alexey-milovidov
103ecf48e0
Merge pull request #25247 from ClickHouse/minor-changes-2
Minor change
2021-06-13 23:45:58 +03:00
alexey-milovidov
99cfa9f463
Merge pull request #25248 from matwey/missed_include_condition_variable
Add missed #include <condition_variable>
2021-06-13 22:55:10 +03:00
Matwey V. Kornilov
797b29d082 Add missed #include <condition_variable>
std::condition_variable is used for wait_table_finally_dropped

Signed-off-by: Matwey V. Kornilov <matwey.kornilov@gmail.com>
2021-06-13 22:14:05 +03:00
Alexey Milovidov
6738774722 Minor change 2021-06-13 21:54:55 +03:00
Alexey Milovidov
93b907931d Fix the annoying ya.make. 2021-06-13 21:21:44 +03:00
Maksim Kita
d36703fb78
Merge pull request #25246 from kitaisreal/add-to-json-string-to-ya-make
Add function toJSONString to ya.make
2021-06-13 19:19:13 +03:00
Maksim Kita
ca785c5a6f Add function toJSONString to ya.make 2021-06-13 18:17:07 +03:00
alexey-milovidov
a293979353
Merge pull request #25210 from ClickHouse/database_replicated_tests_parallel
Try run tests with Replicated database in parallel
2021-06-13 16:40:21 +03:00
alexey-milovidov
a2c6b98b94
Merge pull request #25146 from oxidecomputer/master
Adds a better way to include binary resources
2021-06-13 16:13:34 +03:00
Kseniia Sumarokova
bc8be8bc99
Merge pull request #25234 from meoww-bot/patch-1
Update odbc.md
2021-06-13 12:19:09 +03:00
Maksim Kita
da2c8c2f46
Merge pull request #25237 from meoww-bot/patch-3
Create zh translation for mongodb.md
2021-06-13 12:10:18 +03:00
Maksim Kita
43a0c730ba
Merge pull request #25203 from kitaisreal/dictionaries-attribute-support-default-nullable-type
Dictionaries attribute support default nullable type
2021-06-13 11:46:53 +03:00
Benjamin Naecker
fcd0eafb6d Adds full cross-compilation support when embedding binary resources 2021-06-12 15:54:21 -07:00
Maksim Kita
de115cfc8c
Merge pull request #25198 from kitaisreal/dictionary-added-update-field-documentation
Dictionary added update field documentation
2021-06-13 01:22:26 +03:00
Maksim Kita
084bcb389c Fixed tests 2021-06-12 23:44:59 +03:00
Vladimir
494107e437
Merge pull request #25130 from gyuton/gyuton-DOCSUP-8425-Document-max_distributed_depth-setting 2021-06-12 22:17:04 +03:00
meoww-bot
16340b8d8e
Create mongodb.md 2021-06-13 02:07:29 +08:00
meoww-bot
165e9da464
Update odbc.md 2021-06-13 01:20:29 +08:00
Maksim Kita
b16e801fb4 Added update_lag option documentation 2021-06-12 18:42:00 +03:00
alexey-milovidov
2377a802bc
Merge pull request #25196 from kitaisreal/added-executable-pool-documentation
Added ExecutablePool documentation
2021-06-12 18:01:46 +03:00
Nikolai Kochetov
8e80bf16cf
Merge pull request #24920 from ClickHouse/test-key-condition-mon
Update something in KeyCondition
2021-06-12 17:58:27 +03:00
Maksim Kita
314fe86565 Updated documentationg 2021-06-12 13:56:53 +03:00
Maksim Kita
2a016f52e9 Added tests 2021-06-12 13:53:03 +03:00
Ivan
0092cc61cf
Enable back the ANTLR in .sql (#25170)
* Enable back the ANTLR in .sql

* Update skip-list

* More tests to skip-list
2021-06-12 04:09:36 +03:00
alexey-milovidov
7c048a9dc8
Merge pull request #23976 from excitoon-favorites/s3unstablereads
Improved `test_storage_s3_get_unstable`
2021-06-12 04:04:29 +03:00
mergify[bot]
ab2a1a410f
Merge branch 'master' into test-key-condition-mon 2021-06-12 00:32:38 +00:00
alexey-milovidov
5b98f0eddb
Merge pull request #24855 from ClickHouse/rename-const-context-ptr
Rename ContextConstPtr to ContextPtr.
2021-06-12 03:25:33 +03:00
alexey-milovidov
05d1af153c
Merge branch 'master' into rename-const-context-ptr 2021-06-12 03:25:09 +03:00
alexey-milovidov
3792d20061
Merge pull request #24863 from azat/echo-hint
clickhouse-client: echo hint improvements
2021-06-12 03:23:54 +03:00
alexey-milovidov
16114c38c7
Merge pull request #24875 from ClickHouse/fix_woboq_build
Trying to resurrect woboq
2021-06-12 03:18:37 +03:00
alexey-milovidov
b64950b193
Merge pull request #25045 from kssenii/odbc-fixes
odbc fix
2021-06-12 03:13:39 +03:00
alexey-milovidov
abe206f4fc
Merge pull request #25037 from nvartolomei/nv/queue-entry-wait-dead-code
Update waitForTableReplicaToProcessLogEntry comments
2021-06-12 03:11:13 +03:00
alexey-milovidov
fea7917917
Merge pull request #25144 from vzakaznikov/testflows_windows_functions_add_lag_and_lead_in_frame_tests
Adding leadInFrame/lagInFrame window functions TestFlows tests
2021-06-12 03:00:18 +03:00
alexey-milovidov
99f108d704
Merge pull request #25162 from kitaisreal/rewrite-function-to-subcolumn-visitor-add-into-ya-make
RewriteFunctionToSubcolumnVisitor add into ya.make
2021-06-12 02:58:53 +03:00
alexey-milovidov
8bb3d22a51
Merge pull request #25128 from qoega/better-hdfs-tests
Better hdfs tests
2021-06-12 02:47:18 +03:00
alexey-milovidov
12260d115b
Merge pull request #25113 from qoega/better-odbc-integration-test
Better odbc integration test
2021-06-12 02:46:11 +03:00
alexey-milovidov
f96b512ffb
Merge pull request #24728 from qoega/remove-enable-dictionaries
Remove explicit enable_dictionaries files in integration tests
2021-06-12 02:45:25 +03:00
alexey-milovidov
320f253912
Merge pull request #25022 from amosbird/initialquerystarttimefix
Add initial_query_start_time to query log
2021-06-12 02:41:24 +03:00
alexey-milovidov
a5380d6b46
Merge pull request #25218 from MaxWk/enable-s3-in-osx
enable s3 in osx
2021-06-12 02:38:19 +03:00
alexey-milovidov
f81212d560
Merge pull request #24897 from excitoon/patch-5
Fixed problems with double spaces in logs for `S3Common`
2021-06-12 02:36:30 +03:00
alexey-milovidov
971c79611b
Merge branch 'master' into patch-5 2021-06-12 02:36:13 +03:00