Commit Graph

60278 Commits

Author SHA1 Message Date
Kseniia Sumarokova
baa6e60cfd
Merge pull request #66009 from ClickHouse/fix-s3queue-flaky-tests
Fix flaky test_storage_s3_queue tests
2024-07-05 09:59:52 +00:00
Raúl Marín
8076e3ae60
Merge branch 'master' into exp_settings 2024-07-05 11:18:27 +02:00
Robert Schulze
4dca031e9d
Merge pull request #66100 from rschu1ze/bump-azure
Bump Azure to 1.12
2024-07-05 09:11:00 +00:00
Antonio Andelic
d777a7a941
Reduce one more time 2024-07-05 08:38:09 +01:00
Pablo Marcos
6848c2e0ac
Merge pull request #65838 from pamarcos/bitshift-throw-error-for-negative-shift-positions
Throw an error in `bitShift*` if the shift position is out-of-bounds
2024-07-05 07:05:25 +00:00
kevinyhzou
a92d6b0761 Merge branch 'master' into support_orc_reader_timezone 2024-07-05 10:27:39 +08:00
Anton Popov
7fbe5a7915
Merge pull request #63636 from CurtizJ/azure-refactoring
Refactoring near azure blob storage
2024-07-05 00:27:14 +00:00
Nikita Taranov
6a40628bff
Merge pull request #65470 from ClickHouse/cgroup_mem_observer
Fix CgroupsMemoryUsageObserver
2024-07-04 23:10:20 +00:00
Nikolay Degterinsky
59607413a0
Merge pull request #65801 from ClickHouse/evillique-patch-1
Update StorageMaterializedView.cpp
2024-07-04 22:22:52 +00:00
Vitaly Baranov
e428542b2e Add prometheus protobufs. 2024-07-04 23:06:14 +02:00
avogar
04f20f6a68 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-dynamic-subcolumns-in-analyzer 2024-07-04 21:02:04 +00:00
pufit
0a5ee12f0b
Merge pull request #62103 from ClickHouse/pufit/fuzz-query
FuzzQuery table function
2024-07-04 20:46:47 +00:00
Nikita Mikhaylov
3a7c98399f
Merge pull request #65777 from ClickHouse/make_analyzer_important
Make `allow_experimental_analyzer` be controlled by the initiator for distributed queries
2024-07-04 20:38:40 +00:00
Antonio Andelic
ec6739120c
Merge pull request #66041 from ClickHouse/try-disabling-jemalloc-background-threads
Try disabling jemalloc background threads
2024-07-04 20:30:39 +00:00
Michael Kolupaev
d394278b1b Merge remote-tracking branch 'origin/master' into ms 2024-07-04 18:44:18 +00:00
Michael Kolupaev
f40f46e244 Merge remote-tracking branch 'origin/ms' into ms 2024-07-04 18:44:11 +00:00
Michael Kolupaev
b98c123f3a Remove logging, if this happens again we'll have to guess again 2024-07-04 18:41:20 +00:00
vdimir
6184515817
Merge branch 'master' into vdimir/debug_02956_rocksdb_bulk_sink 2024-07-04 20:33:24 +02:00
Kruglov Pavel
eaf8475781
Merge pull request #66066 from Avogar/fix-memory-engine-dynamic
Fix reading dynamic subcolumns from altered Memory table
2024-07-04 18:32:35 +00:00
vdimir
20f1256a2f
Debuging 02956_rocksdb_bulk_sink 2024-07-04 18:29:09 +00:00
avogar
f556f2cd95 Try to fix special build 2024-07-04 18:28:22 +00:00
Nikita Taranov
ad23d211b9 impl 2024-07-04 18:56:26 +01:00
Anton Popov
e7c0ff54c9 fix tests 2024-07-04 17:19:35 +00:00
Nikolai Kochetov
4271b2b6e3 Add noreturn/ 2024-07-04 16:29:32 +00:00
Anton Popov
86a2fbf3f1 Merge remote-tracking branch 'upstream/master' into HEAD 2024-07-04 16:18:30 +00:00
Anton Popov
7f2bfc5f14 Merge remote-tracking branch 'upstream/master' into HEAD 2024-07-04 16:13:30 +00:00
Anton Popov
14f54cb6e9 slightly better calculation of primary index 2024-07-04 15:44:16 +00:00
Robert Schulze
2c94218120
Random header fixes for libcxx 16 2024-07-04 15:39:50 +00:00
Pablo Marcos
13f4d0d7cf Merge branch 'master' into bitshift-throw-error-for-negative-shift-positions 2024-07-04 14:54:18 +00:00
Pablo Marcos
e7e2b0953c Prevent another possible buffer overflow 2024-07-04 14:50:51 +00:00
Anton Popov
f8ea14da5d fix function 'has' with LowCardinality and FixedString 2024-07-04 14:50:00 +00:00
Vitaly Baranov
6bf1320870
Merge pull request #66061 from vitlibar/fix-shutdown-in-grpc-server
Fix shutdown in GRPCServer
2024-07-04 14:33:59 +00:00
divanik
4815f0d6ff Resolve conflicts 2024-07-04 14:09:43 +00:00
jsc0218
6e181ab383
Merge pull request #65594 from jsc0218/DropProjInLWD
Add options in lightweight delete on table with projections
2024-07-04 14:03:29 +00:00
Sema Checherinda
19816401c4
Merge pull request #61601 from ClickHouse/chesema-dedup-matview
insertion deduplication on retries for materialised views
2024-07-04 13:52:52 +00:00
Nikolai Kochetov
3776fafc88 Print stacktrace in case of about after logical error. 2024-07-04 13:44:44 +00:00
Sema Checherinda
7be481decf init 2024-07-04 15:44:06 +02:00
alesapin
9d10647544 Merge remote-tracking branch 'origin/master' into fix_prewhere_without_columns 2024-07-04 15:37:33 +02:00
Antonio Andelic
975e8ee14a
Merge pull request #65910 from ClickHouse/keeper-remove-standalone-build
Remove standalone Keeper build
2024-07-04 12:14:42 +00:00
Antonio Andelic
613ed1ebbf Merge branch 'master' into try-disabling-jemalloc-background-threads 2024-07-04 13:58:26 +02:00
Antonio Andelic
c93d8cbb66 Fixes 2024-07-04 13:57:47 +02:00
Nikita Mikhaylov
fe6a875c74 Make the setting back IMPORTANT + fix build 2024-07-04 11:12:27 +00:00
Nikita Mikhaylov
fcabefa8f3 Automatically disabling 2024-07-04 11:12:27 +00:00
Nikita Mikhaylov
d57375181d Better 2024-07-04 11:12:27 +00:00
Nikita Mikhaylov
dd3eb538f6 Better 2024-07-04 11:12:27 +00:00
Nikita Mikhaylov
6ea4c10121 Done 2024-07-04 11:12:26 +00:00
Kseniia Sumarokova
fc73c068ac
Merge pull request #66034 from azat/config-merge-from_env-replace-fix
Fix config merging for from_env with replace overrides
2024-07-04 10:01:07 +00:00
kssenii
7ae85fda3f Restore previous order 2024-07-04 11:46:17 +02:00
kssenii
4cf0625f70 Merge remote-tracking branch 'origin/master' into fix-s3queue-flaky-tests 2024-07-04 11:44:52 +02:00
kssenii
bfc755c000 Fix shutdown 2024-07-04 11:44:24 +02:00
Robert Schulze
9b98abac42
Merge pull request #66050 from ClickHouse/regex-cache-profile-events
Add profile events for regex cache
2024-07-04 08:48:26 +00:00
vdimir
e68c8b6587
Merge branch 'master' into vdimir/join_on_null_fix 2024-07-04 10:41:01 +02:00
lgbo-ustc
87978327d6 fixed 2024-07-04 15:44:11 +08:00
lgbo-ustc
b6782d4b2d update 2024-07-04 15:44:11 +08:00
lgbo-ustc
297b65dbbe fixed 2024-07-04 15:44:11 +08:00
lgbo-ustc
e52828abf9 fixed typos 2024-07-04 15:44:11 +08:00
lgbo-ustc
7f706dd9d1 fixed 2024-07-04 15:44:10 +08:00
lgbo-ustc
04e7b11a64 fixed style 2024-07-04 15:44:10 +08:00
lgbo-ustc
13d5b336ad check window frame 2024-07-04 15:44:10 +08:00
lgbo-ustc
6e231eedcf fixed style 2024-07-04 15:44:10 +08:00
lgbo-ustc
e38e105e20 add window function percent_rank 2024-07-04 15:44:10 +08:00
Antonio Andelic
fe42d2ffe4
Lower sampling rate 2024-07-04 08:10:40 +01:00
Yakov Olkhovskiy
dd662ed4ad Merge remote-tracking branch 'upstream/master' into patch-5 2024-07-04 03:22:37 +00:00
kevinyhzou
99015189a4 Merge branch 'master' into support_orc_reader_timezone 2024-07-04 10:39:14 +08:00
kevinyhzou
45a73dc3b5 fast test 2024-07-04 10:37:55 +08:00
Yakov Olkhovskiy
e11b48c7b5 fix 2024-07-03 23:04:13 +00:00
Kruglov Pavel
41b9216dd1
Fix build 2024-07-04 00:22:41 +02:00
Nikolay Degterinsky
615d5501d0
Merge pull request #66038 from ClickHouse/evillique-patch-2
Fix lock-order-inversion in DatabaseCatalog
2024-07-03 21:15:20 +00:00
Anton Popov
e56507a73e
Merge pull request #58661 from CurtizJ/enable-optimize_functions_to_subcolumns
Enable `optimize_functions_to_subcolumns` by default
2024-07-03 20:44:19 +00:00
Robert Schulze
9f1b3e2979
Merge pull request #65983 from arenadata/ADQM-1971
Fix support of non-const scale arguments in rounding functions
2024-07-03 20:22:49 +00:00
Nikita Taranov
1b6ef06a91 review fixes 2024-07-03 21:14:28 +01:00
Nikita Taranov
39cf64bec1 Merge branch 'master' into cgroup_mem_observer 2024-07-03 20:54:01 +01:00
Nikita Taranov
37851686ad better variable name 2024-07-03 20:47:07 +01:00
Nikita Taranov
fc36a449c6
Merge branch 'master' into concurrent_hash_join_cache_ht_sizes 2024-07-03 21:29:10 +02:00
Nikita Taranov
8cb7936838 dedicated setting for joins 2024-07-03 20:28:01 +01:00
Vitaly Baranov
ecfe6fddcf Move function HTTPHandler::formatExceptionForClient() to a separate header in order to reuse it. 2024-07-03 21:23:09 +02:00
Vitaly Baranov
49b982747a Move function authenticateUserByHTTP() to a separate header in order to reuse it. 2024-07-03 21:23:09 +02:00
Vitaly Baranov
25dc96aaca Simplify initialization of settings in HTTPHandler. 2024-07-03 21:23:09 +02:00
Vitaly Baranov
bf56ad69dd Make Context::setCurrentRoles() check that new current roles are granted in order to make HTTPHandler's implementation easier. 2024-07-03 21:23:09 +02:00
Vitaly Baranov
29ed1c9bf8 Move function exceptionCodeToHTTPStatus() from HTTPHandler.cpp to a separate header in order to reuse it. 2024-07-03 21:23:09 +02:00
avogar
877445c88d Fix reading dynamic subcolumns from altered Memory table 2024-07-03 19:21:12 +00:00
Nikita Taranov
bbbf6cd6f9 remove todo 2024-07-03 19:41:05 +01:00
Nikita Taranov
b243e4d0fb Merge branch 'master' into concurrent_hash_join_cache_ht_sizes 2024-07-03 19:35:48 +01:00
jsc0218
b8e355f9d8
Merge branch 'master' into DropProjInLWD 2024-07-03 14:23:49 -04:00
Kruglov Pavel
a5adf31b9e
Fix special build 2024-07-03 19:30:36 +02:00
Robert Schulze
9d79bd9625
Merge pull request #65792 from rschu1ze/stats-refactoring
Refactor statistics interface
2024-07-03 17:26:09 +00:00
Robert Schulze
77aec8a301
Merge pull request #65985 from rschu1ze/fix-error-messages
More aesthetic error messages
2024-07-03 17:22:57 +00:00
Antonio Andelic
d688d4114c
Rename events 2024-07-03 18:16:45 +01:00
Raúl Marín
bfd91d1e72 Merge remote-tracking branch 'blessed/master' into exp_settings 2024-07-03 18:55:48 +02:00
Antonio Andelic
045cb0a581 Increase special allocation sampling 2024-07-03 18:50:33 +02:00
Antonio Andelic
5875694669 Fix includes 2024-07-03 18:48:32 +02:00
Vitaly Baranov
e8701dc4e4 Fix shutdown in GRPCServer. 2024-07-03 18:18:23 +02:00
Alexander Tokmakov
3a4d05f54a
Merge pull request #63963 from ClickHouse/vdimir/replicateddb_forbid_populate
Forbid POPULATE with Replicated databases
2024-07-03 15:43:43 +00:00
Robert Schulze
790b66d921
Merge pull request #66059 from rschu1ze/remove-comment
Remove obsolete comment
2024-07-03 15:42:20 +00:00
Robert Schulze
ee3c530817
Remove obsolete comment 2024-07-03 15:41:24 +00:00
jsc0218
73c440b38d Merge remote-tracking branch 'origin/master' into DropProjInLWD 2024-07-03 15:37:10 +00:00
avogar
6530ae104d Fix tests 2024-07-03 15:23:01 +00:00
pufit
9a023744a5 fix build 2024-07-03 11:13:39 -04:00
Antonio Andelic
07f51e02ed Reuse some checks 2024-07-03 16:54:09 +02:00
Robert Schulze
8319d25797
Minor updates 2024-07-03 14:43:47 +00:00
avogar
d03fcb5ff1 Fix 2024-07-03 14:23:38 +00:00
Antonio Andelic
cddd2312fb Merge branch 'master' into keeper-remove-standalone-build 2024-07-03 16:23:31 +02:00
Antonio Andelic
ce4d361cd7 Merge branch 'master' into keeper-remove-standalone-build 2024-07-03 16:23:06 +02:00
alesapin
c96e3c6d1a Fix which I don't understand 2024-07-03 16:21:36 +02:00
Antonio Andelic
1c14a458e7 Add profile events for regex cache 2024-07-03 16:14:19 +02:00
avogar
63303dd798 Fix style 2024-07-03 14:03:04 +00:00
avogar
5fe594243a Remove old file 2024-07-03 13:53:30 +00:00
avogar
ea3b0e735d Refactor JSONExtract functions and support more types and reuse its code in new JSON type 2024-07-03 13:40:41 +00:00
Daniil Ivanik
4ab2d514e6
Merge pull request #65993 from ClickHouse/divanik/fix_size_column_in_s3_archives
Fix bug with _size of archives in s3 table function
2024-07-03 13:38:01 +00:00
gabrielmcg44
97b5c78b8b clearer comment 2024-07-03 10:25:37 -03:00
Anton Popov
a3c0f09bb1
Merge branch 'master' into enable-optimize_functions_to_subcolumns 2024-07-03 15:17:35 +02:00
Mikhail Gorshkov
97e2c8c7d2 PR review follow-up 2024-07-03 12:56:20 +00:00
Konstantin Morozov
4a460760a7 Merge branch 'master' into add_log_clear_detached_tables 2024-07-03 12:38:53 +00:00
Sema Checherinda
3a09000e44 remove trailing whitespaces 2024-07-03 14:33:21 +02:00
Yarik Briukhovetskyi
d3ede543bb
Merge pull request #65936 from hanfei1991/hanfei/exception-storage-join
add restriction for storage join
2024-07-03 12:32:16 +00:00
Nikita Taranov
36e557652f
Merge pull request #65940 from ClickHouse/add_table_name_to_mt_source_spans
Add table name to MergeTreeSource spans
2024-07-03 12:26:09 +00:00
Nikolay Degterinsky
6d3d33638a
Fix lock-order-inversion in DatabaseCatalog 2024-07-03 14:22:33 +02:00
Nikita Mikhaylov
3c62ffd752
Merge pull request #66005 from ClickHouse/cancelled-twice
Fix printing `Query was cancelled` twice
2024-07-03 12:20:29 +00:00
Sema Checherinda
913e97b1a5 work with review comments 2024-07-03 14:06:05 +02:00
alesapin
23c04fa110
Merge pull request #65999 from ClickHouse/fix_azure_profile_events
Add more Azure profile events + rename AzureUploadPart to AzureStageBlock
2024-07-03 11:54:29 +00:00
Sema Checherinda
c4207e9a6e
Update src/Interpreters/InterpreterInsertQuery.cpp
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2024-07-03 13:48:45 +02:00
Sema Checherinda
f0aa006461
Update src/Interpreters/InterpreterInsertQuery.cpp
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2024-07-03 13:48:32 +02:00
Sema Checherinda
aee1289f2d
Update src/Interpreters/InterpreterInsertQuery.cpp
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2024-07-03 13:48:04 +02:00
Sema Checherinda
5c88d5b48a
Update src/Interpreters/InterpreterInsertQuery.cpp
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2024-07-03 13:47:55 +02:00
Sema Checherinda
8777363670
Update src/Processors/Transforms/DeduplicationTokenTransforms.h
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2024-07-03 13:47:45 +02:00
vdimir
7a993d737b
better 2024-07-03 11:45:31 +00:00
Sema Checherinda
c082930265 rename to buildPreAndSinkChains 2024-07-03 13:43:27 +02:00
Raúl Marín
dd28947e82
Update Settings.h 2024-07-03 13:41:39 +02:00
Sema Checherinda
10d48afc20 token_info is defined always 2024-07-03 13:16:01 +02:00
Robert Schulze
6ccb26b1aa
Switch to a virtual interface to get rid of static_pointer_cast 2024-07-03 10:38:51 +00:00
Azat Khuzhin
5f53a73457 Fix config merging for from_env with replace overrides
Without this patch new test fails with:

    Exception: Failed to preprocess config '/etc/clickhouse-server/config.xml': Exception: Element <max_thread_pool_size> has value and does not have 'replace' attribute, can't process from_env substitution. Stack trace:

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-07-03 12:24:17 +02:00
Robert Schulze
9f4e44bfc4
Rename XStatistics to StatisticsX
Makes the naming more consistent with the rest of the codebase, e.g.
- MergeTreeIndexSet
- MergeTreeIndexMinMax

or
- StorageJoin
- StorageMergeTree

etc.
2024-07-03 10:13:15 +00:00
Robert Schulze
337871e0ec
Move some methods around
Makes the order of methods within classes consistent. Did not touch the
code itself.
2024-07-03 10:13:15 +00:00
Robert Schulze
198b80b6a2
Cosmetics
No code was harmed in the process (really just cosmetics).
2024-07-03 10:13:15 +00:00
Raúl Marín
601ee4ee3e
Update Settings.h 2024-07-03 12:08:02 +02:00
Kseniia Sumarokova
cfafbc388c
Fix test_drop_table 2024-07-03 11:56:07 +02:00
Raúl Marín
d199a243fa Move experimental settings to the experimental block 2024-07-03 11:34:35 +02:00
alesapin
706dd14367 Merge branch 'master' into fix_prewhere_without_columns 2024-07-03 11:25:58 +02:00
alesapin
4066d82ca3
Merge pull request #65970 from ClickHouse/keeper-fix-race-snapshot
Fix data race for Keeper snapshot queue
2024-07-03 09:20:07 +00:00
Kseniia Sumarokova
188261913c
Merge pull request #65949 from ClickHouse/fix-tmp-data-in-cache-assertion
Fix logical error "Expected ReadBufferFromFile, but got DB::EmptyReadBuffer"
2024-07-03 08:54:10 +00:00
Robert Schulze
6079373ce3
Incorporate review feedback 2024-07-03 08:36:16 +00:00
kevinyhzou
9341bbe197 ORC read use writer time zone 2024-07-03 16:36:08 +08:00
Antonio Andelic
e3beff45c1
Merge pull request #65918 from ClickHouse/add-some-tools-for-keeper-profiling
Add extra profiling helpers for Keeper
2024-07-03 07:01:13 +00:00
Antonio Andelic
3779d89f30 Merge branch 'master' into gwp-asan-disable-stacktrace-by-default 2024-07-03 08:54:30 +02:00
pufit
bcf8a93a52 max_query_length argument for the fuzzQuery 2024-07-03 01:34:25 -04:00
gun9nir
be9a17f2cc feat: implicitly append wildcard if querying directory in file engine 2024-07-02 21:42:59 -07:00
pufit
497ab310be Merge branch 'master' into pufit/fuzz-query
# Conflicts:
#	src/Storages/registerStorages.cpp
2024-07-03 00:02:54 -04:00
Yakov Olkhovskiy
92126e6a12 Merge remote-tracking branch 'upstream/master' into fix_unexpected_cte_projection_name 2024-07-03 03:54:13 +00:00
Yakov Olkhovskiy
6128f53f63 fix 2024-07-03 02:56:47 +00:00
jsc0218
91f44476a7
Merge pull request #65945 from Algunenano/setting_247
Fix SettingsChangesHistory 24.7
2024-07-03 01:46:54 +00:00
Yakov Olkhovskiy
84fb836ecb proper qualification for CTE, fix tests 2024-07-02 23:27:02 +00:00
Anton Popov
e99dac2f65
Merge branch 'master' into enable-optimize_functions_to_subcolumns 2024-07-03 00:55:16 +02:00
Kseniia Sumarokova
9f1152301e
Merge pull request #65986 from ClickHouse/fix-race-in-s3queue
Fix race in s3queue
2024-07-02 22:01:09 +00:00
Daniil Ivanik
97215f473a
Merge branch 'master' into divanik/fix_size_column_in_s3_archives 2024-07-02 22:26:38 +02:00
Robert Schulze
0afccecd6b
Fix build 2024-07-02 19:35:58 +00:00
Robert Schulze
a6c8509b32
Merge pull request #65818 from pamarcos/bittest-throw-error-if-out-of-bounds
Throw an error in `bitTest*` if the bit position is out-of-bounds
2024-07-02 19:03:10 +00:00
Kseniia Sumarokova
188e9536e1
Merge pull request #63201 from ClickHouse/fix-partitioned-delta-lake
Support reading partitioned DeltaLake data, infer DeltaLake schema by reading metadata instead of data
2024-07-02 18:02:08 +00:00
Robert Schulze
659020dc86
More aesthetic error messages 2024-07-02 17:43:29 +00:00
Robert Schulze
1821638d5e
Replace validateArgumentType() by validateFunctionArguments() 2024-07-02 17:43:29 +00:00
vdimir
6fadbf1cf1
Merge branch 'master' into vdimir/replicateddb_forbid_populate 2024-07-02 18:38:42 +02:00
Robert Schulze
0ed3466124
Cleanup FunctionArgumentDescriptor
const char * can be nullptr, std::string_view can't.
2024-07-02 16:30:48 +00:00
Pablo Marcos
389a86ec05 Sort error codes alphabetically 2024-07-02 16:20:42 +00:00
Kseniia Sumarokova
bdc7157670
Merge pull request #65839 from ClickHouse/fix-s3-queue-memory-usage
Fix s3queue memory usage
2024-07-02 16:19:33 +00:00
kssenii
21f0eb2eec Do not use async initialization of readers in s3queue 2024-07-02 18:13:49 +02:00
Pablo Marcos
7a7633a230 Simplify logic in corner case to avoid comparing doubles
The case for > bit_limit is already covered in previous branch,
so we just need to cover the other case.

This also fixes an overflow that was caused in previous check. e.g.
b > B(word_size * n) if sizeof(B) is 1 byte but n is huge
2024-07-02 16:10:46 +00:00
avogar
02de441246 Remove unrelated files 2024-07-02 15:55:26 +00:00
Nikita Mikhaylov
b5af73a299 Better 2024-07-02 15:48:10 +00:00
alesapin
4ac30aa7d5 Fxi style 2024-07-02 17:18:14 +02:00
avogar
2f083fd1a7 Fix resolving dynamic subcolumns in analyzer 2024-07-02 15:08:14 +00:00
Pablo Marcos
d567a0e247 Merge branch 'master' into bitshift-throw-error-for-negative-shift-positions 2024-07-02 14:48:35 +00:00
alesapin
8dfa8d6df4 Add more Azure profile events + AzureUploadPart to AzureStageBlock 2024-07-02 16:42:42 +02:00
gabrielmcg44
b9b030d0aa better comment 2024-07-02 11:37:38 -03:00
gabrielmcg44
df086999ff remove redundant type cast 2024-07-02 11:37:38 -03:00
gabrielmcg44
dd1eccd32f fix brackets 2024-07-02 11:37:38 -03:00
gabrielmcg44
7d7750e29b remove brackets 2024-07-02 11:37:37 -03:00
gabrielmcg44
6a0d912b1c remove trailing spaces 2024-07-02 11:37:37 -03:00
gabrielmcg44
9821c042f1 fix tie handling issue 2024-07-02 11:37:37 -03:00
Antonio Andelic
cfa86b54ea Review fixes 2024-07-02 16:33:06 +02:00
Nikita Mikhaylov
bfc0260f35
Merge pull request #65972 from ClickHouse/remove-weirdness-parquet
Remove unnatural punctuation from Parquet
2024-07-02 13:59:03 +00:00
jsc0218
6831280a83 Merge remote-tracking branch 'origin/master' into DropProjInLWD 2024-07-02 13:37:48 +00:00
Sema Checherinda
f6a2c3156b rename transform 2024-07-02 15:24:29 +02:00
Sema Checherinda
06e235024f work with review 2024-07-02 15:16:57 +02:00
divanik
70a2061c9b Fixed bug and added test 2024-07-02 12:27:01 +00:00
Han Fei
dcb69758f4 Merge branch 'master' into hanfei/exception-storage-join 2024-07-02 13:54:30 +02:00
Alexey Milovidov
6f586edba3
Merge pull request #65852 from CurtizJ/offload-outdated-index
Unload primary index of outdated parts
2024-07-02 11:48:55 +00:00
Robert Schulze
a9d05bc349
Merge remote-tracking branch 'ClickHouse/master' into bittest-throw-error-if-out-of-bounds 2024-07-02 11:47:15 +00:00
Kruglov Pavel
15b32b6d0c
Merge branch 'master' into data-types-binary-encoding 2024-07-02 13:26:43 +02:00
Konstantin Bogdanov
138eb924fa
Merge pull request #65626 from tonickkozlov/tonickkozlov/x509-san-validation
Add support for x509 SubjectAltName identification
2024-07-02 11:20:01 +00:00
kssenii
f2c06becd5 Fix race in s3queue 2024-07-02 13:17:28 +02:00
Antonio Andelic
39932938e2 Merge branch 'master' into merge-tree-parallel-replicas-custom-key 2024-07-02 12:59:39 +02:00
Mikhail Gorshkov
baa4d50067 Fix support of non-const scale arguments in power function 2024-07-02 10:51:58 +00:00
avogar
a2f7d8e13f Add missing settings in schema inference cache 2024-07-02 10:42:12 +00:00
vdimir
422b8dea31
Add database_replicated_allow_heavy_create to settings changes 2024-07-02 12:30:22 +02:00
vdimir
87e2fb4f74
Merge branch 'master' into vdimir/replicateddb_forbid_populate 2024-07-02 12:28:47 +02:00
vdimir
530ce95d62
Merge pull request #65816 from canhld94/fix_rocksdb_ttl
Fix EmbeddedRocksDB with TTL writes corrupted data
2024-07-02 10:27:36 +00:00
kssenii
f778ddd7bc Merge remote-tracking branch 'origin/master' into fix-tmp-data-in-cache-assertion 2024-07-02 12:12:08 +02:00
Kseniia Sumarokova
a905b24f75
Fix clang-tidy 2024-07-02 11:54:56 +02:00
Alexey Milovidov
4613b23c37
Merge pull request #65634 from ClickHouse/fix-object-storage
Speed up loading of plain_rewritable disks; fix many bugs in ObjectStorage
2024-07-02 09:31:29 +00:00
Raúl Marín
d9909cb251
Merge branch 'master' into setting_247 2024-07-02 11:31:16 +02:00
vdimir
59bf6f16bd
Merge pull request #64818 from bigo-sg/too_large_hash_join
Refactor `HashJoin` to avoid `too large translation units`
2024-07-02 09:12:02 +00:00
vdimir
b94dd515c7
Merge pull request #65887 from bigo-sg/improve_concat
Allow to use `concat` function with empty arguments
2024-07-02 09:11:30 +00:00
Alexey Milovidov
dc8a8d9719 Remove unnatural punctuation from Parquet 2024-07-02 10:56:44 +02:00
Antonio Andelic
a0f6751c4d Merge branch 'master' into add-some-tools-for-keeper-profiling 2024-07-02 10:50:24 +02:00
Antonio Andelic
9e586f0871 Fixes 2024-07-02 10:50:21 +02:00
Antonio Andelic
aaffa64cdd Fix data race for Keeper snapshot queue 2024-07-02 10:36:20 +02:00
Pablo Marcos
93c1b5d8a7 Address issues pointed out in the PR 2024-07-02 08:21:51 +00:00
Antonio Andelic
91e27ea7f4 Merge branch 'master' into gwp-asan-disable-stacktrace-by-default 2024-07-02 09:13:38 +02:00
Alexey Milovidov
350711ec53 Merge branch 'master' into fix-object-storage 2024-07-02 08:17:59 +02:00
Alexey Milovidov
9d8cc51dc5
Merge pull request #65917 from azat/mysql-server-TLS-retries
Fix possible issues with MySQL server protocol TLS connections
2024-07-02 05:06:55 +00:00
Alexey Milovidov
3b1e1d01d4
Merge pull request #65848 from ClickHouse/Add_missing_workload_identity_changes
Add missing workload identity changes
2024-07-02 04:35:31 +00:00
Alexey Milovidov
0bb374b597 Fix error (tnx, @jkartseva) 2024-07-02 06:19:21 +02:00
Alexey Milovidov
e07cd70a1e Merge branch 'master' into fix-object-storage 2024-07-02 06:17:55 +02:00
Alexey Milovidov
3d67e6b127
Merge pull request #65928 from ClickHouse/follow-up-to-65046
Follow up to #65046
2024-07-02 03:27:08 +00:00
Alexey Milovidov
8a8b6a881b
Merge pull request #58970 from ClickHouse/dont-optimize-trivial-insert-select
Disable `optimize_trivial_insert_select` by default
2024-07-02 01:33:23 +00:00
kssenii
27e0e57054 Use ReadBufferFromFileBase instead of ReadBufferFromFile for reread_buffer_from_file 2024-07-01 22:47:36 +02:00
kssenii
d4312fe54b Fix 2024-07-01 21:55:45 +02:00
Raúl Marín
447c0db2bc Fix SettingsChangesHistory 24.7 2024-07-01 20:11:19 +02:00
divanik
4d85603e13 Fix build problems 2024-07-01 17:56:26 +00:00
Smita Kulkarni
ac648a1fe3 Fix build 2024-07-01 19:41:45 +02:00
Nikolay Degterinsky
60a0cefb03 Merge remote-tracking branch 'upstream/master' into evillique-patch-1 2024-07-01 17:41:29 +00:00
Nikita Taranov
9d3ddfb47f
Merge branch 'master' into add_table_name_to_mt_source_spans 2024-07-01 17:41:04 +02:00
Nikita Taranov
adcaf117a1 impl 2024-07-01 16:38:39 +01:00
divanik
a163007325 Change creation criteria of a local disk 2024-07-01 15:33:34 +00:00
Anton Popov
e439921d37 slightly better 2024-07-01 15:31:32 +00:00
Han Fei
f596f0f66a add restriction for storage join 2024-07-01 16:59:49 +02:00
Pablo Marcos
12608d2090 Improve exception text 2024-07-01 14:22:32 +00:00
avogar
6573b5436e Add docs about dynamic binary format 2024-07-01 14:21:11 +00:00
Anton Popov
884af52e09 Merge remote-tracking branch 'upstream/master' into HEAD 2024-07-01 14:17:03 +00:00
Anton Popov
7c1d4a1965 Merge remote-tracking branch 'upstream/master' into HEAD 2024-07-01 14:10:14 +00:00
kssenii
5541461b99 Fix time of writing to _log table 2024-07-01 16:04:43 +02:00
kssenii
5e7a8245c4 Fix memory leak 2024-07-01 15:40:49 +02:00
Maksim Kita
c43ce89a62 PostgreSQL source cancel query comments 2024-07-01 16:27:10 +03:00
Antonio Andelic
7361407ea5 Fix test 2024-07-01 15:25:00 +02:00
Azat Khuzhin
4f2a0e8eeb Fix possible issues with MySQL server protocol TLS connections
The problem here is that retries (in SecureSocketImpl.cpp::mustRetry())
relies on non-zero socket timeout, but MySQL handler does not set
timeouts for the socket (like other does), and this leads to a problem
when OpenSSL returns SSL_ERROR_WANT_READ/SSL_ERROR_WANT_WRITE, the
connection will be simply terminated.

I've played with this patch, by hacking the openssl sources:

    diff --git a/crypto/bio/bss_sock.c b/crypto/bio/bss_sock.c
    index 82f7be85ae..a399291ff4 100644
    --- a/crypto/bio/bss_sock.c
    +++ b/crypto/bio/bss_sock.c
    @@ -124,7 +125,18 @@ static int sock_read(BIO *b, char *out, int outl)
                 ret = ktls_read_record(b->num, out, outl);
             else
     # endif
    -            ret = readsocket(b->num, out, outl);
    +        {
    +            /* pthread_kill(pthread_self(), SIGUSR1); */
    +            static int i = 0;
    +            if (!(++i % 2))
    +            {
    +                fprintf(stderr, "sock_read: inject EAGAIN\n");
    +                ret = -1;
    +                errno = EAGAIN;
    +            }
    +            else
    +                ret = readsocket(b->num, out, outl);
    +        }
             BIO_clear_retry_flags(b);
             if (ret <= 0) {
                 if (BIO_sock_should_retry(ret))

And after this patch this succeed without errors:

    ch benchmark -c10 -q "SELECT * FROM mysql('127.0.0.1:9004', system, one, 'default', '', SETTINGS connection_pool_size=1, connect_timeout = 100, connection_wait_timeout = 100)"

Note, that this also fixes the timeouts for plain (non-TLS) connections

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-07-01 15:22:33 +02:00
Antonio Andelic
1a95259182 Add extra profiling helpers for Keeper 2024-07-01 15:17:41 +02:00
Pablo Marcos
d0506f0214 Fix more tests
One of tests actually uncovered a casting error :)
2024-07-01 12:23:56 +00:00
divanik
90601e0a1d Merge branch 'divanik/fix_clickhouse_disks_2' of github.com:divanik/ClickHouse; branch 'master' of github.com:ClickHouse/ClickHouse into divanik/fix_clickhouse_disks_2 2024-07-01 11:10:05 +00:00
Antonio Andelic
6061f2308e Merge branch 'master' into gwp-asan-disable-stacktrace-by-default 2024-07-01 12:39:35 +02:00
Pablo Marcos
0b24a416b5 Also throw error if bit shift positions is greater than the bit width of value 2024-07-01 10:31:29 +00:00
avogar
22eb2fe006 Merge branch 'master' of github.com:ClickHouse/ClickHouse into data-types-binary-encoding 2024-07-01 10:19:31 +00:00
Nikolai Kochetov
5a6e6d3c5d
Merge pull request #65771 from kitaisreal/postgresql-source-support-cancel-query
PostgreSQL source support cancel query
2024-07-01 10:17:01 +00:00
Anton Kozlov
b1b9aaf2ec Add support for x509 SubjectAltName identification 2024-07-01 09:47:28 +00:00
Antonio Andelic
4a9daa202d Remove Keeper standalone build 2024-07-01 11:24:45 +02:00
vdimir
632ad5156d
Merge branch 'master' into fix_rocksdb_ttl 2024-07-01 11:01:08 +02:00
taiyang-li
4fcafde610 allow empty arguments for concat 2024-07-01 15:29:32 +08:00
Antonio Andelic
50c1121c6a
Merge pull request #65735 from ClickHouse/fix-keeper-session-close-bug
Fix bug with session closing in Keeper
2024-07-01 07:12:33 +00:00
Antonio Andelic
15d9ad65c6 Reduce even more 2024-07-01 09:01:32 +02:00
Antonio Andelic
a4a5204e1d Merge branch 'master' into gwp-asan-disable-stacktrace-by-default 2024-07-01 09:01:09 +02:00
Antonio Andelic
43bd12f86b
Merge pull request #65819 from ClickHouse/keeper-respect-cgroup-cpu
Respect cgroup CPU limit in Keeper
2024-07-01 06:57:43 +00:00
Duc Canh Le
047dcfb806 fix undefined LOGICAL_ERROR
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-07-01 04:39:53 +00:00
Alexey Milovidov
97311bd51f Merge branch 'master' of github.com:ClickHouse/ClickHouse into dont-optimize-trivial-insert-select 2024-06-30 20:56:54 +02:00
Igor Nikonov
2fcca61fe9
Merge pull request #65769 from ClickHouse/fix-progress-bar-read-in-order
Fix: progress bar for read in order queries
2024-06-30 18:07:13 +00:00
Alexey Milovidov
06d0f2fd5d Merge branch 'master' into dont-optimize-trivial-insert-select 2024-06-30 18:52:28 +02:00
Robert Schulze
c72ce5be8a
Merge remote-tracking branch 'ClickHouse/master' into patch-1 2024-06-30 08:55:58 +00:00
Robert Schulze
235133aa5c
Move code from header to source file 2024-06-30 08:50:28 +00:00
Robert Schulze
8fdb3b83e0 Fix style 2024-06-30 10:33:54 +08:00
Robert Schulze
cec2aba6bb Some fixups 2024-06-30 10:33:54 +08:00
cw5121
b97158f5b6 implement with std::initializer_list 2024-06-30 10:33:44 +08:00
cw5121
10a0eb1712 fix 2024-06-30 10:33:32 +08:00
Robert Schulze
0bff61de13 Move parsedatetime_parse_without_leading_zeros to the right place 2024-06-30 10:33:28 +08:00
cw5121
b6500bcdf1 Fix and prevent compatibility settings from becoming not effective 2024-06-30 10:32:43 +08:00
jsc0218
004d913c56 change option to enum and add test 2024-06-30 02:14:28 +00:00
Alexey Milovidov
cbe0eb83db Fix error 2024-06-30 03:39:14 +02:00
Alexey Milovidov
238b65cf26 Fix trash 2024-06-30 01:41:39 +02:00
Alexey Milovidov
6b53abbfab Merge branch 'master' into fix-object-storage 2024-06-30 01:35:51 +02:00
Alexey Milovidov
01c4301165 Merge branch 'master' into dont-optimize-trivial-insert-select 2024-06-29 21:52:21 +02:00
Alexey Milovidov
e72d54ce34
Merge pull request #65246 from ClickHouse/fix-flaky-cli-completion-test
Fix flaky autocompletion test
2024-06-29 16:43:40 +00:00
jsc0218
a06e82e8ee Merge remote-tracking branch 'origin/master' into DropProjInLWD 2024-06-29 14:37:03 +00:00
Duc Canh Le
cf2f2cfc1c use writeBinaryLittleEndian
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-06-29 14:14:36 +00:00
Alexey Milovidov
1531aeb029
Merge pull request #65635 from ClickHouse/dont-load-outdated-parts-on-readonly
Do not load inactive parts on readonly disks
2024-06-29 13:45:07 +00:00
Kseniia Sumarokova
5a6666d330
Merge pull request #63348 from ClickHouse/small-refactoring-for-tmp-data-in-cache
Make write to temporary data in cache do all checks and assertions as during write to ordinary cache
2024-06-29 09:40:50 +00:00
Alexey Milovidov
9113981d0c Merge branch 'master' into dont-load-outdated-parts-on-readonly 2024-06-29 04:38:44 +02:00
Alexey Milovidov
3649e209c4 Merge branch 'master' into dont-optimize-trivial-insert-select 2024-06-29 04:34:00 +02:00
Anton Popov
db0beabb1c less load under mutex 2024-06-29 02:31:24 +00:00
Anton Popov
e1b1c454e2 unload primary key of oudated parts 2024-06-29 01:46:05 +00:00
Sema Checherinda
05dbb241f5 adjust logging 2024-06-29 01:35:59 +02:00
Sema Checherinda
abe58184df Merge branch 'master' into chesema-dedup-matview 2024-06-29 01:35:32 +02:00
Anton Popov
d4b71ea4cb fix settings changes 2024-06-28 23:09:08 +00:00
Anton Popov
21633b259b Merge remote-tracking branch 'upstream/master' into HEAD 2024-06-28 23:08:29 +00:00
Alexander Tokmakov
4748e2929f
Merge pull request #65570 from ClickHouse/keeper_az
Improve ZooKeeper load balancing
2024-06-28 22:57:20 +00:00
Smita Kulkarni
95932db170 Add missing workload identity changes 2024-06-28 22:01:12 +02:00
Alexander Tokmakov
c97ef5dc32
Merge pull request #65405 from Avogar/check-cyclic-dependencies-on-create
Check cyclic dependencies on CREATE/REPLACE/RENAME/EXCHANGE queries
2024-06-28 16:28:14 +00:00
Alexander Tokmakov
6dd4fcae37
Merge pull request #65746 from ClickHouse/tavplubix-patch-14
Always optimize `ClientBase::parseAndCheckOptions`
2024-06-28 15:59:55 +00:00
kssenii
c63263fe39 One more 2024-06-28 17:56:51 +02:00
kssenii
9864508b05 Fix 2024-06-28 17:51:08 +02:00
Pablo Marcos
898dd8bb8e Throw exception in bitShift for negative shift positions 2024-06-28 15:20:15 +00:00
vdimir
8e770c7046
fix 2024-06-28 15:19:33 +00:00
Han Fei
8f086d7eff
Merge pull request #65820 from ClickHouse/vdimir/fix_hash_join_any_last_row
Propogate join_any_take_last_row to hash join in any query
2024-06-28 15:19:06 +00:00
SmitaRKulkarni
ccfe7c0121
Merge pull request #64757 from azat/load-part-without-columns.txt
Fix filling parts columns from metadata (when columns.txt does not exists)
2024-06-28 15:16:39 +00:00
vdimir
f95434f4c0
Better handling join on nulls 2024-06-28 15:08:06 +00:00
Anton Popov
31c65a4092 add settings to change history 2024-06-28 14:29:30 +00:00
Anton Popov
6957241388 Merge remote-tracking branch 'upstream/master' into HEAD 2024-06-28 14:19:13 +00:00
Kseniia Sumarokova
fbdbbf5a78
Fix typo 2024-06-28 15:17:35 +02:00
kssenii
f25147aefd Review fixes 2024-06-28 14:57:53 +02:00
Kseniia Sumarokova
2673a773c3
Merge pull request #65458 from ClickHouse/add-azure-queue-storage
Add AzureQueue storage
2024-06-28 12:39:05 +00:00
Maksim Kita
f61d1052e2 PostgreSQL source support cancel query 2024-06-28 15:16:10 +03:00
Konstantin Bogdanov
c8497c81b7
Lint 2024-06-28 13:59:16 +02:00
vdimir
8e034c499f
Propigate join_any_take_last_row to hash join in any query 2024-06-28 11:58:10 +00:00
Antonio Andelic
fa7bad4993 Decrease sampling rate slightly 2024-06-28 13:51:42 +02:00
Antonio Andelic
ba25964503 Merge branch 'master' into gwp-asan-disable-stacktrace-by-default 2024-06-28 13:51:30 +02:00