Commit Graph

79 Commits

Author SHA1 Message Date
Alexey Milovidov
8966520801 Added "assert_cast" function as a replacement for static_cast for columns 2019-08-21 05:28:04 +03:00
Alexander Kuzmenkov
9df09f3506 Do not access shared arenas in aggregate function columns.
These arenas may be updated concurrently, so it is unsafe to
access them, as illustrated by issue #4402. Store them separately
and use a different arena for the updates. Change some callers
to accomodate for this.
2019-07-18 14:21:37 +03:00
Nikolai Kochetov
1034295f04 Fixed UInt32 overflow bug in linear models. Allow eval ML model for non-const model argument. 2019-06-03 08:11:15 +03:00
Alexander Kozhikhov
5cd85baec6 changes on return type of linearRegression 2019-05-27 23:14:23 +03:00
Alexander Kozhikhov
79010b7c3c some review fixes 2019-05-13 16:49:53 +03:00
Alexander Kozhikhov
daf4690d37 review fixes 2019-04-21 17:32:42 +03:00
Alexander Kozhikhov
b6d2c9f4d2 some review fixes 2019-04-21 02:22:42 +03:00
Alexander Kozhikhov
19021e76bb style 2019-04-15 03:16:13 +03:00
Alexander Kozhikhov
c93aae6741 linear regression 2019-04-09 01:40:37 +03:00
Alexander Kozhikhov
f550304fa4 Merge branch 'master' of https://github.com/yandex/ClickHouse 2019-04-04 03:17:37 +03:00
alexey-milovidov
6db73152d2
Hardening debug build (experimental) (#4632)
* Hardening debug build: more granular memory mappings and ASLR; add memory protection for mark cache and index

* Addition to prev. revision

* Addition to prev. revision

* Addition to prev. revision
2019-03-10 06:16:51 +03:00
Alexey Milovidov
9d89cc0fc1 Debugging PODArray 2019-03-08 06:23:02 +03:00
Vitaly Baranov
4b6cba9a8e IColumn::getPermutation() and IColumn::permutate() functions, "limit" parameter: change type UInt64 -> size_t. 2019-02-19 14:56:09 +03:00
Vitaly Baranov
833aa9189b IColumn::index() function, "limit" parameter: change type UInt64 -> size_t. 2019-02-19 14:47:41 +03:00
alexander kozhikhov
b23cd21ce1 predict correctly using scalar aggr state 2019-02-13 01:33:37 +03:00
alexander kozhikhov
aedf4925dc Merge branch 'master' into ml_methods 2019-02-12 23:04:25 +03:00
alexander kozhikhov
f20ad204e7 Merge branch 'master' of https://github.com/yandex/ClickHouse 2019-02-12 23:00:47 +03:00
Nikolai Kochetov
a4441bfba2 Fix tests. 2019-02-12 13:09:03 +03:00
Nikolai Kochetov
c35439a5f0 Updated FieldVisitor. 2019-02-11 18:46:19 +03:00
Nikolai Kochetov
85318c0bfd Merge branch 'master' into aggregate-function-state-in-field 2019-02-11 15:41:11 +03:00
Nikolai Kochetov
9787b3a1ee Added Field type AggregateFunctionState. 2019-02-11 14:19:56 +03:00
alexander kozhikhov
fc4c721fa5 some review fixes 2019-02-11 01:07:47 +03:00
alexander kozhikhov
bfccafef49 small test code 2019-02-11 00:16:16 +03:00
alexey-milovidov
0dd618b9ad
Merge pull request #4326 from yandex/duplicate-includes
Removed duplicate includes
2019-02-10 22:31:37 +03:00
Alexey Milovidov
e150e62040 Grouped includes (40 of 182) 2019-02-10 20:40:52 +03:00
Alexey Milovidov
c603d270f4 Cleanups #4246 2019-02-10 18:17:45 +03:00
Masha
39f1d9756e fixed name Logistic 2019-01-28 11:54:55 +00:00
Masha
286fa25ad9 logreg and momentum 2019-01-28 10:39:57 +00:00
alexander kozhikhov
57cd47a194 LinearModelData completed 2019-01-26 15:38:42 +03:00
alexander kozhikhov
b229498203 mini-batches 2019-01-23 21:03:26 +03:00
alexander kozhikhov
fd8f9c4fba changes after review 2019-01-23 04:29:53 +03:00
alexander kozhikhov
19ca2f3af8 linear regression 2019-01-23 01:18:07 +03:00
alexander kozhikhov
61bb3b8ade simple linear regression 2019-01-23 00:07:05 +03:00
Alexey Milovidov
e8328c576b Fixed UB #3926 2018-12-27 03:59:52 +03:00
Alexey Milovidov
f720a5bf95 Fixed typos in code #3373 2018-10-13 17:33:43 +03:00
Alexey Milovidov
8497af1d7f Fixed memory leak in insertion methods of ColumnAggregateFunction if the object have another as a source; exception safety [#CLICKHOUSE-2] 2018-09-09 04:16:34 +03:00
Alexey Milovidov
26587dd2bb Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 08:23:20 +03:00
Alexey Milovidov
f7107f12b4 Merge branch 'master' into extra-warnings 2018-09-02 03:13:36 +03:00
Alexey Milovidov
7d77d001f5 Full support for alignment of aggregate states #2808 2018-09-01 07:25:03 +03:00
alexey-milovidov
6d5092518f
Merge pull request #2808 from chenxing-xc/master
Aligned aggregate state  #2754
2018-09-01 05:38:11 +03:00
Alexey Milovidov
a3cd1ea8cb Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 21:16:32 +03:00
Alexey Milovidov
486d87ebcd Merge remote-tracking branch 'origin/master' into extra-warnings 2018-08-27 20:01:33 +03:00
Amos Bird
ea84430864 Get rid of useless std::move to get NRVO
http://eel.is/c++draft/class.copy.elision#:constructor,copy,elision

Some quote:

> Speaking of RVO, return std::move(w); prohibits it. It means "use move constructor or fail to compile", whereas return w; means "use RVO, and if you can't, use move constructor, and if you can't, use copy constructor, and if you can't, fail to compile."

There is one exception to this rule:
```cpp
Block FilterBlockInputStream::removeFilterIfNeed(Block && block)
{
    if (block && remove_filter)
        block.erase(static_cast<size_t>(filter_column));

    return std::move(block);
}
```

because references are not eligible for NRVO, which is another rule "always move rvalue references and forward universal references" that takes precedence.
2018-08-27 22:15:48 +08:00
Alexey Milovidov
6779de62d1 Enabling -Wextra-semi [#CLICKHOUSE-2] 2018-08-26 03:44:23 +03:00
chenxing.xc
4acc441179 fix aligned states review comments 2018-08-05 18:12:06 +08:00
chenxing.xc
90d8290d28 aligned aggregate state 2018-08-05 16:45:15 +08:00
Nikolai Kochetov
f56d16769b Added pre and post serialization for IDataType BinaryBulkWithMultipleStreams. Supported dictionary serialization format with single global dictionary (limited wit max_dictionary_size) and additional keys which are stored per granule. Changed IDataType::enumerateStream interface. Added (de)serialization params for binary bulk with multiple stream (de)serialization. Changed IColumn::index interface. 2018-06-26 17:12:21 +03:00
Nikolai Kochetov
2119469c51 added IColumn::select 2018-04-19 00:00:47 +03:00
Nikolai Kochetov
476d4b339c Immutable construction for columns 2018-03-20 22:45:10 +03:00
Alexey Milovidov
f87cc75734 Fixed build [#CLICKHOUSE-2]. 2017-12-24 13:12:49 +03:00