Commit Graph

132919 Commits

Author SHA1 Message Date
Mikhail Koviazin
a83f6be97c
SensitiveDataMasker: replace mutex with atomic_{load,store} 2024-01-17 08:10:50 +02:00
Mikhail Koviazin
9e0414f557
fix data race in SensitiveDataMasker
This commit fixes the data race that was introduced in 3067ca6. That commit
added scope lock for `getInstance` and `setInstance`, but `getInstance`
returned a pointer that could be invalidated between call for `getInstance` and
actual usage of the pointer.

This commit changes `SensitiveDataMasker` singleton from `unique_ptr` to
`shared_ptr`, so even if `setInstance` will be called right after
`getInstance`, the pointer returned from `getInstance` will live long enough to
call `wipeSensitiveData` on it.
2024-01-17 08:10:50 +02:00
Mikhail Koviazin
6e6197019c
Reintroduce commit 3067ca6
Update `query_masking_rules` when reloading the config

This reverts commit 7e55eab1c3.
2024-01-17 08:10:49 +02:00
Pradeep Chhetri
09f29b4502 Update nomenclature of variables 2024-01-17 13:52:10 +08:00
Alexey Milovidov
863c6523a3 Add a test for #47988 2024-01-17 06:48:24 +01:00
Yakov Olkhovskiy
1d9ac13418 fix test 2024-01-17 05:38:16 +00:00
Alexey Milovidov
f349a7d0c0
Merge pull request #58883 from den-crane/patch-67
Fix ambiguity in the setting description
2024-01-17 06:08:40 +01:00
Alexey Milovidov
d85abfafa4
Update KeeperAsynchronousMetrics.cpp 2024-01-17 08:05:48 +03:00
Alexey Milovidov
90e35be861
Update KeeperAsynchronousMetrics.cpp 2024-01-17 08:04:32 +03:00
Pradeep Chhetri
eafaab3795 Add metric for keeper memory soft limit 2024-01-17 12:56:18 +08:00
Yakov Olkhovskiy
e6b3f69137 style fix 2024-01-17 02:58:18 +00:00
Yakov Olkhovskiy
e06e4695e1 refactoring bzip2 buffer and fix possible data loss in internal buffer 2024-01-17 01:55:38 +00:00
Yakov Olkhovskiy
5da897ac20 fix test 2024-01-17 00:19:59 +00:00
Yakov Olkhovskiy
a9e12d7498 fix test 2024-01-16 23:40:25 +00:00
Yakov Olkhovskiy
1bda1bc839 test is added 2024-01-16 22:53:16 +00:00
Denny Crane
e4fa000f6f
Update Settings.h 2024-01-16 18:29:15 -04:00
Yakov Olkhovskiy
92d42567fa separate explicit finalization for buffers 2024-01-16 22:15:35 +00:00
Nikita Taranov
7291674013
Merge pull request #58610 from azat/stacktrace-cleanup
Refactor stacktrace symbolizer to avoid copy-paste
2024-01-16 22:22:08 +01:00
Alexander Tokmakov
38b85e6409
Merge pull request #58649 from azat/tests/test_replicated_database
Fix test_replicated_database::test_startup_without_zk flakiness
2024-01-16 21:08:33 +01:00
Blargian
a457fa34f4 Merge remote-tracking branch 'refs/remotes/origin/58363_disable_ansi_pretty_automatically' into 58363_disable_ansi_pretty_automatically 2024-01-16 20:00:04 +02:00
Blargian
1b81efc337 fix failing 02421 stateless and (hopefully) fix failing integration tests 2024-01-16 19:48:23 +02:00
Yakov Olkhovskiy
73f1ed3b69 explicit finalization for chained buffer 2024-01-16 17:02:22 +00:00
Robert Schulze
9146391e48
Merge pull request #58731 from rschu1ze/qc-quota
Query cache: Fix per-user quota
2024-01-16 17:14:45 +01:00
Dmitry Novik
80291ec3f2
Add comments 2024-01-16 16:59:04 +01:00
Dmitry Novik
f3017959ff Analyzer: add test with GROUP BY on shards 2024-01-16 15:41:02 +00:00
Dmitry Novik
c325f08e79 Fix RPN construction for indexHint 2024-01-16 15:34:45 +00:00
Antonio Andelic
4ce6b64d62 Fix 00089_group_by_arrays_of_fixed with external aggregation 2024-01-16 15:16:13 +00:00
János Benjamin Antal
1d34f4a304
Merge pull request #58809 from ClickHouse/print-entries-to-be-processed-in-trace
Increase log level to trace to help debug `00993_system_parts_race_condition_drop_zookeeper`
2024-01-16 16:14:22 +01:00
kssenii
e5d8b9b190 More lazy loading 2024-01-16 16:12:14 +01:00
Alexander Tokmakov
27fc822e0b
Merge pull request #58872 from ClickHouse/revert-58835-support-net-write-read-settings
Revert "Add support for MySQL `net_write_timeout` and `net_read_timeout` settings"
2024-01-16 15:16:32 +01:00
Antonio Andelic
f33f374ac5 Make Kovi happy 2024-01-16 15:09:49 +01:00
Alexander Tokmakov
661500a140
Revert "Add support for MySQL net_write_timeout and net_read_timeout settings" 2024-01-16 15:01:14 +01:00
Kruglov Pavel
74973c1b41
Merge pull request #58537 from sunny19930321/fix/hive-threadpool-query
Fix hive threadpool read ORC/Parquet/... Failed
2024-01-16 14:46:22 +01:00
Antonio Andelic
0f55a99fe9 Merge branch 'master' into fix-keeper-data-race 2024-01-16 13:14:49 +00:00
Nikita Taranov
7d03ccd8db
Merge pull request #58844 from nickitat/fixxxx
Fix reading from an invisible part in new (not released yet) parallel replicas coordinator
2024-01-16 14:09:21 +01:00
Nikolai Kochetov
534e086a5d
Update StorageMergeTree.cpp 2024-01-16 13:50:39 +01:00
vdimir
9b54bf465f
Merge pull request #58863 from ClickHouse/vdimir/timeout_01961_roaring_memory_tracking
Set max_bytes_before_external_group_by in 01961_roaring_memory_tracking
2024-01-16 13:07:44 +01:00
Yarik Briukhovetskyi
c9cee8c6cb
Merge pull request #58771 from yariks5s/polygon_bug_fix
Fix Segfault in `SlabsPolygonIndex::find`
2024-01-16 12:35:04 +01:00
vdimir
d2dccf9a22
Merge pull request #49703 from ClickHouse/vdimir/analyzer_join_resolve_nested
Analyzer: Fix resolving subcolumns in JOIN
2024-01-16 11:24:02 +01:00
Nikolai Kochetov
738057fec3
Update 02784_parallel_replicas_automatic_decision_join.sh 2024-01-16 11:23:14 +01:00
vdimir
07ffbc9f2a
Merge pull request #51550 from ClickHouse/vdimir/join_nested_lowcardinality_convert
Add join keys conversion for nested lowcardinality
2024-01-16 11:13:14 +01:00
vdimir
de3e7012d5
Merge pull request #58652 from ClickHouse/vdimir/analyzer_hash_join_duplicate_columns
Analyzer: Fix assertion in HashJoin with duplicate columns
2024-01-16 11:12:31 +01:00
vdimir
188cadc02b
Set max_bytes_before_external_group_by in 01961_roaring_memory_tracking 2024-01-16 10:12:00 +00:00
vdimir
54a79c1f3d
Merge pull request #58123 from ClickHouse/vdimir/cluster_discovery_password
ClusterDiscovery supports setting username and password
2024-01-16 11:05:54 +01:00
vdimir
8b108365f5
Merge pull request #58808 from ClickHouse/vdimir/json_extract_lc_fix
Fix JSONExtract function for LowCardinality(Nullable) columns
2024-01-16 11:01:10 +01:00
Kseniia Sumarokova
167b6bee1b
Merge pull request #58786 from xleoken/eos
Ecloud EOS Storage support
2024-01-16 10:05:31 +01:00
Alexey Milovidov
e708b6ed94 Fix bad log message 2024-01-16 09:45:20 +01:00
Kseniia Sumarokova
5fcf1b216b
Merge pull request #58842 from ClickHouse/fix-data-race-in-slru
fs cache: fix data race in slru
2024-01-16 08:53:41 +01:00
Alexey Milovidov
ebfea07f93
Merge pull request #58832 from kitaisreal/database-catalog-background-tasks-add-log-names
DatabaseCatalog background tasks add log names
2024-01-16 08:42:38 +01:00
Alexey Milovidov
786f37251d
Merge pull request #58835 from slvrtrn/support-net-write-read-settings
Add support for MySQL `net_write_timeout` and `net_read_timeout` settings
2024-01-16 08:42:15 +01:00