thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-30 03:22:14 +00:00
Code Issues Packages Projects Releases Wiki Activity
93,142 Commits 9,189 Branches 1,782 Tags 2.2 GiB
1cf17a0454
Commit Graph

93142 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Raúl Marín
35d3a0dd1f Don't report system.errors when the disk is not rotational 2022-07-14 11:08:26 +02:00
Azat Khuzhin
531e3b13ce Optimize accesses to system.stack_trace (filter by name before sending signal) 
Because of failed rebase/push this part of the patch was lost, so
resending separatelly (sigh).

Follow-up for: #39177 (cc @yakov-olkhovskiy)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-07-14 11:49:34 +03:00
Azat Khuzhin
3e77b80b88 Fix fetch of in-memory part with allow_remote_fs_zero_copy_replication 
CI founds the following error during trying to fetch in-memory part [1]:

    2022.07.13 08:06:54.231033 [ 141093 ] {} <Error> InterserverIOHTTPHandler: Code: 107. DB::ErrnoException: Cannot open file /var/lib/clickhouse/disks/s3/store/886/88635b40-e4e3-4fe6-a0a0-1b6755463358/all_0_0_0/data.bin, errno: 2, strerror: No such file or directory. (FILE_DOESNT_EXIST), Stack trace (when copying this message, always include the lines below):

<details>

<summary>stacktrace</summary>

    2022.07.13 08:06:54.101825 [ 189342 ] {8dbd11b3-f38a-4d5d-9ded-148987adb71d} <Debug> executeQuery: (from [::1]:54570) (comment: 01643_replicated_merge_tree_fsync_smoke.sql) select 'memory in_memory_parts_insert_sync'; (stage: Complete)
    2022.07.13 08:06:54.131309 [ 691 ] {} <Debug> test_26u6kx.rep_fsync_r2 (39c3823c-22e5-4c05-9dec-cdffd8872c40): Fetching part all_0_0_0 from /clickhouse/tables/test_26u6kx/rep_fsync/replicas/r1
    2022.07.13 08:06:54.231033 [ 141093 ] {} <Error> InterserverIOHTTPHandler: Code: 107. DB::ErrnoException: Cannot open file /var/lib/clickhouse/disks/s3/store/886/88635b40-e4e3-4fe6-a0a0-1b6755463358/all_0_0_0/data.bin, errno: 2, strerror: No such file or directory. (FILE_DOESNT_EXIST), Stack trace (when copying this message, always include the lines below):
    0. DB::Exception::Exception() @ 0xba0191a in /usr/bin/clickhouse
    1. DB::throwFromErrnoWithPath() @ 0xba029ca in /usr/bin/clickhouse
    2. DB::OpenedFile::open() const @ 0x156e7fb0 in /usr/bin/clickhouse
    3. DB::OpenedFile::getFD() const @ 0x156e8003 in /usr/bin/clickhouse
    4. DB::ReadBufferFromFilePReadWithDescriptorsCache::ReadBufferFromFilePReadWithDescriptorsCache() @ 0x156e5f23 in /usr/bin/clickhouse
    5. ? @ 0x156e53f0 in /usr/bin/clickhouse
    6. DB::createReadBufferFromFileBase() @ 0x156e52b5 in /usr/bin/clickhouse
    7. DB::DiskLocal::readFile() const @ 0x15e45ea8 in /usr/bin/clickhouse
    8. DB::MetadataStorageFromDisk::readFileToString() const @ 0x15e6ab8b in /usr/bin/clickhouse
    9. DB::MetadataStorageFromDisk::readMetadataUnlocked() const @ 0x15e6cdeb in /usr/bin/clickhouse
    10. DB::MetadataStorageFromDisk::getSerializedMetadata() const @ 0x15e6cfc4 in /usr/bin/clickhouse
    11. DB::DiskObjectStorage::getSerializedMetadata() const @ 0x15e19e2e in /usr/bin/clickhouse
    12. DB::DiskDecorator::getSerializedMetadata() const @ 0x15e54ed1 in /usr/bin/clickhouse
    13. DB::DiskDecorator::getSerializedMetadata() const @ 0x15e54ed1 in /usr/bin/clickhouse
    14. DB::DataPartsExchange::Service::sendPartFromDiskRemoteMeta() @ 0x1700bb9e in /usr/bin/clickhouse
    15. DB::DataPartsExchange::Service::processQuery(DB::HTMLForm const&, DB::ReadBuffer&, DB::WriteBuffer&, DB::HTTPServerResponse&) @ 0x1700a649 in /usr/bin/clickhouse
    16. DB::InterserverIOHTTPHandler::processQuery(DB::HTTPServerRequest&, DB::HTTPServerResponse&, DB::InterserverIOHTTPHandler::Output&) @ 0x17433c53 in /usr/bin/clickhouse
    17. DB::InterserverIOHTTPHandler::handleRequest(DB::HTTPServerRequest&, DB::HTTPServerResponse&) @ 0x174344f1 in /usr/bin/clickhouse
    18. DB::HTTPServerConnection::run() @ 0x1768714d in /usr/bin/clickhouse
    19. Poco::Net::TCPServerConnection::start() @ 0x1a398093 in /usr/bin/clickhouse
    20. Poco::Net::TCPServerDispatcher::run() @ 0x1a399411 in /usr/bin/clickhouse
    21. Poco::PooledThread::run() @ 0x1a54b7bb in /usr/bin/clickhouse
    22. Poco::ThreadImpl::runnableEntry(void*) @ 0x1a548ec0 in /usr/bin/clickhouse
    23. ? @ 0x7fdf1c204609 in ?
    24. clone @ 0x7fdf1c129133 in ?
     (version 22.7.1.1781 (official build))

</details>

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/0/8b6e31cc615ca52c80724b6e5097777cb9514f07/stateless_tests__release__s3_storage__actions_.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-07-14 11:43:35 +03:00
Vladimir C
66f2ea5ebb
Merge pull request #39123 from vdimir/fjs-pushdown 
Pushdown filter to the right side of sorting join
 2022-07-14 09:32:19 +02:00
Robert Schulze
110862a11e
Merge pull request #38502 from ClibMouse/Issue_38498 
Fixed bug in parsing {..} regex
 2022-07-14 08:27:31 +02:00
Yakov Olkhovskiy
d6a09acb38
Merge pull request #39177 from azat/stack_trace-filter 
Optimize accesses to system.stack_trace
 2022-07-14 01:47:14 -04:00
Yakov Olkhovskiy
887a34869d
merge_reason and merge_algorithm are added 2022-07-14 01:44:19 -04:00
Yakov Olkhovskiy
d108efa2f6
merge_algorithm is added 2022-07-14 01:36:45 -04:00
Nikolay Degterinsky
7ae2f624cc
Merge pull request #39188 from morozovsk/patch-11 
Documentation: Functions hasAny and hasAll also can use a Bloom filter.
 2022-07-14 02:50:22 +02:00
Nikolay Degterinsky
cfe7413678
Merge pull request #38935 from evillique/translate 
Add functions translate & translateUTF8
 2022-07-14 02:31:37 +02:00
DanRoscigno
add169278b fix indent and link 2022-07-13 19:27:33 -04:00
Nikolai Kochetov
dc20b85078 Remove debug output. 2022-07-13 21:08:23 +00:00
Nikolai Kochetov
9528f7e753
Merge branch 'master' into bug-lost-column 2022-07-13 23:06:38 +02:00
Nikolai Kochetov
ba863b11a4 A little fix. Added test. 2022-07-13 21:06:15 +00:00
Kseniia Sumarokova
b4321904bf
Update test.py 2022-07-13 22:59:14 +02:00
Nikolai Kochetov
812143c76b
Merge pull request #39160 from azat/threadpool-fix 
ThreadPool fixes
 2022-07-13 22:54:57 +02:00
Nikolai Kochetov
ee0f7658b5
Merge pull request #39173 from ClickHouse/add-test-for-39132 
Add test for #39132
 2022-07-13 22:53:59 +02:00
Dan Roscigno
997ed35a01
Merge pull request #39196 from DanRoscigno/add-migration-to-new-system 
add migration example
 2022-07-13 15:54:17 -04:00
Anton Popov
5cb3b25754
Merge pull request #39161 from amosbird/text-log-source-regexp 
Control send logs behavior with source name regexp
 2022-07-13 21:13:54 +02:00
DanRoscigno
7ce5757d90 add migration example 2022-07-13 15:07:20 -04:00
Igor Nikonov
b7f46d954e Cleanup: related to #38719 (SortingStep: deduce way to sort based on input stream sort) 2022-07-13 17:57:37 +00:00
Sergei Trifonov
15ab3bc99f use context->getWriteSettings() 2022-07-13 19:48:57 +02:00
Sergei Trifonov
af4a5a5f3a fix conflicts 2022-07-13 19:44:29 +02:00
Kseniia Sumarokova
61ce5161f3
Merge pull request #39106 from kssenii/cache-cacth-disk-full-on-cache-write 
fs cache: continue without exception when getting no disk space left error
 2022-07-13 19:08:13 +02:00
Sergei Trifonov
f854507729 merge master and resolve conflicts 2022-07-13 19:07:28 +02:00
mergify[bot]
79e6f85412
Merge branch 'master' into mapupdate_dev 2022-07-13 17:06:51 +00:00
alesapin
f81650e94a Fix extremely rare condition in hardlinks creation 2022-07-13 19:03:48 +02:00
Sergei Trifonov
60c6a5b23c fix s3 read/write throttling instant 2022-07-13 18:36:08 +02:00
Vladimir Goncharov
189de392fd
Update mergetree.md 
Functions hasAny and hasAll also can use a Bloom filter.
 2022-07-13 19:20:32 +03:00
Dmitry Novik
9e4f516f35
Merge pull request #39112 from ClickHouse/window-expressions-fix 
Fix ActionsDAG construction for window expressions
 2022-07-13 18:19:01 +02:00
Dmitry Novik
14aa62f661 Fix test output 2022-07-13 16:14:51 +00:00
Kseniia Sumarokova
765503cd61
Update test.py 2022-07-13 17:55:24 +02:00
Heena Bansal
76cbfedd2a
Merge branch 'master' into Issue_38498 2022-07-13 11:50:26 -04:00
Kseniia Sumarokova
71aba5b4c6
Merge pull request #38860 from kssenii/object-storages-refactor 
Refactoring of code around object storages, added LocalObjectStorage (extracted this diff from PR #36171)
 2022-07-13 16:51:56 +02:00
Azat Khuzhin
3720a3843c Add merge_algorithm to system.part_log 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-07-13 17:16:25 +03:00
Yakov Olkhovskiy
3fd367ea58 check metadata_snapshot is not empty 2022-07-13 10:08:24 -04:00
Alexey Milovidov
d8b1b44a29
Merge branch 'master' into align-branch-within-32b 2022-07-13 16:53:34 +03:00
Robert Schulze
87197f8f60
Enable -Wdeprecated-dynamic-exception-spec 2022-07-13 13:49:40 +00:00
Vladimir C
27ec36ca91
Merge pull request #37648 from vdimir/enable_parallel_hash 
Bugfixes and performance improvements for parallel_hash
 2022-07-13 14:52:57 +02:00
Azat Khuzhin
68789895a4 ThreadPool: incapsulate Poco::Event and std:🧵:id into State struct 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-07-13 15:51:49 +03:00
HeenaBansal2009
e9dcc7d05a try to fix flaky test as suggested in review comments 2022-07-13 05:49:03 -07:00
Azat Khuzhin
7ffa15b94b ThreadPool: fix thread_id assignment 
As found by @KochetovNicolai before this patch, lambda in
ThreadFromGlobalPool() ctor assigns value only to a copy of the
thread_id value, and so check in joinable() had been working
incorrectly, fix this by changing the value not the shared_ptr itself.

Also it is not safe to assign thread_id w/o atomics, since this can be
racy, so wrap id with std::atomic<>

Fixes: #28431
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-07-13 15:42:46 +03:00
Azat Khuzhin
25eb82f120 ThreadPool: do not use joinable() internally 
joinable() should be used only outside, since internally it is enough to
know `state` to know that something is wrong.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-07-13 15:42:46 +03:00
Azat Khuzhin
3473b80077 ThreadPool: add some clarification comments 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-07-13 15:42:46 +03:00
Alexander Tokmakov
635e527234
Merge pull request #39176 from ClickHouse/tavplubix-patch-1 
Suppression for BC check (`Cannot parse string 'Hello' as UInt64`)
 2022-07-13 15:25:34 +03:00
Nikolai Kochetov
83c3670f2a Fix style 2022-07-13 12:23:01 +00:00
Alexander Tokmakov
991493e6fc
Update run.sh 2022-07-13 15:22:36 +03:00
Azat Khuzhin
8122c1b07f Optimize accesses to system.stack_trace 
- filter by thread_id
- filter by thread_name
- filter by requested columns (query_id/trace, thread_name)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-07-13 15:17:09 +03:00
vdimir
4124dc9ac4
Rewrite tryPushDownFilter for join with lambda 2022-07-13 12:06:29 +00:00
Nikolai Kochetov
37f0d96e36 Add test for #39132 2022-07-13 12:04:42 +00:00