thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-29 19:12:03 +00:00
Code Issues Packages Projects Releases Wiki Activity
98,250 Commits 9,187 Branches 1,782 Tags 2.2 GiB
1d6c6c7144
Commit Graph

98250 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Alexey Milovidov
5d9e125c71 Fix clang-tidy 2022-09-19 00:28:32 +02:00
Igor Nikonov
e888859396 Fix: correct sort description for ReadFromMergeTree with read in order 
optimization
 2022-09-18 22:21:13 +00:00
Azat Khuzhin
2141665c68 Fix clang-tidy build 
Tidy report [1]:

    src/AggregateFunctions/CMakeFiles/clickhouse_aggregate_functions.dir/AggregateFunctionCategoricalInformationValue.cpp.o -c ../src/AggregateFunctions/AggregateFunctionCategoricalInformationValue.cpp
    /build/build_docker/../src/AggregateFunctions/AggregateFunctionCategoricalInformationValue.cpp:38:15: error: method 'counter' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]
        Counter & counter(AggregateDataPtr __restrict place, size_t i, bool what) const
                  ^                                                               ~~~~~
        static
    /build/build_docker/../src/AggregateFunctions/AggregateFunctionCategoricalInformationValue.cpp:43:21: error: method 'counter' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]
        const Counter & counter(ConstAggregateDataPtr __restrict place, size_t i, bool what) const
                        ^                                                                    ~~~~~
        static
    178520 warnings generated.

  [1]: https://s3.amazonaws.com/clickhouse-builds/41459/64b44be513607d59e4b89dd9fb518b8cf4acba21/clickhouse_special_build_check/report.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-09-18 22:04:12 +02:00
alesapin
a5a9d89fb9
Merge branch 'master' into enable_projections_and_zero_copy 2022-09-18 17:20:08 +02:00
alesapin
e4c120742e Add missed throw expression 2022-09-18 16:56:19 +02:00
alesapin
560bc2bc22
Merge pull request #41386 from ClickHouse/fix_redundant_fetch 
Fix redundant fetch in zero copy replication
 2022-09-18 15:57:27 +02:00
alesapin
1d0dbfb112
Merge pull request #41444 from ClickHouse/one_wrong_config_assert 
One more validation for broken config in keeper
 2022-09-18 15:56:48 +02:00
Kruglov Pavel
519bcbb3be
Merge pull request #41236 from Avogar/fix-totals-extremes 
Don't output totals/extremes in all row formats, update docs
 2022-09-18 14:55:07 +02:00
Kseniia Sumarokova
d6748b182f
Update CachedOnDiskWriteBufferFromFile.cpp 2022-09-18 14:48:24 +02:00
Vitaly Baranov
e7e51ab2d9 Add comments. 2022-09-18 12:44:05 +02:00
Vitaly Baranov
69996c960c Add retries for the initialization of ReplicatedAccessStorage. 2022-09-18 12:44:05 +02:00
Vitaly Baranov
5365b105cc Add SYSTEM RELOAD USERS command. 2022-09-18 12:44:00 +02:00
Vitaly Baranov
1b40f94c6b Move common code from MemoryAccessStorage and DiskAccessStorage to IAccessStorage. 2022-09-18 12:17:15 +02:00
Alexey Milovidov
56fd38de44 Add a test for #38383 2022-09-18 10:38:10 +02:00
Alexey Milovidov
3eb7ee8308 Remove noise from build process 2022-09-18 10:35:25 +02:00
Azat Khuzhin
64b44be513 Account any IO that is done from ThreadPoolReader 
In case of some issues with the disk it is possible that
preadv2(RWF_NOWAIT)==EAGAIN can take a lot of time, so let's measure
even this case.

I've verified with a simple (almost) loop of preadv2(RWF_NOWAIT), and
got this:

    EAGAIN: 8565670 (out of 17148317)
    EAGAIN: 8565670 (out of 17148317)
    EAGAIN: 8565670 (out of 17148317)
    too long at offset=8691694, ret=18446744073709551615 (14.5016)
    too long at offset=8694766, ret=18446744073709551615 (14.4338)
    too long at offset=8694766, ret=18446744073709551615 (16.2144)

So here you can see that preadv2(RWF_NOWAIT) took 14-16 seconds in case
of failure.

Complete code can be found here [1].

  [1]: https://gist.github.com/azat/f4a6b0750316c42bec021064e0a7627c

I came up with this patch because I saw some stranginess in
ProfileEvents, that does not show all the time that was spend in IO when
pread_threadpool method was used.
Also there was some stranginess with trace_log too.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-09-18 10:05:21 +02:00
Alexey Milovidov
4f75d818e8 Add a test for #31631 2022-09-18 09:56:29 +02:00
Alexey Milovidov
ca7b4a8737 Merge branch 'fix-trash-schema-inference' into pod-array-overflow 2022-09-18 09:26:05 +02:00
Alexey Milovidov
7e6da853cd Merge branch 'master' into pod-array-overflow 2022-09-18 09:24:23 +02:00
Alexey Milovidov
a6e3ab5515 Fix error 2022-09-18 09:21:57 +02:00
Alexey Milovidov
5c75a7d661 Fix error 2022-09-18 09:20:48 +02:00
Alexey Milovidov
c41e37fa8e Code simplification 2022-09-18 08:58:32 +02:00
Alexey Milovidov
3c43d6516b Fix style 2022-09-18 08:56:52 +02:00
Alexey Milovidov
bafc5f24c7 Merge branch 'master' into remove-trash-5 2022-09-18 08:56:02 +02:00
Alexey Milovidov
7e0f617910 Fix tests 2022-09-18 08:54:48 +02:00
Alexey Milovidov
12e950ae95 Fix tests 2022-09-18 08:49:48 +02:00
Alexey Milovidov
1d279ad6b6 Fix tests 2022-09-18 08:47:55 +02:00
Alexey Milovidov
76aaecf1aa
Merge pull request #41450 from ClickHouse/remove-s3-sample-block-cache 
Remove too long test from the test suite with S3
 2022-09-18 09:44:07 +03:00
Alexey Milovidov
498c4cf445 Fix test 2022-09-18 08:42:48 +02:00
Alexey Milovidov
8764fa4439 Fix very strange behavior of Apache ORC 2022-09-18 08:25:25 +02:00
Alexey Milovidov
6607bf0f5c
Merge pull request #41384 from Algunenano/insert_stats 
Check the behaviour of query_log read/write stats in INSERT queries
 2022-09-18 07:57:05 +03:00
Alexey Milovidov
7e93dbfcd6
Merge pull request #41094 from HarryLeeIBM/hlee-s390x-zlib-ng 
Fix zlib-ng build issue for s390x
 2022-09-18 07:55:20 +03:00
Alexey Milovidov
26965818c2
Merge pull request #41163 from azat/bump-replxx 
Bump replxx to fix possible uncaught exception
 2022-09-18 07:53:50 +03:00
Alexey Milovidov
a958751c98
Merge pull request #40219 from den-crane/test/zvonand-monotonic 
test for datetime64 monotonic #39864
 2022-09-18 07:48:49 +03:00
Alexey Milovidov
6b752bff3a
Merge branch 'master' into revert_prefixes_s3 2022-09-18 07:10:57 +03:00
Alexey Milovidov
32efe6952e
Merge pull request #41429 from ClickHouse/forbid-dlopen-2 
Forbid invocations of `dlopen`
 2022-09-18 07:05:56 +03:00
Alexey Milovidov
6d1e851dcc Fix tests 2022-09-18 05:25:21 +02:00
Alexey Milovidov
097cbf11e7 Fix tests 2022-09-18 05:20:30 +02:00
Alexey Milovidov
00ba819611
Update 00632_get_sample_block_cache.sql 2022-09-18 06:18:22 +03:00
Alexey Milovidov
791de6592b Remove trash from Field 2022-09-18 05:16:08 +02:00
Alexey Milovidov
c8c728e740
Merge pull request #41449 from ClickHouse/fix-categorial-information 
Fix incorrect properties of `categorialInformationValue` function
 2022-09-18 05:26:26 +03:00
Alexey Milovidov
7f68f2c7df Remove trash from LowCardinality 2022-09-18 04:13:21 +02:00
Alexey Milovidov
25dfbba8dd Merge branch 'forbid-dlopen-2' of github.com:ClickHouse/ClickHouse into forbid-dlopen-2 2022-09-18 02:25:12 +02:00
Alexey Milovidov
15e5fc96a1 Add a trap 2022-09-18 02:24:56 +02:00
Alexey Milovidov
515972f459 Merge branch 'master' into forbid-dlopen-2 2022-09-18 02:20:22 +02:00
Alexey Milovidov
f7edbeba22 Remove too long test from the test suite with S3 2022-09-18 02:19:12 +02:00
Alexey Milovidov
45dc3faeca
Merge pull request #41438 from ClickHouse/integration-tests-remove-trash 
Remove trash from integration tests
 2022-09-18 03:16:44 +03:00
Alexey Milovidov
dc76677eb2
Merge pull request #41440 from ClickHouse/remove-cruft 
Remove cruft about gcc
 2022-09-18 03:15:26 +03:00
Alexey Milovidov
e3dafdb865 More hardening 2022-09-18 02:10:06 +02:00
Alexey Milovidov
e5e3bca3ae More hardening and tests 2022-09-18 02:05:13 +02:00