Commit Graph

18296 Commits

Author SHA1 Message Date
Alexey Milovidov
ea643eeff9 Miscellaneous #2758 2018-08-28 03:03:10 +03:00
Alexey Milovidov
7c777c48d7 Miscellaneous #2758 2018-08-28 03:01:03 +03:00
Alexey Milovidov
0a7e288d70 Miscellaneous #2758 2018-08-28 02:59:49 +03:00
Alexey Milovidov
bab6cd504d Miscellaneous #2758 2018-08-27 22:16:38 +03:00
Alexey Milovidov
24bd803c07 Whitespaces #2758 2018-08-27 22:06:32 +03:00
Alexey Milovidov
f5cc5ef877 Merge branch 'CLICKHOUSE-3847' of https://github.com/VadimPE/ClickHouse into VadimPE-CLICKHOUSE-3847 2018-08-27 22:04:14 +03:00
alexey-milovidov
ea18b79b8e
Merge pull request #2972 from proller/fix3
Test fixes
2018-08-27 21:57:14 +03:00
proller
cc86cb503e clickhouse-test-server with temporary data dir 2018-08-27 21:32:50 +03:00
Alexey Milovidov
f9b6483f95 Checkpoint [#CLICKHOUSE-2] 2018-08-27 21:21:34 +03:00
Alexey Milovidov
74fee0dc98 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 21:20:58 +03:00
Alexey Milovidov
a3cd1ea8cb Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 21:16:32 +03:00
Alexey Milovidov
0d02315778 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 21:07:17 +03:00
Alexey Milovidov
3efffba44e Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 21:05:28 +03:00
Alexey Milovidov
956f76e000 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 20:58:43 +03:00
Alexey Milovidov
5b257c588f Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 20:42:13 +03:00
Yury Stankevich
f3024d2fba Make ZK operation timeout configurable 2018-08-27 20:26:19 +03:00
Alexey Milovidov
d4ea8bdb88 Merge remote-tracking branch 'origin/master' into extra-warnings 2018-08-27 20:18:39 +03:00
Alexey Milovidov
6e18af7ed3 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 20:18:14 +03:00
chertus
d6a85d9d63 Merge branch 'master' of github.com:yandex/ClickHouse 2018-08-27 20:17:26 +03:00
chertus
220909eb39 minor fix CLICKHOUSE-3765 2018-08-27 20:17:12 +03:00
alexey-milovidov
98148d914c
Merge pull request #2958 from blahgeek/skip-json-object
Skip object fields on json input
2018-08-27 20:07:32 +03:00
Alexey Milovidov
486d87ebcd Merge remote-tracking branch 'origin/master' into extra-warnings 2018-08-27 20:01:33 +03:00
alexey-milovidov
95b2bcbc6b
Merge pull request #2970 from 4ertus2/decimal
Some more Decimal
2018-08-27 19:59:26 +03:00
alexey-milovidov
3328fb456a
Merge pull request #2966 from amosbird/nrvo
Get rid of useless std::move to get NRVO
2018-08-27 19:56:03 +03:00
alexey-milovidov
0b9044fbf5
Merge pull request #2968 from yandex/addition-to-2954
Suggested changes by Amos Bird #2954
2018-08-27 19:51:39 +03:00
Alexey Milovidov
ad5855b7c1 Compatibility with old CMake [#CLICKHOUSE-2] 2018-08-27 19:49:40 +03:00
chertus
9dbaa5f4a9 remove strange code CLICKHOUSE-3765 2018-08-27 19:46:42 +03:00
Vadim
2d8bffafa3
Update MergeTreeSettings.h 2018-08-27 19:38:54 +03:00
Vadim
4d9d80b271
Update MergeTreeSettings.h 2018-08-27 19:38:36 +03:00
Alexey Milovidov
076e1fb2e1 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 19:31:45 +03:00
alesapin
4ecf3ce8ef
Merge pull request #2969 from alesapin/master
CLICKHOUSE-3894: Fix Kafka test
2018-08-27 19:24:39 +03:00
VadimPE
418375aa1d Merge branch 'CLICKHOUSE-3847' of https://github.com/VadimPE/ClickHouse into CLICKHOUSE-3847 2018-08-27 19:23:08 +03:00
VadimPE
70ebb6a47d CLICKHOUSE-3847 fix code-style 2018-08-27 19:22:39 +03:00
Alexey Milovidov
e5a2dd8624 Merge branch 'master' into extra-warnings 2018-08-27 19:19:04 +03:00
chertus
ee873c8e9f Merge branch 'master' into decimal 2018-08-27 19:18:48 +03:00
chertus
c86f2878ff add special ColumnDecimal instead of ColumnVector<DecimalNN> CLICKHOUSE-3765 2018-08-27 19:16:16 +03:00
alesapin
1f0f1ecad3 CLICKHOUSE-3894: Fix Kafka test 2018-08-27 19:15:39 +03:00
Vadim
64a27e592b
Update ReplicatedMergeTreeCleanupThread.cpp 2018-08-27 19:00:40 +03:00
VadimPE
4d198f2bfe CLICKHOUSE-3847 fix build 2018-08-27 18:54:07 +03:00
VadimPE
0281678c3e CLICKHOUSE-3847 fix code style 2018-08-27 18:44:51 +03:00
Alexey Milovidov
00774ad8c6 Suggested changes by Amos Bird #2954 2018-08-27 18:27:23 +03:00
Alexey Milovidov
303cc7242f Addition to prev. revision #2956 2018-08-27 18:01:33 +03:00
Alexey Milovidov
6e57168030 Removed code with duplicate semantics [#CLICKHOUSE-2] 2018-08-27 18:01:33 +03:00
alexey-milovidov
7de0549879
Update ReadHelpers.h 2018-08-27 18:00:08 +03:00
alexey-milovidov
01f01b1ee1
Update ReadHelpers.cpp 2018-08-27 17:54:58 +03:00
alesapin
a2a623d228
Merge pull request #2967 from alesapin/master
Small fixes in testing framework
2018-08-27 17:53:56 +03:00
alesapin
716c8016d7 CLICKHOUSE-3894: Print stack trace 2018-08-27 17:45:37 +03:00
alesapin
06d091580d CLICKHOUSE-3894: Increase MySQL timeout and add logging 2018-08-27 17:43:59 +03:00
proller
3acce3bff9 Build fix (#2944)
* Build fix

* Better sample build scripts

* zlib apple fix

* fix

* fix

* better so version

* SPLIT_SHARED -> LINK_MODE

* clean
2018-08-27 17:39:20 +03:00
Amos Bird
ea84430864 Get rid of useless std::move to get NRVO
http://eel.is/c++draft/class.copy.elision#:constructor,copy,elision

Some quote:

> Speaking of RVO, return std::move(w); prohibits it. It means "use move constructor or fail to compile", whereas return w; means "use RVO, and if you can't, use move constructor, and if you can't, use copy constructor, and if you can't, fail to compile."

There is one exception to this rule:
```cpp
Block FilterBlockInputStream::removeFilterIfNeed(Block && block)
{
    if (block && remove_filter)
        block.erase(static_cast<size_t>(filter_column));

    return std::move(block);
}
```

because references are not eligible for NRVO, which is another rule "always move rvalue references and forward universal references" that takes precedence.
2018-08-27 22:15:48 +08:00