Commit Graph

3204 Commits

Author SHA1 Message Date
Alexey Milovidov
b561560c99 Remove it from remaining places 2024-03-19 19:55:59 +01:00
Alexander Tokmakov
1c61ef7155 Merge branch 'master' into start-transaction 2024-03-19 19:30:26 +01:00
Alexey Milovidov
613c31038a Fix recompilation of regexps during backtracking in the parser 2024-03-18 18:40:47 +01:00
Nikita Mikhaylov
15896ecaf6
Add table system.keywords [Part 1] (#51808) 2024-03-18 16:58:57 +01:00
Alexey Milovidov
1bc21f1942 Merge branch 'master' into fix-error-in-client 2024-03-18 13:19:55 +01:00
vdimir
c3bfbf541c
Merge pull request #61254 from ClickHouse/vdimir/fix_astrename_clone2
Followup fix ASTRenameQuery::clone
2024-03-18 12:21:29 +01:00
Alexey Milovidov
5000e3e10b Fix error in clickhouse-client 2024-03-18 02:17:24 +01:00
Alexey Milovidov
13797b9712 Fix style 2024-03-17 20:21:07 +01:00
Alexey Milovidov
f0c9fe6bc9 Limit backtracking in parser 2024-03-17 19:54:45 +01:00
Alexey Milovidov
01136bbc3b Limit backtracking in parser 2024-03-17 19:54:45 +01:00
vdimir
c7e8ca789f
Followup fix ASTRenameQuery::clone #61013 2024-03-14 11:42:18 +00:00
Nikita Mikhaylov
765873a371
Merge pull request #61263 from ClickHouse/modern-assert
Modern `chassert` which can accept comment as a second parameter
2024-03-13 11:41:45 +01:00
Raúl Marín
15484bedad Fix clone for ASTQueryWithTableAndOutputImpl derived classes 2024-03-12 21:03:26 +01:00
Nikita Mikhaylov
3149111589
Merge branch 'master' into modern-assert 2024-03-12 18:30:44 +01:00
Nikita Mikhaylov
f3f1f611a4 Better 2024-03-12 17:26:42 +00:00
zhongyuankai
c6c40d1ac1 Merge branch 'master' into drop_tables 2024-03-12 08:54:55 +08:00
vdimir
38b8e7ac7e
Maintain list of ASTRenameQuery children 2024-03-11 11:34:10 +00:00
vdimir
c0689f3760
Fix ASTRenameQuery::clone 2024-03-11 11:34:06 +00:00
Sema Checherinda
5c41727725 http connections pools 2024-03-10 10:00:18 +01:00
Nikita Mikhaylov
6b4867f746
Debug fuzzer failures (#61062) 2024-03-08 21:27:56 +01:00
Dmitry Novik
71dc34074b
Merge pull request #60386 from ClickHouse/imp-analyzer-mask
Analyzer - improve hiding secret arguments.
2024-03-07 12:01:48 +01:00
János Benjamin Antal
6e58161fe6
Merge pull request #60534 from kashwy/Fix_max_query_size_for_kql_compound_operator
Fix_max_query_size_for_kql_compound_operator:
2024-03-07 10:32:19 +01:00
Zach Naimon
d529389522 Add support for 'START TRANSACTION' syntax 2024-03-05 14:20:20 -05:00
Raúl Marín
e1851987d8 Make tidy happy 2024-03-05 19:35:39 +01:00
Yakov Olkhovskiy
34f01c4a02 Merge branch 'master' into imp-analyzer-mask 2024-03-05 15:30:34 +00:00
Raúl Marín
56e0dd0ab0 More fixes 2024-03-05 15:35:06 +01:00
Raúl Marín
06409a8aa3 Merge remote-tracking branch 'blessed/master' into compression_clone 2024-03-05 14:03:41 +01:00
Raúl Marín
680bb3392e More missing trash 2024-03-04 20:01:27 +01:00
Raúl Marín
37891660be More missing resets 2024-03-04 20:01:03 +01:00
Raúl Marín
b86fcf0e7d Add missing compression clone() in ASTQueryWithOutput 2024-03-04 19:53:18 +01:00
Alexey Milovidov
ce6dec65cf
Merge pull request #60729 from ClickHouse/remove-more-live-view
Remove more code from LIVE VIEW
2024-03-04 18:58:21 +03:00
Alexey Milovidov
de6c5d3a40
Merge pull request #60552 from ClickHouse/pc2
Userspace page cache again
2024-03-04 17:47:35 +03:00
robot-ch-test-poll3
580f0f02d3
Merge pull request #60728 from ClickHouse/remove-old-code-5
Remove old code
2024-03-04 14:46:10 +01:00
Alexander Tokmakov
2e64b6722f
Revert "Synchronize parsers" 2024-03-04 11:42:21 +01:00
Alexey Milovidov
fc6f3c8399 Live view's life is close to the end 2024-03-04 00:49:22 +01:00
Alexey Milovidov
da2481c5c8 Merge remote-tracking branch 'origin/master' into remove-old-code-5 2024-03-04 00:12:03 +01:00
Alexey Milovidov
cbf5443585 Remove old code 2024-03-04 00:11:55 +01:00
Alexey Milovidov
75ecc6bdbf Merge branch 'master' into sync-with-private-3 2024-03-03 04:37:37 +01:00
Yakov Olkhovskiy
aa42d5a88d separate FunctionSecretArgumentsFinder for AST and TreeNode to avoid binary bloat due to linkage dependencies 2024-03-01 20:58:22 +00:00
Robert Schulze
4ee1aa8c7c
Fixing more headers 2024-02-29 15:40:30 +00:00
Robert Schulze
ed655815fe
Merge remote-tracking branch 'rschu1ze/master' into clang-tidy-src 2024-02-29 12:58:53 +00:00
Michael Kolupaev
227e3b5806 Conflict 2024-02-29 12:28:32 +00:00
Michael Kolupaev
42437a2ae1 Userspace page cache (#53770)
* Userspace page cache

* Maybe it'll build this time, who knows.

* 'auto' went out of fashion, I guess

* Documentation, tsan workaround, metric 'UnreclaimableRss', disable page cache in the test that uses DatabaseOrdinary

* Moved CachedInMemoryReadBufferFromFile to object store level, changed settings, addressed other comments.

* Fix

* Another fix

* Fix restricted seek, fix ppc64le build

* Don't allow page cache with file cache

* Adjust tests a little

* Fix clang-tidy

* Conflicts

* Comments

* Maybe unbroke AsynchronousBoundedReadBuffer

* SettingsChangesHistory.h

* Fix warning in test
2024-02-29 12:28:32 +00:00
Alexander Tokmakov
15e1191f74
Revert "Userspace page cache (#53770)"
This reverts commit 7b55c61551.
2024-02-29 13:20:17 +01:00
Michael Kolupaev
7b55c61551
Userspace page cache (#53770)
* Userspace page cache

* Maybe it'll build this time, who knows.

* 'auto' went out of fashion, I guess

* Documentation, tsan workaround, metric 'UnreclaimableRss', disable page cache in the test that uses DatabaseOrdinary

* Moved CachedInMemoryReadBufferFromFile to object store level, changed settings, addressed other comments.

* Fix

* Another fix

* Fix restricted seek, fix ppc64le build

* Don't allow page cache with file cache

* Adjust tests a little

* Fix clang-tidy

* Conflicts

* Comments

* Maybe unbroke AsynchronousBoundedReadBuffer

* SettingsChangesHistory.h

* Fix warning in test
2024-02-29 11:27:32 +00:00
Yong Wang
fc58ccfa9e Fix_max_query_size_for_kql_compound_operato:
Fix the issue of max_query_size for kql compound operator like mv-expand
this fix another use case for PR 59626
2024-02-28 20:15:54 -08:00
Robert Schulze
a1c164a758
Fix a bunch of clang-tidy warnings in headers 2024-02-28 23:43:12 +00:00
Alexey Milovidov
1c9bd029ea Synchronize parsers 2024-02-29 00:08:36 +01:00
Alexey Milovidov
e1e66dc2b8
Merge pull request #60095 from ClickHouse/fix-inconsistent-formatting
Fix inconsistent formatting of queries
2024-02-29 00:41:40 +03:00
Alexey Milovidov
b0ab0b37db
Merge pull request #60434 from ClickHouse/revert-60216-revert-59697-check-stack-size-in-parser
Revert "Revert "Check stack size in Parser""
2024-02-28 19:20:49 +03:00
Alexey Milovidov
1950a75bd4 Merge branch 'master' into fix-inconsistent-formatting 2024-02-28 17:10:29 +01:00
pufit
330a206470
Add definers for views (Attempt 2) (#60439) 2024-02-27 19:00:17 -05:00
Alexey Milovidov
8cf619bc03 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-inconsistent-formatting 2024-02-28 00:30:44 +01:00
Yakov Olkhovskiy
802db19e3b dedicated FunctionSecretArgumentsFinder for TreeNode, refactoring of FunctionSecretArgumentsFinder 2024-02-27 20:42:02 +00:00
Alexey Milovidov
9ea7ff231b
Merge pull request #60448 from ClickHouse/clang-19
Update to clang-19
2024-02-27 23:38:08 +03:00
Alexey Milovidov
0f3c9963d1 Merge branch 'master' of github.com:ClickHouse/ClickHouse into revert-60216-revert-59697-check-stack-size-in-parser 2024-02-27 17:30:32 +01:00
Alexey Milovidov
7c6e28708b
Merge pull request #60370 from ClickHouse/remove-alter-live-view
Remove ALTER LIVE VIEW
2024-02-27 17:45:59 +03:00
Alexey Milovidov
c192a448d0 Update to clang-19 2024-02-27 14:37:21 +01:00
Alexey Milovidov
6ac96bdcf1 Fix inconsistent formatting of CREATE TABLE ... COLLATE 2024-02-27 00:40:39 +01:00
Alexey Milovidov
0b90076a36
Revert "Revert "Check stack size in Parser"" 2024-02-27 01:34:50 +03:00
Alexey Milovidov
a3f1411679 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-inconsistent-formatting 2024-02-26 19:01:11 +01:00
Yong Wang
795c1a98dc
Fix segmentation fault in KQL parser when the input query exceeds the max_query_size (#59626)
* Fix_kql_issue_found_by_wingfuzz

This commit fix the issues:
 https://github.com/ClickHouse/ClickHouse/issues/59036
 https://github.com/ClickHouse/ClickHouse/issues/59037

both issues are same reason, the input query exceed the max_query_size,
so the condition isEnd() of token is not meet and cause the assertion failure

* fix_kql_issue_found_by_wingfuzz: use isValid instead of TokenType::EndOfStream

* fix_kql_issue_found_by_wingfuzz: make functional test result consist

* fix_kql_issue_found_by_wingfuzz: update test case for makeseries

* fix_kql_issue_found_by_wingfuzz: disable makeseries

* fix_kql_issue_found_by_wingfuzz:
 use isvalid() function to replace isEnd() function of TokenIterator to check the end of stream

* fix_kql_issue_found_by_wingfuzz: add test case for max_query_size

* fix_kql_issue_found_by_wingfuzz: fix AST structure

* fix_kql_issue_found_by_wingfuzz: make sure the max query size test is in the dialect of kusto

* fix_kql_issue_found_by_wingfuzz : restore max query size after test

* fix_kql_issue_found_by_wingfuzz : fix typo

---------

Co-authored-by: János Benjamin Antal <benjamin.antal@clickhouse.com>
2024-02-26 13:31:47 +01:00
Robert Schulze
5c967c44de
Merge pull request #60248 from ClickHouse/revert-59450-order-by-all-ambiguities
Revert "Replace `ORDER BY ALL` by `ORDER BY *`"
2024-02-26 10:23:41 +01:00
Antonio Andelic
5b01c4feb3
Revert "Fix: IAST::clone() for RENAME" 2024-02-26 08:47:05 +01:00
Alexey Milovidov
979cd2937b Fix inconsistent formatting of SET param_... 2024-02-26 02:11:51 +01:00
Alexey Milovidov
e5cb594944 Fix inconsistent formatting of GRANT CURRENT GRANTS 2024-02-26 01:54:52 +01:00
Alexey Milovidov
4b854399f4
Update src/Parsers/ASTSystemQuery.cpp
Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>
2024-02-26 03:44:35 +03:00
Alexey Milovidov
3f8f641dff Fix inconsistent formatting of GRANT CURRENT GRANTS 2024-02-26 01:43:37 +01:00
Alexey Milovidov
10e59c2e01 Remove ALTER LIVE VIEW 2024-02-26 00:01:34 +01:00
Yakov Olkhovskiy
ab6ab8bfac replace only secret arguments with [HIDDEN], also hide it in TreeNode dump 2024-02-25 17:11:22 +00:00
Alexey Milovidov
2eb4d25126 Remove ALTER LIVE VIEW 2024-02-23 22:56:18 +01:00
Alexey Milovidov
35f379ee64 Fix trash formatting 2024-02-23 15:55:29 +01:00
Alexey Milovidov
da2ae34c1d Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-inconsistent-formatting 2024-02-23 15:55:03 +01:00
Alexey Milovidov
10ba0801be Fix inconsistent formatting of SYSTEM SYNC REPLICA LIGHTWEIGHT 2024-02-23 15:45:08 +01:00
Alexey Milovidov
396402a9b6 Fix inconsistent formatting of operator function and nulls action 2024-02-23 15:22:21 +01:00
Nikita Mikhaylov
8fef0b71c4
Merge pull request #60350 from ClickHouse/revert-54901-pufit/views-sql-security
Revert "Add definers for views"
2024-02-23 15:15:36 +01:00
Alexey Milovidov
75c5b1a2c6 Fix inconsistent formatting of window functions 2024-02-23 15:06:03 +01:00
Alexey Milovidov
9e32d0f5b2 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-inconsistent-formatting 2024-02-23 15:05:46 +01:00
Igor Nikonov
90b1f8544a
Merge pull request #60227 from ClickHouse/fix-clone-ast-for-rename
Fix: IAST::clone() for RENAME
2024-02-23 14:48:14 +01:00
Sergei Trifonov
2c766cf75f
Merge pull request #59507 from ClickHouse/alter-table-forget-partition
Add `FORGET PARTITION` query to remove old partition nodes from ZooKeeper
2024-02-23 12:55:08 +01:00
Raúl Marín
464b5e0e15
Revert "Add definers for views (#54901)"
This reverts commit 57306706b3.
2024-02-23 12:44:31 +01:00
János Benjamin Antal
7cad0050c0
Disambiguate alter commands list (#59532)
* Add optional parentheses to TTL element and alter command

* Add some basic tests

* Extend tests with more test cases

* Add one more test case

* Add server setting to control new formatting behavior

* Automatic style fix

* Fix segfault in `clickhouse-format` related to new server setting

* Remove format_ttl_expressions_with_parentheses

* Fix unit test compilation failures

* Introduce global flag to control the new formatting behavior

* Revert "Fix segfault in `clickhouse-format` related to new server setting"

This reverts commit d7131a3145.

* Revert accidental changes

* Revert accidental include reorder

* Revert accidental changes

* Enable new format in client and local server

---------

Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
2024-02-22 19:17:15 +01:00
pufit
57306706b3
Add definers for views (#54901) 2024-02-22 17:47:50 +01:00
Kseniia Sumarokova
fb7924cdb1
Merge pull request #60233 from ClickHouse/hide-sensitive-info-in-s3-queue
Hide sensitive info for s3queue
2024-02-22 11:37:15 +01:00
Alexey Milovidov
2d9fbaa859 Merge with master 2024-02-21 20:37:48 +01:00
Alexey Milovidov
5076dd6266 Fix inconsistent formatting of lambda functions 2024-02-21 19:19:17 +01:00
Robert Schulze
52afa46e23
Revert "Replace ORDER BY ALL by ORDER BY *" 2024-02-21 19:05:20 +01:00
Alexey Milovidov
659d30774d Fix MODIFY REFRESH formatting 2024-02-21 18:37:46 +01:00
Alexey Milovidov
23afd322c9 Fix CREATE SETTINGS PROFILE 2024-02-21 18:25:21 +01:00
Alexey Milovidov
f726cb4800 Fix CREATE USER query 2024-02-21 17:56:36 +01:00
Alexey Milovidov
716d986238 Fix shit in CREATE INDEX 2024-02-21 17:29:15 +01:00
kssenii
c05c3944d1 Hide sensitive info for s3queue 2024-02-21 16:49:53 +01:00
Igor Nikonov
7411e81bec Fix style 2024-02-21 15:00:25 +00:00
Igor Nikonov
f4643b8341 Fix: RENAME AST clone
+ minor cleanup
2024-02-21 14:14:33 +00:00
Antonio Andelic
fee1565780
Revert "Check stack size in Parser" 2024-02-21 11:33:08 +01:00
Alexey Milovidov
a23e766edc Fix trash 2024-02-21 08:29:39 +01:00
Alexey Milovidov
ee3314b0a0 Fix trash 2024-02-21 08:27:13 +01:00
Alexey Milovidov
71c267e0b0 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-inconsistent-formatting 2024-02-21 07:56:51 +01:00
Sergei Trifonov
d2aebe2c9a
Merge branch 'master' into alter-table-forget-partition 2024-02-20 13:56:50 +01:00
Robert Schulze
5474f36e75
Merge remote-tracking branch 'rschu1ze/master' into order-by-all-ambiguities 2024-02-20 10:09:57 +00:00