Commit Graph

9210 Commits

Author SHA1 Message Date
Antonio Andelic
1e3abc9e84 Add strict mode for KeeperMap 2023-03-31 14:24:32 +00:00
Azat Khuzhin
edeeac84cf Fix incorrect ThreadPool usage after ThreadPool introspection
```
$ gg 'ThreadPool[^()]([A-Za-z_]\+,' src/
src/Interpreters/Context.cpp:        shared->load_marks_threadpool = std::make_unique<ThreadPool>(pool_size, pool_size, queue_size);
src/Interpreters/Context.cpp:        shared->prefetch_threadpool = std::make_unique<ThreadPool>(pool_size, pool_size, queue_size);
src/Interpreters/Context.cpp:        shared->threadpool_writer = std::make_unique<ThreadPool>(pool_size, pool_size, queue_size);
```

Fixes: #47880
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-30 20:08:38 +02:00
Mikhail f. Shiryaev
9593ffc7cb
Determine the hosts order in SHOW CLUSTER query 2023-03-30 17:37:31 +02:00
filimonov
fbb22348ea
Refactor reading the pool setting & from server config. (#48055)
After #36425 there was a lot of confusions/problems with configuring pools - when the message was confusing, and settings need to be ajusted in several places.
See some examples in #44251, #43351, #47900, #46515.

The commit includes the following changes:
1) Introduced a unified mechanism for reading pool sizes from the configuration file(s). Previously, pool sizes were read from the Context.cpp with fallbacks to profiles, whereas main_config_reloader in Server.cpp read them directly without fallbacks.
2) Corrected the data type for background_merges_mutations_concurrency_ratio. It should be float instead of int.
3) Refactored the default values for settings. Previously, they were defined in multiple places throughout the codebase, but they are now defined in one place (or two, to be exact: Settings.h and ServerSettings.h).
4) Improved documentation, including the correct message in system.settings.

Additionally make the code more conform with #46550.
2023-03-30 16:44:11 +02:00
Alexander Tokmakov
131395b00f
Merge pull request #48171 from aalexfvk/add_option_disable_on_cluster_queries
Add allow_distributed_ddl_queries option to the cluster config
2023-03-30 17:29:02 +03:00
Nikolai Kochetov
b3d77c0c30
Merge pull request #48177 from ClickHouse/deprecate-explain-query-tree-with-disabled-analyzer
Deprecate EXPLAIN QUERY TREE with disabled analyzer.
2023-03-30 13:56:40 +02:00
Robert Schulze
47fd1ee06d
Merge pull request #48127 from ClickHouse/rs/sort-show
Sort output of SHOW <INFO> statements
2023-03-30 10:54:23 +02:00
Nikolay Degterinsky
870ee4b4f5
Merge pull request #47813 from FrankChen021/query_id
Add `X-ClickHouse-Query-Id` to HTTP response when queries fail to execute
2023-03-30 09:00:03 +02:00
Alexey Milovidov
e982fb9f1c
Merge pull request #47880 from azat/threadpool-introspection
ThreadPool metrics introspection
2023-03-30 01:27:31 +03:00
Aleksei Filatov
0ac9dcd723 Add allow_distributed_ddl_queries option to the cluster config 2023-03-29 18:15:46 +03:00
Nikolai Kochetov
85795965c0 Deprecate EXPLAIN QUERY TREE with disabled analyzer. 2023-03-29 14:59:01 +00:00
Alexey Milovidov
cc345853e7
Merge pull request #47594 from ClickHouse/decimal256-various
Add specializations for Decimal256 in various places
2023-03-29 17:33:20 +03:00
Alexander Tokmakov
c5b6ed410d
Merge pull request #48130 from ClickHouse/support_undrop_table
Merging "Support undrop table"
2023-03-29 16:49:58 +03:00
Robert Schulze
d0f4c63d27
Fix tests 2023-03-29 10:30:40 +00:00
Azat Khuzhin
f38a7aeabe ThreadPool metrics introspection
There are lots of thread pools and simple local-vs-global is not enough
already, it is good to know which one in particular uses threads.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-29 10:46:59 +02:00
Alexander Tokmakov
cfe0fb6571 fix 2023-03-29 03:31:39 +02:00
Alexander Tokmakov
53725bdea1 monor improvements 2023-03-28 23:47:45 +02:00
Robert Schulze
6f8a450805
Sort output of SHOW <INFO> statements
Sorting is strictly speaking not necessary, but
1. sorted output is more user-friendly,
2. SQL currently does not allow to sort the output of SHOW <INFO>
   otherwise, e.g. SELECT * FROM (SHOW <INFO> ...) ORDER BY is rejected.
3. SQL tests can take advantage of that.
2023-03-28 20:55:59 +00:00
Alexander Tokmakov
614f8b313e
Merge pull request #47856 from Algunenano/zk_inject_timeout
Allow injecting timeout errors on Keeper
2023-03-28 23:40:51 +03:00
Alexander Tokmakov
a1076005c7 Merge branch 'master' into support_undrop_table 2023-03-28 22:03:31 +02:00
Igor Nikonov
259df04415 Merge remote-tracking branch 'origin/master' into decimal256-various 2023-03-28 13:36:53 +00:00
Kseniia Sumarokova
62c6aea45b
Merge pull request #47975 from MikhailBurdukov/mburdukov_ignore_inacc_tables
Skip materialized view checking if source table does not exist
2023-03-28 11:29:11 +02:00
SmitaRKulkarni
98999c2afb
Merge pull request #48065 from ClickHouse/Support_parameterized_view_with_cte
Support for cte in parameterized views
2023-03-28 11:18:16 +02:00
xiedeyantu
62087c3f09 fix 2023-03-28 07:27:13 +08:00
Alexey Milovidov
5d0e34d2a7
Merge pull request #47953 from ClickHouse/Avogar-patch-2
Fix tsan error lock-order-inversion
2023-03-28 01:10:50 +03:00
MikhailBurdukov
c296c2e299 Review changes 2023-03-27 18:34:12 +00:00
Raúl Marín
ff209db129
Merge branch 'master' into zk_inject_timeout 2023-03-27 19:46:10 +02:00
xiedeyantu
9382c6ffdc better 2023-03-27 23:51:35 +08:00
Smita Kulkarni
cb04c6301c Support for cte in parameterized views
Implementation:
* Updated to allow query parameters while evaluating scalar subqueries.
Testing:
* Added test case with cute for parameterized view.
2023-03-27 16:30:53 +02:00
xiedeyantu
5036d19af3 better 2023-03-27 22:16:37 +08:00
xiedeyantu
5a18e0d5a5 support undrop table 2023-03-27 22:16:36 +08:00
avogar
64db4c478b Use one map 2023-03-27 13:19:45 +00:00
Raúl Marín
714b54b322 Reimplement enable_fault_injections_during_startup 2023-03-27 15:06:46 +02:00
Nikolay Degterinsky
227425968f
Merge branch 'master' into query_id 2023-03-27 13:41:42 +02:00
Alexey Milovidov
b6892f53fc
Merge pull request #47724 from ClickHouse/rs/qc-better-cfg-name
Rename cfg parameter query_cache.size to query_cache.max_size
2023-03-27 00:36:24 +03:00
Nikolai Kochetov
327674f56d
Merge pull request #46537 from ClickHouse/aggregate-projections-analysis-query-plan
Projections analysis from query plan
2023-03-25 13:23:30 +01:00
avogar
d00587202d Make better 2023-03-24 19:25:07 +00:00
Maksim Kita
5cb2d30563
Merge pull request #47316 from ClickHouse/vdimir/transform_external_query_analyzer
Support transformQueryForExternalDatabase for analyzer
2023-03-24 17:53:00 +01:00
avogar
ee0fd39f2a Fix data-race 2023-03-24 15:20:19 +00:00
Nikolai Kochetov
a2182f2659
Merge pull request #47874 from amosbird/correct_exact_rows_before_limit
Correct `exact_rows_before_limit` in some scenarios
2023-03-24 15:09:42 +01:00
Robert Schulze
0712627c05
Query cache: Fix config naming ambiguity
Add 'max_' prefix to 'size' setting to make it more clear that the cache
consumes no space if not used.
2023-03-24 12:52:09 +00:00
Kruglov Pavel
97592cfdfd
Merge branch 'master' into Avogar-patch-2 2023-03-24 13:44:28 +01:00
MikhailBurdukov
cc92eacb3e Merged several tests into one and rm unnecessary func 2023-03-24 11:51:09 +00:00
MikhailBurdukov
68118388e6 Rename opt key, added test and refactored code. 2023-03-24 08:23:22 +00:00
Nikolai Kochetov
73e98de46d Merge branch 'master' into aggregate-projections-analysis-query-plan 2023-03-23 21:28:36 +01:00
Maksim Kita
24b9e5103f
Merge pull request #47748 from ClickHouse/revert-47721-revert-47622-analyzer-planner-fixes-before-enable-by-default
Revert "Revert "Analyzer planner fixes before enable by default""
2023-03-23 22:20:34 +03:00
Kruglov Pavel
9003b7d789
Fix tsan error lock-order-inversion 2023-03-23 20:14:32 +01:00
vdimir
c2a3679959
Add buildSelectQueryInfo to Planner/Utils, use in unit tests 2023-03-23 15:53:22 +00:00
Azat Khuzhin
2b439f079e
Make backup_threads/restore_threads server settings (#47881)
Those settings can be applied only at start, so it is better to have
them in configuration file instead of user profile settings.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-23 15:44:15 +01:00
MikhailBurdukov
62c8eeb25c Ignoring inaccessible tables for attaching to the materilized view 2023-03-22 20:13:30 +00:00