Commit Graph

27144 Commits

Author SHA1 Message Date
Alexander Tokmakov
f0607a8d30 try fix 01108_restart_replicas_rename_deadlock flaps 2020-04-01 19:49:54 +03:00
Alexander Tokmakov
90dd36346e fix test_distributed_respect_user_timeouts 2020-04-01 17:53:06 +03:00
Artem Zuikov
836c6fed80
Fix columns override in distributed queries (#9972) 2020-04-01 17:21:37 +03:00
Nikolai Kochetov
8bee467f4c
Merge pull request #9762 from ClickHouse/test-single-thread-read-in-order
Added a test that checks that read from MergeTree with single thread is performed in order
2020-04-01 14:56:11 +03:00
alexey-milovidov
dffa053471
Merge pull request #9727 from abyss7/jemalloc
Improve jemalloc contrib
2020-04-01 05:37:08 +03:00
alexey-milovidov
c7afc51a52
Merge pull request #9923 from azat/dist-on-dist
[RFC] Distributed over distributed (v2)
2020-04-01 05:25:21 +03:00
alexey-milovidov
385d0c68d7
Merge pull request #9956 from ClickHouse/nvartolomei-nv/getStructureOfRemoteTable-try-all-shards
Merging #7278
2020-04-01 05:18:06 +03:00
alexey-milovidov
33daf0b065
Merge pull request #9944 from vzakaznikov/fix_00964_live_view_watch_events_heartbeat
Fixing 00964_live_view_watch_events_heartbeat.py test to avoid race condition
2020-04-01 05:14:05 +03:00
alexey-milovidov
55032c6fb9
Update 00964_live_view_watch_events_heartbeat.py 2020-04-01 05:13:20 +03:00
alexey-milovidov
f4eb24f4c8
Merge pull request #9955 from ClickHouse/fix_restart_replicas_ddlguard_order
Fix DDLGuard lock order in RESTART REPLICAS
2020-04-01 05:08:17 +03:00
alexey-milovidov
e441db9b67
Merge pull request #9971 from ClickHouse/fix-num-threads-in-distributed
Fix num threads in distributed
2020-04-01 05:03:44 +03:00
alexey-milovidov
300fb2f258
Merge pull request #9970 from vitlibar/fix-reusing-connection-after-change-of-default-settings
Fix reusing connection after changing user's default settings
2020-04-01 05:03:12 +03:00
alexey-milovidov
8670d0d28d
Merge pull request #9966 from vitlibar/fix-disabling-dcl-access-rights-in-readonly-mode
Fix disabling DCL access rights in readonly mode.
2020-04-01 05:01:59 +03:00
alexey-milovidov
61fbab4ccb
Merge pull request #9962 from vitlibar/fix-test_settings_constraints
Fix integration test test_settings_constraints
2020-04-01 04:58:09 +03:00
alexey-milovidov
e10cf89896
Merge pull request #9410 from excitoon-favorites/attachpart
Fixed `DeleteOnDestroy` logic in `ATTACH PART` and added few tests
2020-04-01 04:49:41 +03:00
alexey-milovidov
6eb3928567
Merge pull request #9975 from CurtizJ/tuple-literal
Fix use-after-free at syntax error
2020-04-01 04:46:21 +03:00
Nikolai Kochetov
47bc9edc63 Update test 2020-03-31 23:38:05 +03:00
Alexey Milovidov
a87de767a7 Pick comments and style changes from #4385 2020-03-31 23:14:16 +03:00
alexey-milovidov
576936f4e8
Merge pull request #9961 from ClickHouse/fix_zookeeper_implementation
Fix bug with wrong implementation in ZooKeeper API
2020-03-31 23:08:11 +03:00
Alexey Milovidov
2344d4715e Merge branch 'master' of github.com:yandex/ClickHouse into nvartolomei-nv/getStructureOfRemoteTable-try-all-shards 2020-03-31 22:55:36 +03:00
alexey-milovidov
677406648d
Merge pull request #9927 from garneja/master
Fix a race between DDLWorker and DDLWorkerClnr during startup
2020-03-31 22:51:50 +03:00
alexey-milovidov
8dffb62b47
Merge pull request #9938 from achimbab/pr_windowFunnel
Fix bugs in windowFunnel()
2020-03-31 22:44:07 +03:00
alesapin
2b235f1b1a Remove dynamic cast from check 2020-03-31 22:33:37 +03:00
Anton Popov
6e305b2ec1 fix use-after-free at syntax error 2020-03-31 22:25:00 +03:00
Vladimir Chebotarev
8d4c7de231 Added test for attaching partitions across disk sets. 2020-03-31 21:00:29 +03:00
Vladimir Chebotarev
288cee5663 Fixed DeleteOnDestroy logic. 2020-03-31 21:00:29 +03:00
tavplubix
c424db85b4
fix timeout in 01098_temporary_and_external_tables 2020-03-31 20:25:13 +03:00
alesapin
aad0e21621 Fix style 2020-03-31 19:38:04 +03:00
alesapin
7f41087367 Rename parameter 2020-03-31 19:35:41 +03:00
Nikolai Kochetov
801ca4fbe6 Add perftest. 2020-03-31 19:34:06 +03:00
Vitaly Baranov
fcc7d4b031 Fix disabling DCL access rights in readonly mode. 2020-03-31 18:13:46 +03:00
Vitaly Baranov
5cd7b58499 Fix reusing connection after changing user's default settings via ALTER USER or ALTER SETTINGS PROFILE.
This fixes integration test "test_settings_constraints_distributed".
2020-03-31 18:08:01 +03:00
Nikolai Kochetov
3b933f8426 Fix number of threads for pipeline execution. 2020-03-31 17:55:02 +03:00
Nikolai Kochetov
be1f977073 Fix number of threads for pipeline execution. 2020-03-31 17:30:43 +03:00
Vitaly Baranov
0f90c590b1 Fix test_settings_constraints. 2020-03-31 14:46:30 +03:00
alesapin
9df8d1abf5 Fix bug with wrong implementation in ZooKeeper API 2020-03-31 14:45:55 +03:00
achulkov2
c77fe290d3
Fix mysql + join bug (#9949) 2020-03-31 13:52:26 +03:00
Artem Zuikov
cd1683a823
Rename joined table totals columns (#9939) 2020-03-31 13:38:24 +03:00
Vladimir Chebotarev
4839052ba2 Style and review fixes, fixed error code. 2020-03-31 12:02:03 +03:00
alesapin
b09a59de99
Merge pull request #9937 from ClickHouse/fix_parallel_alter_tests
Add hard timeouts to alter tests
2020-03-31 11:59:50 +03:00
alesapin
ab701ec0c5 Fix 00975_indices_mutation_replicated_zookeeper test 2020-03-31 11:54:46 +03:00
Alexey Milovidov
2d75b3d3c8 Fixed one inconsistency and avoid another issue 2020-03-31 04:51:03 +03:00
Alexey Milovidov
314cfb06fe Merged with master 2020-03-31 04:14:32 +03:00
Alexander Tokmakov
e291f93326 fix DDLGuard lock order in RESTART REPLICAS 2020-03-31 03:08:53 +03:00
philip.han
4c8c2d2933 Add a comment of getOwnNullAdapter() 2020-03-31 06:53:36 +09:00
Azat Khuzhin
e44e6ffda5 Fix distributed_aggregation_memory_efficient with Distributed-on-Distributed
Error before this patch:
  Logical error: 'SortingAggregatedTransform already got bucket with number 115'.
2020-03-30 23:46:12 +03:00
Azat Khuzhin
7514f3a0e3 Cover distributed_aggregation_memory_efficient/group_by_two_level_threshold 2020-03-30 21:29:22 +03:00
Azat Khuzhin
e26f0147f4 Add a test for known bug with GLOBAL IN and Distributed-on-Distributed
The stacktrace looks like:

    [ 1393930 ] {61e2952b-5039-497a-8f8c-923644541261} <Debug> executeQuery: (from [::1]:28770) SELECT DISTINCT * FROM dist_01224 WHERE key GLOBAL IN (1) SETTINGS distributed_group_by_no_merge = 1
    [ 1393930 ] {61e2952b-5039-497a-8f8c-923644541261} <Error> : Logical error: 'Table expression is undefined, Method: ExpressionAnalyzer::interpretSubquery.'.
    src/Common/Exception.cpp:37: DB::Exception::Exception(const string&, int): Assertion `false' failed.
    [ 1393906 ] {} <Trace> BaseDaemon: Received signal 6
    [ 1421018 ] {} <Fatal> BaseDaemon: ########################################
    [ 1421018 ] {} <Fatal> BaseDaemon: (version 20.4.1.1) (from thread 1393930) (query_id: 61e2952b-5039-497a-8f8c-923644541261) Received signal Aborted (6).
    [ 1421018 ] {} <Fatal> BaseDaemon:
    [ 1421018 ] {} <Fatal> BaseDaemon: Stack trace: 0x7ffff6f22ce5 0x7ffff6f0c857 0x7ffff6f0c727 0x7ffff6f1b426 0x7ffff7bc5094 0x7fffeae131e6 0x7fffeae12f8b 0x7fffea7697a1 0x7fffea769f26 0x7fffea769e1f 0x7fffea76bc21 0x7fffea76e612 0x7fffea76bc0b 0x7fffea76078b 0x7fffea75fa5f 0x7fffea88742a 0x7fffea89ffa4 0x7fffea872162 0x7fffea8740e1 0x7fffea8715ef 0x7fffea8fcd4d 0x7fffea8facd1 0x7fffea8414b9 0x7fffea83f8a9 0x7fffeae04914 0x7fffeae05f39 0x7ffff7f68506 0x7ffff7f6f4d9
    [ 1421018 ] {} <Fatal> BaseDaemon: 4. gsignal @ 0x3bce5 in /usr/lib/libc-2.31.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 5. abort @ 0x25857 in /usr/lib/libc-2.31.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 6. _nl_load_domain.cold @ 0x25727 in /usr/lib/libc-2.31.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 7. ? @ 0x34426 in /usr/lib/libc-2.31.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 8. /ch-cmake/../dbms/src/Common/Exception.cpp:37: DB::Exception::Exception(...) @ 0x1c1094 in /ch-cmake/dbms/libclickhouse_common_iod.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 9. /ch-cmake/../dbms/src/Interpreters/interpretSubquery.cpp:52: DB::interpretSubquery() [clone .localalias] @ 0x1d831e6 in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 10. /ch-cmake/../dbms/src/Interpreters/interpretSubquery.cpp:28: DB::interpretSubquery(std::shared_ptr<DB::IAST> const&, DB::Context const&, unsigned long, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&) @ 0x1d82f8b in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 11. /ch-cmake/../dbms/src/Interpreters/GlobalSubqueriesVisitor.h💯 DB::GlobalSubqueriesMatcher::Data::addExternalStorage(std::shared_ptr<DB::IAST>&, bool) @ 0x16d97a1 in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 12. /ch-cmake/../dbms/src/Interpreters/GlobalSubqueriesVisitor.h:170: DB::GlobalSubqueriesMatcher::visit(DB::ASTFunction&, std::shared_ptr<DB::IAST>&, DB::GlobalSubqueriesMatcher::Data&) @ 0x16d9f26 in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 13. /ch-cmake/../dbms/src/Interpreters/GlobalSubqueriesVisitor.h:151: DB::GlobalSubqueriesMatcher::visit(std::shared_ptr<DB::IAST>&, DB::GlobalSubqueriesMatcher::Data&) @ 0x16d9e1f in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 14. /ch-cmake/../dbms/src/Interpreters/InDepthNodeVisitor.h:27: DB::InDepthNodeVisitor<DB::GlobalSubqueriesMatcher, false, std::shared_ptr<DB::IAST> >::visit(std::shared_ptr<DB::IAST>&) @ 0x16dbc21 in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 15. /ch-cmake/../dbms/src/Interpreters/InDepthNodeVisitor.h:45: DB::InDepthNodeVisitor<DB::GlobalSubqueriesMatcher, false, std::shared_ptr<DB::IAST> >::visitChildren(std::shared_ptr<DB::IAST>&) @ 0x16de612 in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 16. /ch-cmake/../dbms/src/Interpreters/InDepthNodeVisitor.h:32: DB::InDepthNodeVisitor<DB::GlobalSubqueriesMatcher, false, std::shared_ptr<DB::IAST> >::visit(std::shared_ptr<DB::IAST>&) @ 0x16dbc0b in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 17. /ch-cmake/../dbms/src/Interpreters/ExpressionAnalyzer.cpp:265: DB::ExpressionAnalyzer::initGlobalSubqueriesAndExternalTables(bool) @ 0x16d078b in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 18. /ch-cmake/../dbms/src/Interpreters/ExpressionAnalyzer.cpp:140: DB::ExpressionAnalyzer::ExpressionAnalyzer(std::shared_ptr<DB::IAST> const&, std::shared_ptr<DB::SyntaxAnalyzerResult const> const&, DB::Context const&, unsigned long, bool) @ 0x16cfa5f in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 19. /ch-cmake/../dbms/src/Interpreters/ExpressionAnalyzer.h:235: DB::SelectQueryExpressionAnalyzer::SelectQueryExpressionAnalyzer() @ 0x17f742a in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 20. /usr/include/c++/9.3.0/bits/unique_ptr.h:857: std::_MakeUniq<DB::SelectQueryExpressionAnalyzer>::__single_object std::make_unique<..>(std::shared_ptr<DB::IAST>&, std::shared_ptr<DB::SyntaxAnalyzerResult const>&, DB::Context&, std::unordered_set<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&&, bool&&, DB::SelectQueryOptions&) @ 0x180ffa4 in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 21. /ch-cmake/../dbms/src/Interpreters/InterpreterSelectQuery.cpp:320: DB::InterpreterSelectQuery::InterpreterSelectQuery(std::shared_ptr<DB::IAST> const&, DB::Context const&, std::shared_ptr<DB::IBlockInputStream> const&, std::optional<DB::Pipe>, std::shared_ptr<DB::IStorage> const&, DB::SelectQueryOptions const&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&)::{}::operator()(bool) const @ 0x17e2162 in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 22. /ch-cmake/../dbms/src/Interpreters/InterpreterSelectQuery.cpp:383: DB::InterpreterSelectQuery::InterpreterSelectQuery(...) @ 0x17e40e1 in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 23. /ch-cmake/../dbms/src/Interpreters/InterpreterSelectQuery.cpp:167: DB::InterpreterSelectQuery::InterpreterSelectQuery(...) @ 0x17e15ef in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 24. /usr/include/c++/9.3.0/bits/unique_ptr.h:857: std::_MakeUniq<DB::InterpreterSelectQuery>::__single_object std::make_unique<...>(...) @ 0x186cd4d in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 25. /ch-cmake/../dbms/src/Interpreters/InterpreterSelectWithUnionQuery.cpp:94: DB::InterpreterSelectWithUnionQuery::InterpreterSelectWithUnionQuery(...) @ 0x186acd1 in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 26. /usr/include/c++/9.3.0/bits/unique_ptr.h:857: std::_MakeUniq<DB::InterpreterSelectWithUnionQuery>::__single_object std::make_unique<...>(std::shared_ptr<DB::IAST>&, DB::Context&, DB::SelectQueryOptions&&) @ 0x17b14b9 in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 27. /ch-cmake/../dbms/src/Interpreters/InterpreterFactory.cpp💯 DB::InterpreterFactory::get(std::shared_ptr<DB::IAST>&, DB::Context&, DB::QueryProcessingStage::Enum) @ 0x17af8a9 in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 28. /ch-cmake/../dbms/src/Interpreters/executeQuery.cpp:310: DB::executeQueryImpl(char const*, char const*, DB::Context&, bool, DB::QueryProcessingStage::Enum, bool, DB::ReadBuffer*, bool) @ 0x1d74914 in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 29. /ch-cmake/../dbms/src/Interpreters/executeQuery.cpp:578: DB::executeQuery(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, DB::Context&, bool, DB::QueryProcessingStage::Enum, bool, bool) @ 0x1d75f39 in /ch-cmake/dbms/libclickhouse_interpretersd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 30. /ch-cmake/../dbms/programs/server/TCPHandler.cpp:249: DB::TCPHandler::runImpl() @ 0x23a506 in /ch-cmake/dbms/programs/server/libclickhouse-server-libd.so
    [ 1421018 ] {} <Fatal> BaseDaemon: 31. /ch-cmake/../dbms/programs/server/TCPHandler.cpp:1239: DB::TCPHandler::run() @ 0x2414d9 in /ch-cmake/dbms/programs/server/libclickhouse-server-libd.so
    Aborted (core dumped)
2020-03-30 21:29:22 +03:00
Azat Khuzhin
3a5ea0e443 Cover group_by_two_level_threshold/distributed_aggregation_memory_efficient 2020-03-30 21:29:22 +03:00
Azat Khuzhin
fe3b068d22 More test cases for Distibuted-on-Distributed (LEFT JOIN/RIGHT JOIN) 2020-03-30 21:29:22 +03:00