Commit Graph

111955 Commits

Author SHA1 Message Date
Alexey Milovidov
3de29f5cc1
Merge pull request #48278 from azat/backups/fix-UB
Fix UB (signed integer overflow) in StorageMergeTree::backupData()
2023-03-31 16:35:10 +03:00
vdimir
2a179aed49
Fix usage common::addOverflow for floats in AggregateFunctionSparkbar 2023-03-31 13:35:07 +00:00
natasha
644d83653d only set the necessary FormatStateStacked settings 2023-03-31 14:10:16 +01:00
Anton Popov
12c7992d36
Merge pull request #48118 from CurtizJ/optimize-mapUpdate
Optimize function `mapUpdate`
2023-03-31 15:03:15 +02:00
Alexander Tokmakov
caf00b5968 Merge branch 'master' into sync_replica_lightweight 2023-03-31 14:52:55 +02:00
Raúl Marín
84c30f2f63 I've got no style 2023-03-31 14:49:53 +02:00
natasha
d176be6150 Merge remote-tracking branch 'origin/fix-alter-formatting' into fix-alter-formatting 2023-03-31 13:45:31 +01:00
natasha
6caacd41d4 fix the code, single line formatter was forgotten 2023-03-31 13:45:12 +01:00
natasha
3b5f193949 fix the test 2023-03-31 13:45:11 +01:00
Alexey Milovidov
070210a02f
Merge pull request #48271 from vchekan/master
In messages, put values into quotes
2023-03-31 15:35:19 +03:00
natasha
bae92ddf4e fix the code, single line formatter was forgotten 2023-03-31 13:34:55 +01:00
natasha
7c3c5ad6bb fix the test 2023-03-31 13:34:28 +01:00
Alexey Milovidov
99194d0ff8
Merge pull request #48281 from ClickHouse/auto/v23.3.1.2823-lts
Update version_date.tsv and changelogs after v23.3.1.2823-lts
2023-03-31 15:34:17 +03:00
Raúl Marín
d158b18703 Randomize allow_vertical_merges_from_compact_to_wide_parts in tests 2023-03-31 14:23:30 +02:00
Alexey Milovidov
5206d4b926 Randomize compression of marks and indices in tests 2023-03-31 14:12:55 +02:00
Raúl Marín
aa8e5a1077 Don't use CURRENT_WRITE_BUFFER_IS_EXHAUSTED for expected behaviour 2023-03-31 14:09:21 +02:00
vdimir
2d18689af6
use common::addOverflow in AggregateFunctionSparkbar.h 2023-03-31 11:59:13 +00:00
Alexander Tokmakov
f54fd15112 fix 2023-03-31 12:58:11 +02:00
vdimir
24b46774b0
update AggregateFunctionSparkbar.h 2023-03-31 10:58:09 +00:00
vdimir
def7b19033
Update 02016_aggregation_spark_bar.reference 2023-03-31 10:58:09 +00:00
vdimir
cc61d35bc5
Fix overflow in sparkbar function 2023-03-31 10:58:08 +00:00
robot-clickhouse
0c9d7f73ce Update version_date.tsv and changelogs after v23.3.1.2823-lts 2023-03-31 10:35:58 +00:00
Alexey Milovidov
d06ab59737
Merge pull request #48279 from ClickHouse/23.4-prepare
Update version after release
2023-03-31 13:28:30 +03:00
Alexey Milovidov
dd79bf0a03 Update autogenerated version to 23.4.1.1 and contributors 2023-03-31 12:20:50 +02:00
Robert Schulze
9806a831c0
Small test refactoring 2023-03-31 09:41:59 +00:00
Robert Schulze
8d91a9f4c2
Sort descendingly by elapsed time 2023-03-31 09:36:03 +00:00
Alexander Tokmakov
c28ed094a4
Merge pull request #48277 from ClickHouse/revert-48196-jit-randomization
Revert "Randomize JIT settings in tests"
2023-03-31 12:33:04 +03:00
Azat Khuzhin
bac7def719 Fix UB (signed integer overflow) in StorageMergeTree::backupData()
UBsan report:

    /build/src/Storages/StorageMergeTree.cpp:2088:80: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long'
        0 0x30c2ae7b in DB::StorageMergeTree::backupData(DB::BackupEntriesCollector&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, std::__1::optional<absl::lts_20211102::InlinedVector<std::__1::shared_ptr<DB::IAST>, 7ul, std::__1::allocator<std::__1::shared_ptr<DB::IAST>>>> const&) build_docker/./src/Storages/StorageMergeTree.cpp:2088:80
        1 0x2dd641b5 in DB::BackupEntriesCollector::makeBackupEntriesForTableData(DB::QualifiedTableName const&) build_docker/./src/Backups/BackupEntriesCollector.cpp:703:18
        2 0x2dd5c2a7 in DB::BackupEntriesCollector::makeBackupEntriesForTablesData() build_docker/./src/Backups/BackupEntriesCollector.cpp:676:9
        3 0x2dd5848d in DB::BackupEntriesCollector::run() build_docker/./src/Backups/BackupEntriesCollector.cpp:119:5
        4 0x2dd84da3 in DB::BackupsWorker::doBackup(std::__1::shared_ptr<DB::ASTBackupQuery> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, DB::BackupInfo const&, DB::BackupSettings, std::__1::shared_ptr<DB::IBackupCoordination>, std::__1::shared_ptr<DB::Context const> const&, std::__1::shared_ptr<DB::Context>, bool) build_docker/./src/Backups/BackupsWorker.cpp:359:59
        5 0x2dd82405 in DB::BackupsWorker::startMakingBackup(std::__1::shared_ptr<DB::IAST> const&, std::__1::shared_ptr<DB::Context const> const&) build_docker/./src/Backups/BackupsWorker.cpp:248:13
        6 0x2dd81d0a in DB::BackupsWorker::start(std::__1::shared_ptr<DB::IAST> const&, std::__1::shared_ptr<DB::Context>) build_docker/./src/Backups/BackupsWorker.cpp:179:16
        7 0x2f4d0d5f in DB::InterpreterBackupQuery::execute() build_docker/./src/Interpreters/InterpreterBackupQuery.cpp:39:30

    SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /build/src/Storages/StorageMergeTree.cpp:2088:80 in

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-31 12:29:31 +03:00
Alexander Tokmakov
792979a527
Revert "Randomize JIT settings in tests" 2023-03-31 12:24:47 +03:00
Azat Khuzhin
42abb84325 Fix 01710_projection_optimize_materialize flakiness
Fails with different index granularity

CI: https://s3.amazonaws.com/clickhouse-test-reports/48242/672dbf7cd894be6f5c0ac685d493371f2996229d/stateless_tests__asan__[3/4].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-31 12:16:59 +03:00
Antonio Andelic
f31f11dd67 Disable env credentials for stateless tests 2023-03-31 09:12:41 +00:00
Antonio Andelic
e982f2a67a Merge branch 'master' into enable-env-credentials-default 2023-03-31 09:11:01 +00:00
Robert Schulze
eb93ec35f5
Merge pull request #48154 from azat/varuint-v2
Add sanity checks for writing number in variable length format (resubmit)
2023-03-31 10:59:21 +02:00
Vadym Chekan
0f4c8144a6 In messages, put values into quotes
Configuration values, such as disk names, backup engine names, etc, may give error message unintended sense, for example, if trying to backup to `disk` instead of `Disk`, the error message will be "Not found backup engine disk", which can be interpreted as "disk of backup engine not found". It might be not clear that the word "disk" comes from the query and is not part of the error message.
2023-03-30 22:46:18 -07:00
Rich Raposa
8d9baceeb1
Merge branch 'master' into patch-61 2023-03-30 22:10:50 -06:00
Rich Raposa
1ef49eb5e4
Merge pull request #48265 from ClickHouse/youtube-fixes
Cleaned up the youtube dislikes dataset
2023-03-30 22:07:56 -06:00
Azat Khuzhin
e16b434631 Fix compiling examples without Hive
Skip compiling comma_separated_streams since it requires Hive.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-31 06:05:16 +02:00
Rich Raposa
d49e4afb60
Merge branch 'master' into youtube-fixes 2023-03-30 21:22:01 -06:00
Anton Popov
5ceb855e7f
Merge branch 'master' into fix-race-storage-s3 2023-03-31 04:16:35 +02:00
Alexander Tokmakov
356716f0a1
Update master.yml 2023-03-31 03:26:16 +03:00
Alexander Tokmakov
64b1f74a60 fix 2023-03-31 01:39:49 +02:00
Alexander Tokmakov
2850d2822d more consistent workflows 2023-03-31 01:38:23 +02:00
Alexander Tokmakov
81375431d9 fix some tests 2023-03-31 01:07:08 +02:00
Alexander Tokmakov
46e85357ce
Merge pull request #48244 from azat/fix-threadpools
Fix incorrect ThreadPool usage after ThreadPool introspection
2023-03-31 01:48:01 +03:00
Alexander Tokmakov
b7cbf83395
Merge branch 'master' into fix-threadpools 2023-03-31 01:47:23 +03:00
Alexander Tokmakov
8994305fb3
Merge pull request #48264 from ClickHouse/fix_test_numbers_again
fix test numbers again
2023-03-31 01:47:00 +03:00
Rich Raposa
348da6d19f
Merge branch 'master' into youtube-fixes 2023-03-30 16:43:13 -06:00
rfraposa
98833bcc82 Update youtube-dislikes.md 2023-03-30 16:41:29 -06:00
Alexander Tokmakov
b7f411443d fix test numbers again 2023-03-31 00:36:34 +02:00
Alexander Tokmakov
29e85bd9a4
Merge branch 'master' into fix-threadpools 2023-03-31 01:03:06 +03:00