thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-04 13:32:13 +00:00
Code Issues Packages Projects Releases Wiki Activity
125,072 Commits 9,179 Branches 1,782 Tags 2.3 GiB
21ffbd88de
Commit Graph

125072 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
János Benjamin Antal
13868e4d1d Fix review comments 2023-09-14 14:45:23 +00:00
Azat Khuzhin
5d3e3113b2 Fix possible CANNOT_READ_ALL_DATA exception during ZooKeeper client finalization 
Right now it is possible to get this error CANNOT_READ_ALL_DATA if
timings will goes wrong.

The problem is that finalize() firstly calls shutdown() on the socket,
this will trigger poll(POLLIN) (EOF) and the receiveThread() will
trigger a receiveEvent which will fail because read will return 0
(while reading length).

Note, that rearrange the code in the finalize (i.e. call shutdown()
after) since the client sends CLOSE_XID before, and the server may close
the connection already, and this will also trigger poll(POLLIN) (EOF),
and read will return 0 also.

So checking for the requests_queue.isFinished() is not enough,
finalization_started should be checked instead.

Easy reproducer:

    $ yes /keeper/api_version | head -n10000 | xargs -P30 -i clickhouse-keeper-client -q 'get {}' > /dev/null

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-09-14 16:36:16 +02:00
Nikolay Degterinsky
7643e216be
Better test 2023-09-14 15:58:00 +02:00
Nikolay Degterinsky
ca57eb9546
Fix addData function 2023-09-14 15:55:37 +02:00
Kruglov Pavel
6419f91cfc
Merge pull request #54585 from ClickHouse/Avogar-patch-1 
Remove output_format_markdown_escape_special_characters from settings changes history
 2023-09-14 15:45:05 +02:00
Mikhail f. Shiryaev
bf962a8674
Merge pull request #54517 from HarryLeeIBM/hlee-s390x-jemalloc-bins 
Fix endian issue in jemalloc_bins for s390x
 2023-09-14 15:43:50 +02:00
János Benjamin Antal
f7ceb76dcb Fix pylint and mypy issues 2023-09-14 13:41:34 +00:00
avogar
7e6c41fd15 Better test 2023-09-14 13:37:26 +00:00
avogar
f240243c86 Fix schema inference for *Cluster functions for column names with spaces 2023-09-14 13:34:11 +00:00
Vitaly Baranov
9a0e1ef592 Fix sorting of UNION ALL of already sorted results. 2023-09-14 15:04:37 +02:00
Vitaly Baranov
1eec898274 Add test. 2023-09-14 15:04:32 +02:00
Antonio Andelic
ae88bd3da5
Merge pull request #54572 from ClickHouse/fix-install-backup 
Fix snapshot install in Keeper
 2023-09-14 14:44:45 +02:00
Robert Schulze
e018f1d913
Fix spelling 2023-09-14 12:42:22 +00:00
Azat Khuzhin
929d5d6097 Add stateless test for clickhouse keeper-client --no-confirmation (resubmit) 
Reverts: #54616
Resubmits: #54547

This reverts commit d23daca082, reversing
changes made to e111d4abd3.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-09-14 14:25:09 +02:00
János Benjamin Antal
699bf031c9 Remove accidentally committed code 2023-09-14 12:07:15 +00:00
János Benjamin Antal
51781a6a86 Add workflow 2023-09-14 12:05:50 +00:00
János Benjamin Antal
078c16760f Add --remote-protocol arg 2023-09-14 12:05:49 +00:00
Ilya Yatsishin
67e6725284
Merge pull request #54622 from ClickHouse/vdimir/cluster_discovery_doc 
Add cluster discovery documentation
 2023-09-14 14:00:07 +02:00
robot-clickhouse
0fda5e4bf2 Automatic style fix 2023-09-14 11:44:34 +00:00
János Benjamin Antal
da802b2688 Do the release 2023-09-14 11:28:35 +00:00
Michael Kolupaev
8997464867
Small usearch index improvements: metrics and f16 2023-09-14 11:24:47 +00:00
Kseniia Sumarokova
eeb2c5b223
Merge pull request #53220 from valbok/double-to-single 
MaterializedMySQL: Introduce Character Set Introducers
 2023-09-14 13:18:08 +02:00
János Benjamin Antal
b13a07863d Add gh_cache to gitignore to pass dirty check 2023-09-14 11:17:20 +00:00
vdimir
10bcc028df
Add cluster discovery documentation 2023-09-14 11:16:09 +00:00
Nikita Taranov
079b52fa93
[Resubmit] Remove mmap/mremap/munmap from Allocator.h (#52792) 
* Revert "Revert "Remove `mmap/mremap/munmap` from Allocator.h" (#52589)"

This reverts commit 0a838dc6d1.

* pre-fault pages

* upd contrib to merge commit

* limit log rate

* Update Allocator.h

---------

Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
 2023-09-14 13:11:12 +02:00
Nikita Taranov
bdb52eefc4
Fix race in ColumnUnique.h (#54575) 2023-09-14 12:55:08 +02:00
János Benjamin Antal
6df371754d Fix typos in release.py 2023-09-14 10:54:17 +00:00
Maksim Kita
310dc22266 FunctionHelpers remove areTypesEqual function 2023-09-14 13:51:06 +03:00
Andrey Zvonov
7dd5dbb2ac
Merge branch 'ClickHouse:master' into zvonand-globs-small-fix 2023-09-14 13:49:59 +03:00
Vitaly Baranov
f427ca771e Fix optimize read in order for views. 2023-09-14 12:44:43 +02:00
Robert Schulze
d0ad2fee5c
Ignore different rounding on ARM 2023-09-14 10:37:34 +00:00
Robert Schulze
a9ae813db0
Merge pull request #54115 from slvrtrn/simplified-prepared-statements-for-mysql 
Implement the MySQL binary protocol implementation for initial support of Tableau Online
 2023-09-14 12:27:11 +02:00
János Benjamin Antal
33eeb0737f Fix style errors 2023-09-14 10:23:26 +00:00
Antonio Andelic
6306180333
Merge pull request #53049 from ClickHouse/keeper-batch-flushes 
Try batching multiple flush requests in Keeper
 2023-09-14 11:39:33 +02:00
Andrey Zvonov
ff16ddbbb3
Merge branch 'ClickHouse:master' into zvonand-globs-small-fix 2023-09-14 11:31:49 +03:00
Antonio Andelic
86d3d16539 Merge branch 'master' into fix-install-backup 2023-09-14 07:07:15 +00:00
Val Doroshchuk
6cfbaf9f86 MaterializedMySQL: Introduce Character Set Introducers 
If some string literals are used in DDL, they might have `Character Set Introducers`
https://dev.mysql.com/doc/refman/8.0/en/charset-introducer.html
f.e. _utf8mb4'1' which is not parsable by current ParserStringLiteral.

Since we use utf8 by default, suggesting to automatically convert the string literals to utf8
before executing the query and avoid any charset introducers there.
Conversion from utf8 to utf8 is not needed and skipped.

Also it might convert double quotes to single quotes if any
which might solve issues with COMMENT and empty string literals "" in DEFAULT expressions.

SELECT _latin1"abc"; -- might be also valid for MySQL
... DEFAULT "",
... COMMENT "abc"

Currently no DEFAULT expressions are supported, not parsable at all,
but using this MR it allows to parse the expressions together with double quotes as string literals.
 2023-09-14 08:24:25 +02:00
lgbo-ustc
e8d217634e improve json sql functions by serilizing data into column direclty 2023-09-14 12:41:17 +08:00
bakam412
c5c3833a80 fix tests 2023-09-14 11:12:44 +08:00
Alexey Milovidov
b4f9d8a517
Merge pull request #54601 from nickitat/fix_col_decimal_serialization 
Fix serialization of `ColumnDecimal`
 2023-09-14 04:54:00 +03:00
Alexey Milovidov
9be779beca
Update 02875_fix_column_decimal_serialization.sql 2023-09-14 04:53:17 +03:00
Alexey Milovidov
d23daca082
Merge pull request #54616 from ClickHouse/revert-54547-keeper-non-interactive-confirm 
Revert "Add stateless test for clickhouse keeper-client --no-confirmation"
 2023-09-14 04:43:38 +03:00
Alexey Milovidov
02adae79e0
Revert "Add stateless test for clickhouse keeper-client --no-confirmation" 2023-09-14 04:43:23 +03:00
robot-clickhouse-ci-2
e111d4abd3
Merge pull request #54610 from CurtizJ/fix-after-refactoring 
Fix reading of virtual columns in reverse order
 2023-09-14 03:38:27 +02:00
János Benjamin Antal
462f4111de Turn PoC into real script without calling release.py 2023-09-13 23:33:04 +00:00
slvrtrn
44e1f6b53d Fix LowCardinality/Nullable columns issues 2023-09-13 23:40:31 +02:00
Yarik Briukhovetskyi
15409ff172
Merge branch 'ClickHouse:master' into arr_scalar_mult_div_modulo 2023-09-14 00:34:30 +03:00
Anton Popov
df2d1ed638 fix reading of virtual columns in reverse order 2023-09-13 21:09:49 +00:00
Alexey Milovidov
aaa7025b1a
Merge pull request #54603 from fionera/use-env 
use env to find bash
 2023-09-13 23:50:55 +03:00
HarryLeeIBM
45b06d275d Trigger Build 2023-09-13 13:20:51 -07:00