Commit Graph

9972 Commits

Author SHA1 Message Date
Alexey Milovidov
0fa5142715 Remove tons of garbage 2021-01-31 05:36:52 +03:00
Alexey Milovidov
5c718c8754 Merge branch 'master' into unicode-asan 2021-01-31 02:40:24 +03:00
alexey-milovidov
8ac39e7f56
Merge pull request #19791 from ClickHouse/format-readable-time-delta-ubsan
formatReadableTimeDelta: correctly output infinite values
2021-01-31 01:37:59 +03:00
Alexey Milovidov
30e1db7f47 Merge branch 'master' into azat-client-complete-error-codes 2021-01-31 00:01:47 +03:00
alexey-milovidov
d9e4ea8e58
Merge pull request #19853 from azat/bit-func-forbid-floats
Forbid bit functions for floats
2021-01-31 00:00:15 +03:00
bharatnc
e967ba5f3b try fix clang-11-darwin build 2021-01-30 12:12:38 -08:00
Maksim Kita
155f6c0eb5 Function reinterpretAs updated to support big integers 2021-01-30 22:56:23 +03:00
vdimir
5cb99ae699
Use offsets in FunctionIPv6StringToNum for copying ipv4 to buffer 2021-01-30 20:20:11 +03:00
Vitaly Baranov
95177dc0de Fix access to the key as an attribute in IPAddressDictionary. 2021-01-30 19:06:54 +03:00
Vitaly Baranov
7c8deae0e1 Fix starting the server with tables having columns' default expressions containing dictGet().
Allow getting return type of dictGet() without loading dictionary.
2021-01-30 19:06:48 +03:00
Vitaliy Zakaznikov
dc9c3c8514 Fixing styling errors.
Adding simple tests.
2021-01-30 09:00:42 -05:00
Nikolai Kochetov
f7dc83ae96
Merge pull request #19725 from ClickHouse/limit-push-down
Update QueryPlan tree optimization traverse.
2021-01-30 16:34:46 +03:00
Azat Khuzhin
502d981ab4 Use BinaryArithmeticOverloadResolver::valid_on_float_arguments for lcm/gcd 2021-01-30 09:12:31 +03:00
Azat Khuzhin
7da4083237 Forbid bit functions for floats
This will fix the following UB report [1]:

  "../src/Functions/bitAnd.cpp:24:61: runtime error: nan is outside the
range of representable values of type 'long' Received signal -3 Received
signal Unknown signal (-3)"

  [1]: https://clickhouse-test-reports.s3.yandex.net/19824/89c4055202b9d08459f90ee5791d4e3017b82fbf/fuzzer_ubsan/report.html#fail1
2021-01-30 09:12:31 +03:00
Alexey Milovidov
d44ce00391 Merge branch 'master' into format-readable-time-delta-ubsan 2021-01-30 07:28:38 +03:00
Alexander Kuzmenkov
5519e4c134 unbounded following frame end 2021-01-30 04:16:44 +03:00
Vitaliy Zakaznikov
3de4690450 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into live_view_periodic_refresh 2021-01-29 19:57:13 -05:00
Alexander Kuzmenkov
f42aefc4a4
Merge pull request #19750 from excitoon-favorites/s3betterglobs
Used global region for accessing S3 if can't determine exactly
2021-01-29 23:44:14 +03:00
Alexander Kuzmenkov
98e88d7305
Merge pull request #19793 from excitoon-favorites/fixcompressions3
Fixed table function S3 `auto` compression mode
2021-01-29 23:42:05 +03:00
Pavel Kruglov
d27f5114c5 Add LOG_DEBUG for tests debug 2021-01-29 23:21:11 +03:00
Azat Khuzhin
1fe003b85e Make system.asynchronous_metrics available just after start 2021-01-29 22:10:04 +03:00
Azat Khuzhin
89c4055202 Lock MEMORY_LIMIT_EXCEEDED error from tryLogCurrentException()
This will avoid hiding some exceptions in logs, when the server is under
high memory pressure (i.e. when any new allocation will lead to
MEMORY_LIMIT_EXCEEDED error).

This became more relevent after all memory allocations was tracked with
MemoryTracker, by falling back to total_memory_tracking, in #16121
2021-01-29 21:38:14 +03:00
alexey-milovidov
276e972166
Merge pull request #19789 from ClickHouse/fix-great-circle-angle
Fix mistake in greatCircleAngle
2021-01-29 21:35:26 +03:00
alexey-milovidov
d19feb724b
Merge pull request #19799 from CurtizJ/fix-uint8-filtering
Fix filtering by Uint8 greater than 127
2021-01-29 21:34:42 +03:00
Pavel Kruglov
25e85d71ee Merge branch 'master' of github.com:ClickHouse/ClickHouse into hedged-requests 2021-01-29 21:08:47 +03:00
Pavel Kruglov
78371e15dc Update test, reduce num_threads_for_lonely_parts if data is small 2021-01-29 21:00:08 +03:00
alesapin
f4236fd765 Fix style 2021-01-29 20:12:53 +03:00
Pavel Kruglov
6029597877 Fix style error 2021-01-29 19:56:47 +03:00
alesapin
c373d92a80 Less strict check 2021-01-29 18:50:08 +03:00
Pavel Kruglov
01a0cb649a Fix build, style, tests 2021-01-29 18:46:28 +03:00
Pavel Kruglov
71f4acd48b Use one pool for lonely parts, update tests 2021-01-29 17:30:14 +03:00
Ilya Yatsishin
a353020c54
Merge pull request #19804 from davenger/odbc_build_fix
Fix dependency on ODBC for Yandex internal build
2021-01-29 16:50:59 +03:00
alexey-milovidov
f8c897d308
Merge pull request #19798 from ClickHouse/test-connections
Add test script for #19794
2021-01-29 16:24:45 +03:00
alexey-milovidov
4cfcc18a7f
Merge pull request #19786 from ClickHouse/int-round-ubsan
Fix UBSan report in "round"
2021-01-29 14:59:12 +03:00
alexey-milovidov
0679d81c0d
Merge pull request #19788 from ClickHouse/array-enumerate-extended-bug
Fix trivial bug in arrayEnumerateUniq
2021-01-29 14:58:38 +03:00
Alexander Gololobov
0ee05d34fc Fix dependency on ODBC for Yandex internal build 2021-01-29 14:54:54 +03:00
Pavel Kruglov
a437ee4e31 Merge branch 'master' of github.com:ClickHouse/ClickHouse into select-final 2021-01-29 14:25:47 +03:00
Kruglov Pavel
caef103837
Merge branch 'master' into Add_IStoragePolicy_interface 2021-01-29 14:00:12 +03:00
Nikolai Kochetov
9f9b7fc3e2 Update ya.make 2021-01-29 13:05:21 +03:00
Maksim Kita
c7401f219f
Merge pull request #18236 from kitaisreal/dictionaries-support-for-nullable-and-array
[WIP] Dictionaries support for Array and Nullable
2021-01-29 12:02:23 +03:00
Anton Popov
031132038b fix filtering by uint8 greater than 127 2021-01-29 10:39:18 +03:00
Alexey Milovidov
5a92e633a1 Remove useless headers 2021-01-29 10:37:46 +03:00
Alexey Milovidov
bfcb12c2e9 Add test-connect tool 2021-01-29 09:13:43 +03:00
alexey-milovidov
76894ccb9f
Update greatCircleDistance.cpp 2021-01-29 08:52:52 +03:00
Alexey Milovidov
9477f8a8b1 Revert "Remove old non-automated test"
This reverts commit 217d05443a.
2021-01-29 08:27:58 +03:00
Vladimir Chebotarev
d729aacb09 Fixed table function S3 auto compression mode. 2021-01-29 07:54:52 +03:00
Alexey Milovidov
1e2669fd3c Fix error 2021-01-29 07:54:46 +03:00
Alexey Milovidov
f06bb78c5d Merge branch 'master' into unicode-asan 2021-01-29 05:18:29 +03:00
Alexey Milovidov
eee84eec79 formatReadableTimeDelta: correctly output infinite values 2021-01-29 05:14:15 +03:00
Alexey Milovidov
f4a05bd773 Fix mistake in greatCircleAngle 2021-01-29 05:05:46 +03:00
taiyang-li
35f8a0810a fix client bug while executing select 2021-01-29 09:59:26 +08:00
Alexey Milovidov
b3944006cb Fix trivial bug in arrayEnumerateUniq 2021-01-29 04:41:55 +03:00
alexey-milovidov
10160e5adf
Merge pull request #19767 from kitaisreal/low-cardinality-uuid-fix
LowCardinality UUID fix
2021-01-29 04:06:28 +03:00
Alexey Milovidov
eb0473c3f9 Fix UBSan report in "round" 2021-01-29 04:03:38 +03:00
alexey-milovidov
fa7a795c3a
Merge pull request #19588 from ClickHouse/disable-checksums-on-read
Allow to disable checksums on read
2021-01-29 02:37:26 +03:00
Alexander Kuzmenkov
2dd5062cc0 use current row as partition etalon 2021-01-28 23:46:22 +03:00
Alexander Kuzmenkov
09e192395a update comments and apply the setNeeded() advice from Nikolai 2021-01-28 23:39:27 +03:00
alesapin
2881c830e3 Merge branch 'master' into fix_rare_bug_after_part_corruption 2021-01-28 23:16:52 +03:00
Alexander Kuzmenkov
1b891e042d fix a bug 2021-01-28 21:18:16 +03:00
alexey-milovidov
8dbafc90ca
Merge pull request #19763 from ClickHouse/fix-crash-with-array-filter
Fix crash when nested column name was used in `WHERE` or `PREWHERE`
2021-01-28 20:19:04 +03:00
Alexander Kuzmenkov
3ace39fbf7 simplify a loop and make RANGE frame the default 2021-01-28 20:05:01 +03:00
alexey-milovidov
3c09bcc771
Merge pull request #19758 from ClickHouse/join-minor-improvement
Minor code improvement in JOIN
2021-01-28 19:24:00 +03:00
Maksim Kita
f621871465 Fixed race in tests 2021-01-28 19:17:46 +03:00
alesapin
be1104d6c1 Fix typos 2021-01-28 19:07:47 +03:00
tavplubix
37455304e7
Update FieldVisitorsAccurateComparison.h 2021-01-28 18:51:01 +03:00
tavplubix
817df99d11
Update FieldVisitorsAccurateComparison.h 2021-01-28 18:29:21 +03:00
alexey-milovidov
386bcb07da
Merge pull request #19736 from ClickHouse/stack-overflow-coroutine
Fix stack overflow in coroutine
2021-01-28 18:20:44 +03:00
alesapin
c1d18fc8a2 Fix very rare case 2021-01-28 18:10:53 +03:00
Alexander Kuzmenkov
e553eb112f cleanup 2021-01-28 16:47:06 +03:00
Alexander Kuzmenkov
629cb44d4c everything was wrong 2021-01-28 16:42:18 +03:00
Nikolai Kochetov
3b50a74759 Simplify optimization interface. 2021-01-28 15:32:02 +03:00
alesapin
a7ca26fec4
Merge pull request #19708 from ClickHouse/fix_flaky_test_multiple_ttl
Fix flaky test test_concurrent_ttl_merges
2021-01-28 15:26:56 +03:00
yiguolei
b0d645eea8 check active replicas and detached tables 2021-01-28 20:12:00 +08:00
Nikolai Kochetov
4ef56a41cb Simplify optimizeTree 2021-01-28 14:15:45 +03:00
Maksim Kita
105ecef628 LowCardinality UUID fix 2021-01-28 14:11:34 +03:00
Nikolai Kochetov
e1765e7f88 Add method trivial to ActionsDAG 2021-01-28 14:00:24 +03:00
Nikolai Kochetov
e2ade3c574 Check where and prewhere identifiers exist. 2021-01-28 12:40:08 +03:00
alexey-milovidov
045a8e8a0c
Merge pull request #19487 from ucasFL/ms
remove part of misleading exception message
2021-01-28 12:01:24 +03:00
Alexey Milovidov
b9b573976e Minor code improvement in JOIN 2021-01-28 11:26:10 +03:00
alexey-milovidov
6c5302969b
Merge pull request #19704 from ClickHouse/fix-crash-after-actions-dag-merge
Fix crash after merging ActionsDAG.
2021-01-28 11:16:39 +03:00
Maksim Kita
03eec39719
Merge pull request #19712 from kitaisreal/added-functions-parse-date-time-best-effort-us-or-zero-or-null
Added functions parseDateTimeBestEffortUSOrZero, parseDateTimeBestEffortUSOrNull
2021-01-28 11:13:45 +03:00
alesapin
d14f4a525b Merge branch 'master' into fix_rare_bug_after_part_corruption 2021-01-28 11:09:41 +03:00
Alexey Milovidov
7086402859 Merge branch 'master' into disable-checksums-on-read 2021-01-28 11:08:13 +03:00
alesapin
402e031a22 Throw exception only in debug mode 2021-01-28 11:07:18 +03:00
Alexey Milovidov
d42afe703c Merge branch 'master' into unicode-asan 2021-01-28 10:45:46 +03:00
alexey-milovidov
342326978f
Merge branch 'master' into stack-overflow-coroutine 2021-01-28 10:45:20 +03:00
Alexey Milovidov
355c99568e Fix error 2021-01-28 10:16:36 +03:00
alexey-milovidov
7c240d0ca7
Merge pull request #17870 from excitoon-favorites/s3testiostream
Update of AWS C++ SDK
2021-01-28 07:12:52 +03:00
Alexey Milovidov
297cfb4857 Less parser depth 2021-01-28 06:34:44 +03:00
Alexey Milovidov
708e68b983 Fix stack overflow in coroutine 2021-01-28 04:28:19 +03:00
Alexey Milovidov
9e1c1157b5 Fix error 2021-01-28 04:08:48 +03:00
Alexey Milovidov
d69af4333d Better asserts 2021-01-28 03:46:12 +03:00
Alexey Milovidov
b0b4ccbc6c Merge branch 'master' into unicode-asan 2021-01-28 03:37:17 +03:00
Alexey Milovidov
065d22cf2b Merge branch 'master' into disable-checksums-on-read 2021-01-28 03:07:31 +03:00
alexey-milovidov
fa48545b87
Merge pull request #19617 from ClickHouse/fix-lc-neighbour
Fix function neighbor for LowCardinality argument.
2021-01-28 03:06:56 +03:00
alexey-milovidov
fa419cead2
Merge pull request #19713 from kitaisreal/roaring-bitmap-with-small-set-rbandnot-fix
RoaringBitmapWithSmallSet rb_andnot fix
2021-01-28 03:02:20 +03:00
Anton Popov
e5125b8c73 add comments and test for compatibility 2021-01-28 02:39:15 +03:00
Maksim Kita
ff371ccdb6 Fixed data race in function DictGetNoType 2021-01-27 23:22:05 +03:00
Vladimir Chebotarev
76e62739ed Fixed build. 2021-01-27 23:05:41 +03:00
Nikolai Kochetov
3b7373e992 More comments. 2021-01-27 22:53:07 +03:00
Nikolai Kochetov
b244499d69 Fix build. 2021-01-27 22:24:59 +03:00
alesapin
c74631c650 Fix test and add logical error 2021-01-27 21:54:05 +03:00
bharatnc
419c916612 replace strcat with memcpy 2021-01-27 10:16:46 -08:00
Azat Khuzhin
acde56ff8a Add separate pool for message brokers (RabbitMQ and Kafka)
background_message_broker_schedule_pool_size was introduced in #13939,
but never used actually, use it for RabbitMQ and Kafka.
2021-01-27 21:08:41 +03:00
Nikolai Kochetov
cf05c17cfa Rewrite QueryPlan tree optimizations traverse. 2021-01-27 20:36:53 +03:00
Alexey Milovidov
95e15131a8 Fix unsufficient args check (trash code) in StringSearcher 2021-01-27 20:32:59 +03:00
Anton Popov
a8f3078ce9 Merge remote-tracking branch 'upstream/master' into HEAD 2021-01-27 19:48:55 +03:00
vdimir
36963e0eba
Minor fix 2021-01-27 18:17:42 +03:00
Maksim Kita
a3d6888c5b RoaringBitmapWithSmallSet rb_andnot fix 2021-01-27 18:01:08 +03:00
Maksim Kita
9db9ce11dc Added functions parseDateTimeBestEffortUSOrZero, parseDateTimeBestEffortUSOrNull 2021-01-27 17:10:06 +03:00
Nikolai Kochetov
e9f893d9b0 Move query plan optimixations into separate files. 2021-01-27 16:57:26 +03:00
Nikolai Kochetov
eba2cbfaff
Update neighbor.cpp 2021-01-27 16:26:16 +03:00
Maksim Kita
f0b1bc88c7 Fixed style issues 2021-01-27 16:25:27 +03:00
Maksim Kita
67ffa4189e Fixed clang build 2021-01-27 16:25:27 +03:00
Maksim Kita
31881d24ad Fixed clang errors 2021-01-27 16:25:27 +03:00
Maksim Kita
8e8d6f36ac Fixed DictionaryDefaultValueExtractor 2021-01-27 16:25:27 +03:00
Maksim Kita
6653e356a3 Fixed build issues 2021-01-27 16:25:27 +03:00
Maksim Kita
b7a150cc63 Updated DictionaryDefaultValueExtractor interface 2021-01-27 16:25:27 +03:00
Maksim Kita
c4ffa2160f Updated interfaces. Added documentation. 2021-01-27 16:25:27 +03:00
Maksim Kita
b0d3f32a36 Added DefaultValueExtractor 2021-01-27 16:25:27 +03:00
Maksim Kita
b11905f493 Fixed tests 2021-01-27 16:25:27 +03:00
Maksim Kita
7cb7d4dbce Fixed dicitionaries todo 2021-01-27 16:25:27 +03:00
Maksim Kita
498df53ebf Fixed style issues 2021-01-27 16:25:27 +03:00
Maksim Kita
77d2e00dd8 Updated DictionaryStructure 2021-01-27 16:25:27 +03:00
Maksim Kita
42d4fc1bbd Updated FlatDictionary 2021-01-27 16:25:27 +03:00
Maksim Kita
3d0778cba4 FunctionsExternalDictionaries refactored 2021-01-27 16:25:27 +03:00
Maksim Kita
a45459e095 Fixed tests 2021-01-27 16:25:27 +03:00
Maksim Kita
357b0b95a9 Added Nullable support for ComplexDirectDictionary 2021-01-27 16:25:27 +03:00
Maksim Kita
25d6e18ec0 Added Nullable support for ComplexKeyHashedDictionary 2021-01-27 16:25:27 +03:00
Maksim Kita
6e51b2f60a Added Nullable support for RangeHashedDictionary 2021-01-27 16:25:27 +03:00
Maksim Kita
b745c64459 Added Nullable support for DirectDictionary 2021-01-27 16:25:27 +03:00
Maksim Kita
3e2d615e62 Added Nullable support for HashedDictionary 2021-01-27 16:25:27 +03:00
Maksim Kita
7ded8be0d5 Added Nullable support for FlatDictionary 2021-01-27 16:25:27 +03:00
Maksim Kita
b01027787e Fixed tests 2021-01-27 16:25:27 +03:00
Maksim Kita
164e55972b Fix style issue 2021-01-27 16:25:27 +03:00
Maksim Kita
791c7204d7 Fix style issues 2021-01-27 16:25:27 +03:00
Maksim Kita
8fdbde8642 Updated PolygonDictionary to new interface 2021-01-27 16:25:27 +03:00
Maksim Kita
0ed64d8ab0 Simplified getColumn implementation 2021-01-27 16:25:27 +03:00
Maksim Kita
6f7ad82160 Updated IPAddressDictionary to new interface 2021-01-27 16:25:26 +03:00
Maksim Kita
07fab85cc4 Updated SSDComplexKeyCacheDictionary to new interface 2021-01-27 16:25:26 +03:00
Maksim Kita
0d2e498ed4 Updated ComplexKeyCacheDictionary to new interface 2021-01-27 16:25:26 +03:00
Maksim Kita
b4896ee82b Updated ComplexKeyDirectDictionary to new interface 2021-01-27 16:25:26 +03:00
Maksim Kita
81f4bc7b4c Updated SSDCacheDictionary to new interface 2021-01-27 16:25:26 +03:00
Maksim Kita
6017d1a034 Updated CachedDictionary to new interface 2021-01-27 16:25:26 +03:00
Maksim Kita
cd6ec3234e Updated DirectDictionary to new interface 2021-01-27 16:25:26 +03:00
Maksim Kita
cc767d4f2e Updated HashedDictionary to new interface 2021-01-27 16:25:26 +03:00
Maksim Kita
d61e8c083b Updated RangeHashedDictionary to new interface 2021-01-27 16:25:26 +03:00
Maksim Kita
d92d843e20 Fixed compile issue 2021-01-27 16:25:26 +03:00
Maksim Kita
8bd98ae432 Remove previous interface enum 2021-01-27 16:25:26 +03:00
Maksim Kita
f24a8eadb2 Updated ComplexKeyHashed dictionary to new interface 2021-01-27 16:25:26 +03:00
Maksim Kita
d16a572eee Updated IDictionaryBase interface 2021-01-27 16:25:26 +03:00
Maksim Kita
7a2f6cd5b9 Dictionaries refactoring to new interface 2021-01-27 16:25:26 +03:00
alesapin
5622e6daa6 Fix rare max_number_of_merges_with_ttl_in_pool limit overrun for non-replicated MergeTree 2021-01-27 14:56:12 +03:00
Nikolai Kochetov
d13ec0d909 Fix crash after mergine ActionsDAG. 2021-01-27 14:10:09 +03:00
alexey-milovidov
5e54c9742f
Merge pull request #19683 from ClickHouse/mysql-compatibility
Merging #19387
2021-01-27 13:48:26 +03:00
alexey-milovidov
c3828a1fb2
Merge pull request #19660 from CurtizJ/sync-directory
Better abstractions in disk interface
2021-01-27 13:47:53 +03:00
alesapin
6fc39b10d3 Spelling 2021-01-27 13:11:48 +03:00
alesapin
01c8b9e1b1 Fix rare bug when some replicated operations (like mutation) cannot process some parts after data corruption 2021-01-27 13:07:18 +03:00
Nikolai Kochetov
e3ac2639d2
Merge pull request #19648 from ClickHouse/fix-merge-join-constants
Fix merge join constants
2021-01-27 12:49:27 +03:00
Pavel Kruglov
b3b832cde7 Work with any number of replicas simultaneously, support max_parallel_replicas 2021-01-27 12:33:11 +03:00
Maksim Kita
bd81f43ecb
Merge pull request #19672 from ClickHouse/bigint-remove-old-code
Remove old code for BigInt.
2021-01-27 11:28:45 +03:00
Maksim Kita
3f0b0287da
Merge pull request #19678 from kitaisreal/dictionary-better-error-message-during-attribute-parsing
Dictionary better error message during attribute parsing
2021-01-27 11:28:03 +03:00
alesapin
784ff75d55
Merge pull request #19661 from ClickHouse/fix_obvious_deadlock_in_testkeeper
Fix deadlock in testkeeper
2021-01-27 10:09:11 +03:00
Vladimir Chebotarev
afdea5eff0 Changed handling of PocoHTTPClientConfiguration in order to ensure AWS SDK is initialized. 2021-01-27 09:38:35 +03:00
yiguolei
6693f77c32 fix code style 2021-01-27 13:56:36 +08:00
guoleiyi
9d086f445d Should fail ddl query as soon as possible if table is shutdown 2021-01-27 10:58:07 +08:00
Alexey Milovidov
16b7a0e8ad Merge branch 'master' into mysql-compatibility 2021-01-27 05:07:30 +03:00
Alexey Milovidov
48b4d98b21 Amend 2021-01-27 04:48:41 +03:00
alexey-milovidov
2028228f4b
Merge pull request #18684 from amosbird/betterwith
better CTE and with global
2021-01-27 04:33:17 +03:00
Alexey Milovidov
a6f5f40a65 Merge branch 'master' into disable-checksums-on-read 2021-01-27 04:09:00 +03:00
Anton Popov
09e5bdd1ef fix style check 2021-01-27 03:57:28 +03:00
Anton Popov
b15848e2f0
Update IDisk.h 2021-01-27 03:32:18 +03:00
Alexander Kuzmenkov
0d69249c56 typo 2021-01-27 03:27:40 +03:00
Alexander Kuzmenkov
83cfdde6d9 RANGE frame works in some cases 2021-01-27 03:08:15 +03:00
Maksim Kita
e0dc6f9417 Dictionary better error message during attribute parsing 2021-01-27 00:50:23 +03:00
Maksim Kita
46be4d12ac
Merge pull request #19663 from ucasFL/fix-build
fix special build on clang11
2021-01-27 00:00:31 +03:00
Maksim Kita
81548e051e
Merge pull request #19527 from ucasFL/sign
add sign math function
2021-01-26 23:57:31 +03:00
alexey-milovidov
e8dedbf210
Merge pull request #19532 from azat/UBsan-report-fixes-v2
Forbid lcm/gcd for floats (and few UBsan reports fixes)
2021-01-26 23:16:54 +03:00
Alexey Milovidov
f3929b151a Remove even more code 2021-01-26 22:04:03 +03:00
Alexey Milovidov
877be11398 Remove useless code, part 2 2021-01-26 21:32:46 +03:00
Alexey Milovidov
5f13fdddc0 Remove useless code from BigInt 2021-01-26 21:22:40 +03:00
Alexander Kuzmenkov
10a8831d8b partition by -- single loop 2021-01-26 20:59:38 +03:00
Vladimir Chebotarev
3322cc812d Updated AWS C++ SDK. 2021-01-26 20:58:02 +03:00
vdimir
fc8b8d23b2
Merge pull request #18812 from excitoon-favorites/betters3endpoints
Added prefix-based S3 endpoint settings
2021-01-26 20:47:57 +03:00
Alexander Kuzmenkov
b8a2a29f94 cleanup 2021-01-26 18:31:09 +03:00
feng lv
2dd723e214 fix special build on clang11 2021-01-26 15:20:51 +00:00
Amos Bird
d6c0479cf9
add normalizeQueryKeepNames and normalizedQueryHashKeepNames (#18910) 2021-01-26 17:51:30 +03:00
Anton Popov
c7070da85a better abstractions in disk interface 2021-01-26 17:49:35 +03:00
alesapin
0ff05d2403 Fix deadlock in testkeeper 2021-01-26 17:30:29 +03:00
alexey-milovidov
985805fd01
Merge pull request #19583 from ClickHouse/merge-log-comment
Merging #18549
2021-01-26 17:11:07 +03:00
Nikolai Kochetov
578f36e4f3 Update test.Fix ya.make. 2021-01-26 16:58:49 +03:00
vdimir
bcae07128a
Merge pull request #19530 from taiyang-li/length_for_map
enable length for map, which returns keys number in map
2021-01-26 16:21:21 +03:00
vdimir
a4643bcff2
Whitespace fixes 2021-01-26 16:19:13 +03:00
Nikolai Kochetov
b0c324227d Remove comment. 2021-01-26 15:39:55 +03:00
Nikolai Kochetov
87246ea91b Fix header for MergeJoin with constants. 2021-01-26 15:37:42 +03:00
Azat Khuzhin
e97c01c3ea
Fix UAF of the CompressedWriteBuffer after Connection::disconnect (#19599)
ASan report [1]:

<details>

Stacktrace with stripped shared_ptr and vector stuff:

```
==86==ERROR: AddressSanitizer: heap-use-after-free on address 0x60d0002b4888 at pc 0x00000a997056 bp 0x7f9e2ad55c00 sp 0x7f9e2ad55bf8
READ of size 8 at 0x60d0002b4888 thread T3 (TCPHandler)
    0 0xa997055 in DB::BufferBase::Buffer::end() const obj-x86_64-linux-gnu/../src/IO/BufferBase.h:40:46
    1 0xa997055 in DB::BufferBase::available() const obj-x86_64-linux-gnu/../src/IO/BufferBase.h:81:68
    2 0xa997055 in DB::BufferBase::hasPendingData() const obj-x86_64-linux-gnu/../src/IO/BufferBase.h:94:56
    3 0xa997055 in DB::WriteBuffer::nextIfAtEnd() obj-x86_64-linux-gnu/../src/IO/WriteBuffer.h:67:14
    4 0xa997055 in DB::WriteBuffer::write(char const*, unsigned long) obj-x86_64-linux-gnu/../src/IO/WriteBuffer.h:78:13
    5 0x1dcff45e in DB::CompressedWriteBuffer::nextImpl() obj-x86_64-linux-gnu/../src/Compression/CompressedWriteBuffer.cpp:37:9
    6 0x1dcffb8a in DB::WriteBuffer::next() obj-x86_64-linux-gnu/../src/IO/WriteBuffer.h:46:13
    7 0x1dcffb8a in DB::CompressedWriteBuffer::~CompressedWriteBuffer() obj-x86_64-linux-gnu/../src/Compression/CompressedWriteBuffer.cpp:54:9
    11 0xab600cf in DB::Connection::~Connection() obj-x86_64-linux-gnu/../src/Client/Connection.h:114:28
    15 0xac4adb9 in PoolBase<DB::Connection>::PooledObject::~PooledObject() obj-x86_64-linux-gnu/../src/Common/PoolBase.h:35:12
    30 0xac485e4 in PoolBase<DB::Connection>::~PoolBase() obj-x86_64-linux-gnu/../src/Common/PoolBase.h:105:26
    44 0xad2722f in DB::Cluster::ShardInfo::~ShardInfo() obj-x86_64-linux-gnu/../src/Interpreters/Cluster.h:167:12
    52 0xad393b0 in DB::Cluster::~Cluster() obj-x86_64-linux-gnu/../src/Interpreters/Cluster.h:30:7
    56 0x1f99f269 in DB::StorageDistributed::~StorageDistributed() obj-x86_64-linux-gnu/../src/Storages/StorageDistributed.cpp:338:41
    69 0x1e231846 in DB::Context::~Context() obj-x86_64-linux-gnu/../src/Interpreters/Context.cpp:501:19
    71 0x2073ccd3 in DB::TCPHandler::runImpl() obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:416:23
    72 0x2075db1c in DB::TCPHandler::run() obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:1417:9

0x60d0002b4888 is located 56 bytes inside of 136-byte region [0x60d0002b4850,0x60d0002b48d8)
freed by thread T3 (TCPHandler) here:
    0 0xa93d682 in operator delete(void*, unsigned long) (/workspace/clickhouse+0xa93d682)
    1 0x2059d592 in std::__1::__shared_weak_count::__release_shared() obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2518:9
    2 0x2059d592 in std::__1::shared_ptr<DB::WriteBuffer>::~shared_ptr() obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:3212:19
    3 0x2059d592 in std::__1::shared_ptr<DB::WriteBuffer>::operator=(std::__1::shared_ptr<DB::WriteBuffer>&&) obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:3243:5
    4 0x2059d592 in DB::Connection::disconnect() obj-x86_64-linux-gnu/../src/Client/Connection.cpp:143:9
    5 0x205d6e6d in DB::MultiplexedConnections::disconnect() obj-x86_64-linux-gnu/../src/Client/MultiplexedConnections.cpp:159:25
    6 0x1de6ec19 in DB::RemoteQueryExecutor::~RemoteQueryExecutor() obj-x86_64-linux-gnu/../src/DataStreams/RemoteQueryExecutor.cpp:86:34
    10 0x20bf0e2c in DB::RemoteSource::~RemoteSource() obj-x86_64-linux-gnu/../src/Processors/Sources/RemoteSource.cpp:22:29
    21 0x20869680 in DB::Pipe::~Pipe() obj-x86_64-linux-gnu/../src/Processors/Pipe.h:25:7
    22 0x20869680 in DB::QueryPipeline::reset() obj-x86_64-linux-gnu/../src/Processors/QueryPipeline.cpp:79:1
    23 0x1de2d89d in DB::BlockIO::reset() obj-x86_64-linux-gnu/../src/DataStreams/BlockIO.cpp:45:14
    24 0x1de2d9f7 in DB::BlockIO::operator=(DB::BlockIO&&) obj-x86_64-linux-gnu/../src/DataStreams/BlockIO.cpp:57:5
    25 0x20762731 in DB::QueryState::operator=(DB::QueryState&&) obj-x86_64-linux-gnu/../src/Server/TCPHandler.h:31:8
    26 0x2073c70c in DB::QueryState::reset() obj-x86_64-linux-gnu/../src/Server/TCPHandler.h:85:15
    27 0x2073c70c in DB::TCPHandler::runImpl() obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:399:19
    28 0x2075db1c in DB::TCPHandler::run() obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:1417:9
    29 0x266eeebe in Poco::Net::TCPServerConnection::start() obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerConnection.cpp:43:3
    30 0x266ef9db in Poco::Net::TCPServerDispatcher::run() obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerDispatcher.cpp:112:19
    31 0x269b1204 in Poco::PooledThread::run() obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/ThreadPool.cpp:199:14
    32 0x269ab756 in Poco::ThreadImpl::runnableEntry(void*) obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Thread_POSIX.cpp:345:27
    33 0x7f9f06ea8608 in start_thread /build/glibc-ZN95T4/glibc-2.31/nptl/pthread_create.c:477:8

previously allocated by thread T3 (TCPHandler) here:
    0 0xa93ca1d in operator new(unsigned long) (/workspace/clickhouse+0xa93ca1d)
    1 0x2059b8cd in void* std::__1::__libcpp_operator_new<unsigned long>(unsigned long) obj-x86_64-linux-gnu/../contrib/libcxx/include/new:235:10
    8 0x2059b8cd in DB::Connection::connect(DB::ConnectionTimeouts const&) obj-x86_64-linux-gnu/../src/Client/Connection.cpp:112:15
    9 0x205a0a1d in DB::Connection::getServerRevision(DB::ConnectionTimeouts const&) obj-x86_64-linux-gnu/../src/Client/Connection.cpp:289:9
    10 0x205bdafa in DB::ConnectionPoolWithFailover::tryGetEntry(DB::IConnectionPool&, DB::ConnectionTimeouts const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&, DB::Settings const*, DB::QualifiedTableName const*) obj-x86_64-linux-gnu/../src/Client/ConnectionPoolWithFailover.cpp:251:45
    11 0x205c06cf in DB::ConnectionPoolWithFailover::getManyChecked()::$_8::operator()() const obj-x86_64-linux-gnu/../src/Client/ConnectionPoolWithFailover.cpp:169:16
    20 0x205bd61f in DB::ConnectionPoolWithFailover::getManyChecked(DB::ConnectionTimeouts const&, DB::Settings const*, DB::PoolMode, DB::QualifiedTableName const&) obj-x86_64-linux-gnu/../src/Client/ConnectionPoolWithFailover.cpp:172:12
    28 0x1de6f425 in DB::RemoteQueryExecutor::sendQuery() obj-x86_64-linux-gnu/../src/DataStreams/RemoteQueryExecutor.cpp:143:31
    29 0x1fdd1410 in DB::getStructureOfRemoteTableInShard(DB::Cluster const&, DB::Cluster::ShardInfo const&, DB::StorageID const&, DB::Context const&, std::__1::shared_ptr<DB::IAST> const&) obj-x86_64-linux-gnu/../src/Storages/getStructureOfRemoteTable.cpp:78:12
    30 0x1fdd74a8 in DB::getStructureOfRemoteTable(DB::Cluster const&, DB::StorageID const&, DB::Context const&, std::__1::shared_ptr<DB::IAST> const&) obj-x86_64-linux-gnu/../src/Storages/getStructureOfRemoteTable.cpp:131:32
    31 0x1d42cd79 in DB::TableFunctionRemote::getActualTableStructure(DB::Context const&) const obj-x86_64-linux-gnu/../src/TableFunctions/TableFunctionRemote.cpp:261:12
    32 0x1d42b4e2 in DB::TableFunctionRemote::executeImpl(std::__1::shared_ptr<DB::IAST> const&, DB::Context const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, DB::ColumnsDescription) const obj-x86_64-linux-gnu/../src/TableFunctions/TableFunctionRemote.cpp:222:26
    33 0x1e2c8b15 in DB::ITableFunction::execute(std::__1::shared_ptr<DB::IAST> const&, DB::Context const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, DB::ColumnsDescription) const obj-x86_64-linux-gnu/../src/TableFunctions/ITableFunction.cpp:24:16
    34 0x1e2417ff in DB::Context::executeTableFunction(std::__1::shared_ptr<DB::IAST> const&) obj-x86_64-linux-gnu/../src/Interpreters/Context.cpp:1007:35
    35 0x1f15bd67 in DB::JoinedTables::getLeftTableStorage() obj-x86_64-linux-gnu/../src/Interpreters/JoinedTables.cpp:162:42
    36 0x1ebf393f in DB::InterpreterSelectQuery::InterpreterSelectQuery() obj-x86_64-linux-gnu/../src/Interpreters/InterpreterSelectQuery.cpp:306:33
    42 0x1eb3bf90 in DB::InterpreterFactory::get(std::__1::shared_ptr<DB::IAST>&, DB::Context&, DB::SelectQueryOptions const&) obj-x86_64-linux-gnu/../src/Interpreters/InterpreterFactory.cpp:110:16
    43 0x1f4d9dee in DB::executeQueryImpl(char const*, char const*, DB::Context&, bool, DB::QueryProcessingStage::Enum, bool, DB::ReadBuffer*) obj-x86_64-linux-gnu/../src/Interpreters/executeQuery.cpp:520:28
    44 0x1f4d7067 in DB::executeQuery(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, DB::Context&, bool, DB::QueryProcessingStage::Enum, bool) obj-x86_64-linux-gnu/../src/Interpreters/executeQuery.cpp:900:30
    45 0x2073b0bc in DB::TCPHandler::runImpl() obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:260:24
    46 0x2075db1c in DB::TCPHandler::run() obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:1417:9
```

</details>

  [1]: https://clickhouse-test-reports.s3.yandex.net/19583/9f8ab99dd12a6f60a20f5f84ab2f5d53874c6ae7/fuzzer_asan/report.htmlfail1
2021-01-26 14:27:58 +03:00
feng lv
35125c1b33 rewrite 2021-01-26 11:26:15 +00:00
bo zeng
c2d079d40e
fix issue #18086 (#18124)
* fix issue #18086

* Update convertMySQLDataType.cpp

* add test case for type mapping for mysql

* remove type mapping test case from materialize_with_ddl.py, will add case in mysql engine.

* add test on types and values for mysql database engine.

* typo T_T

* add missing variables

* update the assert code to align with new test data.

* better code for testing, and remove null test since it is not supported.

* remove edge value from test since it always fail. should fix it in clickhouse-client.

* remove some testcases currently not support.

* correct test case

* correct test case. maybe I need to build up a test environment in my local pc...

* correct test data

* Update convertMySQLDataType.cpp

Co-authored-by: Ivan <5627721+abyss7@users.noreply.github.com>
2021-01-26 13:37:57 +03:00
Nikolai Kochetov
d821cf11f8 Fix function neighbor for LowCardinality argument. 2021-01-26 13:31:29 +03:00
tavplubix
b8d6655131
Merge pull request #19572 from ClickHouse/fix_19568
Fix DROP TABLE ON CLUSTER SYNC hang with Atomic database
2021-01-26 12:51:07 +03:00
Maksim Kita
463a48dfe3
Merge pull request #19533 from kitaisreal/multi-if-constant-result-support
Function multiIf constant result support
2021-01-26 12:44:23 +03:00
Maksim Kita
16eb7b01b6
Merge pull request #19571 from kitaisreal/create-simple-dictionary-id-expression-fix
Query CREATE DICTIONARY id expression fix
2021-01-26 12:43:49 +03:00
kreuzerkrieg
29a2ef3089 Add IStoragePolicy interface 2021-01-26 10:55:28 +02:00
Vladimir Chebotarev
25037edfa6 Removed space in winking face smiley. 2021-01-26 11:28:47 +03:00
tavplubix
2d6a71fced
Merge pull request #19443 from ClickHouse/fix_virtual_parts_in_parts_to_do
Addition to #15537
2021-01-26 11:27:14 +03:00
BohuTANG
368121cc04 Remove unused include header 2021-01-26 14:10:33 +08:00
Amos Bird
66fe97d8bd
Per MergeTree table query limit 2021-01-26 14:03:31 +08:00
Azat Khuzhin
27a5794795 Fix UBsan report in lcm()/gcd()
Changelog:
- Check against INT64_MIN/INT64_MAX
- Check against std::numeric_limits<>::min/max
- Move common code into separate header - GCDLCMImpl.h
- Forbid floats

UBsan report [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/19466/cb30a02540a0f223df6668c5f88ff84aa666ff54/fuzzer_ubsan/report.html#fail1
2021-01-26 08:33:49 +03:00
Amos Bird
5998383a3b
Fix with aggregates 2021-01-26 10:29:13 +08:00
Amos Bird
0b74d146ef
Fix unused with column 2021-01-26 10:29:13 +08:00
Amos Bird
3ca0bdc848
Keep with statement 2021-01-26 10:29:13 +08:00
Amos Bird
a2ceca3fa1
Fix recursive propagation 2021-01-26 10:29:12 +08:00
Amos Bird
9e28fd4a8e
make clang happy 2021-01-26 10:29:12 +08:00
Amos Bird
66d84957e2
Get rid of useless with statement during analysis 2021-01-26 10:29:12 +08:00
Amos Bird
9546e61bd4
Normalize away WITH statement 2021-01-26 10:29:12 +08:00
Amos Bird
b6a5d2f8e9
Fix non-select queries 2021-01-26 10:29:12 +08:00
Amos Bird
3afcccaad2
Fix global with after union refactoring 2021-01-26 10:29:12 +08:00
Amos Bird
824aee4020
better cte and with global 2021-01-26 10:29:11 +08:00
bharatnc
db8975c38f remove redundant strcpy call 2021-01-25 17:38:55 -08:00
bharatnc
fc8e22075e refactor code to not use strings 2021-01-25 17:38:55 -08:00
bharatnc
7abedaeaa0 simplify logic flow 2021-01-25 17:38:55 -08:00
bharatnc
562d01e8d8 fix code and rebase 2021-01-25 17:38:55 -08:00
bharatnc
9152a7a4be init - make toIPv6 parse IPv4 addresses 2021-01-25 17:38:55 -08:00
alexey-milovidov
8084e4d614
Merge pull request #19414 from ClickHouse/fix-15889-continuation
Continue fix for Block structure mismatch in PipelineExecuting stream
2021-01-26 00:05:35 +03:00
alexey-milovidov
7197552535
Merge pull request #19430 from ClickHouse/fix-14100
Fix error Extremes transform was already added to pipeline
2021-01-26 00:04:14 +03:00
Alexey Milovidov
8dfa933028 Amend 2021-01-25 23:48:10 +03:00
Alexey Milovidov
9ee5c1535e Allow to disable checksums on read 2021-01-25 23:29:04 +03:00
Alexey Milovidov
cfd47b2980 Merge branch 'master' into issue18494 2021-01-25 22:18:23 +03:00
Anton Popov
658f24dcff
Merge pull request #19358 from CurtizJ/fix-subcolumns
Fix several cases, while reading subcolumns
2021-01-25 20:26:07 +03:00
Nikolai Kochetov
a6f787faea
Merge pull request #19253 from ClickHouse/split-actions-dag
Split actions dag
2021-01-25 18:13:42 +03:00
Alexander Kuzmenkov
574454c270 cleanup 2021-01-25 18:07:09 +03:00
Anton Popov
f203a33a8f
Merge pull request #19515 from hexiaoting/map_functions_fix
Bug fix : support const column processing in mapContains, mapKeys, mapValues functions
2021-01-25 17:30:59 +03:00
dankondr
fb268ec339 Add toMinute MySQL compatibility alias 2021-01-25 16:35:58 +03:00
dankondr
23e86a57d8 Add toSecond MySQL compatibility alias 2021-01-25 16:26:38 +03:00
dankondr
8ca52f9894 Add toQuarter MySQL compatibility alias 2021-01-25 16:24:06 +03:00
dankondr
f49c8779a8 Add repeat MySQL compatibility alias 2021-01-25 16:20:40 +03:00
tavplubix
5f07bfb9f8
Update ReplicatedMergeTreeQueue.cpp 2021-01-25 16:15:47 +03:00
dankondr
d7c5dd3767 Add toYear MySQL compatibility alias 2021-01-25 16:00:11 +03:00
dankondr
8f115f2923 Add toMonth MySQL compatibility alias 2021-01-25 15:59:49 +03:00
Alexander Tokmakov
769257acf4 fix drop table on cluster hang 2021-01-25 15:44:10 +03:00
Maksim Kita
ab7f15c77e Query CREATE DICTIONARY id expression fix 2021-01-25 15:43:35 +03:00
Vitaly Baranov
813b2bcc73
Merge pull request #17211 from traceon/ldap-role-mapping
LDAP group to local role mapping support
2021-01-25 15:39:42 +03:00
taiyang-li
586def7fa3 enable empty/notEmpty for map data type 2021-01-25 18:31:39 +08:00
tavplubix
a88a564aae
Update ReplicatedMergeTreeQueue.cpp 2021-01-25 12:51:06 +03:00
tavplubix
4be33e81ee
Merge pull request #19344 from zhang2014/patch-2
ISSUES-18684 fix MaterializeMySQL integration test failure
2021-01-25 12:46:53 +03:00
Maksim Kita
ec5d541a66 Fixed style issues 2021-01-25 11:08:10 +03:00
alesapin
fe133580ee
Merge pull request #19346 from azat/system.parts-_state-fix
Fix system.parts _state column
2021-01-25 10:11:19 +03:00
alexey-milovidov
ba3e064a63
Merge pull request #19371 from kssenii/test-coverage-with-factories
test coverage with factories
2021-01-25 07:11:09 +03:00
Vladimir Chebotarev
8ba8e8efd5 Added prefix-based S3 endpoint settings. 2021-01-25 06:40:57 +03:00
Maksim Kita
dac6cceac1 Function multiIf constant result support 2021-01-25 00:35:49 +03:00