Commit Graph

7895 Commits

Author SHA1 Message Date
Alexey Milovidov
ecd0c4260b
Merge pull request #42929 from Aaaaaaron/minor_fix01
minor fix error msg, replace outdated func name
2022-11-04 19:18:46 +01:00
Nikolay Degterinsky
6995fa1afd
Merge pull request #42883 from zzsmdfj/fix_join_to_subqueries_null_pointer
Fix  join to subqueries rewriter null pointer
2022-11-04 19:56:40 +03:00
Robert Schulze
9c066e964d
Less use of CH-specific bit_cast()
Converted usage of CH-custom bit_cast to std::bit_cast if possible, i.e.
when
  sizeof(From) == sizeof(To).
(The CH-custom bit_cast is able to deal with sizeof(From) != sizeof(To).)

Motivation for this came from #42847 where it is not clear how the
internal bit_cast should behave on big endian systems, so we better
avoid that situation as much as possible.
2022-11-04 15:52:48 +00:00
Vladimir C
f359411668
Merge branch 'master' into optimze_ttl_merge 2022-11-04 16:52:20 +01:00
Nikolai Kochetov
79facdb4f2 Make query plan optimisation respect query settings in EXPLAIN 2022-11-04 15:44:31 +00:00
Vitaly Baranov
52b1f4aed9
Merge pull request #42484 from vitlibar/mask-sensitive-info-in-logs
Mask some information in logs
2022-11-04 14:09:38 +01:00
zhongyuankai
1345f7e73d Merge branch 'master' into optimze_ttl_merge 2022-11-04 20:54:46 +08:00
zhongyuankai
ecf45bb216 fix test 2022-11-04 20:52:21 +08:00
Kruglov Pavel
a7a5a70189
Merge pull request #42814 from kgoralski/failed_metrics_for_async_inserts
Add `FailedAsyncInsertQuery` event metric for async inserts
2022-11-04 13:41:39 +01:00
Vladimir C
9d51119d57
Merge pull request #42905 from ClickHouse/vdimir/cluster-discovery-issue-42763 2022-11-04 11:15:30 +01:00
zhongyuankai
049a593272 Merge branch 'master' into optimze_ttl_merge 2022-11-04 17:22:38 +08:00
taojiatao
721e85a03e minor fix error msg, repalce outdated func name 2022-11-04 11:27:10 +08:00
zzsmdfj
9d8840b8a7 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix_join_to_subqueries_null_pointer 2022-11-04 10:05:12 +08:00
zzsmdfj
1a8568473c update code style 2022-11-04 10:04:01 +08:00
Krzysztof Góralski
85d5cbbf19 Review: Failed queries metrics for Async Inserts 2022-11-03 22:26:24 +01:00
Krzysztof Góralski
f019c6b4a1 style check fix 2022-11-03 22:26:24 +01:00
Krzysztof Góralski
e2f35a01de Failed queries metrics for Async Inserts 2022-11-03 22:26:24 +01:00
Krzysztof Góralski
98cc4535f0 Failed queries metrics for Async Inserts 2022-11-03 22:26:24 +01:00
Nikolai Kochetov
51ec95eb82 Try to fix #39157 in a different way. 2022-11-03 20:33:48 +00:00
Nikolai Kochetov
d01ef8ca59
Merge branch 'master' into read-in-order-from-query-plan 2022-11-03 18:59:28 +01:00
Kruglov Pavel
83c5c44b11
Merge branch 'master' into improve-schema-inference-insert-select 2022-11-03 18:41:51 +01:00
Smita Kulkarni
d5b3184e86 Merge branch '42452_Bug_fix_parent_node_corrupted' of github.com:ClickHouse/ClickHouse into 42452_Bug_fix_parent_node_corrupted 2022-11-03 14:43:52 +01:00
Smita Kulkarni
4c70622202 Updated to check size of alias before cloning, so that we throw error early - 42452 Bug fix for parent node corrupted 2022-11-03 14:42:34 +01:00
SmitaRKulkarni
f8ce2b1413
Merge branch 'master' into 42452_Bug_fix_parent_node_corrupted 2022-11-03 14:12:56 +01:00
vdimir
b7fb500d5b Fix incorrect saved_block_sample with multiple disjuncts in hash join 2022-11-03 13:00:37 +01:00
Smita Kulkarni
9a002bd378 Removed finished_asts updation when alias is replaced and updated alias of the replaced ast it its initial name so that we don’t replace it further - 42452 Bug fix for parent node corrupted 2022-11-03 11:57:32 +01:00
SmitaRKulkarni
f26d121f6d
Merge branch 'master' into 42452_Bug_fix_parent_node_corrupted 2022-11-02 22:40:10 +01:00
Smita Kulkarni
816f2319f7 Updated finished_asts to fix fast test fails with Normalise AST is too deep and updated ConvertFunctionOrLikeData to merge conditions by aliasorColumnName instead of ASTPtr - 42452 Bug fix for parent node corrupted 2022-11-02 19:35:22 +01:00
vdimir
503f71b285
Do not set treat_local_port_as_remote in ClusterDiscovery 2022-11-02 15:34:06 +00:00
Vitaly Baranov
e0133688bc
Merge branch 'master' into mask-sensitive-info-in-logs 2022-11-02 16:26:13 +01:00
zzsmdfj
61123b7f54 to fix join to subqueries rewriter null pointer 2022-11-02 11:34:15 +08:00
Nikolai Kochetov
478d3079c8 Merge branch 'master' into read-in-order-from-query-plan 2022-11-01 21:02:22 +01:00
Nikolai Kochetov
9ffebf4a0c Fixing read-in-order for special storages. 2022-11-01 19:51:52 +00:00
Vitaly Baranov
085fb80190 Spare stack in InDepthNodeVisitor. 2022-11-01 17:20:12 +01:00
zhongyuankai
c1e2b2af74 Optimize TTL merge, completely expired parts can be removed in time 2022-11-01 22:58:15 +08:00
Vitaly Baranov
9d46547daa
Merge branch 'master' into session-log-support-sslcertificate-auth 2022-11-01 08:32:09 +01:00
Vitaly Baranov
d1c69a0753 Avoid changing query if it doesn't contain password. 2022-10-31 17:04:44 +01:00
Anton Popov
2ae3cfa9e0
Merge branch 'master' into dynamic-columns-14 2022-10-31 16:15:19 +01:00
Nikolai Kochetov
375db5bd15 Use read-in-order from query plan by default. 2022-10-31 13:54:03 +00:00
SmitaRKulkarni
7e9dd825c0
Merge branch 'master' into 42452_Bug_fix_parent_node_corrupted 2022-10-31 14:03:44 +01:00
Smita Kulkarni
c97c78e3ff Updated normaliser to clone the alias ast.
Implementation:
* Updated QueryNormalizer to clone alias ast, when its replaced. Previously just assigning the same leads to exception in LogicalExpressinsOptimizer as it would be the same parent being inserted again.
* This bug is not seen with new analyser (allow_experimental_analyzer), so no changes for it. I added a test for the same.
Testing:
* Added a test for or function with alias and const where 02475_or_function_alias_and_const_where.sql
2022-10-31 13:49:31 +01:00
Nikolai Kochetov
742d9af397
Merge pull request #42582 from azat/memory-tracker/fixes
Fix frequent memory drift message and clarify things in comments
2022-10-31 11:43:20 +01:00
Vitaly Baranov
c07fe6921f Add comments. 2022-10-31 10:50:33 +01:00
Vitaly Baranov
854e1e918f Use assert_cast() instead of as() in some places. 2022-10-31 10:50:33 +01:00
Vitaly Baranov
43efbad642 Wipe passwords from distributed queries too. 2022-10-31 10:50:33 +01:00
Vitaly Baranov
a30bfada63 Wipe passwords from backup logs too. 2022-10-31 10:50:33 +01:00
Vitaly Baranov
dcf8724adf Move prepareQueryForLogging() to a separate header. 2022-10-31 10:50:33 +01:00
Vitaly Baranov
c2cc2ccc99 Make as_table_function a child of ASTCreateQuery (to help writing visitors). 2022-10-31 10:50:33 +01:00
Vitaly Baranov
5d2a222fe4 Mask sensitive information in logs. 2022-10-31 10:50:33 +01:00
Miel Donkers
fb1623a5f8 Add SSL_CERTIFICATE auth method to all places missing 2022-10-28 21:17:59 +02:00
Alexey Milovidov
f64e632707
Merge pull request #42469 from amosbird/issue_42456
Fix misbehavior of key analysis
2022-10-28 16:18:00 +02:00
Nikolai Kochetov
79b30fe133 Merge branch 'master' into read-in-order-from-query-plan 2022-10-28 11:53:51 +00:00
Maksim Kita
835daee0f3
Merge pull request #42728 from ucasfl/fix
Fix truncate table does not hold lock correctly
2022-10-28 11:44:24 +03:00
Nikolai Kochetov
5106c24e88 Merge branch 'master' into read-in-order-from-query-plan 2022-10-27 18:12:20 +00:00
flynn
2b08fe6963 Fix truncate table does not hold lock correctly 2022-10-27 08:56:18 +00:00
Vladimir Chebotaryov
d17b7387f9 Reworked changes to std::shared_ptr<const RowPolicyFilter>. 2022-10-27 10:42:55 +03:00
Vladimir Chebotaryov
6d5d31e49c Removed UUID's. 2022-10-27 10:42:26 +03:00
Vladimir Chebotaryov
0707d88311 Removed extendQueryLogElemImplImpl. 2022-10-27 10:42:25 +03:00
Vladimir Chebotaryov
1ec199b539 Style fix. 2022-10-27 10:42:25 +03:00
Vladimir Chebotaryov
0c485d786c Better includes. 2022-10-27 10:42:24 +03:00
Vladimir Chebotaryov
c28e439c33 Review fixes. 2022-10-27 10:42:22 +03:00
Vladimir Chebotaryov
4cabe1f57c Added applied row-level policies to system.query_log. 2022-10-27 10:41:47 +03:00
Anton Popov
ca4df62e37
Merge branch 'master' into refactor-data-part 2022-10-26 17:49:20 +02:00
Azat Khuzhin
7b69a70e82 Fix frequent memory drift message and clarify things in comments
Somethine like:

    2022.09.28 06:33:34.001433 [ 3133669 ] {} <Trace> AsynchronousMetrics: MemoryTracking: was 562.20 MiB, peak 562.21 MiB, will set to 562.20 MiB (RSS), difference: -70.46 MiB
    2022.09.28 06:33:35.001639 [ 3133669 ] {} <Trace> AsynchronousMetrics: MemoryTracking: was 562.20 MiB, peak 562.21 MiB, will set to 562.20 MiB (RSS), difference: -70.45 MiB

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-26 17:38:37 +02:00
Azat Khuzhin
2faefc0c09 Add amount of memory used by allocator into logs
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-26 17:38:37 +02:00
Kruglov Pavel
b8ee5600be
Merge pull request #42579 from ucasfl/set
Fix create set with wrong header when data type is lowcardinality
2022-10-26 14:17:14 +02:00
Kruglov Pavel
219553df8d
Merge pull request #42580 from hanfei1991/fei/limit_max_rows
fix behaviour of max_rows_to_read for trival limit queries
2022-10-26 14:09:59 +02:00
Maksim Kita
cd2a8966aa
Merge pull request #42649 from kitaisreal/analyzer-change-setting
Analyzer change setting into allow_experimental_analyzer
2022-10-26 12:26:15 +03:00
Nikolai Kochetov
c4685f6994
Merge branch 'master' into fix-42575 2022-10-25 15:31:32 +02:00
Anton Popov
c8199bc125
Merge branch 'master' into refactor-data-part 2022-10-25 14:31:05 +02:00
Nikolai Kochetov
5c4444237e
Merge pull request #42617 from ClickHouse/revert-revert-41268-disable-s3-parallel-write-for-part-moves-to-disk-s3
Revert revert 41268 disable s3 parallel write for part moves to disk s3
2022-10-25 14:29:27 +02:00
Raúl Marín
0016bc2b73
Improve the time to recover keeper connections (#42541)
Co-authored-by: Nikita Mikhaylov <nikitamikhaylov@clickhouse.com>
Co-authored-by: robot-clickhouse <robot-clickhouse@clickhouse.com>
Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
2022-10-25 13:26:29 +02:00
Alexander Gololobov
759d8bcd80
Merge pull request #42609 from filimonov/patch-6
Fix incorrect trace log line on dict reload
2022-10-25 12:51:00 +02:00
Maksim Kita
e6bfff3de2 Analyzer change setting into allow_experimental_analyzer 2022-10-25 12:35:25 +02:00
Maksim Kita
06fe6f3c8b
Merge pull request #31796 from kitaisreal/identifier-resolver
Added Analyzer
2022-10-25 12:36:08 +03:00
Nikolai Kochetov
93310fe8b1 Fix typo. 2022-10-24 15:51:21 +00:00
Nikolai Kochetov
d5bd905a41 Try to fix data race on zookeeper vs DDLWorker at server shutdown. 2022-10-24 15:09:35 +00:00
Vitaly Baranov
cd158b021f
Merge pull request #42562 from vitlibar/subqueries-in-row-policy-filters
Fix using subqueries in row policy filters
2022-10-24 13:38:15 +02:00
filimonov
0762783fbd
Fix incorrect trace log line on dict reload 2022-10-24 11:58:37 +02:00
Maksim Kita
d083200d65 Fixed code review issues 2022-10-24 10:22:38 +02:00
Maksim Kita
5a0298ea34 Fixed tests 2022-10-24 10:22:37 +02:00
Maksim Kita
3a22e37691 Fix normalization of UNION inside DESCRIBE query 2022-10-24 10:22:37 +02:00
Maksim Kita
2f282eeec9 Updated InDepthQueryTreeVisitor implementation 2022-10-24 10:22:21 +02:00
Maksim Kita
10438aea01 Added JOIN support for different algorithm 2022-10-24 10:22:21 +02:00
Maksim Kita
a0d9251f3a Added ASOF join support 2022-10-24 10:22:21 +02:00
Maksim Kita
8cadb1b318 Added WINDOW functions support 2022-10-24 10:22:20 +02:00
Maksim Kita
890d9678b9 Fixed tests 2022-10-24 10:22:20 +02:00
Maksim Kita
4f68305dbe Fixed tests 2022-10-24 10:22:20 +02:00
Maksim Kita
ca93ee7479 Fixed tests 2022-10-24 10:22:20 +02:00
Maksim Kita
2b571004f3 Added support for projection names 2022-10-24 10:22:19 +02:00
Maksim Kita
03864790ad Added DISTINCT support 2022-10-24 10:22:19 +02:00
Maksim Kita
2995fb7944 Added support for building sets for IN function 2022-10-24 10:22:19 +02:00
Maksim Kita
44ada63a97 Added Planner 2022-10-24 10:22:19 +02:00
Maksim Kita
85193ede42 Added UNION support 2022-10-24 10:22:19 +02:00
Maksim Kita
0da0019634 Added ARRAY JOIN support 2022-10-24 10:22:19 +02:00
Maksim Kita
89e5b09e7f Updated JOIN tests 2022-10-24 10:22:19 +02:00
Maksim Kita
b32092f24a JOIN support join_use_nulls, USING 2022-10-24 10:22:19 +02:00
Maksim Kita
40cb904a3d Added support for JOIN, ARRAY JOIN 2022-10-24 10:22:19 +02:00
Maksim Kita
062e17052f Added support for IN function 2022-10-24 10:22:19 +02:00
Maksim Kita
2148d0e58d Added support for arrayJoin function 2022-10-24 10:22:19 +02:00