Commit Graph

150613 Commits

Author SHA1 Message Date
Robert Schulze
effaeeeeac
Update 3rd party lib guide 2024-08-08 08:43:39 +00:00
Antonio Andelic
d0f35ce6a6 Fix setting prefix 2024-08-08 10:29:01 +02:00
Dmitry Novik
486d717e88
Merge pull request #67661 from bigo-sg/win_bug
Fix crash on `percent_rank`
2024-08-08 08:28:48 +00:00
Max K.
beb43734ae
Merge pull request #67898 from ClickHouse/ci_mergeable_check_fix_2
CI: Fix for setting Mergeable Check from sync
2024-08-08 08:20:01 +00:00
Antonio Andelic
f4aac7bbd9
Another fix 2024-08-08 09:19:45 +01:00
Alexey Milovidov
82ffa75b7a
Merge pull request #68023 from ClickHouse/revert-65860-atomic-database-in-clickhouse-local
Revert "Use `Atomic` database by default in `clickhouse-local`"
2024-08-08 10:07:30 +02:00
Alexey Milovidov
6a2ebfc95b
Revert "Use Atomic database by default in clickhouse-local" 2024-08-08 10:07:14 +02:00
János Benjamin Antal
7579d06272 Merge remote-tracking branch 'origin/master' into fix_trivial_count_non_deterministic_func 2024-08-08 08:02:28 +00:00
János Benjamin Antal
92be2db5b6 Merge remote-tracking branch 'origin/master' into kafka-zookeeper 2024-08-08 08:01:43 +00:00
Max Kainov
59a63cd110 CI: Fix for filtering jobs in PRs 2024-08-08 09:56:31 +02:00
Andrey Zvonov
29d701aea7
Forgot to drop table in test 2024-08-08 10:51:57 +03:00
morning-color
211999fde6
Merge branch 'master' into rows_before_group_by_counter 2024-08-08 15:49:24 +08:00
Michael Stetsyuk
71a761232c empty 2024-08-08 08:45:42 +01:00
Antonio Andelic
9d30b45dbe
Fix 2024-08-08 08:43:49 +01:00
Robert Schulze
5a17d93bf3
Fix freebsd build 2024-08-08 07:29:20 +00:00
Robert Schulze
5c97205742
Reapply "Bump rocksdb from v8.10 to v9.4 + enable jemalloc and liburing"
This reverts commit ff8ce505d7.
2024-08-08 07:23:10 +00:00
Antonio Andelic
4059b45237 Merge branch 'master' into update-minio-statless 2024-08-08 09:00:27 +02:00
Antonio Andelic
bd3674e6e9 Add restart 2024-08-08 08:55:31 +02:00
Julia Kartseva
d6ecabb41d Fix flaky test_storage_s3_queue/test.py::test_multiple_tables_streaming_sync_distributed
Disable parallel processing for the Ordered mode for the
test_storage_s3_queue/test.py::test_multiple_tables_streaming_sync_distributed
test.

The reason for this is that the load between the processing nodes is
too uneven when s3queue_processing_threads_num != 1,
e.g.:

```
$ grep res1 pytest.log
2024-08-07 07:15:58 [ 575 ] DEBUG : res1 size: 13300, res2 size: 1700, total_rows: 15000 (test.py:813, test_multiple_tables_streaming_sync_distributed)
```

In CIs environment, there are rare cases when one of the processors handles all the workload,
while the other is busy-waiting, and the test fails on assert:

When s3queue_processing_threads_num == 1, the workload is evenly
distributed:

```
$ grep res1 pytest.log
2024-08-07 07:26:52 [ 586 ] DEBUG : res1 size: 7200, res2 size: 7800, total_rows: 15000 (test.py:813, test_multiple_tables_streaming_sync_distributed)
```

This change only fixes test flakiness. Further investigation of the Order
mode parallelism is required.
2024-08-08 06:13:36 +00:00
Azat Khuzhin
301ac5dab7 Fix possible data-race StorageKafka with statistics_interval_ms>0
The problem here is that ignorelist did not work by some reason, if I
will look at the ignored functions it should not contain any TSan
interseption code, while it does:

    $ lldb-13 clickhouse
    (lldb) target create "clickhouse"
    disas -n rd_avg_rollover
    Current executable set to '/home/azat/ch/tmp/tsan-test/clickhouse' (x86_64).
    (lldb) disas -n rd_avg_rollover
    clickhouse`rd_kafka_stats_emit_avg:
    clickhouse[0x1cbf84a7] <+39>:  leaq   0x30(%r15), %r12
    clickhouse[0x1cbf84ab] <+43>:  movq   %r12, %rdi
    clickhouse[0x1cbf84ae] <+46>:  callq  0x1ccdad40                ; rdk_thread_mutex_lock at tinycthread.c:111
    clickhouse[0x1cbf84b3] <+51>:  leaq   0x58(%r15), %rdi
    clickhouse[0x1cbf84b7] <+55>:  callq  0x71b5390                 ; __tsan_read4
    clickhouse[0x1cbf84bc] <+60>:  cmpl   $0x0, 0x58(%r15)
    clickhouse[0x1cbf84c1] <+65>:  je     0x1cbf8595                ; <+277> [inlined] rd_avg_rollover + 238 at rdavg.h
    clickhouse[0x1cbf84c7] <+71>:  leaq   -0xc8(%rbp), %rdi
    clickhouse[0x1cbf84ce] <+78>:  xorl   %esi, %esi
    clickhouse[0x1cbf84d0] <+80>:  callq  0x1ccdac80                ; rdk_thread_mutex_init at tinycthread.c:62
    clickhouse[0x1cbf84d5] <+85>:  leaq   0x5c(%r15), %rdi
    clickhouse[0x1cbf84d9] <+89>:  callq  0x71b5390                 ; __tsan_read4

    (lldb) disas -n rd_avg_calc
    clickhouse`rd_kafka_broker_ops_io_serve:
    clickhouse[0x1cbdf086] <+1990>: leaq   0x5a4(%rbx), %rdi
    clickhouse[0x1cbdf08d] <+1997>: callq  0x71b5390                 ; __tsan_read4
    clickhouse[0x1cbdf092] <+2002>: cmpl   $0x0, 0x5a4(%rbx)
    clickhouse[0x1cbdf099] <+2009>: je     0x1cbdf12b                ; <+2155> [inlined] rd_kafka_broker_timeout_scan + 719 at rdkafka_broker.c

I guess the reason is that they had been inlined

So now rd_avg_calc() guarded with a mutex.

Refs: https://github.com/ClickHouse/librdkafka/pull/11
Fixes: https://github.com/ClickHouse/ClickHouse/issues/60939
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-08 07:43:29 +02:00
pufit
6c0cc194d3
Merge branch 'master' into pufit/fuzz-query-revert-revert 2024-08-07 23:26:05 -04:00
pufit
32153d6e0d
Merge branch 'master' into pufit/correct-error-for-alter-modify-definer 2024-08-07 23:25:02 -04:00
Yakov Olkhovskiy
013680e397 empty commit 2024-08-08 03:00:51 +00:00
Yakov Olkhovskiy
3319a5e6f8
Merge pull request #67341 from ClickHouse/fix-race-tcphandler
Fix: data race in TCPHandler on socket timeouts settings
2024-08-08 02:50:24 +00:00
Alexey Milovidov
7a07ca56fd Merge branch 'master' into change-log-level-clickhouse-local 2024-08-08 04:27:54 +02:00
Alexey Milovidov
e0975213bc
Merge pull request #66821 from ClickHouse/randomize-trace_profile_events
Randomize `trace_profile_events`
2024-08-08 02:05:13 +00:00
Alexey Milovidov
93bdf99278 Merge branch 'master' into clickhouse-local-remove-unused-command-line-option 2024-08-08 03:49:08 +02:00
Alexey Milovidov
d60cb9d3a6
Merge pull request #67960 from azat/tests/03002_part_log_rmt_fetch__error
tests: fix 03002_part_log_rmt_fetch_merge_error flakiness
2024-08-08 01:43:23 +00:00
Alexey Milovidov
e07069c500
Merge pull request #68002 from Algunenano/no-parallel-5
Remove some no-parallel tags from tests (Part 5)
2024-08-08 01:42:58 +00:00
Alexey Milovidov
31dd584df3
Merge pull request #68011 from ClickHouse/fix-test-02845_threads_count_in_distributed_queries
Fix test `02845_threads_count_in_distributed_queries`
2024-08-08 01:42:45 +00:00
Alexey Milovidov
ae6139e66c
Merge pull request #68007 from ClickHouse/qoega-patch-7
Follow up for #67843
2024-08-08 01:38:54 +00:00
Alexey Milovidov
142e9528f0 Add a test for #57420 2024-08-08 03:10:45 +02:00
Konstantin Bogdanov
b4cb5dcdd3
Typo 2024-08-08 02:47:21 +02:00
robot-clickhouse
f4e1bde9b6
Automatic style fix 2024-08-08 02:47:21 +02:00
Konstantin Bogdanov
5329fba9a2
Fix harder 2024-08-08 02:47:21 +02:00
Konstantin Bogdanov
c42725331d
Fix 2024-08-08 02:47:02 +02:00
lgbo-ustc
daf62e1682 update 2024-08-08 08:30:10 +08:00
lgbo-ustc
8426e0d5e5 fix crash 2024-08-08 08:28:20 +08:00
Nikita Mikhaylov
ef31d9301b
Merge pull request #68014 from ClickHouse/revert-67904-bump-rocksdb3
Revert "Bump rocksdb from v8.10 to v9.4 + enable jemalloc and liburing"
2024-08-08 00:07:49 +00:00
Yarik Briukhovetskyi
c19ee360d1
Update StorageObjectStorageSource.cpp 2024-08-08 00:44:42 +02:00
Nikita Mikhaylov
ff8ce505d7
Revert "Bump rocksdb from v8.10 to v9.4 + enable jemalloc and liburing" 2024-08-08 00:20:16 +02:00
Nikita Fomichev
55ad7d3094 Fix stylelint 2024-08-08 00:08:12 +02:00
Yarik Briukhovetskyi
9e3a2931d2
Merge branch 'master' into hive_style_partitioning 2024-08-07 23:59:34 +02:00
Yarik Briukhovetskyi
c6c0a44b93
fix flaky tests 2024-08-07 23:57:19 +02:00
Nikita Fomichev
755b06b455
Merge pull request #67793 from ClickHouse/flaky-test_reload_after_fail_by_timer
Integration tests: fix flaky `test_dictionaries_update_and_reload::test_reload_after_fail_by_timer`
2024-08-07 21:36:54 +00:00
Nikita Fomichev
086b3d240d CI: push CI 2024-08-07 23:34:36 +02:00
Nikita Fomichev
1dece979fe CI: pass job timout into tests 2024-08-07 23:22:05 +02:00
Azat Khuzhin
85427030aa tests: fix 03002_part_log_rmt_fetch_merge_error flakiness
CI found [1]:

    --- /usr/share/clickhouse-test/queries/0_stateless/03002_part_log_rmt_fetch_merge_error.reference	2024-08-07 05:09:42.058643403 +0200
    +++ /tmp/clickhouse-test/0_stateless/03002_part_log_rmt_fetch_merge_error.stdout	2024-08-07 05:54:45.514083455 +0200
    @@ -6,5 +6,7 @@
     after
     rmt_master	NewPart	0	1
     rmt_master	MergeParts	0	1
    +rmt_master	RemovePart	0	1
     rmt_slave	MergeParts	1	0
     rmt_slave	DownloadPart	0	2
    +rmt_slave	RemovePart	0	1

    MergeTree settings used in test: --ratio_of_defaults_for_sparse_serialization 1.0 --prefer_fetch_merged_part_size_threshold 3517855074 --vertical_merge_algorithm_min_rows_to_activate 1000000 --vertical_merge_algorithm_min_columns_to_activate 100 --allow_vertical_merges_from_compact_to_wide_parts 0 --min_merge_bytes_to_use_direct_io 10737418240 --index_granularity_bytes 7659983 --merge_max_block_size 17667 --index_granularity 48465 --min_bytes_for_wide_part 1073741824 --marks_compress_block_size 58048 --primary_key_compress_block_size 18342 --replace_long_file_name_to_hash 0 --max_file_name_length 36 --min_bytes_for_full_part_storage 536870912 --compact_parts_max_bytes_to_buffer 148846831 --compact_parts_max_granules_to_buffer 140 --compact_parts_merge_max_bytes_to_prefetch_part 4513530 --cache_populated_by_fetch 1 --concurrent_part_removal_threshold 8 --old_parts_lifetime 10

The reason is old_parts_lifetime=10

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/67511/881d57a7644057b586e4cdb95ebb8785d912d4c5/stateless_tests__msan__%5B3_4%5D.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-07 23:06:14 +02:00
Nikita Mikhaylov
f37e0c7fc6 Merge branch 'master' of github.com:ClickHouse/ClickHouse into ts-engine 2024-08-07 21:01:13 +00:00
Nikita Mikhaylov
b2722d8832 Disallow LowCardinality type for external tables 2024-08-07 20:54:40 +00:00