Commit Graph

5249 Commits

Author SHA1 Message Date
Maksim Kita
0a2ea38cc9
Merge pull request #23916 from azat/dict-found_rate
Measure found rate for dictionaries
2021-05-08 19:23:52 +03:00
Alexander Kuzmenkov
308c4657ce support longer query ids in trace log for perf tests 2021-05-08 18:20:42 +03:00
Azat Khuzhin
4cecc238d6 Fix SIGSEGV for external GROUP BY and overflow row
Overflow row is used for GROUP BY if all of the above is true:
- WITH TOTALS is requested
- max_rows_to_group_by > 0
- group_by_overflow_mode = any
- totals_mode != after_having_exclusive

And in case of overflow row and external GROUP BY, once the temporary
file dumps to disk it resets without_key data variant to nullptr, so any
subsequent dump to disk will cause SIGSEGV.

Fix this, by recreating without_key data variant after dumping to disk,
instead of reseting to nullptr.

And also add sanity check (LOGICAL_ERROR) to make error more
deterministic in case of such error.

Found with fuzzer [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/23929/e7027e052998540ee660d186727e20f9555b729d/fuzzer_ubsan/report.html#fail1
2021-05-08 17:48:24 +03:00
Maksim Kita
57d5f55d7f Added jit if test 2021-05-08 17:39:35 +03:00
Azat Khuzhin
bdb5dad3a3 Cover system.dictionaries.found_count
v2: fix for ANTRL
v3: add all dictionaries layouts
2021-05-08 17:09:01 +03:00
Maksim Kita
108c2022d9 Function arrayDifference decimal math overflow 2021-05-08 17:01:30 +03:00
Alexey Milovidov
47a4c101b9 Merge branch 'master' into normalize-bigint 2021-05-08 16:41:15 +03:00
Maksim Kita
80dbb7ca4f
Merge pull request #23948 from azat/dict-range-min-max-check
Check MIN/MAX attributes in the list of dictionary attributes
2021-05-08 16:07:26 +03:00
FArthur-cmd
acb09f01d4 fixing details in code style and moving tests 2021-05-08 12:46:50 +03:00
Maksim Kita
b617c57ce8
Merge pull request #23929 from azat/dict-cache-source-dups-fix
Fix keys metrics accounting for CACHE() dictionary with duplicates in the source
2021-05-08 11:56:20 +03:00
FArthur-cmd
c6c80085b8 solving problem with same test naming 2021-05-08 10:15:55 +03:00
FArthur-cmd
13a6e03849 solving style-check problems 2021-05-08 10:15:14 +03:00
Azat Khuzhin
8e9655d513 Check MIN/MAX attributes in the list of dictionary attributes
This way there will be proper exception instead of std::out_of_range
2021-05-08 08:59:47 +03:00
Alexey Milovidov
dd4e002b5c Adjust a test after relaxed overflow checks 2021-05-08 03:38:56 +03:00
Alexey Milovidov
53637d7be0 Adjust a test after relaxed overflow checks 2021-05-08 03:38:15 +03:00
Alexey Milovidov
89d56f1668 Fix bad test 2021-05-08 03:36:28 +03:00
Alexey Milovidov
1f69f8c475 Make test for Decimal correct 2021-05-08 03:33:01 +03:00
Alexey Milovidov
e8c29bf15f Adjust test because rounding in conversion of Float to Decimal has changed 2021-05-08 03:27:23 +03:00
Alexey Milovidov
5f3377cb84 Adapt test after some overflow checks were removed 2021-05-08 03:24:56 +03:00
Alexey Milovidov
059bdd89dc Adapt test after some overflow checks were removed 2021-05-08 03:22:34 +03:00
FArthur-cmd
4ea9851e99 fixing dictionary http source by adding wrapper 2021-05-08 02:20:30 +03:00
Alexey Milovidov
e49b44a0fd Update generateRandom tests 2021-05-08 01:09:51 +03:00
Azat Khuzhin
c1b213b96e Fix 01863_dictionary_cache_duplicates under ANTLR parser
By do not start name of table/dict from number.
2021-05-08 00:59:55 +03:00
Alexey Milovidov
c404e6db2f Merge branch 'master' of github.com:yandex/ClickHouse into normalize-bigint 2021-05-07 18:25:12 +03:00
Anton Popov
01e99ab72e
Merge pull request #23871 from CurtizJ/cast-operator
Add postgres-like cast operator
2021-05-07 16:29:22 +03:00
alexey-milovidov
fd56e0a984
Merge pull request #23919 from ucasFL/hint-enum
Add hints for enum names
2021-05-07 16:12:16 +03:00
Alexey Milovidov
ef280a2698 Update test 2021-05-07 01:47:20 +03:00
Anton Popov
e51cd90c6f better cast operator 2021-05-06 21:21:10 +03:00
Azat Khuzhin
e7027e0529 Fix keys metrics accounting for CACHE() dictionary with duplicates in the source 2021-05-06 21:03:20 +03:00
feng lv
59f5f2d03c Add hints for enum names
add test
2021-05-06 14:22:54 +00:00
Alexey Milovidov
a4f134fcab Update test (but not the reference) 2021-05-06 03:30:26 +03:00
Alexey Milovidov
206f9e0a4b Fix test that depends on configuration too much 2021-05-06 01:14:54 +03:00
Alexey Milovidov
d283870f3d Fix test that depends on configuration too much 2021-05-06 01:14:32 +03:00
Alexey Milovidov
8827857fc3 Fix bad test 2021-05-06 01:09:50 +03:00
Alexey Milovidov
969649c4e5 Fix bad test (tabs) 2021-05-06 01:09:50 +03:00
Alexey Milovidov
3bf9a1f5c0 Fix bad test 2021-05-06 01:09:08 +03:00
Alexey Milovidov
6959057393 Fix bad test (tabs) 2021-05-06 01:03:27 +03:00
pingyu
46f809d07f Revert "Merge pull request #23334 from ClickHouse/revert-22609-datasketches-uniq"
This reverts commit af2499359b, reversing
changes made to db82e9e3d5.
2021-05-05 16:42:57 +08:00
Azat Khuzhin
74269882f7 Add broken_data_files/broken_data_compressed_bytes into distribution_queue 2021-05-04 22:48:07 +03:00
Anton Popov
d4ea53f642 fix test 2021-05-04 17:28:40 +03:00
Anton Popov
2b79bf838f add postgres-like cast operator 2021-05-04 06:43:17 +03:00
Vladimir
3b7c68196b
Merge pull request #23429 from Jokser/disk-s3-restart-possibility 2021-05-01 15:28:14 +03:00
alexey-milovidov
72d9e4d340
Merge pull request #23813 from nikitamikhaylov/move-partiton-lost
Add test for #18170
2021-05-01 11:31:36 +03:00
alexey-milovidov
711cc5f62b
Merge pull request #23823 from azat/tests-wait
Improve 00840_long_concurrent_select_and_drop_deadlock
2021-05-01 08:30:32 +03:00
alexey-milovidov
7ca42d2ce1
Merge pull request #23805 from ClickHouse/fix-hedged-requests-ext-tables
Fix sending external table for hedged connections.
2021-05-01 08:13:13 +03:00
Maksim Kita
fa1e9de7f7
Merge pull request #23782 from ClickHouse/merging-array-product-function
Merging array product function
2021-05-01 00:53:57 +03:00
Azat Khuzhin
2b7818ba6d Improve 00840_long_concurrent_select_and_drop_deadlock
Improve waiting in the test to avoid hung check triggering [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/23744/73ab415c4c27e481cddf4d6d70b24e79fb8d8941/stress_test_(thread).html#fail1
2021-04-30 23:50:13 +03:00
Nikita Mikhaylov
080802e043 add test 2021-04-30 18:00:47 +03:00
Maksim Kita
14e879cef9
Merge pull request #23781 from ucasFL/fix-clear-column
Fix CLEAR COLUMN does not work after #21303
2021-04-30 17:28:59 +03:00
Nikolai Kochetov
352ec049ad Fix sending external table for hedged connections. 2021-04-30 17:19:48 +03:00
Nikolai Kochetov
4bb56849b3
Merge pull request #23763 from amosbird/rowfilterfix
Fix crash when prewhere and row policy filter are both in effect with empty result
2021-04-30 16:25:36 +03:00
Maksim Kita
44b966af5a Removed const path for arrayAggregation 2021-04-30 12:33:34 +03:00
Maksim Kita
aa71b4a6df
Merge pull request #22242 from hexiaoting/dev_arrayproduct
Introduce arrayProduct function
2021-04-30 09:55:21 +03:00
feng lv
aed2f337e9 Fix CLEAR COLUMN does not work after #21303 2021-04-30 05:02:32 +00:00
alexey-milovidov
b029e9e4f6
Merge pull request #23050 from ClickHouse/remove-strange-code-fix-19283
Remove wrong code, fix #19283
2021-04-29 22:00:02 +03:00
Amos Bird
70ec13f3d3
Fix empty block with row_filter 2021-04-29 19:40:14 +08:00
tavplubix
1cecc0d724
Update 01184_long_insert_values_huge_strings.sh 2021-04-29 13:34:43 +03:00
Vladimir
1a8407e029
Merge pull request #23237 from vdimir/fix-join-lowcard-nullable 2021-04-29 13:18:04 +03:00
alexey-milovidov
7a2f6f4277
Update 01184_long_insert_values_huge_strings.sh 2021-04-29 09:46:14 +03:00
Azat Khuzhin
73ab415c4c Preserve errors for INSERT into Distributed
Before this patch (and after #22208) the INSERT may fail with "Cannot
schedule a task" because the pool in DistributedBlockOutputStream
already throws exception and simply fail in writeSuffix().
2021-04-28 22:33:29 +03:00
vdimir
6e4b37a45e
Merge branch 'master' into fix-join-lowcard-nullable 2021-04-28 20:06:49 +03:00
Nikolai Kochetov
c508868570
Merge pull request #23082 from ClickHouse/explain-output
JSON output for EXPLAIN
2021-04-28 15:39:06 +03:00
Maksim Kita
b544037f03
Merge pull request #23436 from kitaisreal/storage-dictionary-updated
Refactored StorageDictionary
2021-04-28 13:11:48 +03:00
Nikita Mikhaylov
bbd1068d6e
Merge pull request #23643 from nikitamikhaylov/pp-segfault
Segfault on INSERT in HTTPHandler
2021-04-27 13:43:21 +03:00
Nikita Mikhaylov
02a53ff2c0
Merge pull request #23654 from nikitamikhaylov/mann-whitney-bug
`mannWhitneyUTest` same values in both samples
2021-04-27 13:42:52 +03:00
Amos Bird
8a3b5c1fab
Add _partition_value virtual column 2021-04-27 16:15:59 +08:00
alexey-milovidov
186b1128d0
Merge pull request #23310 from amosbird/fixbugindex
Don't relax NOT conditions during partition pruning.
2021-04-27 07:13:18 +03:00
alexey-milovidov
013555907c
Merge pull request #23314 from excitoon-favorites/tdigest
Fixed `quantile(s)TDigest` inaccuracies
2021-04-27 06:57:44 +03:00
Alexey Milovidov
0cefaf0f4b Speedup test 2021-04-27 06:54:09 +03:00
Alexey Milovidov
83b071a3d9 Merge branch 'master' into remove-strange-code-fix-19283 2021-04-27 06:34:46 +03:00
Nikita Mikhaylov
710921dc46 fix tests 2021-04-27 02:12:15 +03:00
Nikita Mikhaylov
7dc0f27c88 done 2021-04-26 21:07:30 +03:00
Nikita Mikhaylov
9a70136bcf better 2021-04-26 18:50:40 +03:00
Maksim Kita
0c012d4288 Fixed tests 2021-04-26 13:52:41 +03:00
Maksim Kita
561b045991 Fixed tests 2021-04-26 13:52:41 +03:00
Maksim Kita
e5079c87db Added test 2021-04-26 13:52:41 +03:00
Alexander Kuzmenkov
fed35445d9
Merge pull request #23546 from ClickHouse/aku/window-distributed
fix window functions for Distributed tables
2021-04-26 12:34:46 +03:00
Nikolai Kochetov
092ff0faeb
Merge pull request #23524 from kssenii/insert-union-select
Allow to insert default instead of Null in insert-select / insert-select-union-all
2021-04-26 12:25:49 +03:00
Kruglov Pavel
cb0bd3df5f
Merge pull request #21888 from rf/rf/deltasum-with-timestamp
add `deltaSumTimestamp` + docs, tests & minor improvement to `deltaSum`
2021-04-26 11:26:50 +03:00
tavplubix
81726de8fe
Merge pull request #23366 from amosbird/pid
Fix invalid virtual column expr
2021-04-26 11:10:24 +03:00
Vladimir
3c48b88929
Merge pull request #22208 from azat/s3-writer 2021-04-26 10:31:45 +03:00
Vladimir Chebotarev
c0afbc0043 Reset tests. 2021-04-26 10:21:06 +03:00
alexey-milovidov
a77843bd7d
Merge pull request #23617 from ClickHouse/fix-test-memory_tracking_insert_optimize_long
Fix bad test 01641_memory_tracking_insert_optimize_long
2021-04-26 00:47:32 +03:00
Alexey Milovidov
0dcf87aecc Prefer easy path 2021-04-26 00:46:43 +03:00
alexey-milovidov
42de40ab35
Update tests/queries/0_stateless/01641_memory_tracking_insert_optimize_long.sql
Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
2021-04-25 13:09:58 +03:00
Azat Khuzhin
0d6f9c0816 Add a test for writeSuffix() via Memory engine 2021-04-25 12:47:30 +03:00
alexey-milovidov
e20a6e0f96
Update 01641_memory_tracking_insert_optimize_long.sql 2021-04-25 11:05:59 +03:00
alexey-milovidov
3cf18d8a5f
Merge pull request #23610 from ClickHouse/bad-like
Fix error in LIKE (found by SQLancer)
2021-04-25 08:01:07 +03:00
Alexey Milovidov
301d75dcbe Fix bad test 01641_memory_tracking_insert_optimize_long 2021-04-25 06:24:39 +03:00
alexey-milovidov
1c472b014d
Merge pull request #23517 from azat/flaky-tests-v21.6
Fix function tests flaps
2021-04-25 04:08:49 +03:00
alexey-milovidov
6191f30892
Merge pull request #23595 from azat/fuzzer-tupleElement-formatting
Fix inconsistent formatting for tupleElement (for fuzzer)
2021-04-25 04:03:39 +03:00
Alexey Milovidov
263378bb20 Fix error in LIKE (found by SQLancer) 2021-04-25 03:58:44 +03:00
Azat Khuzhin
a5a8ecfe42 Fix inconsistent formatting for tupleElement (for fuzzer)
fuzzer sometimes [1] may inserts tupleElement() created from ASTLiteral:

    Function_tupleElement, 0xx
    -ExpressionList_, 0xx
    --Literal_Int64_255, 0xx
    --Literal_Int64_100, 0xx

And in this case it will be printed as "255.100", which
later will be parsed as float, and formatting will be
inconsistent.

So instead of printing it as regular tuple,
let's print it as ExpressionList instead (i.e. with ", " delimiter).

Simple reproducer:

    void ast()
    {
        auto arg1 = std::make_shared<ASTLiteral>(Field(255));
        auto arg2 = std::make_shared<ASTLiteral>(Field(100));

        auto func = makeASTFunction("tupleElement", arg1, arg2);

        auto ast = func;
        std::cerr << ast->formatForErrorMessage() << std::endl;
        std::cerr << ast->dumpTree() << std::endl;
    }

  [1]: https://clickhouse-test-reports.s3.yandex.net/23517/f1187aeb69109c88f0be978b8083080c7a843820/fuzzer_debug/report.html#fail1
2021-04-25 00:30:17 +03:00
mergify[bot]
51c16a6b7d
Merge branch 'master' into flaky-tests-v21.6 2021-04-24 19:11:52 +00:00
alexey-milovidov
280c0666a5
Merge pull request #23559 from ClickHouse/reproducible-build
Reproducible build
2021-04-24 21:26:31 +03:00
Azat Khuzhin
313b576aec Improve retry logic in 01675_distributed_bytes_to_delay_insert_long
https://clickhouse-test-reports.s3.yandex.net/23517/414d8d0634ea5e3f05d30f53df8531da54a7ff50/functional_stateless_tests_(ubsan).html#fail1
2021-04-24 15:18:01 +03:00
Azat Khuzhin
414d8d0634 Mark 01675_distributed_bytes_to_delay_insert as long
https://clickhouse-test-reports.s3.yandex.net/23517/416bacc341a815b1b2d28ae24a31e13982ff5a0f/functional_stateless_tests_flaky_check_(address)/test_run.txt.out.log
2021-04-24 09:01:58 +03:00
alexey-milovidov
bcede10919
Merge pull request #23312 from vdimir/issue-23002
Correct sample_block in HashJoin for dict join with join_algorithm
2021-04-24 04:40:43 +03:00
alexey-milovidov
2cfc2c8825
Merge pull request #23397 from CurtizJ/better-move-to-prewhere
Allow to move more conditions to PREWHERE
2021-04-24 04:39:33 +03:00
mergify[bot]
a5da512e39
Merge branch 'master' into pid 2021-04-24 00:37:39 +00:00