Commit Graph

36937 Commits

Author SHA1 Message Date
serxa
4fada6f992 fix typo 2023-02-09 11:50:28 +00:00
alesapin
859f528fe1
Merge pull request #45648 from ClickHouse/45508_Update_strategy_for_system_sync_replica
Updated checking of SYSTEM SYNC REPLICA
2023-02-09 11:51:05 +01:00
Vladimir C
0042c20770
Merge pull request #46054 from alexX512/bug_fix_pulling_pipeline 2023-02-09 10:50:46 +01:00
Alexey Milovidov
d9fbf643bc
Merge pull request #45226 from hanfei1991/hanfei/gwp-asan
Introduce llvm/gwp-asan
2023-02-09 09:24:52 +03:00
pufit
7cf71d1f82
Merge pull request #46144 from ClickHouse/46131-fix-config-attributes-merge
Fix config merge for XML attributes.
2023-02-08 23:28:13 -05:00
Alexander Tokmakov
4fd4058259
Merge pull request #45629 from arthurpassos/fix_cares_crash
Cancel c-ares failed requests and retry on system interrupts to prevent callbacks with dangling references and premature resolution failures
2023-02-09 02:29:29 +03:00
Ilya Yatsishin
9f480b8fa2
Merge pull request #46132 from azat/file-fd-schema-inference 2023-02-08 23:23:32 +01:00
Alexander Tokmakov
648812b652
Merge pull request #46003 from azat/client-settings-fix
Fix applying settings for FORMAT on the client
2023-02-09 01:06:35 +03:00
Alexander Tokmakov
8101b044fa
Merge pull request #46091 from azat/sanity-assertions
Sanity assertions for closing file descriptors
2023-02-09 01:02:03 +03:00
Alexander Tokmakov
65cbb0fcfc
Merge pull request #46138 from vitlibar/fix-dependency-checks
Fix dependency checks
2023-02-09 00:54:40 +03:00
Anton Popov
31adebdca8
Merge pull request #46045 from azat/compact-nested-fix
Fix reading of non existing nested columns with multiple level in compact parts
2023-02-08 22:54:11 +01:00
Han Fei
64b84f8e31 fix style 2023-02-08 22:16:28 +01:00
serxa
cfb8291029 Cleanup disk unittest 2023-02-08 18:14:05 +00:00
Han Fei
8f665b5bbf fix 2023-02-08 18:28:06 +01:00
Han Fei
a4efb1fbda fix compile 2023-02-08 18:06:36 +01:00
Han Fei
d9aab84701 fix fork hang 2023-02-08 16:20:42 +01:00
pufit
e833decd88 try to fix memory leak 2023-02-08 15:17:46 +00:00
Antonio Andelic
45d4ba59dc
Merge pull request #46068 from bigo-sg/alloc_map_metrics
Add new metric to record allocations times and bytes using mmap
2023-02-08 15:49:20 +01:00
Vladimir C
247d6c1edd
Merge pull request #44730 from bigo-sg/optimize_aggregate_function_withif 2023-02-08 15:26:47 +01:00
Maksim Kita
77ec255d7c
Merge pull request #45396 from kitaisreal/hashed-dictionary-sharded-nullable-fix
HashedDictionary sharded fix nullable values
2023-02-08 17:15:10 +03:00
Anton Popov
f0b0eacbad
Merge pull request #45992 from CurtizJ/fix-type-object-analyzer
Fix basic functionality with type `Object` and new analyzer
2023-02-08 14:25:17 +01:00
Anton Popov
62dfac1425
Merge pull request #46103 from bigo-sg/improve_pad_string
Fix doc and enable int types for pad
2023-02-08 14:24:04 +01:00
Smita Kulkarni
87ec32f235 Updated to use znode_name instead of log_entry_id - Updated checking of SYSTEM SYNC REPLICA 2023-02-08 14:07:06 +01:00
robot-clickhouse-ci-1
99274f1db1
Merge pull request #46143 from ClickHouse/evillique-patch-2
Interpret `cluster_name` identifier in `s3Cluster` function as literal
2023-02-08 14:06:16 +01:00
Alexander Gololobov
a7c30eecf4
Merge pull request #46141 from ClickHouse/fix-assertion-in-statistics
Fix assertion in statistical functions
2023-02-08 13:42:02 +01:00
Kruglov Pavel
8bdb1c3453
Merge pull request #44728 from bigo-sg/improve_count_if
Improve count if rewrite
2023-02-08 12:21:29 +01:00
Kseniia Sumarokova
f6ebe11350
Merge pull request #46108 from azat/azure-fix
Fix test_merge_tree_azure_blob_storage::test_zero_copy_replication test
2023-02-08 12:04:46 +01:00
Robert Schulze
b79ead9c84
Move poco to base/poco/ (#46075)
* Replicate poco into base/poco/

* De-register poco submodule

* Build poco from ClickHouse

* Exclude poco from stylecheck

* Exclude poco from whitespace check

* Exclude poco from typo check

* Remove x bit from sources/headers (the style check complained)

* Exclude poco from duplicate include check

* Fix fasttest

* Remove contrib/poco-cmake/*

* Simplify poco build descriptions

* Remove poco stuff not used by ClickHouse

* Glob poco sources

* Exclude poco from clang-tidy
2023-02-08 12:04:11 +01:00
Kseniia Sumarokova
693006ba42
Merge pull request #46083 from kssenii/simplify-storage-s3-configuration
Simplify code around storages s3/hudi/delta-lake
2023-02-08 12:02:38 +01:00
Kruglov Pavel
0e5ceae896
Merge pull request #45296 from bigo-sg/improve_multi_if
Improve performance of function multiIf by columnar executing
2023-02-08 11:33:12 +01:00
Azat Khuzhin
151ba92a2e Fix reading of non existing nested columns with multiple level in compact parts
Consider the following example:

    CREATE TABLE data (root.array_str Array(UInt8)) ENGINE = MergeTree() ORDER BY tuple();
    INSERT INTO data VALUES ([]);
    ALTER TABLE data ADD COLUMN root.nested_array Array(Array(UInt8));

In this case the first part will not have data for root.nested_array,
and thanks to #37152 it will simply read offsets column from
root.array_str, however since root.nested_array is a nested array, it
will try to read elements from the same offsets stream and if you are
lucky enough you will get one of the following errors:

- Cannot read all data. Bytes read: 1. Bytes expected: 8.: (while reading column root.nested_array): While executing MergeTreeInOrder. (CANNOT_READ_ALL_DATA)
- DB::Exception: Array size is too large: 8233460228287709730: (while reading column serp.serp_features): While executing MergeTreeInOrder.

So to address this, findColumnForOffsets() had been changed to return
the level of the column too, to allow to read only up to this level.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-08 10:21:40 +01:00
Igor Nikonov
72c393e7c4
Merge pull request #46014 from ClickHouse/inorder-optimization-update-sorting-properties
Update sorting properties after reading in order applied
2023-02-08 10:19:47 +01:00
Azat Khuzhin
758deac715 Do not check close() return value in BaseDaemon::closeFDs()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-08 05:52:35 +01:00
Azat Khuzhin
0b37344b26 Use BAD_ARGUMENTS over LOGICAL_ERROR for schema inference error file() over fd
Otherwise the following leads to SIGSEGV in debug/sanitizers builds:

  echo '0000000000Custom NULL representation0000000000' | clickhouse-local -q "desc file('-', 'TSV')"

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-08 05:36:49 +01:00
taiyang-li
51f565a470 fix ast fuzzer error 2023-02-08 12:13:29 +08:00
Alexey Milovidov
69d3575ce5 Fix style, remove trash 2023-02-08 05:12:23 +01:00
Alexey Milovidov
2dc014254e Update tests 2023-02-08 03:37:46 +01:00
Alexey Milovidov
924f19e94a
Update AzureBlobStorageAuth.cpp 2023-02-08 04:12:00 +03:00
pufit
c066c0dfdb Fix config merge for an attributes 2023-02-07 23:46:13 +00:00
Nikolay Degterinsky
4040b9c91b
Interpret cluster_name identifier in s3Cluster function as literal 2023-02-08 00:39:19 +01:00
Alexey Milovidov
41722a6163 Fix assertion in statistical functions 2023-02-08 00:15:32 +01:00
Alexey Milovidov
55c3bbb739 Fix assertion in statistical functions 2023-02-08 00:09:41 +01:00
Kseniia Sumarokova
a5d3b00699
Merge pull request #46010 from kssenii/named-collections-fix-access
Fix named collections access
2023-02-07 23:20:22 +01:00
Smita Kulkarni
8c9d994fd7 Extended scope of state_mutex while adding subscriber - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 22:04:17 +01:00
Azat Khuzhin
911fabd0dc Fix applying settings for FORMAT on the client
Previously the following query does not works correctly:

    SELECT number FROM numbers(5) SETTINGS output_format_json_array_of_rows = 1 FORMAT JSONEachRow

While this one works OK:

    SELECT number FROM numbers(5) FORMAT JSONEachRow SETTINGS output_format_json_array_of_rows = 1

The problem is in which AST those settings are stored, use the logic as
executeQuery() has to apply them:

  c83f701696/src/Interpreters/executeQuery.cpp (L467-L497)

Note, the only problem should be with the settings for FORMAT, since
client applies thoes settings (and formats) locally w/o server, while in
case of i.e. HTTP it will be applied on the server and everything will
works fine.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 18:29:40 +01:00
Kseniia Sumarokova
41dbdcff67
Merge branch 'master' into simplify-storage-s3-configuration 2023-02-07 18:09:34 +01:00
Azat Khuzhin
d21f6a0bd6 Fix WriteBufferFromFile destructor after close()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 17:59:05 +01:00
Smita Kulkarni
ecea28a832 Fixed style check - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 17:27:34 +01:00
Nikolai Kochetov
3912f5a333
Merge pull request #45681 from CurtizJ/compact-parts-vertical-merge
Allow vertical merges from compact to wide parts
2023-02-07 17:09:17 +01:00
Smita Kulkarni
34341ddabe Updated locks and removed getLogEntryIds function - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 16:57:58 +01:00