Commit Graph

36937 Commits

Author SHA1 Message Date
Zhiguo Zhou
b43ffb98e8
Vectorize filter generation of ColumnNullable in FilterDescription (#45962)
This commit achieved the data parallelism for filter generations of
the nullable columns by replacing the logical AND operator with the
bitwise one, which could be auto-vectorized by the compiler.
2023-02-07 16:33:01 +01:00
kssenii
40deaf1661 Fix clang-tidy 2023-02-07 16:30:04 +01:00
Han Fei
0f7defb87f
Merge branch 'master' into hanfei/gwp-asan 2023-02-07 14:55:55 +01:00
Sema Checherinda
52d4e78b7f
Merge pull request #45907 from CheSema/forbid-wal-on-s3
do not run wal on remote disks
2023-02-07 14:48:00 +01:00
Yakov Olkhovskiy
4e7dffafe4
Merge pull request #46087 from ClickHouse/fix-ip-bloom
Allow bloom filter for IPv4 and IPv6
2023-02-07 08:29:28 -05:00
Yakov Olkhovskiy
909a772701
Merge pull request #45375 from ClibMouse/window_view_fix
Window view functional test failed on platform s390x
2023-02-07 08:23:50 -05:00
Vitaly Baranov
6555b48132 Disable evaluating the right part of IN operator while analyzing dependencies. 2023-02-07 13:21:30 +01:00
Han Fei
021e6e90cc
Merge pull request #45631 from hanfei1991/hanfei/regexp-refine
RegExpTreeDict use re2 engines when processing heavy regexps
2023-02-07 13:21:22 +01:00
Vitaly Baranov
324b0b6896 Fix DDLDependencyVisitor for an empty table name. 2023-02-07 13:21:18 +01:00
Azat Khuzhin
fe832c4418 Fix TOCTOU while checking for container existence in azure_blob_storage
This is a simple time-of-check vs time-of-use, since between checking
does such container exist and creating one, there is a time window.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 12:51:06 +01:00
kssenii
9485873a2f Fix integration test 2023-02-07 12:45:23 +01:00
Smita Kulkarni
fb765696b6 Removed state_mutex lock from addSubscriber - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 12:19:58 +01:00
Robert Schulze
690d873126
Merge pull request #46088 from ClickHouse/rs/fix-liburing-build
Fix build with `-DENABLE_LIBURING=0` (or `-DENABLE_LIBRARIES=0`)
2023-02-07 12:16:14 +01:00
Sergei Trifonov
950c04cb0e
Merge pull request #44907 from azat/dist/async-INSERT-error-message-fix
Fix error message for a broken distributed batches ("While sending batch")
2023-02-07 12:14:52 +01:00
Vitaly Baranov
f021c0eab6
Merge pull request #46058 from vitlibar/remove-unnecessary-execute-for-const-expr
Remove unnecessary execute() while evaluating a constant expression.
2023-02-07 12:09:37 +01:00
Robert Schulze
f9b6c10700
Merge pull request #46072 from ClickHouse/rs/follow-up-to-46057
Smallish follow-up to #46057
2023-02-07 11:52:51 +01:00
Azat Khuzhin
8cc41b7f41 Check return value of ::close()
Note, that according close(2), EINTR should not be retriable for close()

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 11:28:22 +01:00
taiyang-li
f41f41c78c fix doc; enable int type for pad 2023-02-07 18:25:36 +08:00
Smita Kulkarni
135615cda6 Removed unwanted check from before callback - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 10:27:45 +01:00
Smita Kulkarni
ef29b61786 Updated callback to return log entry ids - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 10:02:38 +01:00
Smita Kulkarni
f34ef86332 Moved background task trigger before getting log entries to wait - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 08:49:41 +01:00
Anton Popov
7dfea59267 remove an assertion 2023-02-07 00:50:41 +00:00
Alexander Tokmakov
13da43ead8
Merge branch 'master' into fix_test_00002 2023-02-07 03:25:42 +03:00
Anton Popov
3ad5a085da
Merge pull request #45987 from CurtizJ/fix-sparse-columns-crash
Fix `INTERSECT` and `EXCEPT` with sparse columns
2023-02-06 23:01:02 +01:00
Azat Khuzhin
e83163e25f Add sanity check of evtimer_del() in QueryProfiler
Saw this one time on CI with EINVAL [1], while this was EINVAL this
time, next time it can be completelly different fd and break something
in a different place.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/45654/1716af465d376f5335720b5045bcccdd9e1823aa/fast_test.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-06 20:13:05 +01:00
Han Fei
d1d893275a fix 2023-02-06 18:46:23 +01:00
Robert Schulze
8840aa9242
Fix build with -DENABLE_LIBURING=0 (or -DENABLE_LIBRARIES=0)
Follow-up to #38456

The problem was that code which uses liburing was conditionally build
depending on define OS_LINUX and not based on whether liburing was
enabled/disabled at build time.
2023-02-06 16:57:42 +00:00
Yakov Olkhovskiy
e433c26cf9 allow bloom filter for IPv4 and IPv6 2023-02-06 16:30:18 +00:00
Han Fei
eb76041312 address comments and add one more test 2023-02-06 17:26:20 +01:00
Alexander Tokmakov
af655eb7dc
Merge pull request #45889 from CheSema/release-merge-blocker-drop-part
do not block merges when old parts are droping in drop queries
2023-02-06 19:09:09 +03:00
kssenii
ab0dedf0c8 Simplify code around storage s3 configuration 2023-02-06 16:23:17 +01:00
Anton Popov
3850a1969d
Merge branch 'master' into fix-memory-leak-azure 2023-02-06 16:21:56 +01:00
Suzy Wang
6edbffa3cc
Merge branch 'master' into window_view_fix 2023-02-06 10:06:04 -05:00
alesapin
e999f66234
Merge pull request #46040 from azat/backup-fix-race
Fix data race in BACKUP
2023-02-06 15:20:44 +01:00
Alexander Tokmakov
e9f770d89d fix 2023-02-06 14:03:14 +01:00
alesapin
b94f9f8006
Merge branch 'master' into 45508_Update_strategy_for_system_sync_replica 2023-02-06 12:38:39 +01:00
Kseniia Sumarokova
38c001ca42
Merge pull request #45957 from xiedeyantu/s3_file_not_found
Throw an error on no files satisfying S3 wildcard
2023-02-06 12:32:12 +01:00
Alexander Gololobov
a784750e66
Merge pull request #45949 from bigo-sg/improve_decimal
Improve performance of ColumnArray::filter/replicate  for big int and decimal
2023-02-06 12:27:19 +01:00
Alexander Gololobov
d18364476d
Merge pull request #46047 from azat/system.processes-elapsed-fix
Fix elapsed column in system.processes (10x error)
2023-02-06 12:26:05 +01:00
Alexey Perevyshin
7a4d658a46
Merge branch 'master' into bug_fix_pulling_pipeline 2023-02-06 14:24:26 +03:00
Vladimir C
5686703e79
Merge pull request #46053 from ucasfl/json-columns
Closes https://github.com/ClickHouse/ClickHouse/issues/46024
2023-02-06 12:22:13 +01:00
Sema Checherinda
734d3a318b
const auto ref in the loop 2023-02-06 12:09:33 +01:00
Robert Schulze
4c89327c9f
Add TODO comment to MultiVersion.h
Follow-up to #46057
2023-02-06 11:04:58 +00:00
Robert Schulze
fa131edba5
Merge pull request #46057 from k-morozov/refactoring/multiversion-atomic-functions
MultiVersion: change mutex to lock-free
2023-02-06 11:55:27 +01:00
Vladimir C
e3712bb2c6
Merge pull request #45961 from ClickHouse/vdimir/sparkbar-fix 2023-02-06 11:52:15 +01:00
Maksim Kita
e8d66fb1a2 HashedDictionary sharded fix nullable values 2023-02-06 10:50:58 +01:00
taiyang-li
7b10ac8d5b add new metric to record allocations times and bytes using mmap 2023-02-06 17:50:45 +08:00
Alexey Perevyshin
10f3c9f640
Merge branch 'master' into bug_fix_pulling_pipeline 2023-02-06 12:00:24 +03:00
李扬
444373679a
Merge branch 'master' into improve_decimal 2023-02-06 13:08:51 +08:00
Robert Schulze
4a328828b5
Merge pull request #45758 from ClickHouse/qc-max_cache_size
Make Query Cache server-level settings reconfigurable at runtime
2023-02-05 21:55:37 +01:00
Vitaly Baranov
a3423ce196 Remove unnecessary execute() while evaluating a constant expression. 2023-02-05 20:26:34 +01:00
Han Fei
baa345fa64 remove logs 2023-02-05 18:06:06 +01:00
Han Fei
532b341de9
Merge pull request #45975 from ucasfl/_part
use LowCardnality for _part and _partition_id virtual column
2023-02-05 18:00:46 +01:00
Robert Schulze
9b841d67e8
Merge remote-tracking branch 'origin/master' into qc-max_cache_size 2023-02-05 16:47:02 +00:00
Konstantin Morozov
ff05162904 change mutex to lock-free 2023-02-05 19:25:09 +03:00
Igor Nikonov
089a0009ad Polishing
+ try to stabilize distinct in order perf test
2023-02-05 13:38:20 +00:00
alexX512
ea07f08f75 Fix bug with wrong checking of execution finish in PullingAsyncPipeline 2023-02-05 13:23:26 +00:00
flynn
f89a6cf68d Improve format JSONColumns when result is empty 2023-02-05 13:13:21 +00:00
Azat Khuzhin
1307e6d323 Fix elapsed column in system.processes (10x error)
Fixes: #43455 (cc @Algunenano)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-04 22:37:11 +01:00
bkuschel
1f3b1c697f
Add newline 2023-02-04 15:39:28 -05:00
bkuschel
dc995f7c67
Fix size,free ctx,formatting 2023-02-04 15:03:04 -05:00
Boris Kuschel
d9f3698a43
Fix copy/pasta 2023-02-04 14:59:47 -05:00
Boris Kuschel
1d4cf4fe69
Add encryption support with openssl 2023-02-04 14:59:34 -05:00
Alexander Gololobov
4ef09ecc0f
Update gtest_azure_sdk.cpp 2023-02-04 19:05:05 +01:00
xiedeyantu
f13eedd644 change settings name 2023-02-04 22:11:14 +08:00
Azat Khuzhin
a3a5867b07 Fix data race in BACKUP
Fixes the following data race:

<details>

WARNING: ThreadSanitizer: data race (pid=1)
  Write of size 8 at 0x7b580016ff20 by thread T218 (mutexes: write M0):
    0 DB::BackupImpl::writeFile() build_docker/../src/Backups/BackupImpl.cpp:1000:9 (clickhouse+0x1bd0b7a6) (BuildId: 3558ba44526114e01870f02cc410103fa6cb8de3)
    1 DB::writeBackupEntries()::$_0::operator()(bool) const build_docker/../src/Backups/BackupUtils.cpp:109:25 (clickhouse+0x1bc19cda) (BuildId: 3558ba44526114e01870f02cc410103fa6cb8de3)

  Previous read of size 8 at 0x7b580016ff20 by thread T238:
    0 DB::BackupImpl::writeFile() build_docker/../src/Backups/BackupImpl.cpp:956:14 (clickhouse+0x1bd0ae8d) (BuildId: 3558ba44526114e01870f02cc410103fa6cb8de3)
    1 DB::writeBackupEntries()::$_0::operator()(bool) const build_docker/../src/Backups/BackupUtils.cpp:109:25 (clickhouse+0x1bc19cda) (BuildId: 3558ba44526114e01870f02cc410103fa6cb8de3)

</details>

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-04 11:09:11 +01:00
Han Fei
9ea3de14ce use re2 by default 2023-02-04 10:53:54 +01:00
Alexey Milovidov
496cacf25e
Merge pull request #45985 from ClickHouse/fix-crash-in-regression
Fix crash in stochasticLinearRegression.
2023-02-04 03:01:46 +01:00
Alexey Milovidov
22bd0b6f69
Merge pull request #38983 from CurtizJ/randomize-mt-settings
Allow to randomize merge tree settings in tests
2023-02-04 02:59:52 +01:00
Anton Popov
e9f80c650a fix memory leak at creation of curl connection in azure sdk 2023-02-03 20:10:39 +00:00
Anton Popov
20ebd38242
Merge branch 'master' into fix-sparse-columns-crash 2023-02-03 21:00:02 +01:00
vdimir
1e45033531
Update AggregateFunctionSparkbar 2023-02-03 17:22:08 +00:00
Igor Nikonov
f49f5d7091 Update tests
+ updadte sorting properties after applying aggregation in order
2023-02-03 17:10:31 +00:00
Anton Popov
a394f9c92a check is storage supports subcolumns 2023-02-03 17:05:57 +00:00
Alexander Tokmakov
3f11948bb0
Merge branch 'master' into stack_trace_in_part_log 2023-02-03 20:05:00 +03:00
Alexander Tokmakov
7e6f7c79f2
Merge pull request #45457 from FrankChen021/exception_time
Add last_exception_time to replication_queue
2023-02-03 20:00:15 +03:00
Han Fei
061204408a
Merge pull request #45952 from ucasfl/tuple
Fix tupleElement with Null arguments
2023-02-03 16:15:54 +01:00
Anton Popov
88f2068bfb
Merge branch 'master' into fix-sparse-columns-crash 2023-02-03 16:01:11 +01:00
Robert Schulze
85cbb9288c
Merge pull request #45456 from FrankChen021/uncaught_exception
Fix uncaught exception in HTTPHandler
2023-02-03 15:26:02 +01:00
Nikita Mikhaylov
33877b5e00
Parallel replicas. Part [2] (#43772) 2023-02-03 14:34:18 +01:00
Antonio Andelic
d5117f2aa6
Define S3 client with bucket and endpoint resolution (#45783)
* Update aws

* Define S3 client with bucket and endpoint resolution

* Add defines for ErrorCodes

* Use S3Client everywhere

* Remove unused errorcode

* Add DROP S3 CLIENT CACHE query

* Add a comment

* Fix style

* Update aws

* Update reference files

* Add missing include

* Fix unit test

* Remove unneeded declarations

* Correctly use RetryStrategy

* Rename S3Client to Client

* Fix retry count

* fix clang-tidy warnings
2023-02-03 14:30:52 +01:00
Han Fei
2656027c9f make it work if we dont define use_vectorscan macro 2023-02-03 14:25:53 +01:00
Anton Popov
cdbe145bc1
Merge pull request #45796 from CurtizJ/fix-leak-in-azure-sdk
Fix test `test_azure_blob_storage_zero_copy_replication ` (memory leak in azure sdk)
2023-02-03 14:16:19 +01:00
Igor Nikonov
ed00db7580 Update sorting properties after reading in order applied 2023-02-03 13:15:06 +00:00
Vitaly Baranov
45d2d678ab
Merge pull request #45800 from vitlibar/rename-new-columns-in-system-backups
Rename new columns in system.backups
2023-02-03 14:00:16 +01:00
Azat Khuzhin
a196f995b1 Fix error message for a broken distributed batches ("While sending batch")
There was an error from the begginning that does not respect
file_indices, and iterate only over file_index_to_path, while this is
not correct, since there can be less files then in file_index_to_path,
and this is what file_indices for.

Note, that only an error message was wrong, logic was fine. You can
verify this by the logs:

    2022.12.07 11:55:50.951976 [ 39217 ] {} <Debug> default.dist.DirectoryMonitor: Sending a batch of 10 files to localhost:9000 (128.42 thousand rows, 36.32 MiB bytes).
    2022.12.07 11:55:50.953762 [ 39217 ] {} <Error> default.dist.DirectoryMonitor: Code: 516. DB::Exception: Received from localhost:9000. DB::Exception: Interserver authentication failed. Stack trace:
    ...
    : While sending batch, nums: 62, files: /work6/clickhouse/data/default/dist/shard1_replica1/66827258.bin

As you can see "Sending a batch of 10 files" but "nums: 62"

Fixes: #23856
Refs: #41813
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-03 13:54:40 +01:00
Alexey Milovidov
3e3df376c0
Merge pull request #45995 from CurtizJ/check-dynamic-columns
Check dynamic columns of part before its commit
2023-02-03 15:39:54 +03:00
Alexey Milovidov
c91b5c264f
Merge pull request #45940 from ClickHouse/fix-uring
Fix IO URing
2023-02-03 15:36:29 +03:00
Sema Checherinda
e0db071563
Merge branch 'master' into release-merge-blocker-drop-part 2023-02-03 13:35:51 +01:00
kssenii
486c10bde1 Fix named collections access 2023-02-03 13:18:54 +01:00
Sema Checherinda
fe0b13e9f4
Merge pull request #45458 from FrankChen021/better_postpone_reason
Show the name of replica that is executing a merge in the postpone_reason
2023-02-03 13:15:10 +01:00
Nikolai Kochetov
9cabbd07cc
Merge branch 'master' into fix-crash-in-regression 2023-02-03 12:38:29 +01:00
Antonio Andelic
cb0e338d70
Revert "Improve behaviour of conversion into Date for boundary value 65535" 2023-02-03 12:10:39 +01:00
Kseniia Sumarokova
ef7acb9b66
Merge pull request #44404 from kssenii/storage-rabbitmq-fix-flush
RabbitMQ - fix writing many small blocks by flushing data only exactly by flush_interval_ms or by max_block_size
2023-02-03 11:50:12 +01:00
Robert Schulze
f72286c8f3
Merge branch 'master' into qc-max_cache_size 2023-02-03 10:54:35 +01:00
Robert Schulze
6908093787
Merge pull request #45973 from ClickHouse/final-codecs
Add "final" specifier to some classes
2023-02-03 10:52:59 +01:00
Antonio Andelic
e507721557
Merge branch 'master' into optimize_parquet_reader 2023-02-03 10:24:18 +01:00
flynn
3d9b8ba991 Merge branch 'master' of github.com:ClickHouse/ClickHouse into tuple 2023-02-03 07:48:57 +00:00
Smita Kulkarni
123f3cfe1f Used unordered_set for log entries and fixed the callback function - Updated checking of SYSTEM SYNC REPLICA 2023-02-03 08:48:16 +01:00
Frank Chen
7831cf85db Revert an extra change 2023-02-03 15:36:12 +08:00