Commit Graph

58427 Commits

Author SHA1 Message Date
Alexey Milovidov
02a3049876
Merge pull request #58285 from canhld94/fix_a_test
Hot reload storage policy for distributed tables when adding a new disk
2024-06-05 04:11:49 +02:00
lgbo-ustc
8c94832c20 fixed #64513. mixed join condition with function 'in' 2024-06-05 09:33:04 +08:00
Alexey Milovidov
bb9091ad5a
Merge pull request #64582 from arenadata/ADQM-1868
Binary math functions Decimal support
2024-06-05 02:15:40 +02:00
Alexey Milovidov
78506304b7
Merge pull request #55061 from amosbird/support-empty-tuple-2
Support empty tuple [second implementation]
2024-06-05 02:00:03 +02:00
Han Fei
f7ca33868b Merge branch 'master' into hanfei/stats_uniq 2024-06-05 01:21:49 +02:00
Julia Kartseva
1638dd0837
Merge pull request #64483 from korowa/read-in-order-nullable
fix: optimize_read_in_order for nullable keys
2024-06-04 22:49:27 +00:00
Alexey Milovidov
5a5bdd87cb
Merge pull request #64592 from tomershafir/xray
xray: add global xray instrumentation support
2024-06-05 01:25:25 +02:00
Alexey Milovidov
a6fe50c103
Merge pull request #42544 from ClickHouse/try-about-on-current-thread-join
Try abort on current thread join.
2024-06-05 01:13:25 +02:00
Julia Kartseva
12bf33c519
Merge pull request #64778 from jkartseva/fix-plain-rewritable-cache
Fix crash in a local cache over `plain_rewritable` disk
2024-06-04 20:34:58 +00:00
Kseniia Sumarokova
d044d228ba
Merge pull request #64349 from ClickHouse/s3queue-fix-ordered-mode
S3Queue rework ordered mode parallel processing
2024-06-04 20:27:46 +00:00
Robert Schulze
46434f9040
Merge pull request #63578 from ElderlyPassionFruit/add-compression-sorts-optimization
Best-effort sorting to improve compressability
2024-06-04 19:02:55 +00:00
Robert Schulze
9cf8bdcdb2
Merge pull request #64656 from rschu1ze/deprecated-inverted-index
Be more graceful with existing tables with `inverted` indexes
2024-06-04 18:45:03 +00:00
Robert Schulze
c061a42f35
Merge pull request #64742 from Beetelbrox/fjurado-61548/feat-add-parseReadableSize-function
Add `parseReadableSize` function
2024-06-04 18:39:33 +00:00
Alexey Milovidov
c0aad2a2b5
Merge pull request #64777 from ClickHouse/remove-iostream-debug-helpers
Remove iostream debug helpers
2024-06-04 20:44:30 +02:00
Eduard Karacharov
f1a56080af fix: optimize_read_in_order for nullable keys 2024-06-04 20:56:45 +03:00
kssenii
1790c85465 Fix build without s3 in fast test 2024-06-04 19:42:31 +02:00
Raúl Marín
499514f57d
Merge pull request #64785 from Algunenano/comment
Remove unnecessary comment
2024-06-04 17:33:31 +00:00
kssenii
c05d4e52d3 Fix memory leak in slry 2024-06-04 19:26:12 +02:00
Sema Checherinda
dd6ae2f77c
Merge pull request #63427 from arthurpassos/fix_wrong_request_protocol_proxy
Several minor fixes to proxy support in ClickHouse
2024-06-04 16:35:03 +00:00
Alexey Milovidov
5b16681311 Merge branch 'master' into try-about-on-current-thread-join 2024-06-04 18:11:34 +02:00
Igor Markelov
613e82c39b Merge branch 'master' into add-compression-sorts-optimization 2024-06-04 15:05:44 +00:00
Antonio Andelic
0ae901c479 Better 2024-06-04 16:51:04 +02:00
Igor Nikonov
9372768239 Merge remote-tracking branch 'origin/master' into store-analysis-result 2024-06-04 14:41:52 +00:00
Igor Nikonov
2f45caca28
Merge pull request #64767 from ClickHouse/fix-crash-distinct-optimization
Fix crash with DISTINCT and window functions
2024-06-04 14:29:00 +00:00
Alexander Tokmakov
9f49c83130
Merge pull request #63087 from Unalian/feat-59377
[feature]: allow to attach parts from a different disk (v2.0)
2024-06-04 13:52:25 +00:00
Francisco Javier Jurado Moreno
24cf1c7dbf Fix unintentional changes 2024-06-04 14:57:57 +02:00
Antonio Andelic
5c9aac484d Avoid taking lock 2024-06-04 14:57:43 +02:00
Francisco Javier Jurado Moreno
c8565abaeb Remove trailing whitespace 2024-06-04 14:24:35 +02:00
Francisco Javier Jurado Moreno
858bfb429f Add wildcard at end of function name in comment 2024-06-04 14:16:29 +02:00
Francisco Javier Jurado Moreno
d60e14c1d7 Remove wildcard from comment 2024-06-04 14:15:10 +02:00
Francisco Javier Jurado Moreno
9e1c3f1081 Make ternary into full blown ifelse using constexpr and fix comment 2024-06-04 14:13:46 +02:00
kssenii
080c6037ab Merge remote-tracking branch 'origin/master' into s3queue-fix-ordered-mode 2024-06-04 13:52:45 +02:00
Kseniia Sumarokova
557c423007
Merge branch 'master' into s3queue-fix-ordered-mode 2024-06-04 13:14:49 +02:00
vdimir
cbe99d5619
fix race in BlobStorageLog::shouldIgnorePath 2024-06-04 11:14:03 +00:00
alesapin
6d7c6a47cc
Merge pull request #64747 from ClickHouse/better-session-move-message
Return the explanation for session moved error
2024-06-04 10:55:51 +00:00
Alexander Gololobov
ee3ea236b9
Merge pull request #64433 from ClickHouse/faster_test_keeper_shutdown
Faster TestKeeper shutdown
2024-06-04 10:47:17 +00:00
Raúl Marín
6f89f39708 Remove unnecessary comment 2024-06-04 11:54:08 +02:00
Robert Schulze
3cef283541
Merge remote-tracking branch 'rschu1ze/master' into deprecated-inverted-index 2024-06-04 09:49:51 +00:00
Robert Schulze
5fffba2291
Minor fixups 2024-06-04 09:49:32 +00:00
Antonio Andelic
9d30a7f056 Fix Keeper snapshot size in mntr 2024-06-04 11:30:22 +02:00
Robert Schulze
14404b8a0a
Merge remote-tracking branch 'rschu1ze/master' into map-stuff 2024-06-04 08:42:25 +00:00
Nikolai Kochetov
8c2c27e346
Merge pull request #61459 from amosbird/trivial-count-opt-base
Refactor KeyCondition and key analysis
2024-06-04 07:57:18 +00:00
vdimir
764199e63c
fix build 2024-06-04 07:52:50 +00:00
vdimir
37fa4f5dd6
Revert "Fix build BlobStorageLogWriter with CLICKHOUSE_KEEPER_STANDALONE_BUILD"
This reverts commit dfcc36ee2d02c036126007dcdc1ffc1946a3e9f2.
2024-06-04 07:52:49 +00:00
vdimir
72e7a266e7
Revert "Move BlobStorageLogWriter to Interpreters"
This reverts commit ca3d80102365e76d931be016638b1ca506dffb86.
2024-06-04 07:52:49 +00:00
vdimir
6d9b2c8f5a
Move BlobStorageLogWriter to Interpreters 2024-06-04 07:52:48 +00:00
vdimir
5d1b33612c
Fix build BlobStorageLogWriter with CLICKHOUSE_KEEPER_STANDALONE_BUILD 2024-06-04 07:52:48 +00:00
vdimir
57e7e46a2b
Add enable_blob_storage_log to SettingsChangesHistory.h 2024-06-04 07:52:48 +00:00
vdimir
03fa9c32ee
Update BlobStorageLog and SystemLog to add settings for query 2024-06-04 07:52:47 +00:00
vdimir
55512d4a61
Prevent recursive logging in blob_storage_log 2024-06-04 07:52:44 +00:00
Igor Nikonov
7290e270dc Merge remote-tracking branch 'origin/master' into fix-crash-distinct-optimization 2024-06-04 07:26:58 +00:00
Eduard Karacharov
a7729d6bc4 fix: function filters with token-based text indexes 2024-06-04 09:25:00 +03:00
pufit
c3fd58475a Add comment 2024-06-04 01:12:30 -04:00
Julia Kartseva
2ee4159453 Fix crash in a local cache over plain_rewritable disk
The plain_rewritable object storage has introduced some new methods
to object storage. Override the CachedObjectStorage methods so that
they call these.
2024-06-04 04:53:38 +00:00
Alexey Milovidov
887a56d5f7
Merge pull request #63584 from ClickHouse/trek
Track memory allocated by the arrow library
2024-06-04 04:03:30 +00:00
Alexey Milovidov
b6e3b9c784
Merge pull request #64774 from ClickHouse/ask-company-name
Ask about company name on GitHub
2024-06-04 05:59:07 +02:00
Alexey Milovidov
a24b9054b3 Whitespace 2024-06-04 05:50:07 +02:00
Alexey Milovidov
84914f2c3d Remove iostream_debug_helpers 2024-06-04 05:48:45 +02:00
Alexey Milovidov
f4d1f6050f
Merge pull request #64562 from bigo-sg/literal
ASTLiteral support custom type
2024-06-04 03:20:08 +00:00
Alexey Milovidov
863d799765 Whitespace 2024-06-04 04:55:41 +02:00
shuai-xu
8c62bde552 add comments 2024-06-04 09:36:14 +08:00
Michael Kolupaev
26abb08b84 Conflict 2024-06-04 00:01:25 +00:00
Michael Kolupaev
4e38e89ffd Conflict 2024-06-04 00:01:25 +00:00
Michael Kolupaev
10a78f0841 Declare ErrorCodes 2024-06-04 00:01:25 +00:00
Michael Kolupaev
0fd9cdf47e Track memory allocated by the arrow library 2024-06-04 00:01:25 +00:00
Michael Kolupaev
16bf3e3062 Make table functions always report engine 'StorageProxy' in system.tables 2024-06-03 23:47:52 +00:00
Michael Kolupaev
4aa396d115 Fix assert in IObjectStorageIteratorAsync 2024-06-03 22:50:57 +00:00
pufit
62aacc5539 Fix default database with grant on cluster 2024-06-03 18:43:08 -04:00
Igor Nikonov
f8e6614b80 Fix crash with DISTINCT and window functions 2024-06-03 20:52:23 +00:00
Igor Markelov
52eb917ef0 Merge branch 'master' into add-compression-sorts-optimization 2024-06-03 20:47:04 +00:00
Azat Khuzhin
1e01adda04 Do not try to write columns.txt if it does not exists for write-once storages
Remember that write-once does not allows move:

    [local] 2024.06.03 17:21:22.520165 [ 10032 ] {c923ec81-c802-407f-8078-a5b46cec4d21} <Error> DiskObjectStorageTransaction: An error occurred while executing transaction's operation #0 (PureMetadataObjectStorageOperation): Code: 48. DB::Exception: Operation is not implemented. (NOT_IMPLEMENTED), Stack trace (when copying this message, always include the lines below):

    0. /src/ch/clickhouse/contrib/llvm-project/libcxx/include/exception:141: Poco::Exception::Exception(String const&, int) @ 0x00000000143113d6
    1. /src/ch/clickhouse/src/Common/Exception.cpp:101: DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000000ae2fd6c
    2. /src/ch/clickhouse/contrib/llvm-project/libcxx/include/string:1499: DB::Exception::Exception(PreformattedMessage&&, int) @ 0x0000000006133a61
    3. /src/ch/clickhouse/contrib/llvm-project/libcxx/include/vector:434: DB::Exception::Exception<>(int, FormatStringHelperImpl<>) @ 0x000000000613f0dc
    4. /src/ch/clickhouse/src/Disks/ObjectStorages/IMetadataStorage.h:164: DB::IMetadataTransaction::throwNotImplemented() @ 0x000000000f895364
    7. /src/ch/clickhouse/contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:701: DB::(anonymous namespace)::PureMetadataObjectStorageOperation::execute(std::shared_ptr<DB::IMetadataTransaction>) @ 0x000000000f84ddde
    8. /src/ch/clickhouse/src/Disks/ObjectStorages/DiskObjectStorageTransaction.cpp:946: DB::DiskObjectStorageTransaction::commit() @ 0x000000000f84d74f
    9. /src/ch/clickhouse/contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:701: DB::DiskObjectStorage::moveFile(String const&, String const&, bool) @ 0x000000000f83c472
    10. /src/ch/clickhouse/contrib/llvm-project/libcxx/include/string:1499: DB::DataPartStorageOnDiskFull::moveFile(String const&, String const&) @ 0x00000000111b541a
    11. /src/ch/clickhouse/src/Storages/MergeTree/IMergeTreeDataPart.cpp:1053: DB::IMergeTreeDataPart::writeColumns(DB::NamesAndTypesList const&, DB::WriteSettings const&) @ 0x00000000111f28be
    12. /src/ch/clickhouse/contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:701: DB::IMergeTreeDataPart::loadColumns(bool) @ 0x00000000111e9883
    13. /src/ch/clickhouse/src/Storages/MergeTree/IMergeTreeDataPart.cpp:714: DB::IMergeTreeDataPart::loadColumnsChecksumsIndexes(bool, bool) @ 0x00000000111e8b12
    14. /src/ch/clickhouse/src/Storages/MergeTree/MergeTreeData.cpp:0: DB::MergeTreeData::loadDataPart(DB::MergeTreePartInfo const&, String const&, std::shared_ptr<DB::IDisk> const&, DB::MergeTreeDataPartState, std::mutex&) @ 0x00000000112849d0

Note, that DataPartStorageOnDiskBase::isReadonly() is used only in
loadColumns() for calling writeColumns() in case of columns.txt does not
exists

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-06-03 17:42:25 +02:00
vdimir
ecc6836dee
Merge pull request #64424 from liuneng1994/reduce-parquet-writer-peak-memory
Reduce parquet writer peak memory
2024-06-03 14:49:05 +00:00
Amos Bird
ba7b4e058b
Resolve conflicts 2024-06-03 22:46:18 +08:00
Raúl Marín
ee416a6862
Merge pull request #63723 from Algunenano/ifunction_column_size
Add a bunch of important asserts
2024-06-03 14:04:02 +00:00
Antonio Andelic
9be51d6f20 Return the explanation for session moved error 2024-06-03 15:48:18 +02:00
Amos Bird
7e6bb6b20d
Simply based on review comment 2024-06-03 21:25:23 +08:00
Amos Bird
dbecec7dbf
Improve PartitionPruner and trivial count opt 2024-06-03 21:25:21 +08:00
Nikolai Kochetov
49043d4399
Merge pull request #64517 from ClickHouse/fix-some-aliases-for-global-in
Fixing aliases for GLOBAL IN
2024-06-03 13:06:18 +00:00
Yarik Briukhovetskyi
230fbf76a9
Merge pull request #60156 from Artemmm91/hilbert-function
Add `hilbertEncode` and `hilbertDecode` functions
2024-06-03 12:23:01 +00:00
Mikhail Gorshkov
869134eaac Original remaining rows handling retained 2024-06-03 12:14:02 +00:00
Nikolai Kochetov
84d2bbcf8b Merge branch 'master' into fix-some-aliases-for-global-in 2024-06-03 11:29:35 +00:00
Nikolai Kochetov
f5c2bbd9ce
Merge pull request #64672 from ClickHouse/split-query-analyzer
Split query analyzer
2024-06-03 11:27:25 +00:00
kssenii
fc06bd7da5 Review fixes 2024-06-03 12:59:27 +02:00
Mikhail Gorshkov
f2bebae0d5 Original formatting retained 2024-06-03 10:55:19 +00:00
Mikhail Gorshkov
0a64a75f19 PR suggestions follow-ups 2024-06-03 10:44:36 +00:00
alesapin
c45ebafc70
Merge pull request #64694 from ClickHouse/fix_ttl_incompatibility
Fix backward incompatibility in TTL execution
2024-06-03 10:29:26 +00:00
János Benjamin Antal
99f547529c Merge remote-tracking branch 'origin/master' into fix_integer_accurate_cast 2024-06-03 09:35:48 +00:00
Francisco Javier Jurado Moreno
66a28e7e69 Add parseReadableSize function 2024-06-03 10:35:01 +02:00
Amos Bird
6fe266bc09
Fix build 2024-06-03 16:06:40 +08:00
vdimir
4e0c806ca1
Fix empty tuple vector functions 2024-06-03 16:06:39 +08:00
Amos Bird
162a6c5685
Update src/Columns/ColumnTuple.cpp
Co-authored-by: vdimir <vdimir@clickhouse.com>
2024-06-03 16:05:45 +08:00
Amos Bird
d5835b6eea
Update src/Columns/ColumnTuple.h
Co-authored-by: vdimir <vdimir@clickhouse.com>
2024-06-03 16:05:45 +08:00
Amos Bird
f397853577
Fix more tests 2024-06-03 16:05:44 +08:00
Amos Bird
1826159c37
Fix tests 2024-06-03 16:05:44 +08:00
Amos Bird
7bec19a82d
Address reviews 2024-06-03 16:05:44 +08:00
Amos Bird
b2d6610d5f
Support empty tuple. 2024-06-03 16:05:42 +08:00
shuai-xu
d0733b4886 add comments 2024-06-03 15:02:21 +08:00
Alexey Milovidov
f6125d2d9f
Merge pull request #64532 from azat/file-use-max_read_buffer_size
Use max_read_buffer_size for file descriptors as well in file()
2024-06-02 20:13:18 +02:00
alesapin
1d1eafc365
Update src/Storages/MergeTree/MergeTreeDataPartTTLInfo.cpp 2024-06-02 13:52:23 +02:00
Alexey Milovidov
a838adc0bf
Merge pull request #64714 from ClickHouse/s3jank
Check for missing Upload ID in CreateMultipartUpload reply
2024-06-02 01:12:00 +02:00