Commit Graph

46359 Commits

Author SHA1 Message Date
Nikolai Kochetov
6649328db8
Merge pull request #54122 from ClickHouse/fix-delayed-source-with-totals-2
Fix rows_before_limit_at_least for DelayedSource.
2023-08-31 19:51:24 +02:00
Nikita Mikhaylov
c08fc52812
Merge pull request #54067 from ClickHouse/vdimir/is_not_distinct_from_operator
Parse IS NOT DISTINCT and <=> operators
2023-08-31 17:14:42 +02:00
Igor Nikonov
c3caead859
Merge pull request #52688 from Algunenano/better_zk_retries_on_insert
Improve insert retries on keeper session expiration
2023-08-31 17:00:02 +02:00
pufit
1bc6b40a12
Merge pull request #35102 from tonickkozlov/bloom-filter-index/deduplicate
Prune bloom filter indices based on data cardinality
2023-08-31 10:04:19 -04:00
Anton Kozlov
af21620ab5
Update src/Storages/MergeTree/MergeTreeIndexGranuleBloomFilter.h
Co-authored-by: pufit <pufit@yandex.ru>
2023-08-31 14:06:21 +01:00
Anton Kozlov
d3123da824
Update src/Storages/MergeTree/MergeTreeIndexAggregatorBloomFilter.cpp
Co-authored-by: pufit <pufit@yandex.ru>
2023-08-31 14:05:57 +01:00
Anton Kozlov
3f6ef6b5d9
Update src/Storages/MergeTree/MergeTreeIndexGranuleBloomFilter.h
Co-authored-by: pufit <pufit@yandex.ru>
2023-08-31 14:05:41 +01:00
Anton Kozlov
e6895688d7
Update src/Storages/MergeTree/MergeTreeIndexAggregatorBloomFilter.cpp
Co-authored-by: pufit <pufit@yandex.ru>
2023-08-31 14:05:28 +01:00
Robert Schulze
77327c69ed
Merge pull request #53893 from ClibMouse/feature/make-it-old-school
Use iterators instead of std::ranges
2023-08-31 14:55:45 +02:00
Nikolai Kochetov
52a7206002 Fix rows_before_limit_at_least for DelayedSource. 2023-08-31 12:53:58 +00:00
Raúl Marín
4703c463aa Merge remote-tracking branch 'blessed/master' into better_zk_retries_on_insert 2023-08-31 14:37:02 +02:00
Raúl Marín
0a5f1a643a Merge remote-tracking branch 'blessed/master' into filesystem_prefetch_max_memory_usage 2023-08-31 14:36:10 +02:00
Vitaly Baranov
90b174d3dc
Merge pull request #53326 from azat/backups/base-backup-credentials
Add ability to override credentials for accessing base backup in S3
2023-08-31 14:24:43 +02:00
Robert Schulze
97d960ba1d
Merge pull request #53818 from arenadata/ADQM-1070
Add new hide_in_preprocessed attribute in configuration file
2023-08-31 13:00:16 +02:00
Alexey Gerasimchuck
3a212217a3 Implemented globs to select * from '<file>' 2023-08-31 04:20:44 +00:00
ltrk2
0b2a32b0ba Use iterators instead of std::ranges
For loops for fun factor
2023-08-30 16:36:02 -07:00
Anton Popov
0387556a34
Merge pull request #53914 from Chen768959/fix-53543-2
'from' is supported as a Expression and fix #53543
2023-08-30 22:25:08 +02:00
Antonio Andelic
0148e15aee
Merge pull request #53880 from ClickHouse/archive-improvements-2
Improve schema inference for archives
2023-08-30 21:11:34 +02:00
Azat Khuzhin
d0397acafc Add ability to override credentials for accessing base backup in S3
Sometimes credentials with which the backup had been done are inactive
already, and ClickHouse will not be able to read the metadata file to
continue and fail.

Add a setting to allow ignoring credential from base_backup -
`use_same_s3_credentials_for_base_backup` (default to true).

And the same for RESTORE.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-08-30 20:16:22 +02:00
Alexander Tokmakov
5cfd1c6d63
Merge pull request #54066 from kssenii/fix-named-collections-access-type-change
Fix named_collection_admin alias
2023-08-30 18:34:03 +02:00
robot-ch-test-poll4
aa3b687d4a
Merge pull request #54064 from kssenii/fix-logical-error
Fix after #52943
2023-08-30 17:06:25 +02:00
Roman Vasin
92b89e8b9e Use NodePtr instead of Node * 2023-08-30 13:50:10 +00:00
vdimir
dd094d1f55
Parse IS NOT DISTINCT and <=> operators 2023-08-30 13:12:43 +00:00
Alexander Tokmakov
4d70624ca3
Merge pull request #53907 from arenadata/ADQM-1126
Added validate_tcp_client_information server setting
2023-08-30 15:10:13 +02:00
kssenii
185e3819ac Fix 2023-08-30 13:41:18 +02:00
kssenii
662f22aed0 Fix 2023-08-30 13:31:54 +02:00
Alexander Tokmakov
83c5e2fba6
Revert "Fix bug on mutations with subcolumns of type JSON in predicates of UPDATE and DELETE queries." 2023-08-30 12:56:17 +02:00
Jiebin Sun
7c529e5691
Optimize the merge if all hashSets are singleLevel in UniqExactSet (#52973)
* Optimize the merge if all hashSets are singleLevel

In PR(https://github.com/ClickHouse/ClickHouse/pull/50748), it has added new phase
`parallelizeMergePrepare` before merge if all the hashSets are not all singleLevel
or not all twoLevel. Then it will convert all the singleLevelSet to twoLevelSet in
parallel, which will increase the CPU utilization and QPS.

But if all the hashtables are singleLevel, it could also benefit from the
`parallelizeMergePrepare` optimization in most cases if the hashtable size are not
too small. By tuning the Query `SELECT COUNT(DISTINCT SearchPhase) FROM hits_v1`
in different threads, we have got the mild threshold 6,000.

Test patch with the Query 'SELECT COUNT(DISTINCT Title) FROM hits_v1' on 2x80 vCPUs
server. If the threads are less than 48, the hashSets are all twoLevel or mixed by
singleLevel and twoLevel. If the threads are over 56, all the hashSets are singleLevel.
And the QPS has got at most 2.35x performance gain.

Threads	Opt/Base
8	100.0%
16	99.4%
24	110.3%
32	99.9%
40	99.3%
48	99.8%
56	183.0%
64	234.7%
72	233.1%
80	229.9%
88	224.5%
96	229.6%
104	235.1%
112	229.5%
120	229.1%
128	217.8%
136	222.9%
144	217.8%
152	204.3%
160	203.2%

Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>

* Add the comment and explanation for PR#52973

Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>

---------

Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>
2023-08-30 11:26:16 +02:00
Antonio Andelic
f406019413 Apply PR comments 2023-08-30 09:26:01 +00:00
Raúl Marín
4f9ddcab2b Correct doc for filesystem_prefetch_max_memory_usage 2023-08-30 10:27:29 +02:00
Antonio Andelic
ddb58217d4 Merge branch 'master' into archive-improvements-2 2023-08-30 07:43:25 +00:00
Antonio Andelic
36fb7cfbd1
Merge pull request #54012 from ClickHouse/refactor-async-insert-with-dedup
Refactor logic around async insert with deduplication
2023-08-30 09:37:55 +02:00
Alexey Gerasimchuck
f7d1041e61 minor improvement 2023-08-30 06:14:39 +00:00
Alexey Gerasimchuck
be2f80cc1c minor corrections 2023-08-29 23:59:36 +00:00
Alexey Gerasimchuck
a1687e618b backward compatibility changes + fixes 2023-08-29 23:50:41 +00:00
Nikita Mikhaylov
97efd14e90
Merge pull request #54009 from ClickHouse/change-istorage-interface
Change IStorage interface by random walk, no goal in particular
2023-08-29 22:22:53 +02:00
Alexey Milovidov
9b74939110
Merge pull request #53742 from aiven-sal/aiven-sal/fix_53187
transform: correctly handle default column with multiple rows
2023-08-29 21:57:59 +03:00
Sergei Trifonov
802579f3f1
Merge pull request #49618 from ClickHouse/concurrency-control-controllable
Make concurrency control controllable
2023-08-29 19:44:51 +02:00
Antonio Andelic
e96c665be7 Refactor logic around async insert with dedup 2023-08-29 14:48:43 +00:00
Alexander Tokmakov
17f3754193
Merge pull request #53851 from ClickHouse/distributed_no_flush_on_shutdown
Follow-up to #53501
2023-08-29 16:34:22 +02:00
Nikita Mikhaylov
96cabcae3a Change interface 2023-08-29 16:26:48 +02:00
robot-clickhouse-ci-1
f5c0890b32
Merge pull request #53895 from ClickHouse/vdimir/write_buffer_to_file_segment_dtor
Finalize file descriptor in ~WriteBufferToFileSegment
2023-08-29 15:15:44 +02:00
Anton Popov
6ce4a82a04
Merge pull request #53677 from VanDarkholme7/mutations_subcolumns
Fix bug on mutations with subcolumns of type JSON in predicates of UPDATE and DELETE queries.
2023-08-29 15:08:00 +02:00
Kseniia Sumarokova
463a197da4
Merge pull request #53847 from kssenii/fix-segfault-in-pg
Fix possible segfault while using PostgreSQL engine
2023-08-29 14:45:46 +02:00
Antonio Andelic
a0dd350e5e Fix assert 2023-08-29 09:59:16 +00:00
Chen768959
a2d451d6e6
domainRFC support ipv6(square brackets) and fix #53179 (#53506) 2023-08-29 11:42:59 +02:00
Alexey Gerasimchuck
de1ed97876 disabled validate_tcp_client_information 2023-08-29 08:59:49 +00:00
János Benjamin Antal
a1a45ee905
Merge pull request #53766 from ilejn/exceptions_kafka_consumers
system.kafka_consumers exception info improvements
2023-08-29 10:22:26 +02:00
Antonio Andelic
8708ebd7fb Correctly check files 2023-08-29 07:40:08 +00:00
chen768959
4db7b866ad If there is a comma after 'from' then the first one was a name of a column 2023-08-29 15:20:23 +08:00