Commit Graph

65790 Commits

Author SHA1 Message Date
Azat Khuzhin
24c8968c80 Add *.log/*.stderr/*.stdout into gitignore 2021-06-08 09:14:47 +03:00
Azat Khuzhin
5c7573d98f tests: disable suggestions for expect tests that does not requires it
Will fix possible issues in CI [1].

    2021-06-07 03:42:56 01520_client_print_query_id:                                            [ FAIL ] 8.24 sec. - return code 1
    2021-06-07 03:42:56 , result:

And in server logs:

    2021.06.07 03:42:48.732289 [ 18471 ] {7df001e8-f9bb-488f-9fe1-6dc538f24808} <Debug> executeQuery: (from [::1]:45680, using production parser) (comment: /usr/share/clickhouse-test/queries/0_stateless/01520_client_print_query_id.expect) CREATE DATABASE test
    ...
    2021.06.07 03:42:52.048064 [ 18703 ] {8526892a-f99a-4949-9f7d-3c8e82969439} <Debug> executeQuery: (from [::1]:45702, using production parser) SELECT DISTINCT arrayJoin(extractAll(name, '[\\w_]{2,}')) AS res FROM (SELECT name FROM system.functions UNION ALL SELECT name FROM system.table_engines UNION ALL SELECT name FROM system.formats UNION ALL SELECT name FROM system.table_functions UNION ALL SELECT name FROM system.data_type_families UNION ALL SELECT name FROM system.merge_tree_settings UNION ALL SELECT name FROM system.settings UNION ALL SELECT cluster FROM system.clusters UNION ALL SELECT macro FROM system.macros UNION ALL SELECT policy_name FROM system.storage_policies UNION ALL SELECT concat(func.name, comb.name) FROM system.functions AS func CROSS JOIN system.aggregate_function_combinators AS comb WHERE is_aggregate UNION ALL SELECT name FROM system.databases LIMIT 10000 UNION ALL SELECT DISTINCT name FROM system.tables LIMIT 10000 UNION ALL SELECT DISTINCT name FROM system.dictionaries LIMIT 10000 UNION ALL SELECT DISTINCT name FROM system.columns LIMIT 10000) WHERE notEmpty(res)
    ...
    2021.06.07 03:42:54.523976 [ 5575 ] {d97df847-0feb-4e8d-92bd-3236e1f7f711} <Debug> executeQuery: (from [::1]:45710, using production parser) (comment: /usr/share/clickhouse-test/queries/0_stateless/01520_client_print_query_id.expect) DROP DATABASE test_3bce13
    ...
    2021.06.07 03:42:54.722391 [ 18703 ] {8526892a-f99a-4949-9f7d-3c8e82969439} <Error> executeQuery: Code: 210, e.displayText() = DB::NetException: I/O error: Broken pipe, while writing to socket ([::1]:45702) (version 21.7.1.7071) (from [::1]:45702) (in query: SELECT DISTINCT arrayJoin(extractAll(name, '[\\w_]{2,}')) AS res FROM (SELECT name FROM system.functions UNION ALL SELECT name FROM system.table_engines UNION ALL SELECT name FROM system.formats UNION ALL SELECT name FROM system.table_functions UNION ALL SELECT name FROM system.data_type_families UNION ALL SELECT name FROM system.merge_tree_settings UNION ALL SELECT name FROM system.settings UNION ALL SELECT cluster FROM system.clusters UNION ALL SELECT macro FROM system.macros UNION ALL SELECT policy_name FROM system.storage_policies UNION ALL SELECT concat(func.name, comb.name) FROM system.functions AS func CROSS JOIN system.aggregate_function_combinators AS comb WHERE is_aggregate UNION ALL SELECT name FROM system.databases LIMIT 10000 UNION ALL SELECT DISTINCT name FROM system.tables LIMIT 10000 UNION ALL SELECT DISTINCT name FROM system.dictionaries LIMIT 10000 UNION ALL SELECT DISTINCT name FROM system.columns LIMIT 10000) WHERE notEmpty(res)), Stack trace (when copying this message, always include the lines below):

  [1]: https://clickhouse-test-reports.s3.yandex.net/24069/263c06137cda16213c14ca60a89cfdd7fb511c81/functional_stateless_tests_(thread).html
2021-06-08 09:12:24 +03:00
Azat Khuzhin
2109980284 Respect max_distributed_connections for insert_distributed_sync
Otherwise for huge clusters and sync insert it may run out of
max_thread_pool_size (default 10K).
2021-06-08 09:11:44 +03:00
Nikita Mikhaylov
22864aff23 delete files 2021-06-08 01:52:30 +00:00
Nikita Mikhaylov
c0238e839a another try to fix tests 2021-06-08 01:50:43 +00:00
alexey-milovidov
deeaa98af5
Merge pull request #24069 from azat/log-ignore-errors
[RFC] Suppress exceptions from logger code
2021-06-08 03:59:06 +03:00
mergify[bot]
b1deed7659
Merge branch 'master' into config-processor-xml-default 2021-06-08 00:54:17 +00:00
alexey-milovidov
d72526d6c0
Merge pull request #25046 from DenKoren/master
Add exit instruction to init script after service status check
2021-06-08 03:47:11 +03:00
Alexey Milovidov
14ef6f4039 Review fixes 2021-06-08 03:11:36 +03:00
Alexey Milovidov
d6513b22cb Merge remote-tracking branch 'origin/master' into fix-wrong-code-in-aggregate-functions 2021-06-08 03:08:03 +03:00
Denis Zhuravlev
857551178c test for attach partition from. #17500 2021-06-07 18:34:02 -03:00
Denis Zhuravlev
944940d6fb test for attach partition from. #17500 2021-06-07 18:30:03 -03:00
alesapin
5284f192ee Ban loop aliases in table definitions 2021-06-07 23:59:38 +03:00
Maksim Kita
23bf4cf09f
Merge pull request #25034 from sdk2/patch-1
fix jemalloc build on OS_DARWIN
2021-06-07 21:08:28 +03:00
Ivan
71f1a101c1
More pytest fixes (#23538) 2021-06-07 20:29:19 +03:00
tavplubix
e01850c02b
Merge pull request #25053 from ClickHouse/tavplubix-patch-2
Fix incorrect queries in documentation
2021-06-07 19:07:06 +03:00
Amos Bird
840895509e
Fix using aggregate projection when group by without key 2021-06-07 22:44:42 +08:00
Ivan Lezhankin
0e9ce8c23a Fix Disks/ya.make 2021-06-07 17:22:24 +03:00
tavplubix
634730f4dc
Update s3.md 2021-06-07 17:08:20 +03:00
Korenevskiy Denis
1931406ec4 Mute stdout and stderr for both branches of cron task's if 2021-06-07 16:14:04 +03:00
Korenevskiy Denis
f2ea7d9985 Add exit instruction to init script after service status check 2021-06-07 15:46:49 +03:00
Ilya Yatsishin
c453a84944
Merge pull request #24973 from qoega/cleanup-iptables-on-session-start 2021-06-07 15:43:13 +03:00
tavplubix
805171c41f
Merge pull request #24546 from damozhaeva/dmozhaeva-DOCSUP-8448-russian
DOCSUP-8448: [CLICKHOUSEDOCS] Edit and translate to Russian
2021-06-07 14:45:11 +03:00
Nikita Mikhaylov
6f5997b0aa fix tests 2021-06-07 10:49:01 +00:00
damozhaeva
802f48ea86
Update docs/ru/sql-reference/functions/date-time-functions.md
Co-authored-by: tavplubix <tavplubix@gmail.com>
2021-06-07 13:42:18 +03:00
Kruglov Pavel
1cf4eab2d0
Merge pull request #25038 from Avogar/fix-reload-model-doc
Remove database before model name in docs
2021-06-07 13:24:37 +03:00
Pavel Kruglov
0a70304085 Remove database before model name in docs 2021-06-07 13:10:51 +03:00
Nikita Mikhaylov
652de7c9b0
Update test.py 2021-06-07 13:06:41 +03:00
alesapin
86759753e0
Merge pull request #24878 from ClickHouse/blinkov-patch-22
fix markdown at window functions page
2021-06-07 12:54:29 +03:00
Nikolai Kochetov
0043434d5c
Merge pull request #24894 from amosbird/notinpartitionprune
Allow not in be used in partition pruning
2021-06-07 12:42:48 +03:00
alesapin
2ea9d998e8
Merge pull request #24960 from nvartolomei/nv/queue-entry-wait-dead-code
Delete support for waiting on queue- entries, is this dead code?
2021-06-07 12:40:34 +03:00
Nikolai Kochetov
cbd46280eb
Update Set.cpp 2021-06-07 12:36:34 +03:00
alesapin
fba2d66042 Disable storage_kerberized_hdfs test 2021-06-07 12:25:13 +03:00
Maksim Kita
719b419104
Merge pull request #25031 from kitaisreal/fix-disks-ya-make
Disks fix ya.make
2021-06-07 12:01:39 +03:00
alesapin
170c49db69
Merge pull request #24961 from ClickHouse/more_general_check_in_queue
Trying to fix 'Tagging already tagged part'
2021-06-07 11:52:05 +03:00
sdk2
717f7ed01b
Update contrib/jemalloc-cmake/CMakeLists.txt 2021-06-07 16:38:24 +08:00
Kruglov Pavel
78f1ecb71f
Merge pull request #24890 from sevirov/sevirov-DOCSUP-8709-document_reload_model_and_reload_models_system_queries
DOCSUP-8709: Document RELOAD MODEL and RELOAD MODELS system queries
2021-06-07 11:12:12 +03:00
Kruglov Pavel
ee683ea90e
Merge pull request #24729 from vdimir/segment-lenght-sum-fixes
Minor fixes in AggregateFunctionSegmentLengthSumData
2021-06-07 11:01:29 +03:00
Maksim Kita
16b3355ac1 Disks fix ya.make 2021-06-07 10:05:05 +03:00
Vladimir Chebotarev
ad816fde7b
Fix. 2021-06-07 09:56:15 +03:00
Vladimir Chebotarev
e21f76b137
Fixed unit tests accoording to the fix. 2021-06-07 09:54:05 +03:00
Azat Khuzhin
c65ae8ac31 Do not check writeRetry errors in OwnSplitChannel
Should fix PVS warning:

  "There are identical sub-expressions '!writeRetry(2, "\n")' to the left and to the right of the '||' operator."
2021-06-07 09:40:29 +03:00
Azat Khuzhin
38c7056ecc Rewrite 01594_too_low_memory_limits
After #24483 had been merged the only place where the allocation may
fail is the insert into PODArray in DB::OwnSplitChannel::log, but this
MR ignores the errors in this function, so to check new behaviour
separate server is required.
2021-06-07 09:38:15 +03:00
Azat Khuzhin
ac1ff225a3 Revert "Cleanup 01594_too_low_memory_limits (by using clientError)"
--testmode can't be used since this disables logging while the
failed allocation comes from:

    2021.06.04 09:54:49.576479 [ 31070 ] {} <Error> ServerErrorHandler: Code: 241, e.displayText() = DB::Exception: Memory limit (for query) exceeded: would use 2.01 MiB (attempt to allocate chunk of 4096 bytes), maximum: 1.00 B, Stack trace (when copying this message, always include the lines below):

    0. /src/ch/clickhouse/.cmake/../contrib/libcxx/include/exception:133: std::exception::capture() @ 0xe2d88 in /src/ch/clickhouse/.cmake/programs/server/libclickhouse-server-libd.so
    1. /src/ch/clickhouse/.cmake/../contrib/libcxx/include/exception:111: std::exception::exception() @ 0x1e9b92 in /src/ch/clickhouse/.cmake/contrib/poco-cmake/Foundation/lib_poco_foundationd.so
    2. /src/ch/clickhouse/.cmake/../contrib/poco/Foundation/src/Exception.cpp:28: Poco::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0x1dd943 in /src/ch/clickhouse/.cmake/contrib/poco-cmake/Foundation/lib_poco_foundationd.so
    3. /src/ch/clickhouse/.cmake/../src/Common/Exception.cpp:59: DB::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, bool) @ 0x2aaffd in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    4. /src/ch/clickhouse/.cmake/../src/Common/Exception.h:40: DB::Exception::Exception<char const*, char const*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, long&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*&&, char const*&&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&&, long&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&&) @ 0x2ebef0 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    5. /src/ch/clickhouse/.cmake/../src/Common/MemoryTracker.cpp:226: MemoryTracker::allocImpl(long, bool) @ 0x2eac82 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    6. /src/ch/clickhouse/.cmake/../src/Common/MemoryTracker.cpp:0: MemoryTracker::allocImpl(long, bool) @ 0x2eae3e in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    7. /src/ch/clickhouse/.cmake/../src/Common/CurrentMemoryTracker.cpp:47: CurrentMemoryTracker::(anonymous namespace)::allocImpl(long, bool) @ 0x27b621 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    8. /src/ch/clickhouse/.cmake/../src/Common/CurrentMemoryTracker.cpp:61: CurrentMemoryTracker::alloc(long) @ 0x27b541 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    9. /src/ch/clickhouse/.cmake/../src/Common/Allocator.h:96: Allocator<false, false>::alloc(unsigned long, unsigned long) @ 0x274b71 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    10. /src/ch/clickhouse/.cmake/../src/Common/PODArray.h:120: void DB::PODArrayBase<4ul, 4096ul, Allocator<false, false>, 15ul, 16ul>::alloc<>(unsigned long) @ 0x305af3 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    11. /src/ch/clickhouse/.cmake/../src/Common/PODArray.h:146: void DB::PODArrayBase<4ul, 4096ul, Allocator<false, false>, 15ul, 16ul>::realloc<>(unsigned long) @ 0x305cbb in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    12. /src/ch/clickhouse/.cmake/../src/Common/PODArray.h:182: void DB::PODArrayBase<4ul, 4096ul, Allocator<false, false>, 15ul, 16ul>::reserveForNextSize<>() @ 0x306010 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    13. /src/ch/clickhouse/.cmake/../src/Common/PODArray.h:0: void DB::PODArray<unsigned int, 4096ul, Allocator<false, false>, 15ul, 16ul>::push_back<unsigned int>(unsigned int&&) @ 0x5423a6a in /src/ch/clickhouse/.cmake/src/AggregateFunctions/libclickhouse_aggregate_functionsd.so
    14. /src/ch/clickhouse/.cmake/../src/Columns/ColumnVector.h:280: DB::ColumnVector<unsigned int>::insert(DB::Field const&) @ 0x3c6422 in /src/ch/clickhouse/.cmake/src/libclickhouse_columnsd.so
    15. /src/ch/clickhouse/.cmake/../base/loggers/OwnSplitChannel.cpp:60: DB::OwnSplitChannel::logSplit(Poco::Message const&) @ 0xa2833 in /src/ch/clickhouse/.cmake/base/loggers/libloggersd.so
    16. /src/ch/clickhouse/.cmake/../base/loggers/OwnSplitChannel.cpp:35: DB::OwnSplitChannel::log(Poco::Message const&) @ 0xa2588 in /src/ch/clickhouse/.cmake/base/loggers/libloggersd.so

This reverts commit 0cecc754709cc774c90269a1dc8653eac8725341.
2021-06-07 09:38:15 +03:00
Azat Khuzhin
3d9218dbfa Use writeRetry in case of exception during writing to the log 2021-06-07 09:38:15 +03:00
Azat Khuzhin
8ec874dc33 Add writeRetry helper 2021-06-07 09:38:15 +03:00
Azat Khuzhin
b9c869871b Block memory tracking during catching exceptions in OwnSplitChannel 2021-06-07 09:38:15 +03:00
Azat Khuzhin
d5767da5fd Cleanup 01594_too_low_memory_limits (by using clientError) 2021-06-07 09:38:15 +03:00
Azat Khuzhin
0d34cb655c Disable 01594_too_low_memory_limits under sanitizers 2021-06-07 09:38:15 +03:00
Azat Khuzhin
89a4d886bf Suppress exceptions from logger code
Some code does not expect from the logger code to throw, and this can
lead to the problems like:
- marking distributed batch as broken (in
  StorageDistributedDirectoryMonitor)
- some MergeTree code may also be affected.

So instead of throwing the exception, it will be logged to the stderr
(if it is possible).
2021-06-07 09:38:15 +03:00