Commit Graph

74753 Commits

Author SHA1 Message Date
Azat Khuzhin
8cc45bea7b Avoid accounting memory from another mutation/merge
Before this path it was possible that one merge/mutation may account
memory from another, due to ThreadStatus::untracked_memory.

And this cause flakiness of 01200_mutations_memory_consumption.
2021-10-15 01:43:28 +03:00
Azat Khuzhin
fd38cbb0df Fix memory tracking for merges and mutations (by destroying earlier)
It fixes only some tiny allocations, and so it should not affect any
huge mutations/merges.

And plus, this should not be a real fix, since peak_memory_usage is
obtained before even destrying this objects, and destroing objects will
unlikely update peak memory usage (although it is possible).

v0: do this in dtors
v2: do this earlier
2021-10-15 01:43:27 +03:00
Azat Khuzhin
e4b39ca99c Remove unused Block member from MutateTask
v0: Fix excessive memory usage in MutateTask
    This is relevant only for 01200_mutations_memory_consumption test, since
    this is just a block.
v2: just remove unused Block member, since other part had been fixed in #29768
2021-10-15 01:43:27 +03:00
Azat Khuzhin
ae980fcd62 Move 01200_mutations_memory_consumption out from bugs 2021-10-15 01:43:27 +03:00
Azat Khuzhin
5d5f94f456 Mark 01200_mutations_memory_consumption as long and allow run in fasttest 2021-10-15 01:43:27 +03:00
Azat Khuzhin
a063097fdf Fix INSERT SELECT incorrectly fills MATERIALIZED column based of Nullable column
Required columns of the default expression should not be converted to NULL,
since this map value to default and MATERIALIZED values will not work.

Consider the following structure:
- A Nullable(Int64)
- X Int64 materialized coalesce(A, -1)

With recursive_null_as_default=true you will get:

    _CAST(coalesce(A, -1), 'Int64') AS X, NULL AS A

And this will ignore default expression.

Fixes: #23524 (Cc: @kssenii)
Fixes: #29729 (Cc: @tavplubix)
Backport: 21.7+
2021-10-15 01:36:09 +03:00
alexey-milovidov
bc1662b9fe
Merge pull request #29946 from azat/log-fix-data-race
Fix data-race between LogSink::writeMarks() and LogSource in StorageLog
2021-10-15 01:30:58 +03:00
alexey-milovidov
8d694cbcdc
Merge pull request #29959 from azat/log-data-race-file-checker-fix
Fix possible data-race between FileChecker and StorageLog/StorageStripeLog
2021-10-15 01:30:23 +03:00
alexey-milovidov
9a57fbc9e8
Merge pull request #30150 from azat/test_MemoryTracking-flap
Make test_MemoryTracking::test_http not flaky
2021-10-15 01:28:59 +03:00
karnevil13
8ec43b7c70 fixed type-conversion-functions en-ru 2021-10-15 00:56:21 +03:00
Azat Khuzhin
bb8105951f Disable fsync_metadata on CI
Sometimes we see that pretty simple queries like CREATE DATABASE can
take > 30 seconds, let's try to disable fsync.

CI: https://clickhouse-test-reports.s3.yandex.net/30065/e5bc573250d3d6938937739b05d6f8cf618722db/functional_stateless_tests_(address).html#fail1
CI: https://clickhouse-test-reports.s3.yandex.net/30065/e5bc573250d3d6938937739b05d6f8cf618722db/functional_stateless_tests_(release).html#fail1
2021-10-15 00:53:34 +03:00
Maksim Kita
5b5ba5fbc8
Merge pull request #30179 from kitaisreal/clickhouse-local-support-sql-user-defined-functions
Support SQL user defined functions for clickhouse-local
2021-10-14 23:14:18 +03:00
Maksim Kita
a51ab78c68 Fixed style check 2021-10-14 23:13:41 +03:00
Maksim Kita
888c619472
Merge pull request #30145 from kitaisreal/functions-json-avoid-copying-object-element-during-iteration
FunctionsJSON avoid copying object element during iteration
2021-10-14 23:11:16 +03:00
Maksim Kita
5568461acf FunctionsJSON move to cpp file 2021-10-14 23:10:53 +03:00
Artur Filatenkov
74e3978110 commit assert to fix build 2021-10-14 22:55:17 +03:00
Maksim Kita
913a8f3640 Fixed style check 2021-10-14 22:15:21 +03:00
Maksim Kita
83879415b4 Fixed tests 2021-10-14 22:12:06 +03:00
Nikolai Kochetov
6b251ddd97
Merge pull request #30193 from ClickHouse/try-to-fix-01288_shard_max_network_bandwidth
Smaller smoothing window in throttler.
2021-10-14 22:10:37 +03:00
Nikolai Kochetov
700504e7d6
Update Internals.cpp 2021-10-14 22:09:44 +03:00
Nikolai Kochetov
aa56fd1592 Fix style. 2021-10-14 21:29:02 +03:00
Nikolai Kochetov
e9cab3aaad Smaller smoothing window in throttler. 2021-10-14 21:20:19 +03:00
Azat Khuzhin
d030e08d05 Make test_MemoryTracking::test_http not flaky
By comparing only megabytes in the memory changes, instead of bytes as
before, since it may be tricky at least due to max_untracked_memory and
how thread pool handle it.

It should be safe, since originally it was written in #16121 which fixes
issue #15932, which has ~4MB consumption of memory per request.
2021-10-14 21:06:39 +03:00
Azat Khuzhin
56ab0e31e6 Add description for test_MemoryTracking 2021-10-14 21:06:22 +03:00
Cody Baker
4dd1a4fe5c Update release date 2021-10-14 10:41:41 -06:00
Cody Baker
7b1eb7cb54 Add 21-10 release blog post 2021-10-14 10:16:10 -06:00
Dmitry Novik
2f6d771d94 Remove trailing whitespace 2021-10-14 18:15:30 +03:00
mergify[bot]
92dd528c78
Merge branch 'master' into remove_trash 2021-10-14 14:14:07 +00:00
Maksim Kita
04e07ed86d FunctionsJSON avoid copying object element during iteration 2021-10-14 16:37:52 +03:00
Maksim Kita
c1f04452de AddDefaultDatabaseVisitor support dictGet 2021-10-14 16:31:32 +03:00
tavplubix
746964af88
Merge pull request #30084 from vitlibar/fix-external-loader-without-extra-mutex
Fix ExternalLoader without additional mutex.
2021-10-14 16:18:17 +03:00
Maksim Kita
fbaa9e7be4 Support SQL user defined functions for clickhouse-local 2021-10-14 16:15:39 +03:00
Denny Crane
ddf6ca716c
Doc. fix optimize_skip_unused_shards description (#30114)
* fix optimize_skip_unused_shards description

* Update settings.md
2021-10-14 15:47:43 +03:00
Maksim Kita
4ed28d8e52
Merge pull request #29981 from kitaisreal/added-function-tokens
Added function tokens
2021-10-14 15:36:06 +03:00
Anton Popov
6c1da023f7
Merge pull request #30142 from kitaisreal/polygon-dictionary-support-read
Polygon dictionary support read
2021-10-14 15:03:10 +03:00
Anton Popov
5802037f1e
Merge pull request #29916 from ucasfl/format-alter
Format improvement of AlterQuery
2021-10-14 14:30:08 +03:00
Denny Crane
6a0ee3d23e
test for rename atomic hanging (#30080)
* test for rename atomic hanging

* test for rename atomic hanging

* Update 02096_rename_atomic_hang.sql

* Update 02096_rename_atomic_hang.sql

Co-authored-by: tavplubix <tavplubix@gmail.com>
2021-10-14 13:31:34 +03:00
Nikolai Kochetov
ab28c6c855 Remove BlockInputStream interfaces. 2021-10-14 13:25:43 +03:00
Maksim Kita
8ed4e73705
Merge pull request #30000 from ClickHouse/profile-snapshot
Make read of Counters snapshot non-atomic
2021-10-14 13:22:44 +03:00
Maksim Kita
96bee8d241 Fixed test 2021-10-14 13:20:52 +03:00
Maksim Kita
b854726228 Updated documentation 2021-10-14 13:19:53 +03:00
Maksim Kita
562c8984a4 Added documentation 2021-10-14 13:15:45 +03:00
Maksim Kita
6c6dd7a0c8
Merge pull request #30056 from orloffv/orloffv.JSONExtractKeys
Add JSONExtractKeys function
2021-10-14 12:50:19 +03:00
alesapin
01ac2fea79
Update 00167_read_bytes_from_fs.sql 2021-10-14 12:44:41 +03:00
Nikolai Kochetov
3d3e143c29
Merge pull request #30001 from ClickHouse/remove-streams-from-formats
Remove streams from formats.
2021-10-14 12:39:07 +03:00
Maksim Kita
f589084a94
Merge pull request #29899 from Enmk/Governance/dictionary_comment
Governance/dictionary comment
2021-10-14 12:35:10 +03:00
Maksim Kita
baf75065e3
Update 02024_create_dictionary_with_comment.sql 2021-10-14 12:34:52 +03:00
Maksim Kita
8d544a55b7
Merge pull request #30075 from kitaisreal/sql-user-defined-functions-fix-alias
SQL user defined functions fix alias
2021-10-14 11:15:32 +03:00
Maksim Kita
828b19fd51
Merge pull request #29801 from kitaisreal/refactor-concurrent-bounded-queue
Refactor ConcurrentBoundedQueue
2021-10-14 11:09:42 +03:00
alesapin
386d47cb22 Fix typo 2021-10-14 10:49:29 +03:00