Commit Graph

50248 Commits

Author SHA1 Message Date
alexey-milovidov
c579611420
Merge pull request #16306 from azat/Set-Join-total-rows-bytes
Add total_rows/total_bytes support for Set/Join
2020-10-24 07:26:32 +03:00
Alexey Milovidov
74558a4e27 Better diagnostics when client has dropped connection 2020-10-24 06:41:47 +03:00
alexey-milovidov
6037982343
Merge pull request #16284 from ClickHouse/primary_key_without_order_by
Add ability to specify PRIMARY KEY without ORDER BY
2020-10-24 06:05:04 +03:00
zhang2014
e354108e53 ISSUES-15883 trigger CI 2020-10-24 10:54:02 +08:00
sundy-li
21315127a0 remove unused codes in AggregateFunctionGroupBitmapData 2020-10-24 10:05:54 +08:00
Azat Khuzhin
96da5f6534 Disable syncing MemoryTracking with RSS for test_MemoryTracking 2020-10-24 02:33:16 +03:00
Azat Khuzhin
6e5b04fad8 Make 01540_MemoryTracking integration
01540_MemoryTracking is failing on CI for the following reasons:
- log_queries (fixed, by adding log_queries=0)
- profilers (fixed)
- but what can't be fixed is metric_log and so on, so we need separate
  instance with separate configuration (sigh).
2020-10-24 02:27:29 +03:00
MyroTk
a972a2ca50 Merge branch 'testflows_RBAC_tests' of https://github.com/MyroTk/ClickHouse into testflows_RBAC_tests 2020-10-24 01:02:17 +02:00
MyroTk
6b64ac8536 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into testflows_RBAC_tests 2020-10-24 01:00:07 +02:00
MyroTk
d42a049d9d small fixes 2020-10-24 00:59:38 +02:00
alexey-milovidov
d350d864e6
Merge pull request #16297 from alex-karo/patch-2
Fix broken link in replication docs
2020-10-24 01:20:26 +03:00
alexey-milovidov
91dc8d4cb3
Merge pull request #16264 from amosbird/ssmfix
Fix TwoLevelStringHashTable bug
2020-10-24 01:00:27 +03:00
Alexey Milovidov
13b8dce792 Update contributors 2020-10-24 00:26:22 +03:00
tavplubix
790950ea56
Merge pull request #15934 from ClickHouse/ddl_queries_fixes
Fixes for DDL queries
2020-10-23 23:52:13 +03:00
nikitamikhaylov
a949293f95 better 2020-10-23 23:27:38 +03:00
nikitamikhaylov
0064a75916 Merge branch 'master' of github.com:ClickHouse/ClickHouse into welch-t-test 2020-10-23 23:06:15 +03:00
tavplubix
380786882b
Merge pull request #16127 from azat/atomic-drop-database-sync
Atomic DROP DATABASE SYNC
2020-10-23 23:00:25 +03:00
Azat Khuzhin
3f594ed3ad Add a test for memory drift in user memory tracker (max_memory_usage_for_user) 2020-10-23 22:13:34 +03:00
tavplubix
587f83b2ef
Merge branch 'master' into atomic-drop-database-sync 2020-10-23 21:54:26 +03:00
tavplubix
d6f1056951
Update arcadia_skip_list.txt 2020-10-23 21:53:50 +03:00
MyroTk
24aca57885
Merge branch 'master' into testflows_RBAC_tests 2020-10-23 11:31:01 -07:00
Azat Khuzhin
4d1385ef19 Add total_rows/total_bytes support for Set/Join 2020-10-23 21:11:55 +03:00
Azat Khuzhin
6c42ad564c Add a test for MemoryTracking drift
v2: disable query profiling and logging in 01540_MemoryTracking
    (This should make MemoryTracker drift zero).
2020-10-23 21:11:22 +03:00
Azat Khuzhin
0cccf3049a Fix parent memory tracker during query detaching 2020-10-23 21:07:53 +03:00
Azat Khuzhin
114ea9b1eb Fix accounting for new/delete from different threads for VariableContext::Thread
MemoryTracker assumes that for VariableContext::Thread new/delete may be
called from different threads, hence the amount of memory can go
negative.

However the MemoryTracker is nested, so even if the negative amount is
allowed for VariableContext::Thread it does not allowed for anything
upper, and hence the MemoryTracking will not be decremented properly.

Fix this, by passing initial size to the parent free.

This should fix memory drift for HTTP queries.
2020-10-23 21:07:52 +03:00
Azat Khuzhin
72d7b6117e Use total_memory_tracker when there is no other MemoryTracker object.
This should significantly reduce the MemoryTracking drift, test shows
that there is 0 drift after query storm (100 queries, via http/tcp/tcp
in one session).

TL;DR;

To track memory, clickhouse creates memory tracker object for each
thread **explicitly**, but until it is not created the memory
allocations are not under account.
There should not be lot of allocations w/o memory tracker, since most of
the time it is created early enough, but even this maybe enough to
trigger some problems.

Plus sometimes it is not possible to create it, for example some 3d
party library does not allow to do this explicitly:
- for example before #15740 allocations from librdkafka threads,
- or even worse, poco threads, they don't have any routines to do this.
This won't be a problem for `MemoryTracking` metric if the deallocation
will be done from the same thread w/o memory tracker (or vise versa),
but this is not always true.

NOTE, that this will slow down per-thread allocations w/o memory
tracker, since before this patch there were no memory tracking for them
while now they will be accounted in total_memory_tracker, and for
total_memory_tracker max_untracked_memory is always reached.
But this should not be significant.
2020-10-23 21:07:52 +03:00
alexey-milovidov
840d96255e
Merge pull request #16199 from azat/clang10-build-fix
Link dbms w/ atomic to fix undefined reference in unbundled build
2020-10-23 20:17:37 +03:00
Nikolai Kochetov
c808ab878b Review fixed. 2020-10-23 20:15:23 +03:00
Nikolai Kochetov
a2014378fe Remove has_untuple flag 2020-10-23 19:57:22 +03:00
Nikolai Kochetov
5c791edd43 Remove ColumnNameCache 2020-10-23 19:56:11 +03:00
alesapin
bc331a8029 Better set 2020-10-23 19:34:41 +03:00
alesapin
b28894c43b More compatible way 2020-10-23 19:31:51 +03:00
alesapin
63ebc02bc3
Update 00652_replicated_mutations_zookeeper.sh 2020-10-23 19:07:53 +03:00
robot-clickhouse
f2b506785b Update version_date.tsv after release 20.10.2.20 2020-10-23 18:20:43 +03:00
sevirov
b8e754d68f
DOCSUP-3121: Update the SHOW DATABASES and SHOW TABLES descriptions (#16115)
* Update show.md

Update descriptions of show databases and show tables.

* Update show.md

Update 'identical query'.

* Update show.md

Внес поправки согласно комментариям.

* Update show.md

Внес поправки и перевел на русский язык.

* Update show.md

Внес мелкие поправки.

Co-authored-by: Dmitriy <sevirov@yandex-team.ru>
2020-10-23 18:11:02 +03:00
Mikhail Filimonov
f3a18864d5
After CR fixes - better & simpler. Issue in Context::shutdown fixed 2020-10-23 16:57:06 +02:00
Aleksandr Karo
ba0513b031
Fix broken link in replication docs 2020-10-23 17:49:56 +03:00
Alexander Kuzmenkov
69b16fc8ef
Update tests.md 2020-10-23 17:39:09 +03:00
Alexander Kuzmenkov
77654eeee8 fixup 2020-10-23 17:35:03 +03:00
Alexander Kuzmenkov
b0a14a41c3 fixup 2020-10-23 17:28:55 +03:00
tavplubix
84b453f4be
Update InterpreterDropQuery.cpp 2020-10-23 17:19:02 +03:00
alesapin
f0ef7dd1e9 Change default to zero 2020-10-23 16:31:45 +03:00
alesapin
a73a908264 Optionally upload clickhouse binary 2020-10-23 16:31:00 +03:00
Alexander Tokmakov
337fe7b81f add comment 2020-10-23 15:53:58 +03:00
Nikita Mikhaylov
cb4945d8b0
Merge pull request #16205 from azat/do-not-cache-dictGet
Do not cache dictionary for dictGet*/dictHas*
2020-10-23 15:47:11 +03:00
Alexander Tokmakov
b29cfa7f82 fix test with uuid 2020-10-23 15:32:57 +03:00
Alexander Kuzmenkov
d17a49f127 Add more context to error messages 2020-10-23 15:20:07 +03:00
Alexander Kuzmenkov
28c9e66dc1
Merge pull request #15978 from ucasFL/interval-op
INTERVAL operator support string literal
2020-10-23 14:44:05 +03:00
sundy-li
f407504a7a try use cmake version for croaring instead of amalgamation.sh 2020-10-23 19:42:21 +08:00
alesapin
59ca0d071c Fix comment 2020-10-23 14:17:37 +03:00