Commit Graph

26705 Commits

Author SHA1 Message Date
Pavel Kovalenko
f2dca656f9
MergeTree full support for S3 (#9646)
* IMergeDataPart full S3 support.

* MergeTreeData full S3 support.

* Compilation fixes.

* Mutations and merges S3 support.

* Fixed removing data part.

* MergeTree for S3 integration tests and fixes.

* Code style issues.

* Enable AWS logging.

* Fixed hardlink creation for DiskLocal.

* Fixed localBackup.cpp compilation.

* Fixed attaching partition.

* Get rid of extra methods in IDisk.

* Fixed storage config reloading.

* More tests with table manipulations.

* Remove unused error codes.

* Move localBackup to MergeTree folder.

* Minor fixes.
2020-03-19 19:37:55 +03:00
Alexander Kuzmenkov
9d9ae00956 Relax a test due to Poco regression.
Poco 1.9.3 has one second precision for mtime, because of this we can
miss an update of a dictionary file if it happens in the same second
we've read the file.

Should probably be fixed by switching to std::filesystem.

Also add some logs because finding out what's going on with dictionary
reloading is borderline impossible.
2020-03-19 19:05:41 +03:00
Alexander Kuzmenkov
e38f70de65 Doesn't look like I'll ever complete this. 2020-03-19 19:05:41 +03:00
Alexander Kuzmenkov
2b0b7efa8c Use the appropriate Int64 variant.
Our Int64 is int64_t, and Poco's is long long, which are distinct for
the purposes of template specialization on MacOS.
2020-03-19 19:05:41 +03:00
Alexander Kuzmenkov
10019b4cc6 Check order values in clickhouse-test 2020-03-19 19:05:41 +03:00
Alexander Kuzmenkov
486c061d34 Remove global scope from sigprocmask etc.
These functions may be macros on some platforms e.g. Mac OS
2020-03-19 19:05:41 +03:00
Alexander Kuzmenkov
8b754fdcde Straighten the ODBC integration test somewhat. 2020-03-19 19:05:41 +03:00
Alexander Kuzmenkov
dac83d2f9a Reset signal mask before calling exec().
It might be non-empty and the child process might not expect this. For
example, in one case we started clickhouse-odbc-bridge with blocked
SIGTERM and then it didn't shutdown properly along with the server.
2020-03-19 19:05:41 +03:00
Alexander Kuzmenkov
fbfa74e5c4 test 2020-03-19 19:05:41 +03:00
Alexander Kuzmenkov
42c59af127 Remove trailing whitespace. 2020-03-19 19:05:41 +03:00
alexey-milovidov
47738615e6 Update ShellCommand.h 2020-03-19 19:05:41 +03:00
alexey-milovidov
f716fb66f9 Update ShellCommand.cpp 2020-03-19 19:05:41 +03:00
Alexander Kuzmenkov
e864b6f338 More logs + build fix. 2020-03-19 19:05:41 +03:00
Alexander Kuzmenkov
2918324807 More logs to catch the ODBC bridge shutdown error.
Also increase a potentially flappy timeout in another test.
2020-03-19 19:05:41 +03:00
Alexander Kuzmenkov
3eac794fab Register Poco ODBC Connector on clickhouse-odbc-bridge startup 2020-03-19 19:05:41 +03:00
alesapin
c6d10e32fc Revert accident changes 2020-03-19 18:12:22 +03:00
Nikolai Kochetov
b6d7cb45dd Added comment. 2020-03-19 17:30:43 +03:00
Nikolai Kochetov
b4a93c092d Fix build. 2020-03-19 17:16:49 +03:00
alesapin
204d0ac955 Fix bugs after method split 2020-03-19 17:11:37 +03:00
Nikolai Kochetov
db9ad40db5 Fix build. 2020-03-19 16:53:25 +03:00
Nikolai Kochetov
100fe4c93c Fix build. 2020-03-19 16:45:19 +03:00
Nikolai Kochetov
f7c17435b8 Fix build 2020-03-19 16:29:59 +03:00
alesapin
ce8eb9293a Merge branch 'master' into alter_on_top_of_mutations_merge_tree 2020-03-19 16:05:17 +03:00
alexey-milovidov
77b26f6a93
Update PartLog.cpp 2020-03-19 16:00:34 +03:00
alesapin
9982f548f5 Remove redundant header 2020-03-19 14:48:11 +03:00
Nikolai Kochetov
5d763dead0 Change the way how rows_before_limit_at_least is calculated for processors pipeline. 2020-03-19 14:45:52 +03:00
alesapin
5818dfeb45 Simplier string get 2020-03-19 14:45:04 +03:00
alesapin
72baec8523 Better includes 2020-03-19 14:34:54 +03:00
alesapin
2b41cb2f5c Rename part_log table 2020-03-19 14:34:02 +03:00
alesapin
fbad7cb23b Remove new lines 2020-03-19 14:32:06 +03:00
alesapin
d27cd773cc Fix mutations huge memory consumption 2020-03-19 14:31:21 +03:00
Ivan
571d0d541c
Improve CCTZ contrib (#9687)
* common/Types.h → common/types.h
  Also split Core/Defines.h and merge with common/likely.h
* Improve cctz contrib
* Fix ALWAYS_INLINE and unbundled build
* Update Dockerfile from master
* Fix test for unbundled library
2020-03-19 13:38:34 +03:00
alexey-milovidov
b91bb18886
Merge pull request #9716 from ClickHouse/aku/more-stable-perf-tests
More stable perf tests
2020-03-19 12:50:33 +03:00
alexey-milovidov
a3e78a3b86
Merge pull request #9721 from amosbird/cc
Always prefer case insensitive suggestions
2020-03-19 12:34:16 +03:00
alexey-milovidov
4b943cd044
Merge pull request #9723 from amosbird/cd
random seed by default in groupArraySample
2020-03-19 12:33:40 +03:00
alexey-milovidov
36773b661c
Merge pull request #9742 from hczhcz/patch-0319
Extend splitByString for empty separators
2020-03-19 12:28:24 +03:00
alesapin
c4553f2f7b Reuse correct function 2020-03-19 11:36:37 +03:00
hcz
c115757e79 Update tests and docs for string splitting functions 2020-03-19 10:35:18 +08:00
hcz
08f9413e64 Extend splitByString for empty separators 2020-03-19 10:26:40 +08:00
alesapin
d060b7111d Also unescape backslashes 2020-03-18 23:23:48 +03:00
Alexey Milovidov
a7956013f3 Fixed clang-tidy check 2020-03-18 22:17:35 +03:00
Alexey Milovidov
9cc463b1af Merge branch 'master' of github.com:yandex/ClickHouse into clang-tidy-4 2020-03-18 22:16:07 +03:00
Alexander Kuzmenkov
a5e078736d
Merge pull request #9698 from ClickHouse/aku/faster-perf-test
Faster performance test
2020-03-18 22:04:51 +03:00
Ivan
38b2dec354
Arcadia (#9729)
* Move getFQDNOrHostName to base/common/
* Add argsToConfig to ya.make
* Add coverage.cpp to ya.make
  Also remove WITH_COVERAGE from config file
2020-03-18 21:54:27 +03:00
alesapin
37cc49efad Fix clang-tidy 2020-03-18 20:06:48 +03:00
alesapin
04494c6ec2 Merge with master after strange conflict 2020-03-18 19:59:22 +03:00
Alexey Milovidov
5e72202b51 Fixed clang-tidy check 2020-03-18 19:51:20 +03:00
Alexey Milovidov
1ced2550d0 Fixed clang-tidy check 2020-03-18 19:51:20 +03:00
Alexey Milovidov
4514f89fb3 Fixed style 2020-03-18 19:51:20 +03:00
Alexey Milovidov
93466ce097 Added even more clang-tidy checks 2020-03-18 19:51:20 +03:00
Alexey Milovidov
c20853eecc Added most of bugprone checks 2020-03-18 19:51:20 +03:00
alesapin
20211451ae Fix backquoting in dictionary ddl 2020-03-18 19:47:33 +03:00
Alexander Kuzmenkov
f04c2da180
Update arithmetic.xml 2020-03-18 18:31:03 +03:00
Alexander Kuzmenkov
83c8581e5a
Update synthetic_hardware_benchmark.xml 2020-03-18 18:22:29 +03:00
alesapin
baec35a18b Better locking in alter 2020-03-18 17:43:16 +03:00
alesapin
f64c005e70 Split merger mutator 2020-03-18 16:16:59 +03:00
Alexey Milovidov
cf1a8bc36e Fixed error 2020-03-18 15:14:10 +03:00
alesapin
d00406294c Splitting mutate part to temporarty part 2020-03-18 14:36:18 +03:00
alesapin
eb938f66e4 Better mutations interface 2020-03-18 13:02:57 +03:00
alesapin
3babac10f5 Fix query hang 2020-03-18 12:48:29 +03:00
alesapin
13a0151cf3 Remove garbage 2020-03-18 12:34:05 +03:00
alesapin
e6acfd4e8b Return new test 2020-03-18 12:12:35 +03:00
alesapin
b3d52cfb33 Merge branch 'master' into alter_on_top_of_mutations_merge_tree 2020-03-18 11:54:19 +03:00
alesapin
87e9a84ef7 Unblock waiting mutations 2020-03-18 11:53:55 +03:00
Amos Bird
045f5ae348
random seed by default 2020-03-18 16:12:15 +08:00
Amos Bird
adf4ad6ce3
Always prefer case insensitive suggestions 2020-03-18 13:27:56 +08:00
Alexander Kuzmenkov
f19c34d36d Merge remote-tracking branch 'origin/master' into HEAD 2020-03-18 06:26:29 +03:00
Alexey Milovidov
1bd7e594b0 clang-tidy, part 2 2020-03-18 03:57:00 +03:00
Alexander Kuzmenkov
2510aed7b5 More stable perf tests 2020-03-18 03:33:32 +03:00
Alexander Kuzmenkov
3ec3732d99
Update synthetic_hardware_benchmark.xml 2020-03-18 03:15:05 +03:00
alexey-milovidov
a800fa7986
Merge pull request #9693 from den-crane/patch-2
extended test for deduplicate_blocks_in_dependent_materialized_views
2020-03-18 01:33:18 +03:00
alexey-milovidov
52f51ba5dc
Merge pull request #9696 from ClickHouse/aku/trace-timestamp
Add high-precision timestamp to trace_log
2020-03-18 01:32:49 +03:00
Artem Zuikov
dbc08d7644
Add DATE and TIMESTAMP operators (#9691)
* DATE and TIMESTAMP operators
2020-03-18 00:56:47 +03:00
Alexander Kuzmenkov
458b724600 fixpu 2020-03-17 23:27:42 +03:00
alesapin
17e505da0f Fix build errors 2020-03-17 20:22:41 +03:00
alesapin
347d2a328f Remove columns lock!!! 2020-03-17 18:10:56 +03:00
Alexander Kuzmenkov
81631e4e6a fixup 2020-03-17 17:36:24 +03:00
alesapin
d5636fb76b Fix style check 2020-03-17 17:31:24 +03:00
alesapin
8d0cb42ef3 Remove more code 2020-03-17 17:07:27 +03:00
alesapin
5877a5af42 Remove alter transaction!!! 2020-03-17 16:49:50 +03:00
alesapin
b0b81bec89 Merge with master and fix 2020-03-17 14:03:29 +03:00
alesapin
5a152f8d09
Merge pull request #9689 from ClickHouse/better_logging_on_part_remove
More verbose error text
2020-03-17 12:13:42 +03:00
Alexander Kuzmenkov
1b7954cbae Faster performance test 2020-03-17 05:56:44 +03:00
Alexander Kuzmenkov
04bed5f032 Add high-precision timestamp to trace_log 2020-03-17 05:16:04 +03:00
Denis Zhuravlev
d6e843d1f4
Update test.py 2020-03-16 17:03:52 -03:00
Denis Zhuravlev
f1f1c1c591
extended test for deduplicate_blocks_in_dependent_materialized_views 2020-03-16 16:49:51 -03:00
alesapin
9c4f21eb54
Merge pull request #9680 from ClickHouse/fix_mutations_test
Simplify kill mutation test
2020-03-16 22:06:15 +03:00
alesapin
18dcb193fd More verbose message about error in case of exception during recursive remove 2020-03-16 21:57:01 +03:00
alesapin
1c98210b71 Fix bug in integration test 2020-03-16 18:09:20 +03:00
alesapin
5b54ef5bfd Split long dictionaries test 2020-03-16 17:59:11 +03:00
alesapin
718903f140 Simplify test and fix order of messages 2020-03-16 17:05:11 +03:00
Alexey Milovidov
32b3e7946c Fix flacky test, take two 2020-03-16 15:32:07 +03:00
alesapin
4547e1a25b Simplify kill mutation test 2020-03-16 14:54:07 +03:00
Nikita Mikhaylov
b34d1dfc7d fix debug build for gcc-9 2020-03-16 12:16:14 +03:00
alesapin
930e6f24b1
Merge pull request #9652 from ClickHouse/fix_compatibility_for_mutations
Fix compatibility in replication
2020-03-16 11:19:57 +03:00
Hui Wang
c1ff111146 remove warnings under MacOS 2020-03-15 21:02:06 +01:00
alesapin
2c16732536 Revert version check 2020-03-15 22:34:36 +03:00
alesapin
b0cc690cfb Fix entries compatibility without versions update 2020-03-15 22:33:25 +03:00
Azat Khuzhin
a15b2daf6d Do not shutdown global thread pool on exception
Otherwise GlobalThreadPool can be terminated (for example due to an
exception from the ParallelInputsHandler::onFinish/onFinishThread, from
ParallelAggregatingBlockInputStream::Handler::onFinish/onFinishThread,
since writeToTemporaryFile() can definitelly throw) and the server will
not accept new connections (or/and execute queries) anymore.

Here is possible stacktrace (it is a bit inaccurate, due to
optimizations I guess, and it had been obtained with the
DB::tryLogCurrentException() in the catch block of the
ThreadPoolImpl::worker()):

    2020.02.16 22:30:40.415246 [ 45909 ] {} <Error> ThreadPool: Unhandled exception in the ThreadPool(10000,1000,10000) the loop will be shutted down: Code: 241, e.displayText() = DB::Exception: Memory limit (total) exceeded: would use 279.40 GiB (attempt to allocate chunk of 4205536 bytes), maximum: 279.40 GiB, Stack trace (when copying this message, always include the lines below):

    1.  Common/Exception.cpp:35: DB::Exception::Exception(...)
    ...
    6.  Common/Allocator.h:102: void DB::PODArrayBase<8ul, 4096ul, Allocator<false, false>, 15ul, 16ul>::reserve<>(unsigned long) (.part.0)
    7.  Interpreters/Aggregator.cpp:1040: void DB::Aggregator::writeToTemporaryFileImpl<...>(...)
    8.  Interpreters/Aggregator.cpp:719: DB::Aggregator::writeToTemporaryFile(...)
    9.  include/memory:4206: DB::Aggregator::writeToTemporaryFile(...)
    10. DataStreams/ParallelInputsProcessor.h:223: DB::ParallelInputsProcessor<DB::ParallelAggregatingBlockInputStream::Handler>::thread(...)

Refs: https://github.com/ClickHouse/ClickHouse/issues/6833#issuecomment-579221732
(Reference to particular comment, since I'm not sure about the initial issue)
2020-03-15 13:13:10 +03:00
Azat Khuzhin
6969191c9f Call onException if ParallelInputsHandler::onFinish* throws 2020-03-15 13:13:10 +03:00