Commit Graph

116109 Commits

Author SHA1 Message Date
Robert Schulze
fb6c4f2802
Fix msan issue, pt. II 2023-05-30 08:51:44 +00:00
Val Doroshchuk
ecea1ac090 Fix crash when Pool::Entry::disconnect() is called
Many Pool::Entry objects can keep the same pointer to Pool::Connection.
If Pool::Entry::disconnect() is called on one such object,
Pool::removeConnection() is called to remove Pool::Connection from the pool,
where connection->ref_count is cleared and connection->removed_from_pool is set.

Next Pool::Entry::~Entry() calls decrementRefCount() with

1. const auto ref_count = data->ref_count.fetch_sub(1);
   where data->ref_count will be negative, since it was cleared
2. checks removed_from_pool and deletes Pool::Connection
   but there might be multiple Entry objects still keep pointer to this Pool::Connection

Suggesting not to clear ref_count on disconnect()
and delete Pool::Connection only on the last Pool::Entry is being destroyed.

Fixes ea375ef989
2023-05-30 10:29:49 +02:00
SmitaRKulkarni
f2172ab8dd
Merge pull request #46661 from ClickHouse/42192_Lower_parallel_parsing_threads_with_globs
When reading from multiple files displace parallel parsing
2023-05-30 08:53:08 +02:00
sslouis
a278d13043
Update first_value.md:remove redundant 's'
remove redundant 's'
2023-05-30 10:09:12 +08:00
zvonand
d4cec1f0e0 fix client thread attachment + make better tests 2023-05-30 01:30:01 +02:00
Victor Krasnov
9a8086a377 Reorder toLastDayOf* functions in settings.md 2023-05-29 22:12:44 +00:00
Victor Krasnov
6c94632d47 Deprive toStartOfWeek and toLastDayOfWeek functions of in-source documentation 2023-05-29 22:10:34 +00:00
Alexey Gerasimchuk
9714fa011e
Merge branch 'master' into ADQM-880 2023-05-30 07:45:09 +10:00
Robert Schulze
aefa9df1ce
Merge branch 'master' into rs/entropy-learned-hashing 2023-05-29 22:20:50 +02:00
Nikolay Degterinsky
e10f951467 Fix IS (NOT) NULL operator priority 2023-05-29 19:11:09 +00:00
Alexey Milovidov
701e2fb6e3
Merge pull request #50242 from ClickHouse/fix-max-parallel-replicas-custom-key
Fix `02535_max_parallel_replicas_custom_key`
2023-05-29 21:06:57 +03:00
Alexey Milovidov
32d4221097
Merge pull request #50270 from ClickHouse/evillique-patch-1
Docs: Add PostgreSQL and ODBC related settings
2023-05-29 20:52:44 +03:00
Alexey Milovidov
3cc9feafc2
Merge pull request #50285 from ucasfl/uniqExactIf
Parallel merge of uniqExactIf states
2023-05-29 19:42:44 +03:00
Alexey Milovidov
12ca383132
Merge pull request #50317 from ClickHouse/nickitat-patch-11
Update gtest_async_loader.cpp
2023-05-29 19:34:20 +03:00
Robert Schulze
516fa1c375
Merge branch 'master' into rs/entropy-learned-hashing 2023-05-29 17:40:14 +02:00
Nikita Taranov
87d6564b9b
Update gtest_async_loader.cpp 2023-05-29 15:50:06 +02:00
Sergei Trifonov
688f23b325
Merge pull request #50313 from ClickHouse/fix-flaky-async-loader-test
Fix flaky `AsyncLoader.StaticPriorities` unit test
2023-05-29 13:42:15 +02:00
Sergei Trifonov
0a42adfc18
Merge pull request #50310 from Algunenano/clang15_crash
Avoid clang 15 crash
2023-05-29 13:41:27 +02:00
Sergei Trifonov
c26b3b36ae
Merge branch 'master' into fix-flaky-async-loader-test 2023-05-29 13:38:35 +02:00
Sergei Trifonov
355f917daa
Update src/Common/tests/gtest_async_loader.cpp 2023-05-29 13:38:14 +02:00
Sergei Trifonov
df14ec4d58
Merge branch 'master' into clang15_crash 2023-05-29 13:36:08 +02:00
alesapin
6b7e2a0041
Merge pull request #49961 from CheSema/mem-consumption-s3-write
Introduce a limitation of async calls inside s3 write buffer, make a test that memory is bounded even when s3 is slow
2023-05-29 13:29:01 +02:00
serxa
bdb974ab3c Fix flaky AsyncLoader.StaticPriorities unit test 2023-05-29 11:21:44 +00:00
Raúl Marín
1ae1f1273a Avoid clang 15 crash 2023-05-29 11:40:45 +02:00
Han Fei
806ef08e5f
Merge pull request #50306 from helifu/master1
Fix a typo
2023-05-29 10:34:38 +02:00
Victor Krasnov
0ad5b9f598 Merge branch 'master' of github.com:ClickHouse/ClickHouse into ADQM-810-dev 2023-05-29 08:26:26 +00:00
Robert Schulze
41d60f0be3
Fix style 2023-05-29 08:08:47 +00:00
Robert Schulze
503105d4b1
Fix 02415_all_new_functions_must_be_documented 2023-05-29 08:07:46 +00:00
Robert Schulze
47daaad172
Merge pull request #49778 from helifu/master2
Support custom 'order by' expression for system log tables
2023-05-29 10:05:14 +02:00
Robert Schulze
a3ca8f9485
Merge pull request #50308 from rschu1ze/isal-cmake-comment
QPL: Add a comment about isal
2023-05-29 09:45:40 +02:00
Robert Schulze
f0ed55bac4
QPL: Add a comment about isal 2023-05-29 07:43:58 +00:00
helifu
1821933995 Fix a typo 2023-05-29 15:12:16 +08:00
flynn
758beda39a
Merge branch 'master' into uniqExactIf 2023-05-29 11:06:08 +08:00
flynn
f616314f8b fix typo 2023-05-29 02:22:13 +00:00
Alexey Milovidov
53de761e0e
Merge pull request #50272 from ClickHouse/inverse-async-loader-priority
Unify priorities: rework AsyncLoader
2023-05-29 05:01:44 +03:00
Alexey Milovidov
ef7e9e28b7
Merge pull request #50231 from ClickHouse/inverse-io-scheduler-priority-3
Unify priorities: rework IO scheduling subsystem
2023-05-29 04:34:23 +03:00
robot-ch-test-poll
d2f4b4d395
Merge pull request #50250 from johanngan/regexptree-doc-tweaks
Clean up regexp tree dictionary documentation
2023-05-29 02:08:47 +02:00
Alexey Milovidov
8c9546118a
Merge pull request #50249 from usernam3/usernam3-sample-clause-links-fix
Update SAMPLE clause documentation links
2023-05-29 02:46:31 +03:00
Alexey Milovidov
1875a93328
Merge pull request #50224 from Avogar/fix-custom-separated-ignore-spaces
Fix skipping spaces at end of row in CustomSeparatedIgnoreSpaces format
2023-05-29 02:42:38 +03:00
Alexey Milovidov
9b7260772a
Merge pull request #50290 from azat/tests/fix-02767_into_outfile_extensions_msan
Fix 02767_into_outfile_extensions_msan under analyzer
2023-05-29 02:28:33 +03:00
Alexey Gerasimchuk
e21fa2b35c
Merge branch 'master' into ADQM-880 2023-05-29 09:12:19 +10:00
Alexey Milovidov
9647cfa33d
Merge pull request #50291 from kitaisreal/jit-aggregation-nullable-key-fix
JIT aggregation nullable key fix
2023-05-29 02:08:02 +03:00
Alexey Milovidov
e1d535c890
Merge pull request #50287 from kitaisreal/function-equals-nan-fix
Comparison functions NaN fix
2023-05-29 01:56:02 +03:00
Alexey Gerasimchuck
8574559e23 Disallow usage of --query and --queries-file 2023-05-28 22:25:40 +00:00
alesapin
1bf32f70a0
Merge branch 'master' into fix-iceberg 2023-05-28 21:59:13 +02:00
alesapin
3a3cee586a
Merge pull request #50257 from CurtizJ/useless-refactoring
Yet another refactoring
2023-05-28 21:42:16 +02:00
alesapin
274fc4640b
Merge pull request #49004 from ClickHouse/keeper-log-improvements
Small Keeper performance improvements for larger requests
2023-05-28 21:25:23 +02:00
Maksim Kita
e9840bc6e1 JIT aggregation nullable key fix 2023-05-28 21:05:17 +03:00
Azat Khuzhin
e0563b95f2 Fix 02767_into_outfile_extensions_msan under analyzer
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-28 18:18:59 +02:00
Maksim Kita
c970266084 Updated tests 2023-05-28 17:35:29 +03:00