Commit Graph

142 Commits

Author SHA1 Message Date
Alexey Milovidov
ff5c433f10 Check for non-deterministic functions in keys, including constant expressions 2021-07-12 08:58:19 +03:00
Maksim Kita
c50909468f Updated ExpressionActionSettings 2021-05-19 17:32:07 +03:00
Maksim Kita
9699299083 Fix build 2021-05-19 16:11:38 +03:00
Maksim Kita
150a88d647 ExpressionActions compile only necessary places 2021-05-19 11:43:16 +03:00
Nikolai Kochetov
c508868570
Merge pull request #23082 from ClickHouse/explain-output
JSON output for EXPLAIN
2021-04-28 15:39:06 +03:00
Alexander Kuzmenkov
06ca44a378 fix pvs warnings 2021-04-22 22:54:58 +03:00
Nikolai Kochetov
9b86c19836 Use JSONBuilder for explain json result. 2021-04-14 17:07:56 +03:00
Nikolai Kochetov
48bcd5b490 Add tree conversion for expression. 2021-04-09 19:18:45 +03:00
Azat Khuzhin
42d858b7e5 Fix LOGICAL_ERROR for Log with nested types w/o columns in the SELECT clause
Found with fuzzer [1]:

<details>

    2021.04.04 10:25:46.762596 [ 135 ] {4b6b5de3-d242-4267-910a-76b235467356} <Fatal> : Logical error: 'Logical error: no information about file column%2Ename.size0 in StorageLog'.
    ...
    2021.04.04 10:25:46.763563 [ 44 ] {} <Trace> BaseDaemon: Received signal 6
    2021.04.04 10:25:46.765884 [ 165 ] {} <Fatal> BaseDaemon: 5. abort @ 0x25859 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    2021.04.04 10:25:46.901540 [ 165 ] {} <Fatal> BaseDaemon: 6. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:51: DB::handle_error_code() @ 0x11cc4f16 in /workspace/clickhouse
    2021.04.04 10:25:47.030755 [ 165 ] {} <Fatal> BaseDaemon: 7. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:58: DB::Exception::Exception() @ 0x11cc5025 in /workspace/clickhouse
    2021.04.04 10:25:47.617201 [ 165 ] {} <Fatal> BaseDaemon: 8. ./obj-x86_64-linux-gnu/../src/Storages/StorageLog.cpp:183: DB::LogSource::readData()

</details>

  [1]: https://clickhouse-test-reports.s3.yandex.net/22583/69296876005c0fa171c755f8b224e4d58192c402/fuzzer_debug/report.html#fail1

The problem here is that there is no column%2Ename.size0 there is
column.size0 instead, and it seems that reading sizeX file is not enough
in other places, so just filter them out in
ExpressionActions::getSmallestColumn() (fallback method for storages w/o
getColumnSizes() implemented)
2021-04-05 08:48:04 +03:00
Nikolai Kochetov
c3c393a7aa Merge branch 'master' into refactor-actions-dag 2021-03-18 14:33:07 +03:00
Nikolai Kochetov
5ef5ec4e05 Fix build. 2021-03-10 13:48:08 +03:00
Nikolai Kochetov
4f133ae036 Merge branch 'master' into refactor-actions-dag 2021-03-10 12:40:55 +03:00
Nikolai Kochetov
5ef9d87790 Fix some other tests. 2021-03-10 11:41:24 +03:00
Nikolai Kochetov
fc415952ce Try fix test. 2021-03-05 16:56:44 +03:00
Nikolai Kochetov
c481401b0b Fix build. 2021-03-05 12:54:17 +03:00
Nikolai Kochetov
9a39459888 Refactor ActionsDAG 2021-03-04 20:38:12 +03:00
Nikolai Kochetov
15921fbfcb Remove index by name from ActionsDAG 2021-03-03 23:01:07 +03:00
Nikolai Kochetov
4775ea305e Remove index by name from ActionsDAG 2021-03-02 20:51:54 +03:00
vdimir
a378bd08aa
Perform implicit type conversion for JOIN ON keys 2021-02-19 14:28:40 +03:00
vdimir
435f63f42b
Calculate common type for join using in TreeRewriter
Split before_join and converting_join_columns dags

Add more detailed comments for column type conversion for join using
2021-02-19 14:28:32 +03:00
Nikolai Kochetov
a6f787faea
Merge pull request #19253 from ClickHouse/split-actions-dag
Split actions dag
2021-01-25 18:13:42 +03:00
feng lv
beb0fec8bb mirror changes in code and comment 2021-01-22 09:13:22 +00:00
Nikolai Kochetov
b9c0f2b4c9 Push actions result to begin of block. 2021-01-19 00:54:01 +03:00
Nikolai Kochetov
382e6d0855 Review fix. 2020-11-20 19:52:50 +03:00
Nikolai Kochetov
71d726ea21 Order inputs for ActionsDAG. 2020-11-17 16:20:23 +03:00
Nikolai Kochetov
70f898e667 Order inputs for ActionsDAG. 2020-11-17 15:34:31 +03:00
Nikolai Kochetov
c2f1873f77 Remove comments. 2020-11-16 18:11:55 +03:00
Nikolai Kochetov
e8e6461fa7 Move ActionsDAG to separate file. 2020-11-16 17:57:56 +03:00
Nikolai Kochetov
1a0add5a22 Fix compile expressions 2020-11-12 11:58:36 +03:00
Nikolai Kochetov
46f70dd0de Merge branch 'master' into actions-dag-f14 2020-11-12 11:54:44 +03:00
Nikolai Kochetov
9b13d0e0eb Revert "Add ActionsDAG::updateHeader()"
This reverts commit b78657656c.
2020-11-11 20:17:26 +03:00
Nikolai Kochetov
58c4a7b890 Some renames. 2020-11-11 19:52:27 +03:00
Nikolai Kochetov
a8ddb27c00 Remove comment. 2020-11-11 19:08:48 +03:00
Nikolai Kochetov
aefbc2b48b Try fix tests. 2020-11-11 18:19:27 +03:00
Nikolai Kochetov
4618df5915 Try fix tests. 2020-11-11 18:16:46 +03:00
Nikolai Kochetov
c7f93140b4 Add more comments. 2020-11-11 17:56:56 +03:00
Nikolai Kochetov
4abcd1bcb3 Add more comments. 2020-11-11 17:26:18 +03:00
Nikolai Kochetov
b78657656c Add ActionsDAG::updateHeader() 2020-11-11 16:50:29 +03:00
Nikolai Kochetov
bd15b4e77f Fix tests. 2020-11-11 14:15:25 +03:00
Nikolai Kochetov
d70f9f4175 Move ExecutionContext 2020-11-10 23:36:38 +03:00
Alexander Tokmakov
b94cc5c4e5 remove more stringstreams 2020-11-10 21:22:26 +03:00
Nikolai Kochetov
5b49454622 Update ExpressionActions constructur 2020-11-10 20:05:56 +03:00
Nikolai Kochetov
c6575c9032 Update ExpressionActions constructur 2020-11-10 19:27:55 +03:00
Nikolai Kochetov
1db8e77371 Add comments. Update ActionsDAG::Index 2020-11-10 17:54:59 +03:00
Nikolai Kochetov
74f7f661ca More comments. 2020-11-09 18:01:08 +03:00
Nikolai Kochetov
6717c7a0af Merge branch 'master' into actions-dag-f14 2020-11-09 14:57:48 +03:00
Alexey Milovidov
fd84d16387 Fix "server failed to start" error 2020-11-07 03:14:53 +03:00
Nikolai Kochetov
28fb1affac Update complie expressions. 2020-11-05 19:11:14 +03:00
Nikolai Kochetov
feccf47f27 Fxi build. 2020-11-03 16:30:55 +03:00
Nikolai Kochetov
6767a226fc Merge branch 'master' into actions-dag-f14 2020-11-03 15:21:06 +03:00
Nikolai Kochetov
07a7c46b89 Refactor ExpressionActions [Part 3] 2020-11-03 14:28:28 +03:00
Nikolai Kochetov
42836c86e2
Merge pull request #16386 from ClickHouse/more-introspection-for-exception-double-free
Check exception message is poisoned in ExpressionActions.
2020-10-26 18:08:54 +03:00
Nikolai Kochetov
4e8bea397b
Update ExpressionActions.cpp 2020-10-26 15:10:16 +03:00
Nikolai Kochetov
fe9db9866c Check exception message is poisoned in ExpressionActions. 2020-10-26 12:56:50 +03:00
Nikolai Kochetov
02bd35924e
Merge pull request #16242 from ClickHouse/another-one-untuple
Another one untuple implementation
2020-10-26 12:26:43 +03:00
alexey-milovidov
7e4079dca1
Merge pull request #16286 from ClickHouse/aku/error-context
Add more context to error messages
2020-10-24 07:28:36 +03:00
Alexander Kuzmenkov
b0a14a41c3 fixup 2020-10-23 17:28:55 +03:00
Nikolai Kochetov
d9d83d8db6 Merge branch 'master' into actions-dag 2020-10-22 13:38:39 +03:00
Nikolai Kochetov
69ae6ace47 Add untuple. 2020-10-21 21:17:27 +03:00
Nikolai Kochetov
571a5fbff3 Update functions interface. 2020-10-15 19:52:25 +03:00
Nikolai Kochetov
07c2730169 Refactor ExpressionActions. 2020-10-13 11:16:47 +03:00
Nikolai Kochetov
fa8ed65c4d Merge branch 'master' into actions-dag 2020-10-12 14:18:25 +03:00
Nikolai Kochetov
76a04fb4b4
Merge pull request #15762 from ClickHouse/new-block-for-functions
Use `ColumnsWithTypeAndName` instead of `Block` for function calls
2020-10-10 08:50:38 +03:00
Nikolai Kochetov
a7fb2e38a5 Use ColumnWithTypeAndName as function argument instead of Block. 2020-10-09 10:41:28 +03:00
Nikolai Kochetov
11e86ed64f Refactor ExpressionActions [Part 1]. 2020-10-07 21:37:27 +03:00
Nikolai Kochetov
df02573c92 Fix ARRAY JOIN optimisation when reading from MV. 2020-10-07 13:11:58 +03:00
Nikolai Kochetov
53d4e5d195 Merge branch 'master' into expression-dag 2020-09-29 12:15:50 +03:00
Nikolai Kochetov
4aed515e19 Add ExpressionDAG [Part 5]. 2020-09-13 16:51:31 +03:00
Nikolai Kochetov
b461f97e4a Add ExpressionDAG [Part 4]. 2020-09-11 15:24:41 +03:00
Nikolai Kochetov
1cae264eae Add ExpressionDAG [Part 3]. 2020-09-10 21:36:51 +03:00
Nikolai Kochetov
c1469aff93 Add ExpressionDAG [Part 2]. 2020-09-10 19:01:41 +03:00
Alexander Kuzmenkov
223fc4d1e7 Avoid error while building the report on broken perf tests 2020-09-10 12:59:10 +03:00
Nikolai Kochetov
a5ed6409ad Add ExpressionDAG [Part 1]. 2020-09-10 10:30:03 +03:00
Nikolai Kochetov
dbd7ef9ee6 Fix build. 2020-09-08 15:31:36 +03:00
Nikolai Kochetov
39aad9979a Remove Join from ExpressionActions. 2020-09-08 13:40:53 +03:00
Nikolai Kochetov
d3fa5895fb Fix build. 2020-08-20 12:33:16 +03:00
Nikolai Kochetov
5cd4312529 Review fixes. 2020-08-19 22:33:49 +03:00
Nikolai Kochetov
8e631a98ea Refactor ActionsChain. 2020-08-14 21:24:58 +03:00
Nikolai Kochetov
246c2cafb7 Refactor splitActionsBeforeArrayJoin. 2020-08-14 21:24:03 +03:00
Nikolai Kochetov
6934974fc5 Lift up ARRAY JOIN step. 2020-08-14 21:24:31 +03:00
Nikolai Kochetov
85d0f1a480 Add ARRAY JOIN to ActionsChain 2020-08-14 21:24:19 +03:00
Nikolai Kochetov
95bbda3667 Specify columns after ARRAY JOIN and JOIN.
Add ArrayJoinTransform and ArrayJoinStep.
2020-08-14 21:24:03 +03:00
alesapin
e0bf5913e7 Fix sticking mutations 2020-07-26 17:21:57 +03:00
Artem Zuikov
2d7d389b77 better ExpressionAction::execute() 2020-06-25 23:28:41 +03:00
Artem Zuikov
bfe30a9723 remove a trick with expression continuation 2020-06-25 22:26:03 +03:00
Nikolai Kochetov
5bb2ddc6f9 Add DISTINCT trait for QueryPlanStep. 2020-06-18 16:00:16 +03:00
Azat Khuzhin
1f45c4302a Drop check for getPositionByName() (it already has it) in ExpressionActions 2020-05-23 00:36:30 +03:00
Azat Khuzhin
d93b9a57f6 Forward declaration for Context as much as possible.
Now after changing Context.h 488 modules will be recompiled instead of 582.
2020-05-21 01:53:18 +03:00
Alexey Milovidov
0a7edce036 Checkpoint 2020-04-22 09:01:33 +03:00
Ivan Lezhankin
e230632645 Changes required for auto-sync with Arcadia 2020-04-16 15:31:57 +03:00
Artem Zuikov
8297683972
renames: AnalyzedJoin -> TableJoin, Join -> HashJoin (#10065) 2020-04-07 12:48:47 +03:00
Ivan Lezhankin
06446b4f08 dbms/ → src/ 2020-04-03 18:14:31 +03:00