avogar
59c1c472cb
Better exception messages on wrong table engines/functions argument types
2022-06-23 20:04:06 +00:00
Robert Schulze
330212e0f4
Remove inherited create() method + disallow copying
...
The original motivation for this commit was that shared_ptr_helper used
std::shared_ptr<>() which does two heap allocations instead of
make_shared<>() which does a single allocation. Turned out that
1. the affected code (--> Storages/) is not on a hot path (rendering the
performance argument moot ...)
2. yet copying Storage objects is potentially dangerous and was
previously allowed.
Hence, this change
- removes shared_ptr_helper and as a result all inherited create() methods,
- instead, Storage objects are now created using make_shared<>() by the
caller (for that to work, many constructors had to be made public), and
- all Storage classes were marked as noncopyable using boost::noncopyable.
In sum, we are (likely) not making things faster but the code becomes
cleaner and harder to misuse.
2022-05-02 08:46:52 +02:00
Anton Popov
df3b07fe7c
Merge remote-tracking branch 'upstream/master' into HEAD
2022-03-03 22:25:28 +00:00
Maksim Kita
b1a956c5f1
clang-tidy check performance-move-const-arg fix
2022-03-02 18:15:27 +00:00
Anton Popov
e8ce091e68
Merge remote-tracking branch 'upstream/master' into HEAD
2022-01-21 20:11:18 +03:00
Maksim Kita
df95a40bbf
Fixed tests
2021-12-28 23:50:48 +03:00
Maksim Kita
9ef359ce2c
Dictionaries fix comment
2021-12-28 23:50:48 +03:00
Anton Popov
6f4d9a53b2
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-12-01 15:54:33 +03:00
Alexander Tokmakov
9237b251d5
allow rename dict in Ordrinary, fix another issue
2021-11-23 20:53:45 +03:00
Alexander Tokmakov
d56950a207
fix rename dictionary
2021-11-22 18:41:35 +03:00
Anton Popov
a20922b2d3
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-11-09 15:36:25 +03:00
Maksim Kita
772c326f2d
Merge pull request #30500 from kitaisreal/dictionaries-read-multiple-threads
...
Dictionaries read support multiple threads
2021-10-25 15:31:50 +03:00
Maksim Kita
8885748a6c
StorageDictionary fix potential configuration race
2021-10-21 17:25:53 +03:00
Maksim Kita
a3a780bbf5
Dictionaries read support multiple threads
2021-10-21 17:17:53 +03:00
Nikolai Kochetov
a08c98d760
Move some files.
2021-10-16 17:03:50 +03:00
Nikolai Kochetov
2957971ee3
Remove some last streams.
2021-10-13 21:22:02 +03:00
tavplubix
e419614d32
remove incorrect code
2021-09-09 21:31:15 +03:00
Anton Popov
61239343e3
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-08-20 16:33:30 +03:00
Nikolai Kochetov
13f95f3fdf
Streams -> Processors for dicts, part 3.
2021-08-06 11:41:45 +03:00
Anton Popov
e36736b50c
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-08-02 22:52:02 +03:00
Maksim Kita
9b53f4f2b3
Storage Dictionary quoted names fix
2021-07-20 11:35:10 +03:00
Anton Popov
3ed7f5a6cc
dynamic subcolumns: add snapshot for storage
2021-07-09 06:15:41 +03:00
Maksim Kita
3c9ae7b5ba
Added more tests
2021-06-26 14:28:13 +03:00
Maksim Kita
7b03150b90
Fixed tests
2021-06-26 14:28:13 +03:00
Maksim Kita
008adabec2
Support REPLACE DICTIONARY, CREATE OR REPLACE DICTIONARY queries
2021-06-26 14:28:13 +03:00
Nikolai Kochetov
aa366829de
Fix special build check.
2021-06-01 12:00:19 +03:00
feng lv
39f68bf5ff
fix conflict
2021-05-02 16:33:45 +00:00
Maksim Kita
2e5f97c6ff
Fixed code review issues
2021-04-27 22:09:03 +03:00
Maksim Kita
8e508a37b7
Fixed dictionaries_lazy_load during StorageDictionary CREATE query
2021-04-27 12:15:35 +03:00
Maksim Kita
71bccfdea1
Fixed integration test
2021-04-26 23:35:56 +03:00
Maksim Kita
c93666e0de
Fixed code review issues
2021-04-26 13:52:41 +03:00
Maksim Kita
375b77dbcb
Fixed integration tests
2021-04-26 13:52:41 +03:00
Maksim Kita
e69581d72f
Fixed tests
2021-04-26 13:52:41 +03:00
Maksim Kita
43680d8ced
Fixed tests
2021-04-26 13:52:41 +03:00
Maksim Kita
fa39c30b4b
Fixed tests
2021-04-26 13:52:41 +03:00
Maksim Kita
64f49a981b
Fixed tests
2021-04-26 13:52:41 +03:00
Maksim Kita
2e3e90b25b
Fixed tests
2021-04-26 13:52:41 +03:00
Maksim Kita
a9917a6540
Refactored StorageDictionary
2021-04-26 13:52:41 +03:00
feng lv
4ffe199d39
Implement table comments
2021-04-23 12:18:23 +00:00
Ivan
495c6e03aa
Replace all Context references with std::weak_ptr ( #22297 )
...
* Replace all Context references with std::weak_ptr
* Fix shared context captured by value
* Fix build
* Fix Context with named sessions
* Fix copy context
* Fix gcc build
* Merge with master and fix build
* Fix gcc-9 build
2021-04-11 02:33:54 +03:00
Maksim Kita
849a980644
Updated ExternalDictionariesLoader interface with context parameter
2021-03-20 18:02:09 +03:00
Maksim Kita
32831e37ba
Added table function dictionary
2021-03-19 15:47:27 +03:00
Mikhail Filimonov
2aeb72c09a
Fix for tiny issue #13850
2020-12-14 15:31:10 +01:00
tavplubix
e0dc004b95
Merge pull request #16885 from amosbird/dd
...
Disable ATTACH/DETACH TABLE <DICTIONARY>
2020-11-12 16:34:21 +03:00
Amos Bird
134786afd5
Disable ATTACH/DETACH TABLE <DICTIONARY>
2020-11-11 23:04:49 +08:00
Alexander Tokmakov
b94cc5c4e5
remove more stringstreams
2020-11-10 21:22:26 +03:00
alexey-milovidov
f4ba5f1f9a
Merge pull request #16772 from ClickHouse/fix-stringstream
...
Fix "server failed to start" error
2020-11-08 14:27:08 +03:00
Alexey Milovidov
fd84d16387
Fix "server failed to start" error
2020-11-07 03:14:53 +03:00
Azat Khuzhin
b838214a35
Pass non-const SelectQueryInfo (and drop mutable qualifiers)
2020-10-02 22:42:35 +03:00
Alexander Tokmakov
7fcf20e48c
enable more tests
2020-09-22 17:29:09 +03:00
