Sergei Trifonov
77ee4c04aa
fix stateless tests
2022-09-06 20:28:50 +02:00
kssenii
487bc0fba3
Fix heap use after free
2022-09-06 16:50:58 +02:00
Sergei Trifonov
6217559175
Merge branch 'master' into readonly-settings-allow
2022-09-06 16:10:48 +02:00
Alexey Milovidov
51dc796275
Remove trash
2022-09-06 02:04:57 +02:00
Alexey Milovidov
b7bdd38e41
Revert "Remove trash"
...
This reverts commit 494dfff73c
2022-09-06 02:04:36 +02:00
Alexey Milovidov
494dfff73c
Remove trash
2022-09-06 02:04:18 +02:00
Alexey Milovidov
940a53e519
Merge pull request #40984 from Lucky-Chang/typo_fix
...
Fix some typos and clang-tidy warnings
2022-09-06 02:37:50 +03:00
Kruglov Pavel
95847775b6
Merge pull request #40120 from evillique/obfuscator-schema-inference
...
Add schema inference to `clickhouse-obfuscator`
2022-09-05 22:03:57 +02:00
kssenii
0f305f8a7a
Fix test
2022-09-05 12:20:21 +02:00
Luck-Chang
1ac8e739c9
fix some typos and clang-tidy warnings
2022-09-05 09:50:24 +08:00
Alexey Milovidov
0e5c94ce80
Merge branch 'master' into add-missing-tests-geobase
2022-09-04 03:32:29 +02:00
Alexey Milovidov
13a129bee7
Merge branch 'master' into remove-useless-line
2022-09-04 03:24:40 +02:00
Alexander Gololobov
90baf74f13
Added mkdir command
2022-09-02 19:30:35 +02:00
kssenii
2dcf3fef94
Fix tests
2022-09-02 19:27:52 +02:00
Sergei Trifonov
005b2588d8
Merge branch 'master' into readonly-settings-allow
2022-09-02 16:37:43 +02:00
Sergei Trifonov
014d109175
fix build, fix docs, fix comments, logical fixes, test are still to be fixed and new test are to be added
2022-09-02 16:20:09 +02:00
Antonio Andelic
e64436fef3
Fix typos with new codespell
2022-09-02 08:54:48 +00:00
Sergei Trifonov
7fec55eea4
work in progress
2022-09-02 04:12:05 +02:00
Nikolay Degterinsky
e9232fc4e6
Better
2022-09-01 20:19:25 +00:00
Nikolay Degterinsky
5a611e272a
Merge remote-tracking branch 'upstream/master' into obfuscator-schema-inference
2022-09-01 13:07:28 +00:00
Sema Checherinda
7b59fdc042
Merge pull request #40779 from CheSema/detached-parts-metric
...
Metric for the number of detached parts
2022-09-01 12:24:42 +02:00
root
d5db88fa27
Structured-logging-custom-keys PR init
2022-08-30 23:20:19 -03:00
Sema Checherinda
e436b4f4cc
Metric for the number of detached parts
2022-08-30 02:12:57 +02:00
Alexander Tokmakov
1c6dea52e0
Update config.xml
2022-08-29 15:50:05 +03:00
Alexey Milovidov
84f9432e7e
Merge pull request #40724 from azat/update-bash-completion
...
Update available formats for bash completion
2022-08-29 00:14:48 +03:00
Alexey Milovidov
f462160bd1
Merge remote-tracking branch 'origin/master' into remove-useless-line
2022-08-28 21:00:29 +02:00
Alexey Milovidov
2fa8d212e6
Fix very strange test
2022-08-28 21:00:15 +02:00
Alexey Milovidov
deac6cfb5d
Minor modifications
2022-08-28 20:49:39 +02:00
Azat Khuzhin
29877d3992
Update available formats for bash completion
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-08-28 17:22:32 +02:00
Alexey Milovidov
ddff5e9145
Merge pull request #40712 from ClickHouse/ci-cmake-self-extractable
...
cmake: Disable default ENABLE_CLICKHOUSE_SELF_EXTRACTING
2022-08-28 17:12:19 +03:00
Alexey Milovidov
b42d26acfe
Remove one line from XML, because we do not care
2022-08-28 02:44:02 +02:00
Alexey Milovidov
632867dbff
Fix error
2022-08-28 02:40:43 +02:00
Alexey Milovidov
3139d4a79a
Fix error
2022-08-28 02:38:46 +02:00
Yakov Olkhovskiy
31a7ed09a1
disable default ENABLE_CLICKHOUSE_SELF_EXTRACTING and add to env
2022-08-27 21:08:01 +00:00
Alexey Milovidov
b14bd43590
Fix error
2022-08-27 20:25:06 +02:00
Alexey Milovidov
b70373d429
Fix error
2022-08-27 20:23:15 +02:00
Alexey Milovidov
6414a01987
Rewrite NLP tests from integration to functional
2022-08-26 22:36:34 +02:00
Alexey Milovidov
77e15a24d0
Add missing tests for legacy geobase
2022-08-26 22:17:49 +02:00
Alexey Milovidov
34b5d267f3
Merge pull request #40461 from ClickHouse/dashboard
...
Dashboard
2022-08-23 15:34:28 +03:00
Alexey Milovidov
0252695c6e
Merge pull request #40224 from ClickHouse/alexey-milovidov-patch-4
...
Check what will be if I enable `concurrency-mt-unsafe` in `clang-tidy`
2022-08-22 23:12:01 +03:00
Alexey Milovidov
6444afac52
Merge branch 'master' into dashboard
2022-08-22 01:30:21 +02:00
Robert Schulze
e8b3f56733
Limit suppression to a specific warning
2022-08-21 18:24:17 +00:00
Alexey Milovidov
000f879779
Add comments
2022-08-21 13:31:04 +02:00
Alexey Milovidov
861e5dbb76
Add comments
2022-08-21 13:26:32 +02:00
Alexey Milovidov
ab079b270a
Add comments
2022-08-21 13:07:46 +02:00
Alexey Milovidov
fa9df87198
Fix margin
2022-08-21 12:56:23 +02:00
Alexey Milovidov
458d21dd3c
Add "readpassphrase" as a dependency for clickhouse-local
2022-08-21 12:12:11 +02:00
Alexey Milovidov
9635fa817b
Embedded dashboard
2022-08-21 12:11:25 +02:00
Alexey Milovidov
4e0bf0dd34
Add a file
2022-08-21 12:11:04 +02:00
Alexey Milovidov
3649aac593
Fix style
2022-08-20 17:59:51 +02:00
Alexey Milovidov
74e1f4dc61
Fix clang-tidy
2022-08-20 17:09:20 +02:00
Sergei Trifonov
7bbbe0a4db
fix darwin build
2022-08-18 19:31:25 +02:00
Sergei Trifonov
b064021cec
fix build
2022-08-18 16:57:31 +02:00
Sergei Trifonov
42a711015f
split concurrent_threads_soft_limit setting into two: concurrent_threads_soft_limit_{num,ratio_to_cores}
2022-08-18 14:51:08 +02:00
Nikita Mikhaylov
a7c3f23dfb
Merge branch 'master' into auto_convert_ordinary_to_atomic
2022-08-17 00:38:25 +02:00
Alexander Tokmakov
c9bb91c31f
Merge pull request #40232 from ClickHouse/fix_a_bug_with_symlinks_detection
...
Fix a bug with symlinks detection
2022-08-15 20:28:30 +03:00
Alexander Tokmakov
6f5a7c3bf7
fix a bug with symlinks detection
2022-08-15 12:30:47 +02:00
Alexey Milovidov
bada9ebefa
Merge branch 'master' into disable-zero-copy-replication
2022-08-14 10:40:16 +03:00
Alexey Milovidov
e774d28c43
Fix style
2022-08-14 04:16:48 +02:00
Alexey Milovidov
53ce2986de
Display server-side time in clickhouse-benchmark by default
2022-08-14 03:33:42 +02:00
Alexey Milovidov
f0c8998471
Add warning message
2022-08-14 01:49:00 +02:00
Alexey Milovidov
42c358aa3c
Add warning message
2022-08-14 01:47:36 +02:00
Kseniia Sumarokova
a6cfc7bc3b
Merge pull request #34651 from alexX512/master
...
New caching strategies
2022-08-12 17:23:37 +02:00
Nikita Taranov
17956cb668
Extend protocol with query parameters ( #39906 )
2022-08-12 14:28:35 +02:00
Anton Popov
0383250383
execute DROP queries for fuzzed tables
2022-08-12 00:32:21 +00:00
Nikolay Degterinsky
644be9dc42
Remove unneded ReadBuffers
2022-08-11 13:27:09 +00:00
Nikolay Degterinsky
1b8ca90fcc
Add schema inference to clickhouse-obfuscator
2022-08-11 11:32:32 +00:00
Anton Popov
e347fa2f45
add fuzzer for table definition
2022-08-11 02:34:10 +00:00
Nikolay Degterinsky
496568101f
Merge pull request #39277 from ClibMouse/Structured-Logging-Support
...
Structured logging support
2022-08-10 22:57:48 +02:00
Kseniia Sumarokova
a4d513657c
Merge pull request #40010 from ClickHouse/catboost-further-preparation
...
Further preparation for catboost integration into library-bridge
2022-08-10 17:35:12 +02:00
Vladimir C
eb1ac41ac5
Merge pull request #40053 from ClickHouse/play-tab-in-textarea
...
Play: recognize tab in textarea
2022-08-10 12:53:28 +02:00
Robert Schulze
810221baf2
Assume unversioned server has version=0 and use tryParse() instead of from_chars()
2022-08-10 07:39:32 +00:00
Alexey Milovidov
34c8d2c3b4
Play: recognize tab in textarea
2022-08-10 08:33:58 +02:00
Mallik Hassan
666fb8dc42
Merge branch 'ClickHouse:master' into Structured-Logging-Support
2022-08-09 15:39:00 -03:00
Robert Schulze
e0d5020a92
Add simple versioning to the *-bridge-to-server protocol
...
- In general, it is expected that clickhouse-*-bridges and
clickhouse-server were build from the same source version (e.g. are
upgraded "atomically"). If that is not the case, we should at least
be able to detect the mismatch and abort.
- This commit adds a URL parameter "version", defined in a header shared
by the server and bridges. The bridge returns an error in case of
mismatch.
- The version is *not* send and checked for "ping" requests (used for
handshake), only for regular requests send after handshake. This is
because the internally thrown server-side exception due to HTTP
failure does not propagate the exact HTTP error (it only stores the
error as text), and as a result, the server-side handshake code
simply retries in case of error with exponential backoff and finally
fails with a "timeout error". This is reasonable as pings typically
fail due to time out. However, without a rework of HTTP exceptions,
version mismatch during ping would also appear as "timeout" which is
too misleading. The behavior may be changed later if needed.
- Note that introducing a version parameter does not represent a
protocol upgrade itself. Bridges older than the server will simply
ignore the field. Only servers older than the bridges receive an error
but such a situation should never occur in practice.
2022-08-08 19:40:37 +00:00
Robert Schulze
9952ab1099
Prefix class names "LibraryBridge*Handler" with "ExternalDictionary"
...
- necessary to disambiguate the names from "CatBoost"-"LibraryBridgeHandler"
which will be added in a next step
2022-08-08 17:16:46 +00:00
Yakov Olkhovskiy
d39e9f65de
Merge branch 'master' into fix-quota-key
2022-08-08 11:54:21 -04:00
Robert Schulze
ad0d060dc1
Merge pull request #39904 from ClickHouse/library-bridge-refactoring
...
Prepare library-bridge for catboost integration
2022-08-08 12:15:01 +02:00
Alexey Milovidov
64a1b0f2b8
Play UI: row numbers; cell selection; hysteresis
2022-08-08 04:25:03 +02:00
Alexey Milovidov
653b86d1e6
Play UI: row numbers; cell selection; hysteresis
2022-08-08 04:16:50 +02:00
Alexey Milovidov
2d83635643
Play UI: row numbers; cell selection; hysteresis
2022-08-08 03:57:02 +02:00
Alexey Milovidov
d914ddc766
Fix Play UI
2022-08-08 02:36:50 +02:00
alexX512
2be72560f4
Add loading of mark cache policy
2022-08-07 19:59:39 +00:00
alexX512
1133e42367
Add CacheBase clas instead of LRUCache and SLRUCache fo simpler configuration oache policiesf
2022-08-07 19:16:40 +00:00
Yakov Olkhovskiy
29622746ea
Merge pull request #39936 from ClickHouse/cmake-fix-self-extracting-split
...
Don't create self-extracting clickhouse for split build
2022-08-07 07:23:24 -04:00
Yakov Olkhovskiy
b1f45fa787
Don't create self-extracting clickhouse for split build
2022-08-05 21:48:40 -04:00
Alexey Milovidov
ac93f0a2ca
Merge pull request #39910 from santrancisco/enhance-playui-authentication
...
Move username and password from URL parameters to Basic Authentication
2022-08-06 01:58:09 +03:00
Alexander Tokmakov
f2c4cad255
add flag that enables automatic canversion from Ordinary to Atomic
2022-08-05 21:41:25 +02:00
santrancisco
c7f0598a6f
Fall back to url parameters if file is opened locally
2022-08-05 13:10:45 +10:00
santrancisco
a25b858097
Move username and password from URL parameter to Basic Authentication header
2022-08-05 09:51:12 +10:00
Robert Schulze
20bb8a248e
Prepare server-side BridgeHelper for catboost integration
...
Wall of text, sorry, but I also had to document some stuff for myself:
There are three ways to communicate data using HTTP:
- the HTTP verb: for our purposes, PUT and GET,
- the HTTP path: '/ping', '/request' etc.,
- the HTTP URL parameter(s), e.g. 'method=libNew&dictionary_id=1234'
The bridge will use different handlers for communication with the
external dictionary library and for communication with the catboost
library. Handlers are created based on a combination of the HTTP verb
and the HTTP method. More specifically, there will be combinations
- GET + '/extdict_ping'
- PUT + '/extdict_request'
- GET + '/catboost_ping'
- PUT + '/catboost_request'.
For each combination, the bridge expects a certain set of URL
parameters, e.g. for the first combination parameter "dictionary_id" is
expected.
Starting with this commit, the library-bridge creates handlers based on
the first two combinations (the latter two combinations will be added
later). This makes the handler creation mechanism consistent with it's
counterpart in xdbc-bridge.
For that, it was necessary to make both IBridgeHelper methods
"getMainURI()" and "getPingURI()" pure virtual so that derived classes
(LibraryBridgeHelper and XDBCBridgeHelper) must provide custom URLs with
custom paths.
Side note 1: Previously, LibraryBridgeHelper sent HTTP URL parameter
"method=ping" during handshake (PING) but the library-bridge ignored
that parameter. We now omit this parameter, i.e.
LibraryBridgeHelper::PING was removed. Again, this makes things
consistent with xdbc-bridge.
Side note 2: xdbc-bridge is unchanged in this commit. Therefore,
XDBCBridgeHelper now uses the HTTP paths previously in the base class.
For funny reason, XDBCBridgeHelper did not use
IBridgeHelper::getMainURI() - it generates the URLs by itself. I kept it
that way for now but provided an implementation of getMainURI() anyways.
2022-08-04 19:29:51 +00:00
Robert Schulze
ea73b98fb9
Prepare library-bridge for catboost integration
...
- Rename generic file and identifier names in library-bridge to
something more dictionary-specific. This is needed because later on,
catboost will be integrated into library-bridge.
- Also: Some smaller fixes like typos and un-inlining non-performance
critical code.
- The logic remains unchanged in this commit.
2022-08-04 19:26:51 +00:00
Yakov Olkhovskiy
23037daf17
Merge branch 'master' into fix-quota-key
2022-08-04 12:14:49 -04:00
Alexey Milovidov
834cbbedce
Merge branch 'master' into escape_diag_creds
2022-08-04 01:59:50 +03:00
Yakov Olkhovskiy
2e34b384c1
update tcp protocol, add quota_key
2022-08-03 15:44:08 -04:00
Mallik Hassan
87bde54ee5
Merge branch 'ClickHouse:master' into Structured-Logging-Support
2022-08-02 10:44:05 -03:00
Alexey Milovidov
5f62863ab9
Merge branch 'master' into escape_diag_creds
2022-08-02 05:50:01 +03:00
Heena Bansal
d8db482b2e
Merge branch 'master' into Issue_39395
2022-08-01 12:22:16 -04:00
Robert Schulze
bf574b9154
Merge pull request #39760 from ClickHouse/bit-fiddling
...
Use std::popcount, ::countl_zero, ::countr_zero functions
2022-08-01 17:04:51 +02:00
HeenaBansal2009
50c98789b8
Updated as per comments
2022-08-01 07:05:50 -07:00
HeenaBansal2009
800ed546be
Updated as per comments
2022-08-01 07:03:36 -07:00
Ilya Yatsishin
c882bdc88e
Merge pull request #35968 from ClickHouse/interserver_listen_port
2022-08-01 13:57:17 +02:00
Alexander Tokmakov
80f9ba9186
Merge pull request #39690 from ClickHouse/show-addresses-in-stack-traces
...
Configuration parameter to hide addresses in stack traces
2022-08-01 14:20:37 +03:00
Alexey Milovidov
6a2f7d0c8f
Merge branch 'master' into interserver_listen_port
2022-07-31 22:51:38 +03:00
Alexey Milovidov
ebc4974188
Merge branch 'master' into escape_diag_creds
2022-07-31 22:46:10 +03:00
Robert Schulze
a7734672b9
Use std::popcount, ::countl_zero, ::countr_zero functions
...
- Introduced with the C++20 <bit> header
- The problem with __builtin_c(l|t)z() is that 0 as input has an
undefined result (*) and the code did not always check. The std::
versions do not have this issue.
- In some cases, we continue to use buildin_c(l|t)z(), (e.g. in
src/Common/BitHelpers.h) because the std:: versions only accept
unsigned inputs (and they also check that) and the casting would be
ugly.
(*) https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html
2022-07-31 15:16:51 +00:00
Robert Schulze
dcc8751685
Disable harmful env var check to workaround failure to start the server
2022-07-31 08:55:07 +00:00
Robert Schulze
7c23e48b5b
Revert exclusion of libharmful (did not work anyways)
2022-07-31 08:05:12 +00:00
Robert Schulze
7fe106a0fb
Try to fix libharmful fail
2022-07-31 07:44:25 +00:00
Alexey Milovidov
fa9c3dcc48
Update programs/local/LocalServer.cpp
...
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2022-07-31 03:02:27 +03:00
Alexey Milovidov
a30dbed6b8
Update programs/local/LocalServer.cpp
...
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2022-07-31 03:02:20 +03:00
Alexey Milovidov
f80a4c184e
Merge branch 'master' into interserver_listen_port
2022-07-31 01:22:32 +03:00
Alexey Milovidov
9adfd259d0
Support in clickhouse-local
2022-07-30 01:50:45 +02:00
Alexey Milovidov
c0d7b6efc3
Suggestions from @tavplubix
2022-07-30 01:45:06 +02:00
Alexey Milovidov
4aa96767d5
Merge branch 'master' of github.com:ClickHouse/ClickHouse into show-addresses-in-stack-traces
2022-07-30 01:44:04 +02:00
Robert Schulze
3d1797f75f
Merge remote-tracking branch 'origin/master' into no-split-binary
2022-07-29 12:17:43 +00:00
Dale Mcdiarmid
d9c585ecf1
Escape credentials for diagnostics tool
2022-07-29 12:25:03 +01:00
Azat Khuzhin
b90152b6ec
Fix clickhouse-su building in splitted build
...
- Add status log message
- Add it to clickhouse-bundle in shared build
- Move clickhouse-su.cpp into su.cpp, since executable does not have
include directories of linked libraries (dbms here), only
clickhouse-lib-su does, hence it cannot find includes
CI: https://github.com/ClickHouse/ClickHouse/runs/7566319416?check_suite_focus=true
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-29 11:36:51 +03:00
root
39369be318
commented out formatting tag in config.xml
2022-07-28 23:56:26 -07:00
root
f9e4d6370d
modified integration test as suggested
2022-07-28 23:51:59 -07:00
Alexey Milovidov
552b517e59
Allow to hide addresses in stack traces
2022-07-29 00:13:02 +02:00
root
bec7408a0c
reflected change requests asked on July 27
2022-07-28 09:20:28 -07:00
Robert Schulze
199e254777
Merge remote-tracking branch 'origin/master' into no-split-binary
2022-07-28 15:54:22 +00:00
Sergei Trifonov
4588e146a6
Merge pull request #37285 from arenadata/ADQM-445
...
Add concurrent_threads_soft_limit parameter
2022-07-28 11:46:43 +02:00
Roman Vasin
f35349eb08
Rename total_max_threads to concurrent_threads_soft_limit
2022-07-28 07:46:20 +00:00
Roman Vasin
37845389c8
Merge branch 'concurrency-control' of github.com:ClickHouse/ClickHouse into ADQM-445
2022-07-27 13:31:22 +00:00
Antonio Andelic
e62526720f
Address PR comments
2022-07-27 07:51:30 +00:00
Antonio Andelic
35b61cc94e
Merge branch 'master' into keeper-version-check
2022-07-26 07:47:57 +00:00
Alexey Milovidov
75d0232265
Merge pull request #39541 from ClickHouse/obfuscator-save-load
...
Add save/load capabilities to Obfuscator
2022-07-25 21:18:28 +03:00
Mallik Hassan
b45e44b7e7
Merge branch 'ClickHouse:master' into Structured-Logging-Support
2022-07-25 12:10:41 -03:00
Yakov Olkhovskiy
d0f5dcad25
Merge pull request #38936 from ClickHouse/cmake-self-extracting-executable
...
Build self-extracting-executable utils
2022-07-25 08:13:25 -04:00
Alexey Milovidov
1f4e7ea34c
Add a test
2022-07-25 05:37:07 +02:00
Alexey Milovidov
dde89c9606
Fix errors
2022-07-25 03:56:32 +02:00
Alexey Milovidov
68f5a397d7
Fix errors
2022-07-25 03:49:09 +02:00
Alexey Milovidov
52ad48d1ba
Better documentation
2022-07-25 03:32:01 +02:00
Alexey Milovidov
c09413e3b9
Add save/load capabilities to Obfuscator
2022-07-25 03:27:10 +02:00
Alexey Milovidov
071374b152
Remove SPLIT_BINARY
2022-07-24 01:15:54 +02:00
Antonio Andelic
afb6cb6824
Add KeeperContext
2022-07-23 14:45:31 +00:00
Antonio Andelic
3040ff0959
Merge branch 'master' into keeper-version-check
2022-07-22 08:07:55 +00:00
jasperzhu
614f3b14a2
Merge branch 'master' into dev_intel_iaa_deflate
2022-07-22 11:05:44 +08:00
HeenaBansal2009
06e8b78efa
Added FT testcase
2022-07-21 19:46:36 -07:00
Kruglov Pavel
49c839bdc1
Merge pull request #39413 from vitlibar/fix-interactive-client-with-older-server
...
Fix interactive client with older server
2022-07-21 11:37:20 +02:00
Antonio Andelic
7d30ab80c4
Fix compatibility
2022-07-21 09:31:06 +00:00
Vitaly Baranov
da0bdd474b
Fix code style.
2022-07-21 10:48:53 +02:00
Yakov Olkhovskiy
e7438cc433
Merge branch 'master' into cmake-self-extracting-executable
2022-07-21 00:25:08 -04:00
Yakov Olkhovskiy
b766552481
add native build for cross-compilation
2022-07-20 23:09:05 -04:00
Nikolai Kochetov
91043351aa
Fixing build.
2022-07-20 20:30:16 +00:00
Vitaly Baranov
8873d16afe
Fix interactive client with older server after https://github.com/ClickHouse/ClickHouse/pull/38970
2022-07-20 11:51:55 +02:00
HeenaBansal2009
d67e061915
Clickhouse-local fixes
2022-07-19 21:38:36 -07:00
jasperzhu
c044c67745
Merge branch 'master' into dev_intel_iaa_deflate
2022-07-19 15:32:57 +08:00
