Robert Schulze
330212e0f4
Remove inherited create() method + disallow copying
...
The original motivation for this commit was that shared_ptr_helper used
std::shared_ptr<>() which does two heap allocations instead of
make_shared<>() which does a single allocation. Turned out that
1. the affected code (--> Storages/) is not on a hot path (rendering the
performance argument moot ...)
2. yet copying Storage objects is potentially dangerous and was
previously allowed.
Hence, this change
- removes shared_ptr_helper and as a result all inherited create() methods,
- instead, Storage objects are now created using make_shared<>() by the
caller (for that to work, many constructors had to be made public), and
- all Storage classes were marked as noncopyable using boost::noncopyable.
In sum, we are (likely) not making things faster but the code becomes
cleaner and harder to misuse.
2022-05-02 08:46:52 +02:00
Amos Bird
4a5e4274f0
base should not depend on Common
2022-04-29 10:26:35 +08:00
Anton Popov
df3b07fe7c
Merge remote-tracking branch 'upstream/master' into HEAD
2022-03-03 22:25:28 +00:00
Anton Popov
c1fdcf7a64
Merge remote-tracking branch 'upstream/master' into HEAD
2022-03-01 20:21:39 +03:00
kssenii
092ec45b47
Merge master
2022-03-01 12:06:56 +01:00
Nikita Mikhaylov
d6036f6da3
Better
...
(cherry picked from commit 4ae445c9e227581ea9f1cbe9aa9d1ba82e1236c9)
2022-02-28 15:27:52 +00:00
kssenii
9b64a8fe39
Fix odbc bridge
2022-02-28 14:29:05 +01:00
Anton Popov
836a348a9c
Merge remote-tracking branch 'upstream/master' into HEAD
2022-02-01 15:23:07 +03:00
Kruglov Pavel
a9d0beb7ae
Fix data race in StorageFile ( #34113 )
...
* Fix data race in StorageFile
* Update StorageFile.h
* Fix
2022-01-31 11:58:40 +03:00
Anton Popov
78b9f15abb
Merge remote-tracking branch 'upstream/master' into HEAD
2022-01-30 03:24:37 +03:00
Kruglov Pavel
7873b4475f
Merge branch 'master' into autodetect-format
2022-01-25 10:56:52 +03:00
avogar
a6740d2f9a
Detect format and schema for stdin in clickhouse-local
2022-01-25 10:25:37 +03:00
Anton Popov
e8ce091e68
Merge remote-tracking branch 'upstream/master' into HEAD
2022-01-21 20:11:18 +03:00
avogar
97788b9c21
Allow to create new files on insert for File/S3/HDFS engines
2021-12-29 21:19:13 +03:00
avogar
8112a71233
Implement schema inference for most input formats
2021-12-29 12:18:56 +03:00
Anton Popov
a20922b2d3
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-11-09 15:36:25 +03:00
kssenii
03d7476864
One more fix
2021-10-29 00:50:59 +03:00
kssenii
1d743b9259
Partitoned write
2021-10-25 19:23:44 +03:00
Alexey Milovidov
fe6b7c77c7
Rename "common" to "base"
2021-10-02 10:13:14 +03:00
Anton Popov
e36736b50c
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-08-02 22:52:02 +03:00
Nikolai Kochetov
9b5a816b43
Merge branch 'master' into output-streams-to-processors
2021-07-26 18:03:11 +03:00
Alexey Milovidov
774f6d2617
Allow to read file descriptor multiple times in File storage
2021-07-24 19:50:03 +03:00
Nikolai Kochetov
2dc5c89b66
Update Storage::write
2021-07-23 17:25:35 +03:00
Anton Popov
3ed7f5a6cc
dynamic subcolumns: add snapshot for storage
2021-07-09 06:15:41 +03:00
kssenii
bdc8fe1ca0
Merge branch 'master' of github.com:ClickHouse/ClickHouse into progress-bar
2021-06-18 09:33:29 +03:00
Maksim Kita
67e9b85951
Merge ext into common
2021-06-16 23:28:41 +03:00
kssenii
de277f8ac4
Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into progress-bar
2021-06-01 07:58:19 +00:00
kssenii
9b8df78fdd
Merge branch 'master' of github.com:ClickHouse/ClickHouse into poco-file-to-std-fs
2021-05-17 17:42:05 +03:00
kssenii
e9c3bc1836
Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into progress-bar
2021-05-16 20:48:35 +00:00
kssenii
c33f358a9a
Better way to track progress, display progress for ch-client
2021-04-28 19:12:28 +00:00
kssenii
eeb71672a0
Change in Storages/*
2021-04-27 16:49:37 +03:00
kssenii
ffcfe5f9a1
Progress bar for file table engine
2021-04-26 21:02:52 +00:00
feng lv
4ffe199d39
Implement table comments
2021-04-23 12:18:23 +00:00
Ivan
495c6e03aa
Replace all Context references with std::weak_ptr ( #22297 )
...
* Replace all Context references with std::weak_ptr
* Fix shared context captured by value
* Fix build
* Fix Context with named sessions
* Fix copy context
* Fix gcc build
* Merge with master and fix build
* Fix gcc-9 build
2021-04-11 02:33:54 +03:00
Nikita Mikhailov
71a2c85d9a
better
2021-04-06 22:23:16 +03:00
keenwolf
3d3923b518
update comments
2021-04-06 22:23:16 +03:00
keenwolf
139bb678a9
Branch with Format isColumnOriented() or not
2021-04-06 22:23:15 +03:00
alexey-milovidov
69719f743d
Merge branch 'master' into revert-15259-revert-14962-log-avoid-deadlock
2020-12-22 00:41:52 +03:00
tavplubix
67099f28ac
Merge pull request #16591 from ClickHouse/aku/create-file
...
Support `SETTINGS` clause for File engine
2020-11-09 14:15:42 +03:00
Alexey Milovidov
5314185e25
Merge branch 'master' into azat-optimize_skip_unused_shards-optimization
2020-11-08 00:17:59 +03:00
Alexander Kuzmenkov
2efbcbaa14
Merge remote-tracking branch 'origin/master' into HEAD
2020-11-05 14:28:56 +03:00
Alexander Kuzmenkov
14f31f5117
add support of settings to URL, fix url and file table functions
2020-11-05 14:28:20 +03:00
Alexander Tokmakov
ac32809b6a
fix #16482
2020-11-02 19:40:39 +03:00
Alexander Kuzmenkov
99ee127620
Support SETTINGS
clause for File engine
...
Accept the usual user settings related to file formats.
Most of the diff are the mechanistic code changes required to allow
providing the required FormatSettings to the format factory. The File
engine then extracts these settings from the `CREATE` query, and specifies
them when creating the format parser.
2020-11-02 10:50:38 +03:00
Alexander Tokmakov
72b1339656
Revert "Revert "Write structure of table functions to metadata""
...
This reverts commit c65d1e5c70
.
2020-10-14 15:19:29 +03:00
tavplubix
c65d1e5c70
Revert "Write structure of table functions to metadata"
2020-10-14 13:59:29 +03:00
Azat Khuzhin
b838214a35
Pass non-const SelectQueryInfo (and drop mutable qualifiers)
2020-10-02 22:42:35 +03:00
alexey-milovidov
47d150b116
Revert "Revert "Avoid deadlocks in Log/TinyLog""
2020-09-25 02:29:16 +03:00
alexey-milovidov
13529265c4
Revert "Avoid deadlocks in Log/TinyLog"
2020-09-25 02:28:57 +03:00
Alexey Milovidov
111acdc63b
Continuation
2020-09-19 14:02:11 +03:00