Yakov Olkhovskiy
d34ee81be6
use Poco::Timestamp() instead of std::time
2023-04-20 14:36:54 +00:00
Smita Kulkarni
780eef674f
Merge branch 'master' into Clear_marks_cache_for_outdated_parts
2023-04-20 16:17:26 +02:00
kssenii
59211c490a
More correct accounting of limits
2023-04-20 15:43:14 +02:00
alesapin
d8e6c6ab88
Merge pull request #48731 from ClickHouse/limit_mutations_per_entry
...
Limit the number of mutations commands per `MUTATE_PART` entry
2023-04-20 15:05:46 +02:00
kssenii
ec1370b2ed
Fix
2023-04-20 14:46:10 +02:00
Antonio Andelic
09156ab2b7
Merge branch 'master' into keeper-check-not-exists
2023-04-20 12:07:16 +00:00
Han Fei
6805edf9e6
Merge pull request #48850 from sichenzhao/add_alias_for_parts_name
...
add aliases for parts name and names
2023-04-20 13:04:11 +02:00
Vladimir C
ad516d2349
Merge pull request #48795 from ClickHouse/vdimir/fix-cluster-discovery-47176
2023-04-20 11:56:07 +02:00
Kseniia Sumarokova
9e481f5faa
Merge pull request #48845 from kssenii/fix-data-race-in-rabbitmq
...
Fix data race in StorageRabbitMQ
2023-04-20 11:43:18 +02:00
vdimir
d6416a1321
Store clusters from ClusterDiscovery in separate map
2023-04-19 16:44:54 +02:00
kssenii
323caae3c0
Fix
2023-04-19 16:29:38 +02:00
Kruglov Pavel
2ad161d2b7
Merge branch 'master' into non-blocking-connect
2023-04-19 13:39:40 +02:00
larryluogit
5fc7a489ae
Merge branch 'master' into noParquet
2023-04-18 21:17:00 -04:00
Igor Nikonov
d5eb65b5ea
Remove redundant narrowPipe()
2023-04-18 22:41:28 +00:00
Igor Nikonov
2455334009
Merge remote-tracking branch 'origin/master' into parallel-processing-from-storages
2023-04-18 21:42:51 +00:00
Antonio Andelic
fb16623d48
Add CheckNotExists request to Keeper
2023-04-18 14:45:24 +00:00
Alexander Gololobov
f7fe747ddc
Fix segfault
2023-04-18 16:30:58 +02:00
kssenii
16b027ed0c
Merge remote-tracking branch 'upstream/master' into better-local-object-storage
2023-04-18 16:25:08 +02:00
kssenii
59459cb287
Fix test
2023-04-18 15:54:36 +02:00
Anton Popov
c06b580890
Merge pull request #48844 from CheSema/wait_loading_parts
...
fix the race wait loading parts
2023-04-18 14:58:20 +02:00
kssenii
67d695580a
Merge remote-tracking branch 'upstream/master' into cache-better-locks
2023-04-18 12:42:25 +02:00
Larry Luo
b929547ab2
fix build without parquet
2023-04-17 21:37:32 -07:00
凌涛
a975211185
add more tests
2023-04-18 10:26:35 +08:00
Yakov Olkhovskiy
55389def04
use Poco::Timestamp() instead of std::time
2023-04-17 19:29:02 -04:00
Nikita Mikhaylov
c04d632373
Fix style
2023-04-18 00:22:52 +02:00
Alexander Gololobov
ba5ca15c40
Merge pull request #46835 from ClickHouse/reduce_mem_in_mutation_with_subquery
...
Reduce memory consumption by mutations with big subqueries used with IN
2023-04-17 23:55:08 +02:00
Robert Schulze
d658305554
Merge pull request #47693 from azat/stringstream-INT_MAX
...
Fix crash for uploading parts which size is greater then INT_MAX to S3
2023-04-17 23:08:56 +02:00
alesapin
ca8f3a10b0
Update src/Storages/StorageReplicatedMergeTree.cpp
2023-04-17 20:20:39 +02:00
kssenii
cd25d61795
Merge remote-tracking branch 'upstream/master' into cache-better-locks
2023-04-17 19:47:43 +02:00
robot-clickhouse-ci-2
45f4a5f74c
Merge pull request #47964 from ClickHouse/fast-parquet
...
Read Parquet files faster
2023-04-17 19:27:38 +02:00
kssenii
1322ad53b8
Merge remote-tracking branch 'upstream/master' into cache-better-locks
2023-04-17 18:22:21 +02:00
Michael Lex
51c9ae05fb
Fix unexpected part name error when trying to drop a ignored detache partition with zero copy replication
...
Before this fix, the integration test failed with this error
E Code: 233. DB::Exception: Received from 172.22.0.9:9000. DB::Exception: Unexpected part name: ignored_all_0_0_0 for format version: 1. Stack trace:
E
E 0. /home/ubuntu/clickhouse/contrib/llvm-project/libcxx/include/exception:134: std::exception::capture() @ 0x19bc7d02 in /usr/bin/clickhouse
E 1. /home/ubuntu/clickhouse/contrib/llvm-project/libcxx/include/exception:112: std::exception::exception[abi:v15000]() @ 0x19bc7ccd in /usr/bin/clickhouse
E 2. /home/ubuntu/clickhouse/base/poco/Foundation/src/Exception.cpp:27: Poco::Exception::Exception(String const&, int) @ 0x3194fae0 in /usr/bin/clickhouse
E 3. /home/ubuntu/clickhouse/src/Common/Exception.cpp:89: DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x2268ae6e in /usr/bin/clickhouse
E 4. /home/ubuntu/clickhouse/src/Common/Exception.h:54: DB::Exception::Exception(String&&, int, bool) @ 0x19bbb00a in /usr/bin/clickhouse
E 5. /home/ubuntu/clickhouse/src/Common/Exception.h:81: DB::Exception::Exception<String const&, StrongTypedef<unsigned int, DB::MergeTreeDataFormatVersionTag>&>(int, FormatStringHelperImpl<std::type_identity<String const&>::type, std::type_identity<StrongTypedef<unsigned int, DB::MergeTreeDataFormatVersionTag>&>::type>, String const&, StrongTypedef<unsigned int, DB::MergeTreeDataFormatVersionTag>&) @ 0x2c4f318c in /usr/bin/clickhouse
E 6. /home/ubuntu/clickhouse/src/Storages/MergeTree/MergeTreePartInfo.cpp:23: DB::MergeTreePartInfo::fromPartName(String const&, StrongTypedef<unsigned int, DB::MergeTreeDataFormatVersionTag>) @ 0x2c4f0867 in /usr/bin/clickhouse
E 7. /home/ubuntu/clickhouse/src/Storages/StorageReplicatedMergeTree.cpp:8305: DB::(anonymous namespace)::getParentLockedBlobs(std::shared_ptr<DB::ZooKeeperWithFaultInjection> const&, String const&, String const&, StrongTypedef<unsigned int, DB::MergeTreeDataFormatVersionTag>, Poco::Logger*) @ 0x2bca90f7 in /usr/bin/clickhouse
2023-04-17 15:57:41 +00:00
kssenii
b77e9c1ef0
Merge remote-tracking branch 'upstream/master' into better-local-object-storage
2023-04-17 16:44:10 +02:00
kssenii
d2c73a5522
Better
2023-04-17 16:41:21 +02:00
Sichen Zhao
eb4c26d81f
add aliases for parts name and names
2023-04-17 13:18:40 +00:00
凌涛
d1a14900ea
remove unused h
2023-04-17 20:26:31 +08:00
凌涛
7ed4c413e3
add settings allow_suspicious_indices
2023-04-17 20:23:19 +08:00
kssenii
0b62354261
Fix data race, refactor
2023-04-17 13:40:53 +02:00
Amos Bird
97d27c87a6
Fix key condition on duplicate primary keys
...
Fix key condition usage when encountering duplicate primary keys. This can happen in projections. This bug was introduced in https://github.com/ClickHouse/ClickHouse/pull/45686 .
This PR is also an optimization because we don't need to create unused FieldRefs anymore.
2023-04-17 19:13:42 +08:00
Sema Checherinda
daa55ae0d2
fix the race wait loading parts
2023-04-17 13:01:28 +02:00
Kseniia Sumarokova
8bc0a3a899
Merge pull request #48759 from kssenii/fix-mysql-named-collection
...
Fix some settings of mysql dictionary with named collection
2023-04-17 11:18:04 +02:00
Azat Khuzhin
f5c3f3a4ab
Remove quirk for s3_max_single_part_upload_size (when it exceed INT_MAX)
...
Reverts: #48816
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-17 10:49:55 +02:00
Michael Kolupaev
473f212c82
Hopefully fix assertion failure in CachedOnDiskReadBufferFromFile
2023-04-17 04:58:32 +00:00
Michael Kolupaev
87be78e6de
Better
2023-04-17 04:58:32 +00:00
Michael Kolupaev
e133633359
Parallel decoding with one row group per thread
2023-04-17 04:58:32 +00:00
Michael Kolupaev
683077890f
Highly questionable refactoring (getInputMultistream() nonsense)
2023-04-17 04:58:32 +00:00
Michael Kolupaev
2d4fe85513
Something
2023-04-17 04:58:32 +00:00
Kseniia Sumarokova
54f660bd4f
Merge pull request #48805 from kssenii/simplify-cache-factory
...
Simplify FileCacheFactory
2023-04-16 19:47:01 +02:00
robot-ch-test-poll1
69cac0a788
Merge pull request #48816 from ClickHouse/fix-s3
...
Prevent a bug in AWS S3
2023-04-16 14:46:02 +02:00
Alexey Milovidov
8e0b1eae69
Update StorageS3Settings.cpp
2023-04-16 08:53:52 +03:00
Igor Nikonov
908ad29106
Do not parallelize output for zeroes()
2023-04-15 22:14:18 +00:00
Alexey Milovidov
1174f4dcbe
Prevent a bug in AWS S3
2023-04-15 23:56:49 +02:00
Alexey Milovidov
7f620bf852
Fix double whitespace in exception message
2023-04-15 23:54:10 +02:00
kssenii
0517de58d1
Simplify FileCacheFactory
2023-04-15 16:15:20 +02:00
Igor Nikonov
8603807b57
Use generic way to parallelize output for file()
...
+ disable parallelization for storage Null
2023-04-15 12:35:24 +00:00
Igor Nikonov
60dbb7b406
Merge remote-tracking branch 'origin/master' into parallel-processing-from-storages
2023-04-14 20:11:51 +00:00
Igor Nikonov
9e92c26d53
Fix test_storage_mysql/test.py::test_settings_connection_wait_timeout
2023-04-14 20:10:57 +00:00
Alexander Tokmakov
70c1000c22
fix some tests
2023-04-14 19:42:17 +02:00
Dmitry Novik
cf5d9a175a
Revert "Merge pull request #48760 from ClickHouse/revert-46089-background-memory-tracker"
...
This reverts commit a61ed33223
, reversing
changes made to 5f01b8a2b5
.
2023-04-14 16:34:19 +02:00
Alexander Gololobov
a7b05589b6
Caches for multiple mutations
2023-04-14 16:12:19 +02:00
Alexander Gololobov
7a381e9232
Added enable_sharing_sets_for_mutations setting
2023-04-14 16:12:18 +02:00
Alexander Gololobov
633aaa73aa
Use use_index_for_in_with_subqueries_max_values setting to limit sizes of sets used in KeyCondition
2023-04-14 16:12:18 +02:00
Alexander Gololobov
28d0cc974a
Cleanups
2023-04-14 16:12:18 +02:00
Alexander Gololobov
adbe87e9d3
Fixes
2023-04-14 16:12:18 +02:00
Alexander Gololobov
0b9579bfb8
Reworked, testing
2023-04-14 16:12:18 +02:00
Alexander Gololobov
02876ed87d
Share PreparedSet-s between task of the same mutation to reduce mem usage
2023-04-14 16:12:18 +02:00
Dmitry Novik
352a240a20
Merge pull request #47984 from ClickHouse/optimize-compilation
...
Optimize compilation
2023-04-14 15:34:46 +02:00
Alexander Tokmakov
de9dc2b0b3
Merge branch 'master' into limit_mutations_per_entry
2023-04-14 15:19:08 +03:00
Igor Nikonov
7c84dc48c6
Better way to define for which storage output is parallelized
2023-04-14 12:00:02 +00:00
Kseniia Sumarokova
9eee7c72fe
Merge pull request #47307 from kssenii/better-tests-for-data-lakes
...
deltalake/iceberg/hudi improvements
2023-04-14 12:13:17 +02:00
Kseniia Sumarokova
6a0d9a37ce
Merge branch 'master' into fix-mysql-named-collection
2023-04-14 12:03:51 +02:00
Igor Nikonov
267cd097bf
Merge pull request #48729 from ClickHouse/fix-memory-order-in-number_mt
...
Fix memory order in number_mt
2023-04-13 23:57:36 +02:00
Kseniia Sumarokova
54518bf928
Merge branch 'master' into better-tests-for-data-lakes
2023-04-13 23:45:12 +02:00
Igor Nikonov
fa6346008a
Merge remote-tracking branch 'origin/master' into parallel-processing-from-storages
2023-04-13 20:55:18 +00:00
Igor Nikonov
fcd2eaea72
Disable 'Dictionary' storage due to count() can return incorrect result
...
see test_dictionaries_redis/test_long.py::test_redis_dict_long
2023-04-13 20:23:59 +00:00
Robert Schulze
43b8cbc50c
Merge pull request #48737 from ClickHouse/rs/fix-wshadow
...
Remove `-Wshadow` suppression which leaked into global namespace
2023-04-13 21:18:50 +02:00
Alexander Tokmakov
af1bf08663
Revert "Add MemoryTracker for the background tasks"
2023-04-13 21:05:02 +03:00
kssenii
ad48e1d010
Fox
2023-04-13 19:36:25 +02:00
Alexander Tokmakov
8d207e8752
Merge branch 'master' into limit_mutations_per_entry
2023-04-13 18:13:44 +02:00
Dmitry Novik
5cc9b46f78
Merge remote-tracking branch 'origin/master' into optimize-compilation
2023-04-13 16:04:09 +02:00
kssenii
6f53784f22
Merge remote-tracking branch 'upstream/master' into better-tests-for-data-lakes
2023-04-13 15:56:40 +02:00
Alexander Tokmakov
93368b4d55
Merge pull request #48730 from ClickHouse/remove_some_code
...
Do not remove broken detached parts on startup
2023-04-13 16:18:59 +03:00
kssenii
3ac7f999bc
Review fixes
2023-04-13 13:38:16 +02:00
kssenii
188b41cdb2
Merge remote-tracking branch 'upstream/master' into cache-better-locks
2023-04-13 13:33:30 +02:00
Dmitry Novik
467ecf45e1
Merge pull request #46089 from ClickHouse/background-memory-tracker
...
Add MemoryTracker for the background tasks
2023-04-13 13:29:27 +02:00
kssenii
09c23287aa
Merge remote-tracking branch 'upstream/master' into cache-better-locks
2023-04-13 13:25:45 +02:00
Robert Schulze
7a21d5888c
Remove -Wshadow suppression which leaked into global namespace
2023-04-13 08:46:40 +00:00
Alexander Tokmakov
d6bff4c5a8
limit the number of mutations commands per MUTATE_PART
2023-04-13 00:20:43 +02:00
Igor Nikonov
ba1adeba2b
Fix fast tests
...
+ avoid parallelization after SourceFromSingleChunk, SystemOne
2023-04-12 21:46:09 +00:00
Alexander Tokmakov
5d77bb149e
do not remove broken detached parts on startup
2023-04-12 23:26:34 +02:00
Igor Nikonov
ac540335e7
Let's see blast radius w/o parallelization after numbers()
2023-04-12 21:05:24 +00:00
Robert Schulze
3f7ce60e03
Merge branch 'master' into rs/gcc-removal
2023-04-12 22:17:04 +02:00
robot-ch-test-poll2
d1793a9bc5
Merge pull request #48692 from ClickHouse/rs/mergetree-syntax
...
Update MergeTree syntax for optional index granularity argument
2023-04-12 21:35:40 +02:00
Igor Nikonov
e3b61a4ea7
Fix memory order in number_mt
2023-04-12 19:35:12 +00:00
Alexey Milovidov
4d74e3da4d
Merge branch 'master' into improve_cluster_table_funcion_skip_unavailable_shards
2023-04-12 22:13:52 +03:00
Igor Nikonov
174885368f
Parallelize query processing right after reading FROM ...
...
- mostly simple or external storages
2023-04-12 18:46:07 +00:00
alesapin
8067cfcb51
Merge pull request #46946 from ClickHouse/revert-46909-revert-45911-mutations_rename_hang
...
Fix several `RENAME COLUMN` bugs
2023-04-12 19:07:48 +02:00
Dmitry Novik
6c11acccc9
Remove unnecessary code
2023-04-12 14:08:09 +00:00
Robert Schulze
6b441b40dd
Update MergeTree syntax for optional index granularity argument
...
This is follow up to #45451 .
2023-04-12 11:16:55 +00:00
alesapin
55c3f1ee29
Merge pull request #48666 from ClickHouse/remove_strange_code_from_mutation_task
...
Remove strange code from MutateTask
2023-04-12 12:38:43 +02:00
SmitaRKulkarni
7ad05c1bc3
Merge branch 'master' into Clear_marks_cache_for_outdated_parts
2023-04-12 09:21:59 +02:00
SmitaRKulkarni
dd64eaed66
Merge pull request #47985 from Algunenano/zk_retry_timeout
...
Do not continue retrying to connect to ZK if the query is killed or over limits
2023-04-12 08:49:47 +02:00
alesapin
f91309d83d
Fix drop in compact parts
2023-04-11 21:21:42 +02:00
Robert Schulze
05606a8835
Clean up GCC warning pragmas
2023-04-11 18:21:08 +00:00
alesapin
a72ee0b85e
Merge remote-tracking branch 'origin/master' into revert-46909-revert-45911-mutations_rename_hang
2023-04-11 20:14:43 +02:00
alesapin
165edd332e
Remove strange code from MutateTask
2023-04-11 18:31:53 +02:00
Dmitry Novik
06e6794fc0
Merge remote-tracking branch 'origin/master' into background-memory-tracker
2023-04-11 15:29:35 +00:00
SmitaRKulkarni
a55d344898
Merge branch 'master' into Clear_marks_cache_for_outdated_parts
2023-04-11 17:00:31 +02:00
Alexander Tokmakov
dfff30e1a9
Merge branch 'master' into clusters_is_active_column
2023-04-11 16:32:15 +02:00
Anton Popov
5b8db57fe8
Merge branch 'master' into retry-loading-of-parts
2023-04-11 15:51:40 +02:00
SmitaRKulkarni
e2010c0257
Merge branch 'master' into zk_retry_timeout
2023-04-11 14:05:52 +02:00
Sergei Trifonov
ca6e253fa6
Merge pull request #48526 from ClickHouse/lost-part-count
2023-04-11 13:11:42 +02:00
Kruglov Pavel
a0d11fdf53
Merge pull request #48436 from Avogar/fix-generate-random
...
Generate valid Decimals and Bools in generateRandom function
2023-04-11 12:06:08 +02:00
Sema Checherinda
4dd86a406a
Merge pull request #48543 from azat/mv-uniq-thread-group
...
Use one ThreadGroup while pushing to materialized views (and some refactoring for ThreadGroup)
2023-04-11 11:47:46 +02:00
Alexey Milovidov
9e1db557e0
Merge pull request #48612 from ClickHouse/remove-strange-code-2
...
Remove strange code
2023-04-11 06:17:45 +03:00
Alexey Milovidov
d259217cf3
Merge pull request #48570 from azat/build/logger_useful
...
Remove superfluous includes of logger_userful.h from headers
2023-04-11 03:56:39 +03:00
Alexey Milovidov
23a0879452
Remove strange code
2023-04-10 21:17:08 +02:00
Nikolai Kochetov
ba468eac45
Merge pull request #48485 from ClickHouse/read-step-for-system-zookeeper
...
Add reading step for system zookeeper. Analyze path from filter DAG.
2023-04-10 19:28:18 +02:00
Kseniia Sumarokova
65259d964b
Merge pull request #48167 from lzydmxy/add_columns_for_system_storage_policies
...
Add columns for table `system.storage_policies`
2023-04-10 18:32:13 +02:00
Azat Khuzhin
79b83c4fd2
Remove superfluous includes of logger_userful.h from headers
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-10 17:59:30 +02:00
Nikolai Kochetov
d564fe4e64
Fixing build
2023-04-10 10:54:37 +00:00
Raúl Marín
45ad555c39
Merge branch 'master' into zk_retry_timeout
2023-04-10 10:04:16 +02:00
Alexey Milovidov
c279516ac1
Merge branch 'master' into parallel-reading-from-file
2023-04-10 08:02:50 +03:00
Igor Nikonov
1187534545
Simpler way to resize pipeline
2023-04-09 21:26:39 +00:00
Alexey Milovidov
eda4a021a6
Merge branch 'master' into server-uuid-macro
2023-04-09 22:26:58 +03:00
Alexey Milovidov
db61140607
Merge branch 'master' into improve_cluster_table_funcion_skip_unavailable_shards
2023-04-09 08:03:23 +03:00
Alexey Milovidov
09ea79aaf7
Add support for {server_uuid} macro
2023-04-09 03:04:26 +02:00
Sergei Trifonov
b319271d59
Remove misleading comment
...
It is no longer "significant" after `NOEXCEPT_SCOPE` macro rework #39229
2023-04-08 22:50:24 +02:00
robot-clickhouse-ci-1
3302f1ff90
Merge pull request #48299 from CurtizJ/do-not-build-unnecessary-sets
...
Do not build sets for skip indexes if they are not used
2023-04-08 21:25:06 +02:00
Artem Pershin
2b00c8cb9b
Fix typo in word acquired, in comment for lockForAlter method
2023-04-08 18:39:04 +03:00
Alexander Tokmakov
bf20e6bfc6
Merge pull request #48550 from ClickHouse/fix_sync_replica
...
Fix some tests
2023-04-08 14:41:10 +03:00
Vitaly Baranov
62e9c419de
Merge pull request #48519 from azat/build/fwd-decl-threadpool
...
Use forward declaration of ThreadPool
2023-04-08 00:44:01 +02:00
Alexander Tokmakov
e39ee3f0af
suppress a bug in filesystem cache
2023-04-07 22:54:49 +02:00
Alexander Tokmakov
9929185eab
fix REPLACE_RANGE
2023-04-07 20:31:03 +02:00
Alexander Tokmakov
18a2eb355e
fix a bug in sync replica
2023-04-07 20:16:25 +02:00
kssenii
00282483c9
Address remaining review comments
2023-04-07 18:29:55 +02:00
Alexander Tokmakov
9ec91acef3
add some columns to system.clusters
2023-04-07 18:26:23 +02:00
Sergei Trifonov
396f6a6421
Update src/Storages/StorageReplicatedMergeTree.cpp
...
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-04-07 17:07:36 +02:00
Azat Khuzhin
aacf2a0838
Move ThreadGroupSwitcher to ThreadStatus.h (out from MergeTree code)
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-07 15:32:08 +02:00
Azat Khuzhin
5b2b20a0b0
Rename ThreadGroupStatus to ThreadGroup
...
There are methods like getThreadGroup() and ThreadGroupSwitcher class,
so seems that this is logical.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-07 15:31:48 +02:00
Igor Nikonov
78038a3c2c
Fix: do not resize pipeline when there is no files to process (globs expands to empty set)
2023-04-07 11:34:04 +00:00
Kseniia Sumarokova
d5889a47d6
Merge pull request #48311 from kssenii/rabbitmq-fix-cpu-usage
...
Fix cpu usage in rabbitmq (was worsened in 23.2 after #44404 )
2023-04-07 11:44:48 +02:00
Azat Khuzhin
011480924a
Use forward declaration of ThreadPool
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-07 11:25:35 +02:00
serxa
343a071798
add lost_part_count
column to system.replicas
2023-04-06 22:38:58 +00:00
Igor Nikonov
96213fa464
Fix header
2023-04-06 22:17:09 +00:00
Igor Nikonov
2e139c21d2
Parallel reading in FROM file()
2023-04-06 21:57:03 +00:00
Nikolai Kochetov
57255eb56c
Fix equals.
2023-04-06 19:22:10 +00:00
Smita Kulkarni
7b33744618
Added a check to clear and not load marks asynchronously from outdated parts
2023-04-06 20:11:40 +02:00
Sema Checherinda
b8729be97a
Merge pull request #47104 from CheSema/thead-group-for-merge
...
merge and mutation make thread group for setting memory trackers right
2023-04-06 15:46:56 +02:00
kssenii
2d335f82cc
Fix another test
2023-04-06 15:43:16 +02:00
Nikolai Kochetov
b199219ec1
Add reading step for system zookeeper. Analyze path from filter DAG.
2023-04-06 12:24:22 +00:00
kssenii
0f02349473
Fix
2023-04-06 14:14:22 +02:00
Antonio Andelic
28a33f0a47
Merge pull request #48435 from ClickHouse/kv-update-only-affected-rows
...
Update only affected rows in KV storage
2023-04-06 12:33:54 +02:00
Vladimir C
e7a5c96353
Merge pull request #48219 from ClickHouse/vdimir/lock_order_47072
2023-04-06 11:54:33 +02:00
Vladimir C
a2b71a0054
Merge pull request #48386 from ClickHouse/vdimir/reset-downloader-tmp-data-cache
2023-04-06 11:23:16 +02:00
robot-ch-test-poll3
3ad0a6ac18
Merge pull request #48433 from ClickHouse/some-fixes-for-parallel-replicas
...
Some fixes for parallel replicas
2023-04-06 02:00:06 +02:00
Anton Popov
4fb7e0ec3c
add retries to loading of data parts
2023-04-05 21:23:57 +00:00
Alexander Tokmakov
a154fa73f4
Merge pull request #48401 from ClickHouse/fix_00002_log_messages
...
Find big allocations without memory limits checks
2023-04-05 23:52:39 +03:00
Sema Checherinda
554c928534
Merge branch 'master' into thead-group-for-merge
2023-04-05 21:09:38 +02:00
Sema Checherinda
c1adbb7aa6
transfer counters to the query directly
2023-04-05 19:51:36 +02:00
robot-clickhouse
3d2c279859
Merge pull request #48242 from azat/better-throttling
...
Per-query/per-server throttling for remote IO/local IO/BACKUPs
2023-04-05 19:32:37 +02:00
kssenii
be13ce76f4
Merge remote-tracking branch 'upstream/master' into better-tests-for-data-lakes
2023-04-05 18:47:08 +02:00
kssenii
a405d06e8a
Merge remote-tracking branch 'upstream/master' into cache-better-locks
2023-04-05 18:46:52 +02:00
avogar
1be6bceb2f
Generate valid Decimals and Bools in generateRandom function
2023-04-05 16:23:06 +00:00
Antonio Andelic
0260b84bc3
Update only affected rows in KV storage
2023-04-05 16:12:14 +00:00
Nikita Mikhaylov
3f44c6d936
Better
2023-04-05 15:19:45 +00:00
kssenii
62244ee57d
Fix test
2023-04-05 17:14:41 +02:00
vdimir
01ce3baf0f
Rename Context::getTemporaryVolume to getGlobalTemporaryVolume
2023-04-05 13:42:13 +00:00
vdimir
6f3fa33641
Add unbound flag to system.filesystem_cache
2023-04-05 13:12:20 +00:00
Robert Schulze
62608f74d3
Merge pull request #48396 from ClickHouse/rs/clang-tidy-cleanup
...
Cleanup mess in .clang-tidy
2023-04-05 14:39:28 +02:00
Alexander Tokmakov
3b5ed9242c
Merge pull request #48391 from azat/fix-sync-replica-stuck
...
Fix possible SYSTEM SYNC REPLICA stuck in case of DROP/REPLACE PARTITION
2023-04-05 15:20:46 +03:00
kssenii
3fb4cd0f52
Fix s3 test
2023-04-05 14:13:46 +02:00
Nikita Mikhaylov
7b526d3df9
Always communicate with local replica through loopback interface for parallel replicas ( #48246 )
2023-04-05 13:32:46 +02:00
Robert Schulze
1be81db885
Fix build, pt. II
2023-04-05 11:23:09 +00:00
Sema Checherinda
f504cd5fed
avoid race, do not set thread_group.counters.parent from query
2023-04-05 12:36:55 +02:00
Azat Khuzhin
218b1f9c29
Add ability to throttle BACKUPs on per-server/backup basis
...
Server settings:
- backup_read_bandwidth_for_server
- backup_write_bandwidth_for_server
Query settings:
- backup_read_bandwidth
- backup_write_bandwidth
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:39:48 +02:00
kssenii
a3d69694f4
Fix build
2023-04-04 23:13:17 +02:00
kssenii
c379eb7c29
Fix style check
2023-04-04 22:59:16 +02:00
kssenii
f44c53b97a
Merge remote-tracking branch 'upstream/master' into better-tests-for-data-lakes
2023-04-04 22:41:22 +02:00
kssenii
8c0be0c3be
Checkpoints
2023-04-04 22:40:05 +02:00
Alexander Tokmakov
ba65be22da
fix bad error messages
2023-04-04 20:21:22 +02:00
Raúl Marín
0e17b3b147
Merge remote-tracking branch 'blessed/master' into zk_retry_timeout
2023-04-04 18:53:55 +02:00
Nikita Mikhaylov
fa5b2bd4a5
Added Keeper retries for backups operations ( #47224 )
2023-04-04 18:12:08 +02:00
Azat Khuzhin
353434f8f1
Fix possible SYSTEM SYNC REPLICA stuck in case of DROP/REPLACE PARTITION
...
In case of DROP/REPLACE PARTITION the entries from the queue will be
removed without notifying the subscribes.
CI: https://s3.amazonaws.com/clickhouse-test-reports/48242/4a315cd0d17bc12edd934fd25663b0119880f207/stress_test__asan_.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-04 17:16:04 +02:00
Antonio Andelic
a329d80bfa
Merge pull request #47397 from ClickHouse/enable-env-credentials-default
...
Enable `use_environment_credentials` by default
2023-04-04 10:00:03 +02:00
Antonio Andelic
52e4149c98
Merge pull request #47934 from ClickHouse/alternative-keeper-configs
...
Merge #35113
2023-04-04 09:58:33 +02:00
Antonio Andelic
4efa707fe3
Merge branch 'master' into alternative-keeper-configs
2023-04-04 09:53:19 +02:00
Antonio Andelic
0dda3d13ef
Merge branch 'master' into keeper-map-strict-mode
2023-04-04 09:52:53 +02:00
lizhuoyu5
2232d5ad14
Merge branch 'master' into add_columns_for_system_storage_policies
2023-04-04 12:58:10 +08:00
Yakov Olkhovskiy
35e9e45249
Merge pull request #48062 from Algunenano/unnecessary_alter_checks
...
Only check MV on ALTER when necessary
2023-04-03 17:23:11 -04:00
Sema Checherinda
6d5edc0315
rename fake_query_context to task_context
2023-04-03 22:01:18 +02:00
kssenii
75b11bceb5
Fix style check
2023-04-03 21:27:05 +02:00
kssenii
18a9a670c3
Better
2023-04-03 20:56:10 +02:00
kssenii
9b3d0ec86d
Adjustments after conflicts
2023-04-03 19:53:34 +02:00
kssenii
8915f49b7d
Merge remote-tracking branch 'upstream/master' into better-tests-for-data-lakes
2023-04-03 17:43:42 +02:00
Antonio Andelic
f5e97fbb66
Merge branch 'master' into alternative-keeper-configs
2023-04-03 15:06:52 +00:00
kssenii
6e1cf1907d
Better
2023-04-03 16:57:49 +02:00
Antonio Andelic
950a7d9948
Merge branch 'master' into keeper-map-strict-mode
2023-04-03 14:26:14 +00:00
kssenii
5578cb08ad
Fix s3 cluster
2023-04-03 14:40:04 +02:00
Anton Popov
207a4c6166
Merge branch 'master' into do-not-build-unnecessary-sets
2023-04-03 14:29:33 +02:00
Robert Schulze
a50e741bea
Merge pull request #45912 from ClickHouse/qc-compression
...
Query cache: Enable compression of cache entries
2023-04-03 13:33:47 +02:00
Robert Schulze
3e124f09d0
Merge remote-tracking branch 'origin/master' into qc-compression
2023-04-03 11:28:17 +00:00
Robert Schulze
e79343c169
Make the column order in system.query_cache more intutitive
2023-04-03 10:36:11 +00:00
kssenii
018df220bf
Remove redundant
2023-04-03 12:18:04 +02:00
kssenii
35a8328922
Fix
2023-04-03 12:11:12 +02:00
Antonio Andelic
2d89057142
Merge branch 'master' into keeper-map-strict-mode
2023-04-03 09:30:52 +00:00
Antonio Andelic
40a0ecf66a
Fix
2023-04-03 09:30:39 +00:00
Raúl Marín
8fdf87982c
Merge remote-tracking branch 'blessed/master' into zk_retry_timeout
2023-04-03 10:26:18 +02:00
Antonio Andelic
da194f082d
Merge branch 'master' into enable-env-credentials-default
2023-04-03 09:45:03 +02:00
Alexey Milovidov
ef1e282d4c
Merge branch 'master' into compress-marks-primary-key-by-default
2023-04-03 06:28:48 +03:00
Alexey Milovidov
99ed3b627b
Merge branch 'master' into fix-race-storage-s3
2023-04-03 06:25:44 +03:00
Anton Popov
ff1cc5598f
fix clang-tidy
2023-04-02 22:21:10 +00:00
Alexey Milovidov
5ebf66819b
Merge pull request #47617 from ClickHouse/cnf-new-analyzer
...
CNF/Constraint optimizer in new analyzer
2023-04-02 20:09:34 +03:00
kssenii
6d75ca9c6f
Fix
2023-04-02 18:21:45 +02:00
Alexey Milovidov
9c6594a043
Merge pull request #48320 from azat/explain-fix
...
Fix crash in EXPLAIN PIPELINE for Merge over Distributed
2023-04-02 17:11:27 +03:00
Azat Khuzhin
907ed27ae2
Fix crash in EXPLAIN PIPELINE for Merge over Distributed
...
CI: https://s3.amazonaws.com/clickhouse-test-reports/48314/179450542879d11711cd2415c3fa7eeab18188be/fuzzer_astfuzzerasan/report.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-02 10:48:23 +02:00
kssenii
ddf2af598d
Fix
2023-04-01 20:52:22 +02:00
kssenii
8cfd544328
Better
2023-04-01 18:41:42 +02:00
Azat Khuzhin
c64f9e6f07
Use StrongTypedef for ProfileEvents
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-01 16:01:33 +02:00
Azat Khuzhin
ba6ecd2d4e
Fix ThreadPool for DistributedSink
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-01 16:00:03 +02:00
Alexander Tokmakov
48b23dd012
Fix race between DROP MatView and RESTART REPLICAS ( #47863 )
...
* fix race between drop mv and restart replicas
* unrelated: fix bad exception messages
* fix test
* fix
* fix
* fix
* fix
* fix test
* fix
* fix test
* Update 02437_drop_mv_restart_replicas.sh
* fix tests
2023-04-01 15:26:00 +03:00
kssenii
6ff728fb4d
Fix cpu usage in rabbitmq
2023-04-01 11:45:25 +02:00
Anton Popov
cdf9cf2fd4
do not build sets for indexes if they are not used
2023-03-31 16:06:20 +00:00
Anton Popov
3b98a43dc6
Merge branch 'master' into fix-race-storage-s3
2023-03-31 17:54:52 +02:00
Alexander Tokmakov
e39498129c
Merge branch 'master' into sync_replica_lightweight
2023-03-31 18:17:08 +03:00
Antonio Andelic
1e3abc9e84
Add strict mode for KeeperMap
2023-03-31 14:24:32 +00:00
Alexander Tokmakov
75ffc8451b
fix
2023-03-31 16:09:00 +02:00
Anton Popov
f715bd95f1
fix writing to StorageS3
2023-03-31 14:08:28 +00:00
Alexey Milovidov
3de29f5cc1
Merge pull request #48278 from azat/backups/fix-UB
...
Fix UB (signed integer overflow) in StorageMergeTree::backupData()
2023-03-31 16:35:10 +03:00
Alexander Tokmakov
caf00b5968
Merge branch 'master' into sync_replica_lightweight
2023-03-31 14:52:55 +02:00
Alexey Milovidov
17c2678675
Merge branch 'master' into compress-marks-primary-key-by-default
2023-03-31 15:15:38 +03:00
Alexey Milovidov
dd79bf0a03
Update autogenerated version to 23.4.1.1 and contributors
2023-03-31 12:20:50 +02:00
Azat Khuzhin
bac7def719
Fix UB (signed integer overflow) in StorageMergeTree::backupData()
...
UBsan report:
/build/src/Storages/StorageMergeTree.cpp:2088:80: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long'
0 0x30c2ae7b in DB::StorageMergeTree::backupData(DB::BackupEntriesCollector&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, std::__1::optional<absl::lts_20211102::InlinedVector<std::__1::shared_ptr<DB::IAST>, 7ul, std::__1::allocator<std::__1::shared_ptr<DB::IAST>>>> const&) build_docker/./src/Storages/StorageMergeTree.cpp:2088:80
1 0x2dd641b5 in DB::BackupEntriesCollector::makeBackupEntriesForTableData(DB::QualifiedTableName const&) build_docker/./src/Backups/BackupEntriesCollector.cpp:703:18
2 0x2dd5c2a7 in DB::BackupEntriesCollector::makeBackupEntriesForTablesData() build_docker/./src/Backups/BackupEntriesCollector.cpp:676:9
3 0x2dd5848d in DB::BackupEntriesCollector::run() build_docker/./src/Backups/BackupEntriesCollector.cpp:119:5
4 0x2dd84da3 in DB::BackupsWorker::doBackup(std::__1::shared_ptr<DB::ASTBackupQuery> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, DB::BackupInfo const&, DB::BackupSettings, std::__1::shared_ptr<DB::IBackupCoordination>, std::__1::shared_ptr<DB::Context const> const&, std::__1::shared_ptr<DB::Context>, bool) build_docker/./src/Backups/BackupsWorker.cpp:359:59
5 0x2dd82405 in DB::BackupsWorker::startMakingBackup(std::__1::shared_ptr<DB::IAST> const&, std::__1::shared_ptr<DB::Context const> const&) build_docker/./src/Backups/BackupsWorker.cpp:248:13
6 0x2dd81d0a in DB::BackupsWorker::start(std::__1::shared_ptr<DB::IAST> const&, std::__1::shared_ptr<DB::Context>) build_docker/./src/Backups/BackupsWorker.cpp:179:16
7 0x2f4d0d5f in DB::InterpreterBackupQuery::execute() build_docker/./src/Interpreters/InterpreterBackupQuery.cpp:39:30
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /build/src/Storages/StorageMergeTree.cpp:2088:80 in
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-31 12:29:31 +03:00
Antonio Andelic
e982f2a67a
Merge branch 'master' into enable-env-credentials-default
2023-03-31 09:11:01 +00:00
Anton Popov
5ceb855e7f
Merge branch 'master' into fix-race-storage-s3
2023-03-31 04:16:35 +02:00
kssenii
f1fe44e43d
Better
2023-03-30 23:09:12 +02:00
Anton Popov
38389d878c
fix one more race in StorageS3
2023-03-30 21:06:53 +00:00
Alexey Milovidov
614be6f718
Merge pull request #47387 from sippy/pg_select_from_only
...
Use "SELECT * FROM ONLY xyz", not "SELECT * FROM xyz" while replicating
2023-03-30 22:57:57 +03:00
kssenii
319417062f
Merge remote-tracking branch 'upstream/master' into better-tests-for-data-lakes
2023-03-30 18:29:46 +02:00
kssenii
60efa3cae7
Fixes for hudi
2023-03-30 18:25:54 +02:00
Antonio Andelic
80cb121d2a
Merge pull request #48092 from ClickHouse/nosign-keyword-for-s3
...
Add support for `NOSIGN` keyword and `no_sign_request` config for S3
2023-03-30 18:10:56 +02:00
kssenii
e2cbccfbc4
Merge remote-tracking branch 'upstream/master' into cache-better-locks
2023-03-30 17:33:46 +02:00
Anton Popov
e72472e71b
Merge branch 'master' into fix-race-storage-s3
2023-03-30 16:19:57 +02:00
kssenii
539414554f
Fix s3
2023-03-30 15:32:38 +02:00
Alexey Milovidov
cb27416d8e
Merge pull request #48102 from ClickHouse/vdimir/25402_storage_merge_explain_graph_crash
...
Fix crash in explain graph with StorageMerge
2023-03-30 13:54:22 +03:00
kssenii
bd407d2d5c
Fix build without s3
2023-03-30 12:13:03 +02:00
Robert Schulze
b0473098c6
Merge branch 'master' into qc-compression
2023-03-30 10:55:42 +02:00
Antonio Andelic
9db58532f4
Clang-tidy fix
2023-03-30 08:41:14 +02:00
Alexey Milovidov
a629fa3ed9
Merge pull request #48162 from ClickHouse/vdimir/remove_unused_from_gtest_transform_query
...
Remove unused mockSystemDatabase from gtest_transform_query_for_exter…
2023-03-30 01:29:42 +03:00
Alexey Milovidov
e982fb9f1c
Merge pull request #47880 from azat/threadpool-introspection
...
ThreadPool metrics introspection
2023-03-30 01:27:31 +03:00