Commit Graph

43572 Commits

Author SHA1 Message Date
Alexey Milovidov
3a48a7b872
Merge pull request #51492 from nickitat/fix_final_header_mismatch
Fix Block structure mismatch in Pipe::unitePipes for FINAL
2023-07-08 08:05:20 +03:00
Alexey Milovidov
e4dd603919
Merge pull request #51497 from ClickHouse/fix-shutdown-race
Fix possible race on shutdown wait
2023-07-08 03:03:45 +03:00
Alexey Milovidov
bc1f815b79
Merge pull request #51640 from alekar/fix-to-outfile
Ignore APPEND and TRUNCATE modifiers if file does not exist.
2023-07-08 02:56:59 +03:00
Alexey Milovidov
236ee81266
Merge pull request #51847 from canhld94/ch_fix_segfault
Fix segfault when create invalid EmbeddedRocksdb table
2023-07-08 02:50:11 +03:00
Alexey Milovidov
fbdb8f387e
Merge pull request #51857 from ljhcage/master
remove duplicate condition
2023-07-08 02:49:32 +03:00
Alexey Milovidov
25aa6fcff9
Merge pull request #51947 from ClickHouse/fix-50669
Do not remove inputs after ActionsDAG::merge
2023-07-08 02:42:14 +03:00
Alexey Milovidov
03d2606eb9
Merge pull request #49342 from ClickHouse/disks-space-improvement
Slight improvement in Disks interface
2023-07-08 02:24:57 +03:00
Alexey Milovidov
e56a5bbd8b
Merge pull request #51865 from ClickHouse/remove-useless-logs
Remove useless logs
2023-07-08 02:23:00 +03:00
Alexey Milovidov
583d48edcd
Merge pull request #51378 from ClickHouse/add-test-43358
Functions `hasToken*` were totally wrong. Add a test for #43358
2023-07-08 02:22:39 +03:00
Alexey Milovidov
c61f0bca65
Merge pull request #51931 from ClickHouse/better-current-thread-check
Fix segfault caused by `ThreadStatus`
2023-07-08 02:15:53 +03:00
Alexey Milovidov
10196ba902
Merge pull request #51932 from ClickHouse/short_fault_info
Print short fault info only from safe fields
2023-07-08 00:59:57 +03:00
Alexey Milovidov
1eaefd0318
Merge pull request #51905 from rschu1ze/varint
Allow full range for var-int encoded integers
2023-07-07 22:33:29 +03:00
Alexey Milovidov
520195f7ef
Merge pull request #51917 from ClickHouse/revert-system-drop-filesystem-cache-by-key
Revert system drop filesystem cache by key
2023-07-07 19:44:28 +03:00
Alexander Tokmakov
152a4b9d4c
Merge pull request #51908 from ClickHouse/fix_deadlock_on_catalog_shutdown
Fix deadlock on DatabaseCatalog shutdown
2023-07-07 19:06:34 +03:00
Nikolai Kochetov
82cbc4e6e3
Merge branch 'master' into fix-50669 2023-07-07 16:35:50 +02:00
Nikolai Kochetov
ee33000fc2 Fixing tests. 2023-07-07 14:08:54 +00:00
Nikolai Kochetov
fa7fe5277c Better comment. 2023-07-07 12:25:13 +00:00
Nikolai Kochetov
1e0d97c282 Do not remove inputs after ActionsDAG::merge 2023-07-07 12:19:10 +00:00
Antonio Andelic
d9d0e9062a Remove maybe_unused 2023-07-07 11:41:01 +00:00
Antonio Andelic
cf50380ff8 Merge branch 'master' into better-current-thread-check 2023-07-07 11:40:04 +00:00
Antonio Andelic
6d798e0bde Better check for current_thread 2023-07-07 11:39:41 +00:00
Alexander Gololobov
d439db3139 Print just signal number first, and only then get its description 2023-07-07 13:15:31 +02:00
Alexey Milovidov
7820876f2d
Merge branch 'master' into remove-useless-logs 2023-07-07 13:44:04 +03:00
Alexey Milovidov
4a6a6fc4f2
Merge branch 'master' into disks-space-improvement 2023-07-07 13:43:04 +03:00
Alexey Milovidov
69dc099dba
Merge branch 'master' into add-test-43358 2023-07-07 13:40:49 +03:00
Alexander Gololobov
602392bb62 Print short fault info only from safe fields 2023-07-07 12:37:16 +02:00
Alexey Milovidov
b5f9a170eb
Merge pull request #51848 from ClickHouse/many-fixes-3
Many fixes [3]
2023-07-07 13:29:49 +03:00
Duc Canh Le
5d6fb7b7b0
Merge branch 'master' into ch_fix_segfault 2023-07-07 13:13:33 +08:00
xiaolei565
5f523e8376
Merge branch 'master' into xuelei_dev 2023-07-07 10:21:19 +08:00
Alexey Milovidov
7cece62d26 Revert "Merge pull request #51547 from kssenii/more-flexible-drop-cache"
This reverts commit 2ce7bcaa3d, reversing
changes made to e897207cd5.
2023-07-07 04:07:19 +02:00
Alexey Milovidov
f0cc90a7fb Revert "Merge pull request #51822 from kssenii/minor-changes"
This reverts commit 5ac85f4fa8, reversing
changes made to 376c903da9.
2023-07-07 04:07:03 +02:00
Nikolay Degterinsky
8da8b79cc4
Merge pull request #51854 from fky2015/master
fix: correct exception messages on policies comparison
2023-07-07 03:58:06 +02:00
xiaolei565
dd87269fc2
Merge branch 'master' into xuelei_dev 2023-07-07 09:49:34 +08:00
Alexander Tokmakov
fde44fe9f0
Merge branch 'master' into fix_deadlock_on_catalog_shutdown 2023-07-07 02:59:29 +03:00
Alexey Milovidov
685f2949b7
Revert "Fix build" 2023-07-07 02:53:13 +03:00
Alexey Milovidov
c47b32b17a Fix build 2023-07-07 01:52:18 +02:00
Alexey Milovidov
48eb30de51 Fix build 2023-07-07 01:42:29 +02:00
Alexander Tokmakov
fc19e74ba9 fix deadlock on DatabaseCatalog shutdown 2023-07-07 01:12:17 +02:00
Alexander Tokmakov
fdbd59ec6c
Merge pull request #51135 from ClickHouse/fix_trash_in_disks
Try to fix some trash in Disks and part moves
2023-07-07 02:02:17 +03:00
alekar
757aee1109
Merge branch 'master' into fix-to-outfile 2023-07-06 14:04:42 -07:00
Robert Schulze
271297823a
Allow var-int encoded 64-bit integers with MSB=1
Resolves: #51486

Until now, it was illegal to encode 64-bit (unsigned) integers with
MSB=1, i.e. values > (1ULL<<63) - 1, as var-int. In more detail, the
var-int code used by ClickHouse server and client spent at most 9 bytes
per value such that 9 * 7 = 63 bits could be encoded. Some 3rd party
clients (e.g. Rust clickhouse-rs) had the same limitation, whereas other
clients understand the full range (Python clickhouse-driver).

PRs #47608 and #48628 added sanity checks as asserts or exceptions
during var-int encoding on the server side. This was considered okay as
such huge integers so far occurred only during testing (usually fuzzing)
but not in practice.

Issue #51486 is a new fuzzing issue where the exception thrown from the
sanity check led to a half-baked progress packet and as a result, a
logical error / server crash.

The only fix which is not another bandaid is to allow the full range in
var-int coding. Clients will have to allow the full range too, a note
will be added to the changelog. (the alternative was to create another
protocol version but as var-int is used all over the place this was
considered infeasible)

Review note: this is the relevant commit.
2023-07-06 20:23:23 +00:00
robot-clickhouse-ci-2
99c64971bd
Merge pull request #51737 from ClickHouse/fix_logical_error_grace_hash_join
Fix: logical error in grace hash join
2023-07-06 19:27:03 +02:00
lcjh
7321f7e9dc
Merge branch 'master' into master 2023-07-07 00:31:47 +08:00
Feng Kaiyu
bf4dbb842d
Merge branch 'master' into master 2023-07-06 23:47:41 +08:00
Igor Nikonov
83af43b8ba
Merge pull request #51852 from ClickHouse/fix-misleading-naming-in-joins
Change misleading name in joins: addJoinedBlock -> addBlockToJoin
2023-07-06 17:27:26 +02:00
Igor Nikonov
7c0e50c4d5
Merge branch 'master' into fix-misleading-naming-in-joins 2023-07-06 17:26:38 +02:00
Robert Schulze
3f744c1e14
Cosmetics: rename template parameter 2023-07-06 14:47:40 +00:00
Robert Schulze
7644f0b37c
Cosmetics: move code around 2023-07-06 14:44:06 +00:00
Alexey Milovidov
6d8434c702 Merge branch 'master' into many-fixes-3 2023-07-06 16:17:32 +02:00
Alexey Milovidov
1fa21700ad Merge remote-tracking branch 'origin/less-flaky-test_start_stop_moves' into many-fixes-3 2023-07-06 16:17:13 +02:00